Re: [PATCH] virsh: Introduce new hypervisor-cpu-models command

2025-03-19 Thread Ján Tomko via Devel
On a Thursday in 2025, Collin Walling wrote: From: David Judkovics Add new virsh command 'hypervisor-cpu-models'. Command pulls from the existing domcapabilities XML and uses xpath to parse CPU model strings. By default, only models reported as usable by the hypervisor on the host system are p

Re: [PATCH 8/8] NEWS: Mention guest agent error code improvements

2025-03-20 Thread Ján Tomko via Devel
On a Thursday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa Signed-off-by: Peter Krempa --- NEWS.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 98ca838642..b2f3415001 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -37,6 +37,16 @@ v11.2.0 (unre

Re: [PATCH] qemu/dbus: Allow connections from root to the dbus-daemon

2025-03-20 Thread Ján Tomko via Devel
On a Thursday in 2025, Martin Kletzander via Devel wrote: From: Martin Kletzander In commit dbfb96d18c04 libvirt started connecting to the daemon to set RDP credentials, but our configuration file did not allow connections from the root user, so the connection failed and the VM failed to start.

Re: [PATCH 8/8] NEWS: Mention guest agent error code improvements

2025-03-21 Thread Ján Tomko via Devel
On a Friday in 2025, Peter Krempa wrote: On Thu, Mar 20, 2025 at 17:36:27 +0100, Ján Tomko wrote: On a Thursday in 2025, Peter Krempa via Devel wrote: > From: Peter Krempa > > Signed-off-by: Peter Krempa > --- > NEWS.rst | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/NEWS.

[libvirt PATCH] NEWS: fix one more typo

2025-03-21 Thread Ján Tomko via Devel
From: Ján Tomko s/ an / a / Signed-off-by: Ján Tomko Reported-by: Jiri Denemark --- Sighed-by: Ján Tomko NEWS.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.rst b/NEWS.rst index de0a205e24..a04cf8f259 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -48,7 +48,7 @@ v11.2

Re: [PATCH] NEWS: hotplug virtio-mem device

2025-03-21 Thread Ján Tomko via Devel
On a Friday in 2025, Martin Kletzander via Devel wrote: On Fri, Mar 21, 2025 at 08:18:31AM +0100, Boris Fiuczynski wrote: Signed-off-by: Boris Fiuczynski Reviewed-by: Martin Kletzander Pushed-by: Ján Tomko :) Jano --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/N

Re: [PATCH v2] qemu_domain_address: fix CCW virtio-mem hotplug

2025-03-18 Thread Ján Tomko via Devel
On a Tuesday in 2025, Boris Fiuczynski wrote: Since commit f23f8ff91a virtio-mem supports also CCW. When hotplugging a virtio-mem device with a CCW address results in a PCI device getting attached. The method qemuDomainAssignMemoryDeviceSlot is only considering PCI as address type and overwriting

[libvirt PATCH] qemu: remove unreachable breaks in qemuDomainAssignMemoryDeviceSlot

2025-03-18 Thread Ján Tomko via Devel
Signed-off-by: Ján Tomko --- Pushed as trivial src/qemu/qemu_domain_address.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index 5b94c27679..e89cdee487 100644 --- a/src/qemu/qemu_domain_address.c +++ b/src/qemu/qemu_domain_a

[libvirt PATCH 1/7] qemu: introduce QEMU_CAPS_AMD_IOMMU

2025-03-18 Thread Ján Tomko via Devel
Check for the presence of the amd-iommu device, so we can conditionalize probing for its properties. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 4 src/qemu/qemu_capabilities.h | 3 +++ tests/qemucapabilitiesdata/caps_1

[libvirt PATCH 2/7] qemu: introduce QEMU_CAPS_PCI_ID

2025-03-18 Thread Ján Tomko via Devel
Introduced by QEMU commit TBD, the presence of this attribute allows libvirt to specify the alias of the AMDVI-PCI device explicitly. (It was implicit before the introduction of this attribute) Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 8 ++ src/qemu/qemu_cap

[libvirt PATCH 0/7] qemu: introduce amd-iommu support

2025-03-18 Thread Ján Tomko via Devel
To the cc'd QEMU developers - I'd appreciate guidance on how/whether to document and expose the 'xtsup' and 'pt' parameters to libvirt users. Based on QEMU series: Subject: [PATCH v4 0/2] hw/i386/amd_iommu: Add migration support From: Suravee Suthikulpanit Message-ID: <20250304141716.638880-1-sur

[libvirt PATCH 3/7] qemu: add IOMMU model amd

2025-03-18 Thread Ján Tomko via Devel
Introduce a new IOMMU device model 'amd', both the parser and the formatter for QEMU because of our enum warnings. https://issues.redhat.com/browse/RHEL-50560 Signed-off-by: Ján Tomko --- docs/formatdomain.rst | 5 ++- src/conf/domain_conf.c| 1

[libvirt PATCH 4/7] docs: formatdomain: document intel-only IOMMU attributes

2025-03-18 Thread Ján Tomko via Devel
Signed-off-by: Ján Tomko --- docs/formatdomain.rst | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index c5708000b8..8c122f5dae 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -8921,14 +8921,15 @@ Example

[libvirt PATCH 6/7] conf: reject some attributes not applicable to intel IOMMU

2025-03-18 Thread Ján Tomko via Devel
Signed-off-by: Ján Tomko --- src/conf/domain_validate.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index be91caee65..1f3643d441 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -3029,6 +3029,15 @@

Re: [PATCH 0/6] qemu: Add support for iothread to virtqueue mapping for 'virtio-scsi'

2025-03-18 Thread Ján Tomko via Devel
On a Friday in 2025, Peter Krempa wrote: The qemu part was now merged. Diff to rfc-v2: - The 'ctrl' and 'event' queues are not exposed to be mapped: - dropped patch for named queue support - adapted validation logic - adapted docs Peter Krempa (6): qemucapabilitiestest: Update 'caps_1

[libvirt PATCH 5/7] conf: add passthrough and xtsup attributes for IOMMU

2025-03-18 Thread Ján Tomko via Devel
For the newly supported AMD device. Signed-off-by: Ján Tomko --- docs/formatdomain.rst | 8 src/conf/domain_conf.c | 30 + src/conf/domain_conf.h | 2 ++ src/conf/schemas/domaincommon.rng | 10 ++ tests/qemu

Re: [PATCH v9 03/17] config: Introduce ThrottleGroup and corresponding XML parsing

2025-03-18 Thread Ján Tomko via Devel
On a Tuesday in 2025, Peter Krempa via Devel wrote: From: Chun Feng Wu Introduce throttlegroup into domain and provide corresponding methods * Define new struct 'virDomainThrottleGroupDef' and corresponding destructor * Add operations(Add, Update, Del, ByName, Copy, Free) for 'virDomainThrott

Re: [libvirt PATCH 3/7] qemu: add IOMMU model amd

2025-03-18 Thread Ján Tomko via Devel
On a Wednesday in 2025, Ján Tomko via Devel wrote: Introduce a new IOMMU device model 'amd', both the parser and the formatter for QEMU because of our enum warnings. https://issues.redhat.com/browse/RHEL-50560 Signed-off-by: Ján Tomko --- docs/formatdomain.rst

Re: [PATCH v9 reviewed 00/17] qemu: block: Support block disk along with throttle filters

2025-03-18 Thread Ján Tomko via Devel
On a Tuesday in 2025, Peter Krempa via Devel wrote: v9 of the throttle filtering series with my reviews and R-b tags applied. Requires [PATCH 0/5] qemu: Two block job fixes https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/TX2YAFHOFO46GR7WVQSPURWHL6O2KCDZ/ to be applied t

[libvirt PATCH] conf: also free auth for rdp in virDomainGraphicsDefFree

2025-03-18 Thread Ján Tomko via Devel
Signed-off-by: Ján Tomko Fixes: bfa7d5aaa8834c6801cacbfc6c6ea83a8ecaca9c --- Pushed as a trivial CI fix src/conf/domain_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5748a89bd1..d05e68dd41 100644 --- a/src/conf/domain_conf.c +++

Re: [PATCH v3 00/20] Add qemu RDP server support

2025-03-18 Thread Ján Tomko via Devel
On a Tuesday in 2025, Peter Krempa via Devel wrote: On Sun, Mar 16, 2025 at 12:18:21 +0400, marcandre.lureau--- via Devel wrote: From: Marc-André Lureau Marc-André Lureau (20): build-sys: drop -Winline when optimization=g build: fix -Werror=maybe-uninitialized qemu-slirp: drop unneeded ch

[libvirt PATCH 7/7] qemu: format pt and xstup on the command line

2025-03-18 Thread Ján Tomko via Devel
Signed-off-by: Ján Tomko --- src/qemu/qemu_command.c| 2 ++ tests/qemuxmlconfdata/amd-iommu.x86_64-latest.args | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 269455ff3b..b778c76f5a 100644 --

Re: [PATCH v2] virsh: Introduce new hypervisor-cpu-models command

2025-03-20 Thread Ján Tomko via Devel
On a Thursday in 2025, Collin Walling wrote: From: David Judkovics Add new virsh command 'hypervisor-cpu-models'. Command pulls from the existing domcapabilities XML and uses xpath to parse CPU model strings. By default, only models reported as usable by the hypervisor on the host system are p

[libvirt PATCH 3/7] Deprecate the QEMU driver

2025-04-04 Thread Ján Tomko via Devel
From: Ján Tomko For mutliple reasons, the use of the QEMU driver is no longer recommended: 1. It is still incomplete Git statistics from '3 years ago' speak for themselves: src/qemu: 42505 insertions(+), 31154 deletions(-) Compared to other drivers that are mostly completed and do not re

Re: [PATCH 3/8] conf: Introduce VIR_STORAGE_NET_HOST_TRANS_FD

2025-04-05 Thread Ján Tomko via Devel
On a Friday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa Prepare the parser code and anything using 'virStorageNetHostTransport' to support passing a FD instead of opening the connection by qemu itself. For now this just preparse the parser and data structures, but the code *pre

Re: [PATCH] esxConnectListAllDomains: Don't propagate failure to lookup a single domain

2025-03-26 Thread Ján Tomko via Devel
On a Wednesday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa In esxConnectListAllDomains if the lookup of the VM name and UUID fails for a single VM (possible e.g. with broken storage) the whole API would return failure even when there are working VMs. Rework the lookup so that if

[libvirt PATCH] NEWS: fix even more typos

2025-03-27 Thread Ján Tomko via Devel
From: Ján Tomko The 'editting one' was: Reported-by: Martin Kletzander I found the rest myself. Signed-off-by: Ján Tomko --- Pushed as trivial. NEWS.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index 484333e55a..6ab34aa756 100644 --- a/NEW

Re: [PATCH 0/3] qemu: block copy fixes

2025-04-10 Thread Ján Tomko via Devel
On a Thursday in 2025, Peter Krempa via Devel wrote: Three patches fixing various bits in block copy job setup. Peter Krempa (3): qemu: domain: Unexport 'qemuDomainPrepareStorageSourceBlockdevNodename' qemuDomainBlockCopyCommon: Reorder setup of 'mirror' data qemuDomainBlockCopyCommon: Don

Re: [PATCH 2/3] qemuDomainBlockCopyCommon: Reorder setup of 'mirror' data

2025-04-10 Thread Ján Tomko via Devel
On a Thursday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa While exploring an idea that modified the setup of the mirror I've noticed that the code setting up the 'discard' field in the block copy job happens after setup of the stroage source, while normally e.g. in *storage qe

[libvirt PATCH] ch: fix double space in error message

2025-04-10 Thread Ján Tomko via Devel
From: Ján Tomko Make it match the errors in bhyve and QEMU drivers, where it was copied from. Fixes: 9d6e2d127e673642b0fb135b6d58539a8e332e08 Signed-off-by: Ján Tomko --- Pushed as trivial. src/ch/ch_monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ch/

Re: [PATCH v2 0/2] storage: vol-create bug fix

2025-04-10 Thread Ján Tomko via Devel
On a Wednesday in 2025, Kirill Shchetiniuk via Devel wrote: When new volume was created using 'vol-create' and '--validate' option an error occured due to invalid flags passed downward. Resolves: https://lists.libvirt.org/archives/list/us...@lists.libvirt.org/thread/7WQ2IRSPWKKV5S3N3YJTFOMAJTZJ

Re: [PATCH 0/4] qemu: Remove legacy 'nbd-export-add' code and deprecate corresponding capabilities

2025-04-08 Thread Ján Tomko via Devel
On a Tuesday in 2025, Peter Krempa via Devel wrote: Peter Krempa (4): qemu: block: Always assume support for 'block-export-add' qemu: monitor: Drop wrappers for 'nbd-server-add' qemu: capabilities: Retire QEMU_CAPS_BLOCK_EXPORT_ADD qemu: capabilities: Retire QEMU_CAPS_NBD_BITMAP src/qemu/qem

Re: [PATCH] docs: drvqemu: Fix required minimum qemu version to 6.2.0

2025-04-08 Thread Ján Tomko via Devel
On a Tuesday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa Commit 8824af826d3 (and also commit 073bf167843 before it) which bumped minimu, qemu version forgot to update the qemu driver documentation page Fixes: 8824af826d3 Signed-off-by: Peter Krempa --- docs/drvqemu.rst | 2 +- 1

Re: [PATCH 0/2] Fix migration with TPM on shared storage

2025-04-10 Thread Ján Tomko via Devel
On a Thursday in 2025, Jiri Denemark via Devel wrote: Jiri Denemark (2): qemu: Rename outgoingMigration parameter in various TPM functions qemu: Properly propagate migration state to TPM cleanup code src/qemu/qemu_domain.c| 8 src/qemu/qemu_domain.h| 2 +- src/qemu/qemu_driver

[libvirt PATCH 7/7] NEWS: Document the QEMU driver removal

2025-04-01 Thread Ján Tomko via Devel
From: Ján Tomko Signed-off-by: Ján Tomko --- NEWS.rst | 64 +++- 1 file changed, 40 insertions(+), 24 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index 03efead80f..9a8611ccb0 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -8,7 +8,23 @@ the changes

Re: [PATCH 2/8] virDomainStorageNetworkParseHost: Refactor cleanup

2025-04-01 Thread Ján Tomko via Devel
On a Friday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa Use a 'switch' statement instead of a bunch of if statements to do validation and selection what to parse. Remove the pre-clearing of the struct as we always alocate cleared allocate memory for it and we can reorder assi

[libvirt PATCH 4/7] meson: remove all references to QEMU

2025-03-31 Thread Ján Tomko via Devel
From: Ján Tomko Signed-off-by: Ján Tomko --- docs/html/meson.build | 2 +- docs/manpages/meson.build | 4 - docs/meson.build| 7 +- meson.build | 16 +--- src/meson.build | 64 +--

[libvirt PATCH 0/7] Deprecate the QEMU driver

2025-03-31 Thread Ján Tomko via Devel
See patch 3/7 (7/3 for Americans) for the reasoning Ján Tomko (7): Add a copy of the Sandwich license remote: do not generate the qemu protocol header Deprecate the QEMU driver meson: remove all references to QEMU Remove src/qemu/ tests: remove qemu NEWS: Document the QEMU driver rem

[libvirt PATCH 6/7] tests: remove qemu

2025-03-31 Thread Ján Tomko via Devel
From: Ján Tomko Signed-off-by: Ján Tomko --- tests/qemuagentdata/fsinfo.xml|39 - tests/qemuagenttest.c | 1442 - tests/qemublocktest.c | 1395 - .../backupmerge/basic-deep-out.json |25 - .../backupmerge/basic-

[libvirt PATCH 2/7] remote: do not generate the qemu protocol header

2025-03-31 Thread Ján Tomko via Devel
From: Ján Tomko In preparation for deprecating the QEMU driver, include a static copy in the source base. Signed-off-by: Ján Tomko --- src/remote/meson.build | 2 +- src/remote/qemu_protocol.h | 23 +++ 2 files changed, 24 insertions(+), 1 deletion(-) create mode 1006

[libvirt PATCH 1/7] Add a copy of the Sandwich license

2025-03-31 Thread Ján Tomko via Devel
From: Ján Tomko Rather than writing them from scratch, the following patches will introduce some files from an external project. Include the necessary license. Signed-off-by: Ján Tomko --- COPYING.Sandwich | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 COPYING.Sandwich diff

Re: [PATCH 0/8] Support FD passing for the NBD server socket used for backup

2025-04-01 Thread Ján Tomko via Devel
On a Friday in 2025, Peter Krempa via Devel wrote: See 6/8 for justification. Peter Krempa (8): virDomainStorageNetworkParseHost: Remove unpopulated 'transport' variable virDomainStorageNetworkParseHost: Refactor cleanup conf: Introduce VIR_STORAGE_NET_HOST_TRANS_FD virStorageNetHostDefCl

Re: [PATCH] news: document dropping apparmor < 3.0.0

2025-04-01 Thread Ján Tomko via Devel
On a Tuesday in 2025, Daniel P. Berrangé via Devel wrote: From: Daniel P. Berrangé Signed-off-by: Daniel P. Berrangé --- NEWS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 0cb11313cd..d359bc5a32 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -15,6 +15,8 @@ v11.3.0

Re: [PATCH] domaincapstest: Remove XMLs for already dropped qemu versions (4.2.0 - 5.1.0)

2025-04-28 Thread Ján Tomko via Devel
On a Monday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa The files were forgotten after the previous bump to use qemu-5.2 as minimum. The data for qemu-5.2, qemu-6.0, and qemu-6.1 was already removed when bumping to qemu-6.2. Signed-off-by: Peter Krempa --- .../domaincapsdata/qem

Re: [PATCH 2/2] docs: man: Document '--once' for 'virsh autostart'

2025-05-06 Thread Ján Tomko via Devel
On a Monday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa Document the '--once' option and how it combines with the setting without '--once'. Resolves: https://issues.redhat.com/browse/RHEL-89414 Signed-off-by: Peter Krempa --- docs/manpages/virsh.rst | 10 +++--- 1 file change

Re: [PATCH 1/2] API: Clarify behaviour of autostart vs autostart once

2025-05-06 Thread Ján Tomko via Devel
On a Monday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa If either of the autostart settings is enabled the VM will be autostarted. Attempt to clarify that. Signed-off-by: Peter Krempa --- src/libvirt-domain.c | 26 -- 1 file changed, 16 insertions(+), 10 d

Re: [PATCH 0/2] qemucapabilitiestest: Update of x86_64 test data for qemu-10.0 release

2025-04-24 Thread Ján Tomko via Devel
On a Wednesday in 2025, Peter Krempa via Devel wrote: Peter Krempa (2): qemucapabilitiestest: Final update for qemu-10.0 release on x86_64 qemucapabilitiestest: Final update for qemu-10.0 release on x86_64 of the 'amdsev' variant .../caps_10.0.0_x86_64+amdsev.replies | 199 +

Re: [PATCH] qemuxmlactivetest: Don't segfault when capability XMLs are invalid

2025-04-25 Thread Ján Tomko via Devel
On a Thursday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa This is purely a devel-time problem in the test suite. 'qemuxmlactivetest' invokes the whole test worker twice, once for inactive output and second time for active. Now 'testQemuInfoInitArgs' returns a failure if the XML

Re: [PATCH v2 0/2] conf: use const virDomainDef pointers

2025-04-15 Thread Ján Tomko via Devel
On a Sunday in 2025, Roman Bogorodskiy wrote: Changes since v1: - Split domain_conf and bhyve changes into separate commits - Convert virDomainNetNotifyActualDevice() as well Roman Bogorodskiy (2): conf: use const virDomainDef pointers bhyve: use const virDomainDef pointer in bhyveBuildNetArg

Re: [PATCH 00/20] Finish the work to stop hardcoding paths at build time

2025-04-29 Thread Ján Tomko via Devel
On a Tuesday in 2025, Daniel P. Berrangé via Devel wrote: Over the years we've made various changes to stop hardcoding paths at build time, but the work is incomplete. This bit us significantly in Fedora 42 where they have merged the 'sbin' and 'bin' dirs together. In the build environment we ha

Re: [PATCH 0/2] docs: Improve ability to select proper API/XML section

2025-04-04 Thread Ján Tomko via Devel
On a Wednesday in 2025, Peter Krempa via Devel wrote: Browse the result at: https://pipo.sk.gitlab.io/-/libvirt/-/jobs/9603174377/artifacts/website/docs.html (The security warning happens as my username on gitlab contains a dot.) Have you considered changing it? Peter Krempa (2): docs: Re

Re: [PATCH 0/3] ch: Misc fixes

2025-04-04 Thread Ján Tomko via Devel
On a Thursday in 2025, Michal Privoznik via Devel wrote: *** BLURB HERE *** Michal Prívozník (3): ch: Use CH_DOMAIN_PRIVATE() more ch: Drop pid from monitor ch: Fix printf format strings wrt size_t argument src/ch/ch_events.c | 4 ++-- src/ch/ch_monitor.c | 14 -- src/ch/ch_monit

Re: [PATCH 0/8] Decrease stack size below 2048 bytes

2025-04-04 Thread Ján Tomko via Devel
On a Friday in 2025, Michal Privoznik via Devel wrote: Inspired by Roman's patch: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/FNAFORLGXFBL7KPI7RTBWV2ERHX57RIR/ There are two functions where clang produces stack greater than 2048 bytes (our current limit - see @stack_f

Re: [PATCH 6/8] backup: Add support for passing server socket file descriptor to backup NBD server

2025-04-04 Thread Ján Tomko via Devel
On a Friday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa In deployments where libvirt is containerized together with the VM it may be hard for the management application to access listening sockets inside the container from the outside. This patch implements "transport='fd'" for t

Re: [PATCH 0/6] qemu: Remove last HMP commands

2025-04-02 Thread Ján Tomko via Devel
On a Wednesday in 2025, Peter Krempa via Devel wrote: RIP HMP use in libvirt: 2007-02-14 [1] - 2025-04-02 [1] 23ad665cb05ef9ce7d298cc34bff5efb95ef6948 Peter Krempa (6): qemu: domain: Don't check return value of 'virCPUDefCopy' qemuSnapshotCreateActiveInternal: Fix error logic qemu: snapshot

Re: [PATCH 1/3] ch: virCHMonitorNew() run new CH monitor daemonized

2025-04-02 Thread Ján Tomko via Devel
On a Tuesday in 2025, Kirill Shchetiniuk via Devel wrote: When the new CH monitor was started, it ran as a non-daemonized process and was a child of the CH driver process. This led to a situation where if the CH driver died, the monitor process were killed too, terminating the running VM under th

[libvirt PATCH 5/7] Remove src/qemu/

2025-04-04 Thread Ján Tomko via Devel
From: Ján Tomko Signed-off-by: Ján Tomko --- [Heavily shortened] src/qemu/libvirt-qemu.sysusers.conf | 4 - src/qemu/libvirt_qemu_probes.d |22 - src/qemu/libvirtd_qemu.aug | 205 - src/qemu/meson.build | 244 - src/qemu/postcopy-migration.sysctl

Re: [PATCH 0/8] qemu: Improve guest agent corner case errors

2025-04-04 Thread Ján Tomko via Devel
On a Thursday in 2025, Peter Krempa via Devel wrote: This series introduces two new error codes aimed to help management applications to better in deciding when corner cases of guest agent interaction are encountered. Peter Krempa (8): lib: error: Introduce 'VIR_ERR_AGENT_COMMAND_TIMEOUT' qemu

Re: [PATCH 1/3] ch: virCHMonitorNew() run new CH monitor daemonized

2025-04-04 Thread Ján Tomko via Devel
On a Wednesday in 2025, Kirill Shchetiniuk wrote: Thanks Jan, Didn’t noticed the issue with the white symbols when submitted a patch, next time will keep it in mind and be careful. Btw, do we have some tools to check and warn such possible issues? For the extra/removed lines, git diff/git s

Re: [PATCH 1/2] virNetDevTapCreate: Use error message hinting to multiqueue use only when opening multiple queues

2025-05-13 Thread Ján Tomko via Devel
On a Tuesday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa Due to a logic bug the error message mentioning mult_queue operation multi_queue would be mentioned also when a single queue would be opened on an externally managed tap device. Adjust the condition to trigger only when

Re: [PATCH 0/2] spec: Bump min_rhel and min_fedora

2025-05-16 Thread Ján Tomko via Devel
On a Friday in 2025, Michal Privoznik via Devel wrote: Per our support policy [1], the minimal version we aim to support is RHEL-9 and Fedora 41. Reflect this in the spec file. 1: https://libvirt.org/platforms.html Michal Prívozník (2): spec: Bump min_rhel spec: Bump min_fedora libvirt.spec.

Re: [PATCH] cpu_x86: Do not inline cpuidCall()

2025-05-16 Thread Ján Tomko via Devel
On a Wednesday in 2025, Fabio Estevam wrote: The following build error is observed with DEBUG_BUILD = 1: What exactly is DEBUG_BUILD? I can't find the variable anywhere. --buildtype debug is the default for meson with -Doptimization=g this should already be disabled since: commit 7253dda5178e

[libvirt PATCH 1/2] build: prohibit inline functions in C files by syntax-check

2025-05-16 Thread Ján Tomko via Devel
From: Ján Tomko Signed-off-by: Ján Tomko --- build-aux/syntax-check.mk | 10 ++ src/hyperv/hyperv_wmi.c| 2 +- src/locking/lock_daemon.c | 4 ++-- src/qemu/qemu_block.c | 2 +- src/qemu/qemu_command.c| 2 +- src/qemu/qemu_saveimage.c | 2 +- src/rpc/virnetserver.c

[libvirt PATCH 0/2] Remove 'inline' keyword from C files

2025-05-16 Thread Ján Tomko via Devel
Ján Tomko (2): build: prohibit inline functions in C files by syntax-check build: do not use -Winline build-aux/syntax-check.mk | 10 ++ meson.build| 6 -- src/hyperv/hyperv_wmi.c| 2 +- src/locking/lock_daemon.c | 4 ++-- src/qemu/qemu_block.c | 2 +

[libvirt PATCH 2/2] build: do not use -Winline

2025-05-16 Thread Ján Tomko via Devel
From: Ján Tomko We don't really care if a function cannot be inlined. Signed-off-by: Ján Tomko --- meson.build | 6 -- 1 file changed, 6 deletions(-) diff --git a/meson.build b/meson.build index bb0436e072..a46c2a7037 100644 --- a/meson.build +++ b/meson.build @@ -438,12 +438,6 @@ cc_flag

[libvirt PATCH] qemu: forbid readonly attribute for externally launched virtiofsd

2025-05-19 Thread Ján Tomko via Devel
From: Ján Tomko In that case, libvirtd cannot set it on the command line because virtiofsd is not launched by libvirt. https://issues.redhat.com/browse/RHEL-87522 Signed-off-by: Ján Tomko --- src/qemu/qemu_validate.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_valid

Re: [PATCH 1/3] qemuBackupPrepare: Actually allow 'VIR_STORAGE_NET_HOST_TRANS_FD'

2025-05-19 Thread Ján Tomko via Devel
On a Monday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa While I've actually implemented support for FD passing the NBD server socket in eb768a556db I managed to misplace the hunk allowing the 'FD' transport in the validation code, rendering the whole feature useless. Fix the vali

Re: [PATCH 2/3] docs: backup: Hint at proper selinux labelling of the FD-passed NBD socket

2025-05-19 Thread Ján Tomko via Devel
On a Monday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa In case selinux is used on the host the socket passed to qemu needs to be properly labelled. Add a hint to the example code. Signed-off-by: Peter Krempa --- docs/formatbackup.rst | 4 1 file changed, 4 insertions(+) di

Re: [PATCH 3/3] qemu: fd: Log information about passed file descriptor

2025-05-19 Thread Ján Tomko via Devel
On a Monday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa Log information (type, label, etc) about FDs passed to qemu via APIs from this module. This does "spill" the selinux library code into this module, but acessing it via the security driver would require passing much more cont

Re: [PATCH 1/1] NEWS : update NEWS for POWER11 support

2025-05-28 Thread Ján Tomko via Devel
Extra space between "NEWS" and ":" On a Wednesday in 2025, Narayana Murty N wrote: Update NEWS.rst with the now added POWER11 processor support Signed-off-by: Narayana Murty N --- NEWS.rst | 4 1 file changed, 4 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc Description: PG

Re: [PATCH] qemu: Fix error when migration with shared TPM storage is unsupported

2025-05-28 Thread Ján Tomko via Devel
On a Wednesday in 2025, Jiri Denemark via Devel wrote: From: Jiri Denemark The VIR_ERR_NO_SUPPORT error is supposed to be used for unsupported driver APIs. It is incorrectly used when swtpm does not support migration with shared storage resulting in a rather strange error message: this func

Re: [PATCH v4 1/2] virDomainVirtioSerialAddrAssign: Fix virtio console port assignment on vioserial bus

2025-05-27 Thread Ján Tomko via Devel
On a Monday in 2025, Peter Krempa via Devel wrote: On Thu, May 22, 2025 at 21:27:34 -0400, Aaron M. Brown wrote: This change fixes an issue with virito console port assignment on vioserial buses. s/viritio/virtio/ Jano Currently, a virtio console device cannot be assigned to a port greater

Re: [PATCH 6/7] libvirt_nss: Allocate buffer in ERROR() dynamically

2025-05-22 Thread Ján Tomko via Devel
On a Thursday in 2025, Michal Privoznik via Devel wrote: From: Michal Privoznik So far, inside of the ERROR() macro there's pretty large buffer allocated on the stack (for use by strerror_r()). Problem is, with our current stack size limit of 2048 bytes we may come pretty close to the limit or

Re: [PATCH] virsh: Do not print warnings with "error:" prefix

2025-05-22 Thread Ján Tomko via Devel
On a Thursday in 2025, Jiri Denemark via Devel wrote: From: Jiri Denemark Both vshWarn and vshError are just wrappers around vshPrintStderr which properly propagates the message level to the log, but fails to honor it when printing on stderr. https://issues.redhat.com/browse/RHEL-79460 Signed

Re: [PATCH] docs: domain: Explain supported options of 'error_policy'

2025-05-22 Thread Ján Tomko via Devel
On a Wednesday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa Explain what the individual settings actually result in. The changes are based on the paraprhase of qemu documentation which in 'qemu-options.hx' states: ``werror=action,rerror=action`` Specify which action to take

Re: [PATCH v5 0/5] Adding POWER11 CPU Support

2025-05-22 Thread Ján Tomko via Devel
On a Tuesday in 2025, Narayana Murty N wrote: This patch series introduces the necessary changes to support the POWER11 CPU and POWER11 host in libvirt. Additionally, it updates the QEMU capabilities with the latest QEMU version v10.0.0 to include power11 in the capabilities tests.During testing

Re: [PATCH 07/11] qemu_capabilities: Add emulated NVMe disk support to domain capabilities

2025-06-02 Thread Ján Tomko via Devel
On a Monday in 2025, Martin Kletzander via Devel wrote: From: Martin Kletzander This is a separate commit for review ease, but who's really going to use a libvirt with this patch in and the actual functionality missing, that ain't gonna happen, right? You can trade it for a problem of the ac

Re: [PATCH] docs: fix indent of hostdev examples

2025-06-02 Thread Ján Tomko via Devel
On a Friday in 2025, Daniel P. Berrangé via Devel wrote: From: Daniel P. Berrangé Signed-off-by: Daniel P. Berrangé --- docs/formatdomain.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) Trivial. Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 00/11] Support for emulated NVMe disks in VMX and QEMU

2025-06-02 Thread Ján Tomko via Devel
On a Monday in 2025, Martin Kletzander via Devel wrote: I took the liberty of adjusting Hongwei's QEMU series and made further adjustments so that the common code can be used for reporting NVMe disks from VMX as well. I added SoBs where I thought applicable, but feel free to correct me and/or ag

Re: [PATCH] NEWS: Mention removal of compile time helper program lookup, virito-net ABI check and FDC capabilities

2025-05-29 Thread Ján Tomko via Devel
On a Thursday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa Signed-off-by: Peter Krempa --- NEWS.rst | 25 + 1 file changed, 25 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index fd577021b3..884fcad2d8 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -35,6 +35,24 @

Re: [PATCH 03/15] storage_file_probe: qcow2GetExtensions: Fix qcow2 header extension parsing

2025-05-29 Thread Ján Tomko via Devel
On a Thursday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa There are 3 bugs in the qcow2 header extension parser: 1) Header extension padding not taken into account Per qcow2 documentation (qemu.git/docs/interop/qcow2.txt, also now mirrored in the comment explaining the parser)

Re: [PATCH 13/15] storage_file_probe: Parse all qcow2 extensions at once

2025-05-29 Thread Ján Tomko via Devel
On a Thursday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa Refactor qcow2GetExtensions to parse everything at once and directly assign it into fields in the parsed virStorageSource. This removes the need for qcow2GetDataFile as it will be parsed directly. The patch also simplifie

Re: [PATCH 00/15] storage_file_probe: Fix ancient bug in qcow2 header extensions parser and refactor the image probing callbacks

2025-05-29 Thread Ján Tomko via Devel
On a Thursday in 2025, Peter Krempa via Devel wrote: Patch 3 fixes an almost 15 year old bug in the qcow2 header extension parser which breaks when the qcow2 image has more than 1 header extension. For us it caused problems for qcow2 images with data file and backing file which we didn't use befo

Re: [PATCH 0/3] util: Fix virFileIsSharedFSOverride on nonexistent paths

2025-05-29 Thread Ján Tomko via Devel
On a Thursday in 2025, Jiri Denemark via Devel wrote: Jiri Denemark (3): util: Document limitation of virFileCanonicalizePath util: Introduce virFileGetExistingParent helper util: Fix virFileIsSharedFSOverride on nonexistent paths src/util/virfile.c | 76 +++---

Re: [PATCH 01/15] qcow2GetExtensions: Add debug logs for interesting fields in qcow2 header extension parser

2025-05-29 Thread Ján Tomko via Devel
On a Thursday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa Add debug statements which were useful in figuring out bugs in the qcow2 extension parser. Signed-off-by: Peter Krempa --- src/storage_file/storage_file_probe.c | 6 ++ 1 file changed, 6 insertions(+) Reviewed-by: J

Re: [PATCH 02/15] virstoragetest: Reformat output to hilight dataFile relationship

2025-05-29 Thread Ján Tomko via Devel
In the commit summary: s/hilight/highlight/ On a Thursday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa Move the 'dataFileRaw' field to the main block as it's based on the data in the qcow2 header same as 'backingStoreRaw'. Indent and annotate the corresponding dataFile block to s

Re: [PATCH] qemu: command: Don't attempt to set backend MTU for networks which don't use host backend directly

2025-06-03 Thread Ján Tomko via Devel
On a Monday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa Attempting to set MTU for network types which don't actually use the network device on the host results in a failure. The 'mtu' property is also used e.g. for the 'host_mtu' property of e.g. 'virtio-net-pci' which is applied

Re: [PATCH 0/7] virsh: Fix cleanup in 'event' command and introduce 'await' command

2025-06-05 Thread Ján Tomko via Devel
On a Thursday in 2025, Peter Krempa via Devel wrote: 'virsh await' is a helper/syntax-sugar command which allows you to wait until a domain reaches a certain state. Currently this series implements conditions named 'domain-inactive' and 'guest-agent-available'. Peter Krempa (7): virthread: Regi

[libvirt PATCH v2 3/7] qemu: add IOMMU model amd

2025-06-18 Thread Ján Tomko via Devel
From: Ján Tomko Introduce a new IOMMU device model 'amd', both the parser and the formatter for QEMU because of our enum warnings. https://issues.redhat.com/browse/RHEL-50560 Signed-off-by: Ján Tomko --- docs/formatdomain.rst | 5 ++- src/conf/domain_conf.c

[libvirt PATCH v2 1/7] qemu: introduce QEMU_CAPS_AMD_IOMMU

2025-06-18 Thread Ján Tomko via Devel
From: Ján Tomko Check for the presence of the amd-iommu device, so we can conditionalize probing for its properties. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 4 src/qemu/qemu_capabilities.h | 3 +++ tests/qemucapab

[libvirt PATCH v2 REBASED 0/7] qemu: introduce amd-iommu support

2025-06-18 Thread Ján Tomko via Devel
Ján Tomko (7): qemu: introduce QEMU_CAPS_AMD_IOMMU qemu: introduce QEMU_CAPS_PCI_ID qemu: add IOMMU model amd docs: formatdomain: document intel-only IOMMU attributes conf: add passthrough and xtsup attributes for IOMMU conf: reject some attributes not applicable to intel IOMMU qemu:

[libvirt PATCH v2 2/7] qemu: introduce QEMU_CAPS_PCI_ID

2025-06-18 Thread Ján Tomko via Devel
From: Ján Tomko Introduced by QEMU commit f864a3235ea1d1d714b3cde2d9a810ea6344a7b5 the presence of this attribute allows libvirt to specify the alias of the AMDVI-PCI device explicitly. (It was implicit before the introduction of this attribute) Signed-off-by: Ján Tomko --- src/qemu/qemu_capa

[libvirt PATCH v2 4/7] docs: formatdomain: document intel-only IOMMU attributes

2025-06-18 Thread Ján Tomko via Devel
From: Ján Tomko Signed-off-by: Ján Tomko --- docs/formatdomain.rst | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 53d4349d2b..7ebb4c3e9e 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -9077,14 +

[libvirt PATCH v2 6/7] conf: reject some attributes not applicable to intel IOMMU

2025-06-18 Thread Ján Tomko via Devel
From: Ján Tomko Signed-off-by: Ján Tomko --- src/conf/domain_validate.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index b9a6740437..b28af7fa56 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -

[libvirt PATCH v2 5/7] conf: add passthrough and xtsup attributes for IOMMU

2025-06-18 Thread Ján Tomko via Devel
From: Ján Tomko For the newly supported AMD device. Signed-off-by: Ján Tomko --- docs/formatdomain.rst | 8 src/conf/domain_conf.c | 30 + src/conf/domain_conf.h | 2 ++ src/conf/schemas/domaincommon.rng | 10

[libvirt PATCH v2 7/7] qemu: format pt and xstup on the command line

2025-06-18 Thread Ján Tomko via Devel
From: Ján Tomko Signed-off-by: Ján Tomko --- src/qemu/qemu_command.c| 2 ++ tests/qemuxmlconfdata/amd-iommu.x86_64-latest.args | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 6fae9b1f5a..b7

Re: [PATCH] NEWS: mention console type in domain capabilities

2025-06-20 Thread Ján Tomko via Devel
On a Thursday in 2025, Roman Bogorodskiy wrote: Signed-off-by: Roman Bogorodskiy --- NEWS.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 7d7df72a50..184df16547 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -47,6 +47,17 @@ v11.5.0 (unreleased) * **Improve

[libvirt PATCH] docs: clarify how to build without -Werror

2025-06-24 Thread Ján Tomko via Devel
From: Ján Tomko --werror does not accept any arguments for me and setting git_werror was also needed to disable it with git. Signed-off-by: Ján Tomko --- docs/compiling.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/compiling.rst b/docs/compiling.rst index 0a4

Re: [PATCH] security_manager: Don't leak seclabel in virSecurityManagerGenLabel()

2025-06-17 Thread Ján Tomko via Devel
On a Monday in 2025, Michal Privoznik via Devel wrote: From: Michal Privoznik When a domain is being started, seclabels are generated for it. This is handled in virSecurityManagerGenLabel() which can either find pre-existing seclabel in domain def or generate a new one. At any rate, domainGenSe

Re: [PATCH 0/6] Various fixes and cleanups

2025-06-17 Thread Ján Tomko via Devel
On a Tuesday in 2025, Peter Krempa via Devel wrote: A collection of random one-off fixes for issues where the root cause was analyzed by the reporter and cleanups that I've recently accumulated. Peter Krempa (6): storage_file_probe: Use named initializer for 'struct FileTypeInfo' virQEMUCapsFi

  1   2   >