Re: [PATCH-for-9.1] rdma: Remove RDMA subsystem and pvrdma device

2024-03-27 Thread Fabiano Rosas
from contrib/. > > Remove PVRDMA device. > > Cc: Peter Xu > Cc: Li Zhijian > Cc: Yuval Shaia > Cc: Marcel Apfelbaum > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Fabiano Rosas ___ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-03-28 Thread Fabiano Rosas
erbs and librdmacm > > Keep the RAM_SAVE_FLAG_HOOK definition since it might appears > in old migration streams. > > Cc: Peter Xu > Cc: Li Zhijian > Acked-by: Fabiano Rosas > Signed-off-by: Philippe Mathieu-Daudé Just to be clear, because people raised the point in the

[PATCH 0/6] migration removals & deprecations

2024-04-25 Thread Fabiano Rosas
fact that the new MigrationAddress API defines transports instead of protocols (loose terms) like the old string API did. So we cannot map 1:1 from fd: to any transport because fd: allows *both* file migration and socket migration. CI run: https://gitlab.com/farosas/qemu/-/pipelines/1267859704 Fab

[PATCH 1/6] migration: Remove 'skipped' field from MigrationStats

2024-04-25 Thread Fabiano Rosas
The 'skipped' field of the MigrationStats struct has been deprecated in 8.1. Time to remove it. Deprecation commit 7b24d32634 ("migration: skipped field is really obsolete."). Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 6 -- docs/about/remo

[PATCH 2/6] migration: Remove 'inc' option from migrate command

2024-04-25 Thread Fabiano Rosas
The block incremental option for block migration has been deprecated in 8.2 in favor of using the block-mirror feature. Remove it now. Deprecation commit 40101f320d ("migration: migrate 'inc' command option is deprecated."). Signed-off-by: Fabiano Rosas --- docs/about/depre

[PATCH 3/6] migration: Remove 'blk/-b' option from migrate commands

2024-04-25 Thread Fabiano Rosas
n a future patch. Deprecation commit 8846b5bfca ("migration: migrate 'blk' command option is deprecated."). Signed-off-by: Fabiano Rosas --- .gitlab-ci.d/buildtest.yml | 2 +- docs/about/deprecated.rst| 9 -- docs/about/removed-features.rst | 15 +++- migratio

[PATCH 6/6] migration: Deprecate fd: for file migration

2024-04-25 Thread Fabiano Rosas
ile usage, which is thought to be rarely used currently and instead establish a 1:1 correspondence between fd: URI and socket transport, and file: URI and file transport. Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git

[PATCH 4/6] migration: Remove block migration

2024-04-25 Thread Fabiano Rosas
Signed-off-by: Fabiano Rosas --- MAINTAINERS |1 - docs/about/deprecated.rst | 10 - docs/about/removed-features.rst | 14 + docs/devel/migration/main.rst |2 +- include/migration/misc.h|6 - meson.build |2 - me

[PATCH 5/6] migration: Remove non-multifd compression

2024-04-25 Thread Fabiano Rosas
eprecation commit 864128df46 ("migration: Deprecate old compression method"). Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 11 - docs/about/removed-features.rst | 55 hw/core/machine.c | 1 - migration/meson.build | 1 - migration/

Re: [PATCH 0/6] migration removals & deprecations

2024-04-26 Thread Fabiano Rosas
Markus Armbruster writes: > Doesn't apply for me. What's your base? 88daa112d4 ("Merge tag 'migration-20240423-pull-request' of https://gitlab.com/peterx/qemu into staging") Probably clashed with the other removals from Philippe. ___ Devel mailing li

Re: Revisiting parallel save/restore

2024-04-26 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Wed, Apr 17, 2024 at 05:12:27PM -0600, Jim Fehlig via Devel wrote: >> A good starting point on this journey is supporting the new mapped-ram >> capability in qemu 9.0 [2]. Since mapped-ram is a new on-disk format, I >> assume we'll need a new QEMU_SAVE_VERSION 3 wh

[PATCH v2 0/6] migration removals & deprecations

2024-04-26 Thread Fabiano Rosas
v1: https://lore.kernel.org/r/20240425150939.19268-1-faro...@suse.de Fabiano Rosas (6): migration: Remove 'skipped' field from MigrationStats migration: Remove 'inc' option from migrate command migration: Remove 'blk/-b' option from migrate commands migration: Remove

[PATCH v2 1/6] migration: Remove 'skipped' field from MigrationStats

2024-04-26 Thread Fabiano Rosas
The 'skipped' field of the MigrationStats struct has been deprecated in 8.1. Time to remove it. Deprecation commit 7b24d32634 ("migration: skipped field is really obsolete."). Reviewed-by: Markus Armbruster Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst

[PATCH v2 2/6] migration: Remove 'inc' option from migrate command

2024-04-26 Thread Fabiano Rosas
The block incremental option for block migration has been deprecated in 8.2 in favor of using the block-mirror feature. Remove it now. Deprecation commit 40101f320d ("migration: migrate 'inc' command option is deprecated."). Signed-off-by: Fabiano Rosas --- docs/about/depre

[PATCH v2 3/6] migration: Remove 'blk/-b' option from migrate commands

2024-04-26 Thread Fabiano Rosas
n a future patch. Deprecation commit 8846b5bfca ("migration: migrate 'blk' command option is deprecated."). Signed-off-by: Fabiano Rosas --- .gitlab-ci.d/buildtest.yml | 2 +- docs/about/deprecated.rst| 9 -- docs/about/removed-features.rst | 14 +++ migratio

[PATCH v2 6/6] migration: Deprecate fd: for file migration

2024-04-26 Thread Fabiano Rosas
ile usage, which is thought to be rarely used currently and instead establish a 1:1 correspondence between fd: URI and socket transport, and file: URI and file transport. Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git

[PATCH v2 4/6] migration: Remove block migration

2024-04-26 Thread Fabiano Rosas
Signed-off-by: Fabiano Rosas --- MAINTAINERS |1 - docs/about/deprecated.rst | 10 - docs/about/removed-features.rst | 14 + docs/devel/migration/main.rst |2 +- include/migration/misc.h|6 - meson.build |2 - me

[PATCH v2 5/6] migration: Remove non-multifd compression

2024-04-26 Thread Fabiano Rosas
eprecation commit 864128df46 ("migration: Deprecate old compression method"). Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 11 - docs/about/removed-features.rst | 55 hw/core/machine.c | 1 - migration/meson.build | 1 - migration/

Re: [PATCH 0/6] migration removals & deprecations

2024-04-26 Thread Fabiano Rosas
Markus Armbruster writes: > Fabiano Rosas writes: > >> Markus Armbruster writes: >> >>> Doesn't apply for me. What's your base? >> >> 88daa112d4 ("Merge tag 'migration-20240423-pull-request' of >> https://gitlab.com/pet

Re: [PATCH 3/6] migration: Remove 'blk/-b' option from migrate commands

2024-04-26 Thread Fabiano Rosas
Markus Armbruster writes: > Markus Armbruster writes: > >> Fabiano Rosas writes: >> >>> The block migration is considered obsolete and has been deprecated in >>> 8.2. Remove the migrate command option that enables it. This only >>> affects the Q

Re: Revisiting parallel save/restore

2024-04-26 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Fri, Apr 26, 2024 at 10:03:29AM -0300, Fabiano Rosas wrote: >> Daniel P. Berrangé writes: >> >> > On Wed, Apr 17, 2024 at 05:12:27PM -0600, Jim Fehlig via Devel wrote: >> >> A good starting point on this journey is supporting

Re: [PATCH v2 3/6] migration: Remove 'blk/-b' option from migrate commands

2024-04-29 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Apr 26, 2024 at 10:14:05AM -0300, Fabiano Rosas wrote: >> @@ -2003,21 +1997,7 @@ static bool migrate_prepare(MigrationState *s, bool >> blk, bool resume, >> } >> } >> >> -if (blk) { >> -if (migr

Re: [PATCH v2 3/6] migration: Remove 'blk/-b' option from migrate commands

2024-04-29 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Apr 29, 2024 at 02:18:57PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Fri, Apr 26, 2024 at 10:14:05AM -0300, Fabiano Rosas wrote: >> >> @@ -2003,21 +1997,7 @@ static bool migrate_prepare(MigrationSt

Re: [PATCH v2 6/6] migration: Deprecate fd: for file migration

2024-04-29 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Apr 26, 2024 at 10:14:08AM -0300, Fabiano Rosas wrote: >> The fd: URI can currently trigger two different types of migration, a >> TCP migration using sockets and a file migration using a plain >> file. This is in conflict with the recently

[PATCH v3 0/6] migration removals & deprecations

2024-04-30 Thread Fabiano Rosas
instead of protocols (loose terms) like the old string API did. So we cannot map 1:1 from fd: to any transport because fd: allows *both* file migration and socket migration. Fabiano Rosas (6): migration: Remove 'skipped' field from MigrationStats migration: Remove 'inc'

[PATCH v3 1/6] migration: Remove 'skipped' field from MigrationStats

2024-04-30 Thread Fabiano Rosas
The 'skipped' field of the MigrationStats struct has been deprecated in 8.1. Time to remove it. Deprecation commit 7b24d32634 ("migration: skipped field is really obsolete."). Reviewed-by: Markus Armbruster Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- docs/

[PATCH v3 2/6] migration: Remove 'inc' option from migrate command

2024-04-30 Thread Fabiano Rosas
The block incremental option for block migration has been deprecated in 8.2 in favor of using the block-mirror feature. Remove it now. Deprecation commit 40101f320d ("migration: migrate 'inc' command option is deprecated."). Reviewed-by: Markus Armbruster Signed-off-by: Fabi

[PATCH v3 3/6] migration: Remove 'blk/-b' option from migrate commands

2024-04-30 Thread Fabiano Rosas
n a future patch. Deprecation commit 8846b5bfca ("migration: migrate 'blk' command option is deprecated."). Reviewed-by: Markus Armbruster Signed-off-by: Fabiano Rosas --- .gitlab-ci.d/buildtest.yml | 2 +- docs/about/deprecated.rst| 9 -- docs/about/remove

[PATCH v3 6/6] migration: Deprecate fd: for file migration

2024-04-30 Thread Fabiano Rosas
ile usage, which is thought to be rarely used currently and instead establish a 1:1 correspondence between fd: URI and socket transport, and file: URI and file transport. Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 14 ++ migration/fd.c| 12

[PATCH v3 4/6] migration: Remove block migration

2024-04-30 Thread Fabiano Rosas
). Reviewed-by: Markus Armbruster Signed-off-by: Fabiano Rosas --- MAINTAINERS |1 - docs/about/deprecated.rst | 10 - docs/about/removed-features.rst | 14 + docs/devel/migration/main.rst |2 +- include/migration/misc.h|6 - meson.build

[PATCH v3 5/6] migration: Remove non-multifd compression

2024-04-30 Thread Fabiano Rosas
eprecation commit 864128df46 ("migration: Deprecate old compression method"). Acked-by: Markus Armbruster Signed-off-by: Fabiano Rosas --- docs/about/deprecated.rst | 11 - docs/about/removed-features.rst | 55 hw/core/machine.c | 1 - migration/meson.b

Re: [PATCH v3 06/17] hw/sd/sdcard: Do not store vendor data on block drive (CMD56)

2024-07-09 Thread Fabiano Rosas
Philippe Mathieu-Daudé writes: > "General command" (GEN_CMD, CMD56) is described as: > > GEN_CMD is the same as the single block read or write > commands (CMD24 or CMD17). The difference is that [...] > the data block is not a memory payload data but has a > vendor specific format and mea

Re: [PATCH v3 06/17] hw/sd/sdcard: Do not store vendor data on block drive (CMD56)

2024-07-10 Thread Fabiano Rosas
Peter Xu writes: > On Tue, Jul 09, 2024 at 05:38:54PM -0300, Fabiano Rosas wrote: >> Philippe Mathieu-Daudé writes: >> >> > "General command" (GEN_CMD, CMD56) is described as: >> > >> > GEN_CMD is the same as the single block read or write

Re: [PATCH v3 06/17] hw/sd/sdcard: Do not store vendor data on block drive (CMD56)

2024-07-10 Thread Fabiano Rosas
Peter Xu writes: > On Wed, Jul 10, 2024 at 11:08:20AM -0300, Fabiano Rosas wrote: >> >> I think it's ok: >> >> >> >> { >> >> "field": "unused", >> >> "version_id": 1, >> >> &qu

Re: [PATCH v3 06/17] hw/sd/sdcard: Do not store vendor data on block drive (CMD56)

2024-07-10 Thread Fabiano Rosas
Peter Xu writes: > On Wed, Jul 10, 2024 at 01:21:51PM -0300, Fabiano Rosas wrote: >> It's not about trust, we simply don't support migrations other than >> n->n+1 and (maybe) n->n-1. So QEMU from 2016 is certainly not included. > > Where does it come fro

Re: [PATCH v3 06/17] hw/sd/sdcard: Do not store vendor data on block drive (CMD56)

2024-07-10 Thread Fabiano Rosas
Peter Xu writes: > On Wed, Jul 10, 2024 at 04:48:23PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Wed, Jul 10, 2024 at 01:21:51PM -0300, Fabiano Rosas wrote: >> >> It's not about trust, we simply don't support migrations other than

Re: [PATCH v3 06/17] hw/sd/sdcard: Do not store vendor data on block drive (CMD56)

2024-07-11 Thread Fabiano Rosas
Peter Xu writes: > On Wed, Jul 10, 2024 at 06:38:26PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Wed, Jul 10, 2024 at 04:48:23PM -0300, Fabiano Rosas wrote: >> >> Peter Xu writes: >> >> >> >> > On Wed, Jul 10, 2

Re: [PATCH v3 06/17] hw/sd/sdcard: Do not store vendor data on block drive (CMD56)

2024-07-11 Thread Fabiano Rosas
Peter Xu writes: > On Thu, Jul 11, 2024 at 10:34:12AM -0300, Fabiano Rosas wrote: >> Is there an easy way to look at a field and tell in which machine type's >> timeframe it was introduced? > > I am not aware of any. > >> If the machine type of that era has b

Re: [PATCH v3 06/17] hw/sd/sdcard: Do not store vendor data on block drive (CMD56)

2024-07-11 Thread Fabiano Rosas
Peter Xu writes: > On Thu, Jul 11, 2024 at 11:44:08AM -0300, Fabiano Rosas wrote: >> But of course, that means we cannot claim to support all kinds of >> forward migrations anymore. Only those in the 6 year period. > > That "6 years" comes from machine type de

Re: [PATCH v2 4/4] virtio-net: Add support for USO features

2024-08-09 Thread Fabiano Rosas
Peter Xu writes: > On Thu, Aug 08, 2024 at 10:47:28AM -0400, Michael S. Tsirkin wrote: >> On Thu, Aug 08, 2024 at 10:15:36AM -0400, Peter Xu wrote: >> > On Thu, Aug 08, 2024 at 07:12:14AM -0400, Michael S. Tsirkin wrote: >> > > This is too big of a hammer. People already use what you call "cross

Re: [PATCH 10/20] qemu: Add support for mapped-ram on save

2024-10-10 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Thu, Aug 08, 2024 at 05:38:03PM -0600, Jim Fehlig via Devel wrote: >> Introduce support for QEMU's new mapped-ram stream format [1]. >> mapped-ram is enabled by default if the underlying QEMU advertises >> the mapped-ram migration capability. It can be disabled by

Re: [PATCH 10/20] qemu: Add support for mapped-ram on save

2024-10-10 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Thu, Oct 10, 2024 at 12:06:51PM -0300, Fabiano Rosas wrote: >> Daniel P. Berrangé writes: >> >> > On Thu, Aug 08, 2024 at 05:38:03PM -0600, Jim Fehlig via Devel wrote: >> >> Introduce support for QEMU's new mapped-r

Re: [PATCH 10/20] qemu: Add support for mapped-ram on save

2024-10-14 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Thu, Oct 10, 2024 at 02:52:56PM -0300, Fabiano Rosas wrote: >> Daniel P. Berrangé writes: >> >> > On Thu, Oct 10, 2024 at 12:06:51PM -0300, Fabiano Rosas wrote: >> >> Daniel P. Berrangé writes: >> >> >> >

Re: [PATCH 1/3] tests/qtest/test-x86-cpuid-compat: Remove tests related to pc-i440fx-2.3

2025-01-17 Thread Fabiano Rosas
Thomas Huth writes: > The pc-i440fx-2.3 machine type has been removed in commit 46a2bd5257 > ("hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine") already, so > these tests are just dead code by now. > > Signed-off-by: Thomas Huth Reviewed-by: Fabiano Ros

Re: [PATCH 2/4] qapi/migration: Deprecate migrate argument @detach

2025-05-21 Thread Fabiano Rosas
Markus Armbruster writes: > Argument @detach has always been ignored. Start the clock to get rid > of it. > > Cc: Peter Xu > Cc: Fabiano Rosas > Signed-off-by: Markus Armbruster Reviewed-by: Fabiano Rosas

[PATCH v2 18/24] qapi/migration: Deprecate capabilities commands

2025-06-30 Thread Fabiano Rosas
The concept of capabilities is being merged into the concept of parameters. From now on, the commands that handle capabilities are deprecated in favor of the commands that handle parameters. Affected commands: - migrate-set-capabilities - query-migrate-capabilities Signed-off-by: Fabiano Rosas