Re: [PATCH] docs: document workaround for DMARC countermeasures

2025-03-17 Thread Daniel P . Berrangé via Devel
On Mon, Mar 17, 2025 at 09:27:51AM -0400, Laine Stump wrote: > On 3/17/25 7:29 AM, Jiri Denemark via Devel wrote: > > On Mon, Mar 17, 2025 at 11:23:00 +0000, Daniel P. Berrangé via Devel wrote: > > > From: Daniel P. Berrangé > > > > > > If a contributor

Re: [PATCH] Add NEWS item for auto-shutdown feature

2025-03-20 Thread Daniel P . Berrangé via Devel
On Thu, Mar 20, 2025 at 01:44:41PM -0400, Laine Stump wrote: > On 3/20/25 10:57 AM, Daniel P. Berrangé via Devel wrote: > > From: Daniel P. Berrangé > > > > Signed-off-by: Daniel P. Berrangé > > --- > > NEWS.rst | 17 + > > 1 file change

Re: [libvirt PATCH 0/6] cleanup and fixes of the mapped-ram feature

2025-03-21 Thread Daniel P . Berrangé via Devel
On Thu, Mar 20, 2025 at 09:36:15PM -0600, Jim Fehlig via Devel wrote: > On 3/20/25 17:07, Pavel Hrdina via Devel wrote: > > Pavel Hrdina (6): > >tools: remove --parallel from virsh restore command > >tools: remote --parallel from virsh save command > >qemu: remove VIR_DOMAIN_SAVE_PARALL

Re: [PATCH 8/8] NEWS: Mention guest agent error code improvements

2025-03-21 Thread Daniel P . Berrangé via Devel
On Fri, Mar 21, 2025 at 12:40:39PM +0100, Peter Krempa wrote: > On Fri, Mar 21, 2025 at 11:35:36 +, Daniel P. Berrangé wrote: > > On Fri, Mar 21, 2025 at 12:15:19PM +0100, Peter Krempa via Devel wrote: > > > On Thu, Mar 20, 2025 at 17:36:27 +0100, Ján Tomko wrote: > > > > On a Thursday in 2025,

Re: [PATCH 8/8] NEWS: Mention guest agent error code improvements

2025-03-21 Thread Daniel P . Berrangé via Devel
On Fri, Mar 21, 2025 at 12:15:19PM +0100, Peter Krempa via Devel wrote: > On Thu, Mar 20, 2025 at 17:36:27 +0100, Ján Tomko wrote: > > On a Thursday in 2025, Peter Krempa via Devel wrote: > > > From: Peter Krempa > > > > > > Signed-off-by: Peter Krempa > > > --- > > > NEWS.rst | 10 ++ >

Re: [PATCH V4 01/18] lib: virDomain{Save,Restore}Params: Ensure absolute path

2025-03-25 Thread Daniel P . Berrangé via Devel
On Tue, Mar 25, 2025 at 10:49:49AM +0100, Martin Kletzander wrote: > On Wed, Mar 19, 2025 at 05:43:20PM -0600, Jim Fehlig via Devel wrote: > > On 3/19/25 05:54, Daniel P. Berrangé wrote: > > > On Wed, Mar 05, 2025 at 03:48:10PM -0700, Jim Fehlig via Devel wrote: > > > > When invoking virDomainSaveP

Re: [PATCH v2 1/3] qemu: Reflect MAC address change in live domain XML

2025-03-18 Thread Daniel P . Berrangé via Devel
On Tue, Mar 18, 2025 at 02:58:18PM +0100, Michal Privoznik via Devel wrote: > From: Michal Privoznik > > If a guest changes MAC address on its vNIC, then QEMU emits > NIC_RX_FILTER_CHANGED event (the event is emitted in other cases > too, but that's not important right now). Now, domain XML allow

Re: [PATCH v2 1/3] qemu: Reflect MAC address change in live domain XML

2025-03-18 Thread Daniel P . Berrangé via Devel
On Tue, Mar 18, 2025 at 02:58:18PM +0100, Michal Privoznik via Devel wrote: > From: Michal Privoznik > > If a guest changes MAC address on its vNIC, then QEMU emits > NIC_RX_FILTER_CHANGED event (the event is emitted in other cases > too, but that's not important right now). Now, domain XML allow

Re: [PATCH v2 1/3] qemu: Reflect MAC address change in live domain XML

2025-03-18 Thread Daniel P . Berrangé via Devel
On Tue, Mar 18, 2025 at 03:31:30PM +0100, Michal Prívozník wrote: > On 3/18/25 15:10, Daniel P. Berrangé wrote: > > On Tue, Mar 18, 2025 at 02:58:18PM +0100, Michal Privoznik via Devel wrote: > >> From: Michal Privoznik > >> > >> If a guest changes MAC address on its vNIC, then QEMU emits > >> NIC

[PATCH] docs: remove references to removed APIs

2025-03-17 Thread Daniel P . Berrangé via Devel
The glib adoption docs was suggesting avoidance of certain APIs that were obsoleted by glib, during the transition period. Now that the referenced APIs no longer exist in libvirt code, they can also be removed from the docs. NB, the virStringListRemoveDuplicates method remains since there is no gl

[PATCH] docs: document workaround for DMARC countermeasures

2025-03-17 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé If a contributor's email domain has a DMARC policy of 'p=quarantine' or 'p=reject', mailman will apply DMARC countermeasures on all mails sent to lists.libvirt.org rewriting the "From" header to remove the sender's email address. e.g. From: Your Name via If these cou

[PATCH] scripts: add execute permission to several files

2025-03-17 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé Most, but not all, files in scripts have execute permission. While we don't need this in order to launch them via meson/ninja build rules, it is nice to direct execution if they have execution permission. This makes the practice consistent across all scripts. Signed-off-

Re: Questions regarding potential resize implementation in libvirt

2025-03-20 Thread Daniel P . Berrangé via Devel
On Thu, Mar 20, 2025 at 08:56:04AM +0100, Maximilian Immanuel Brandtner wrote: > I've been working on an RFC patch-set to implement resizing for > consoles in QEMU. Now that the patch-set is in review I've turned my > attention to bringing this feature to libvirt. Can you point to the QEMU patchse

Re: Questions regarding potential resize implementation in libvirt

2025-03-20 Thread Daniel P . Berrangé via Devel
On Thu, Mar 20, 2025 at 11:05:04AM +0100, Peter Krempa via Devel wrote: > > Libvirt supports console also for unix-socket backed chardevs. I presume > that would require the QMP command approach instead. That will likely > reuqire more plumbing because on the first glance we don't seem to > have t

Re: [PATCH V4 08/18] qemu: Add helper function for creating save image fd

2025-03-20 Thread Daniel P . Berrangé via Devel
On Wed, Mar 19, 2025 at 05:09:01PM -0600, Jim Fehlig wrote: > On 3/19/25 06:49, Daniel P. Berrangé wrote: > > On Wed, Mar 05, 2025 at 03:48:17PM -0700, Jim Fehlig via Devel wrote: > > > Move the code in qemuSaveImageCreate that opens, labels, and wraps the > > > save image fd to a helper function,

Re: [PATCH V4 01/18] lib: virDomain{Save,Restore}Params: Ensure absolute path

2025-03-19 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:10PM -0700, Jim Fehlig via Devel wrote: > When invoking virDomainSaveParams with a relative path, the image is > saved to the daemon's CWD. Similarly, when providing virDomainRestoreParams > with a relative path, it attempts to restore from the daemon's CWD. In most >

Re: [PATCH V4 08/18] qemu: Add helper function for creating save image fd

2025-03-19 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:17PM -0700, Jim Fehlig via Devel wrote: > Move the code in qemuSaveImageCreate that opens, labels, and wraps the > save image fd to a helper function, providing more flexibility for > upcoming mapped-ram support. > > Signed-off-by: Jim Fehlig > --- > src/qemu/qemu_s

Re: [PATCH V4 07/18] qemu_saveimage: add "sparse" to supported save image formats

2025-03-19 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:16PM -0700, Jim Fehlig via Devel wrote: > Extend the list of formats to include "sparse", which uses QEMU's mapped-ram > stream format [1] to write guest memory blocks at fixed offsets in the save > image file. > > [1] > https://gitlab.com/qemu-project/qemu/-/blob/ma

Re: [PATCH V4 18/18] tools: add parallel parameter to virsh restore command

2025-03-19 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:27PM -0700, Jim Fehlig via Devel wrote: > From: Claudio Fontana > > Signed-off-by: Claudio Fontana > Signed-off-by: Jim Fehlig > --- > docs/manpages/virsh.rst | 9 +++-- > tools/virsh-domain.c| 39 +++ > 2 files changed

Re: Questions regarding potential resize implementation in libvirt

2025-03-20 Thread Daniel P . Berrangé via Devel
On Thu, Mar 20, 2025 at 11:09:41AM +0100, Maximilian Immanuel Brandtner wrote: > On Thu, 2025-03-20 at 09:58 +, Daniel P. Berrangé wrote: > > On Thu, Mar 20, 2025 at 08:56:04AM +0100, Maximilian Immanuel > > Brandtner wrote: > > > I've been working on an RFC patch-set to implement resizing for

[PATCH v2 4/5] Revert "apparmor: Allow version-specific bits in profiles"

2025-04-05 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé This reverts commit 19eb8abc9a4d15190852d644b773a2348f11c9da. There is no longer any need to dynamically generate version specific rules. This revert can be reverted, if the need ever arises again in the future. Signed-off-by: Daniel P. Berrangé --- src/security/appar

[PATCH 0/3] apparmor: assume at least version 3

2025-04-05 Thread Daniel P . Berrangé via Devel
Daniel P. Berrangé (3): apparmor: assume at least apparmor >= 3 Revert "apparmor: Allow version-specific bits in profiles" meson: drop remaining checks for apparmor version meson.build | 3 -- src/security/apparmor/libvirt-lxc.in | 2 - src/se

Re: [PATCH 0/4] Allow xml-configured coredump format on VM crash

2025-04-05 Thread Daniel P . Berrangé via Devel
On Fri, Mar 28, 2025 at 05:45:12PM +0100, Denis V. Lunev via Devel wrote: > On 3/27/25 11:14, Nikolai Barybin wrote: > > When libvirt processes VM crash event it always dumps core in raw > > format. > > > > This series makes it possible to configure dump format via domain xml. > > This would be es

Re: [PATCH V4 16/18] qemu: Add support for parallel save and restore

2025-04-05 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:25PM -0700, Jim Fehlig via Devel wrote: > Add support for parallel save and restore by mapping libvirt's > "parallel-channels" parameter to QEMU's "multifd-channels" > migration parameter. > > Signed-off-by: Jim Fehlig > --- > src/qemu/qemu_driver.c | 32 +

Re: [PATCH V4 00/18] qemu: support mapped-ram+directio+mulitfd

2025-04-05 Thread Daniel P . Berrangé via Devel
Hi Jim, There are a couple of CI failures after this, one on 32-bit and one with CLang On Wed, Mar 05, 2025 at 03:48:09PM -0700, Jim Fehlig via Devel wrote: > V4 series adding support for QEMU's mapped-ram stream format [1] and > migration capability. The use of mapped-ram is controlled by extend

Re: [PATCH v8 55/55] docs: Add TDX documentation

2025-04-05 Thread Daniel P . Berrangé via Devel
CC libvirt / Jiri, for confirmation about whether the CPUID restrictions listed below will have any possible impact on libvirt CPUID handling... On Tue, Apr 01, 2025 at 09:02:05AM -0400, Xiaoyao Li wrote: > Add docs/system/i386/tdx.rst for TDX support, and add tdx in > confidential-guest-support.r

Re: [PATCH V4 15/18] include: Define constants for parallel save/restore

2025-04-05 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:24PM -0700, Jim Fehlig via Devel wrote: > From: Claudio Fontana > > Add a new VIR_DOMAIN_SAVE_PARALLEL flag to the save and restore APIs, > which can be used to specify the use of multiple, parallel channels > for saving and restoring a domain. The number of parallel

Re: [PATCH v2 20/22] admin: add 'daemon-shutdown' command

2025-04-05 Thread Daniel P . Berrangé via Devel
On Thu, Mar 13, 2025 at 02:18:18PM +0100, Peter Krempa wrote: > On Wed, Mar 12, 2025 at 17:18:00 +, Daniel P. Berrangé wrote: > > The daemons are wired up to shutdown in responsible to UNIX process > > signals, as well as in response to login1 dbus signals, or loss of > > desktop session. The l

Re: [PATCH V4 14/18] qemu: Support O_DIRECT with mapped-ram on restore

2025-04-05 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:23PM -0700, Jim Fehlig via Devel wrote: > When using the mapped-ram migration capability, direct IO is > enabled by setting the "direct-io" migration parameter to > "true" and passing QEMU an additional fd with O_DIRECT set. > > Signed-off-by: Jim Fehlig > --- > src

Re: [PATCH V4 02/18] qemu: Add function to get FDPass object from monitor

2025-04-05 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:11PM -0700, Jim Fehlig via Devel wrote: > Add new function qemuFDPassNewFromMonitor to get an fdset previously > passed to qemu, based on the 'prefix' provided when the qemuFDPass > object was initially created. > > Signed-off-by: Jim Fehlig > --- > src/qemu/qemu_fd

Re: [PATCH V4 17/18] tools: add parallel parameter to virsh save command

2025-04-05 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:26PM -0700, Jim Fehlig via Devel wrote: > From: Claudio Fontana > > Signed-off-by: Claudio Fontana > Signed-off-by: Jim Fehlig > --- > docs/manpages/virsh.rst | 12 +++- > tools/virsh-domain.c| 42 + > 2 files ch

Re: [PATCH rfcv4 05/13] conf: add tdx as launch security type

2025-03-25 Thread Daniel P . Berrangé via Devel
On Fri, May 24, 2024 at 02:21:20PM +0800, Zhenzhong Duan wrote: > When 'tdx' is used, the VM will launched with Intel TDX feature enabled. > TDX feature supports running encrypted VM (Trust Domain, TD) under the > control of KVM. A TD runs in a CPU model which protects the > confidentiality of its

Re: [PATCH V4 09/18] qemu: Add support for mapped-ram on save

2025-03-27 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:18PM -0700, Jim Fehlig via Devel wrote: > Introduce support for QEMU's new mapped-ram stream format [1]. > mapped-ram can be enabled by setting the 'save_image_format' > setting in qemu.conf to 'sparse'. > > To use mapped-ram with QEMU: > - The 'mapped-ram' migration

Re: [PATCH rfcv4 05/13] conf: add tdx as launch security type

2025-03-26 Thread Daniel P . Berrangé via Devel
On Wed, Mar 26, 2025 at 02:45:55AM +, Duan, Zhenzhong wrote: > > > >-Original Message- > >From: Daniel P. Berrangé > >Subject: Re: [PATCH rfcv4 05/13] conf: add tdx as launch security type > > > >On Fri, May 24, 2024 at 02:21:20PM +0800, Zhenzhong Duan wrote: > >> When 'tdx' is used,

Re: [PATCH rfcv4 08/13] Add Intel TDX Quote Generation Service(QGS) support

2025-03-26 Thread Daniel P . Berrangé via Devel
On Wed, Mar 26, 2025 at 03:29:04AM +, Duan, Zhenzhong wrote: > > > >-Original Message- > >From: Daniel P. Berrangé > >Subject: Re: [PATCH rfcv4 08/13] Add Intel TDX Quote Generation Service(QGS) > >support > > > >On Fri, May 24, 2024 at 02:21:23PM +0800, Zhenzhong Duan wrote: > >> Ad

Re: [PATCH V4 13/18] qemu: Support O_DIRECT with mapped-ram on save

2025-03-27 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:22PM -0700, Jim Fehlig via Devel wrote: > When using the mapped-ram migration capability, direct IO is > enabled by setting the "direct-io" migration parameter to > "true" and passing QEMU an additional fd with O_DIRECT set. > > Signed-off-by: Jim Fehlig > --- > src

Re: [PATCH] virt-aa-helper: delete dynamic files

2025-04-01 Thread Daniel P . Berrangé via Devel
On Tue, Apr 01, 2025 at 08:12:11AM -0700, Andrea Bolognani wrote: > On Tue, Apr 01, 2025 at 03:24:10PM +0100, Daniel P. Berrangé wrote: > > On Tue, Apr 01, 2025 at 07:15:46AM -0700, Andrea Bolognani via Devel wrote: > > > More importantly, I'm not convinced that you can just start deleting > > > th

[PATCH] news: document dropping apparmor < 3.0.0

2025-04-01 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé Signed-off-by: Daniel P. Berrangé --- NEWS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 0cb11313cd..d359bc5a32 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -15,6 +15,8 @@ v11.3.0 (unreleased) * **Removed features** + * Support for

Re: [PATCH] virt-aa-helper: delete dynamic files

2025-04-01 Thread Daniel P . Berrangé via Devel
On Mon, Mar 31, 2025 at 07:30:02PM +0200, Alessandro wrote: > We attempted multiple ways to clean up dynamic files; however, we must > preserve user overrides, which requires keeping the file > /etc/apparmor.d/libvirt/libvirt-uuid > > This commit proposes to move user overrides into > /etc/apparmo

Re: [PATCH] virt-aa-helper: delete dynamic files

2025-04-01 Thread Daniel P . Berrangé via Devel
On Tue, Apr 01, 2025 at 07:15:46AM -0700, Andrea Bolognani via Devel wrote: > On Tue, Apr 01, 2025 at 04:00:42PM +0200, Alessandro wrote: > > On Tue, 1 Apr 2025 at 14:22, Andrea Bolognani wrote: > > > On Tue, Apr 01, 2025 at 10:55:28AM +0200, Alessandro wrote: > > > > We attempted multiple ways to

Re: [PATCH] rpc: Re-read the data if EAGAIN or EINTR were captured

2025-04-11 Thread Daniel P . Berrangé via Devel
On Tue, Apr 08, 2025 at 12:55:04AM +0800, yong.hu...@smartx.com wrote: > From: Hyman Huang > > If EAGAIN or EINTR are returned from the gnutls_record_recv, > GNU TLS suggests calling the gnutls_record_recv once again to > get the data. Refer to the following link to see details: > https://www.gnu

Re: [PATCH v1 1/1] rpc: Add the retry argument for virNetTLSSession{Read,Write}

2025-04-11 Thread Daniel P . Berrangé via Devel
On Tue, Apr 08, 2025 at 10:27:51AM +0800, yong.hu...@smartx.com wrote: > From: Hyman Huang > > As advised by the GNU TLS, the caller should attempt again > if the gnutls_record_{recv,send} return EAGAIN or EINTR; > check the following link to view the details: > https://www.gnutls.org/manual/html

Re: [PATCH V1 0/6] fast qom tree get

2025-04-11 Thread Daniel P . Berrangé via Devel
On Wed, Apr 09, 2025 at 09:58:13AM +0200, Peter Krempa via Devel wrote: > On Wed, Apr 09, 2025 at 09:39:02 +0200, Markus Armbruster via Devel wrote: > > Hi Steve, I apologize for the slow response. > > > > Steve Sistare writes: > > > > > Using qom-list and qom-get to get all the nodes and proper

Re: Management applications and CPU feature flags (was: [PATCH V1 0/6] fast qom tree get)

2025-04-11 Thread Daniel P . Berrangé via Devel
On Fri, Apr 11, 2025 at 12:40:46PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Wed, Apr 09, 2025 at 09:58:13AM +0200, Peter Krempa via Devel wrote: > >> On Wed, Apr 09, 2025 at 09:39:02 +0200, Markus Armbruster via Devel wrote: > >> > Hi Steve, I apologize for the slow r

[PATCH 0/3] remote: improve missing socket diagnostics

2025-04-17 Thread Daniel P . Berrangé via Devel
Daniel P. Berrangé (3): remote: improve error message when no URI is set kbase: update docs to account for changed error message remote: expand some debug messages for socket detection docs/kbase/failed_connection_after_install.rst | 10 ++ src/remote/remote_sockets.c

[PATCH 2/3] kbase: update docs to account for changed error message

2025-04-17 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé The updated doc refers to both the old and new error message, as users with old deployed versions will still be pointed to the current online docs URL. Signed-off-by: Daniel P. Berrangé --- docs/kbase/failed_connection_after_install.rst | 10 ++ 1 file changed,

Re: RFC: libvirt-tck bhyve/FreeBSD support

2025-04-14 Thread Daniel P . Berrangé via Devel
On Mon, Apr 14, 2025 at 02:36:11PM +0200, Roman Bogorodskiy wrote: > Hi, > > I'd like to test the bhyve driver using libvirt-tck, which seems to be > very useful both from the continuous integration perspective, > and making the bhyve driver closer to other drivers to improve > integration with ot

[PATCH 1/3] remote: improve error message when no URI is set

2025-04-17 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé When no URI is set we try to guess what daemon to connect to by looking for any listening sockets. If there are no listening sockets, however, we don't even know what daemon the user expected to connect to. The error message in this case is not especially clear This twea

[PATCH 3/3] remote: expand some debug messages for socket detection

2025-04-17 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé Signed-off-by: Daniel P. Berrangé --- src/remote/remote_sockets.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/remote/remote_sockets.c b/src/remote/remote_sockets.c index 4e6d19098c..b3f6cd6a42 100644 --- a/src/remote/remote_sockets.c ++

Re: [PATCH 1/3] internal: Introduce ATTRIBUTE_NOIPA

2025-04-28 Thread Daniel P . Berrangé via Devel
On Mon, Apr 28, 2025 at 03:20:56PM +0200, Michal Privoznik via Devel wrote: > From: Michal Privoznik > > Currently, if we want to mock a function the noinline attribute > is appended after the function (via G_NO_INLINE macro). This used > to work for non pure functions. But there are some trivial

Re: Question about SEV* guests and automatic firmware selection

2025-04-24 Thread Daniel P . Berrangé via Devel
On Mon, Apr 21, 2025 at 01:38:35PM -0600, Jim Fehlig via Devel wrote: > Hi All, > > While investigating an internal bug report, we noticed that a minimal > firmware auto-selection configuration along with SEV* fails to find a match. > E.g. the following config > > > > hvm > > >

Re: [PATCH] virhostcpu: Fix potential use of unallocated memory

2025-04-24 Thread Daniel P . Berrangé via Devel
On Thu, Apr 24, 2025 at 01:22:46PM +0200, Felix Huettner via Devel wrote: > In case of a host that has a large number of cpus offline the count of > host cpus and the last bit set in the virHostCPUGetOnlineBitmap might > diverge significantly. This can e.g. be the case when disabeling smt via > /sy

Re: [PATCH v1 1/1] rpc: Add the retry argument for virNetTLSSession{Read,Write}

2025-04-14 Thread Daniel P . Berrangé via Devel
On Mon, Apr 14, 2025 at 09:51:32AM +0800, Yong Huang wrote: > On Fri, Apr 11, 2025 at 5:47 PM Daniel P. Berrangé > wrote: > > > On Tue, Apr 08, 2025 at 10:27:51AM +0800, yong.hu...@smartx.com wrote: > > > From: Hyman Huang > > > > > > As advised by the GNU TLS, the caller should attempt again >

Re: [PATCH] bhyve: capabilities: advertise RNG device support

2025-04-14 Thread Daniel P . Berrangé via Devel
On Mon, Apr 14, 2025 at 07:45:25PM +0200, Roman Bogorodskiy wrote: > Signed-off-by: Roman Bogorodskiy > --- > src/bhyve/bhyve_capabilities.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c > index 37ae5d2872..36

Re: [PATCH] nss: Fix memory leak in findLease

2025-04-14 Thread Daniel P . Berrangé via Devel
On Mon, Apr 14, 2025 at 03:06:09PM +0300, Alexander Kuznetsov wrote: > path is allocated by asprintf() and must be freed later if realloc() fails or > at > the end of each while() iteration > > Move the free() call out of LIBVIRT_NSS_GUEST macro and add another one if > realloc() fails > > Found

Re: [PATCH] nss: Fix memory leak in findLease

2025-04-14 Thread Daniel P . Berrangé via Devel
On Mon, Apr 14, 2025 at 02:25:05PM +0200, Peter Krempa wrote: > On Mon, Apr 14, 2025 at 13:20:55 +0100, Daniel P. Berrangé via Devel wrote: > > On Mon, Apr 14, 2025 at 03:06:09PM +0300, Alexander Kuznetsov wrote: > > > path is allocated by asprintf() and must be free

[PATCH v3 1/5] Revert "include/hw: temporarily disable deletion of versioned machine types"

2025-05-06 Thread Daniel P . Berrangé via Devel
This reverts commit c9fd2d9a48ee3c195cf83cc611b87b09f02f0013. When we introduced the specialized machine type deprecation policy, we allow automatic deprecation to take effect immediately, but blocked the automatic deletion of machine types for 2 releases. This ensured we complied with the histori

[PATCH v3 0/5] docs: automated info about machine deprecation/removal info

2025-05-06 Thread Daniel P . Berrangé via Devel
Since we deprecate and remove versioned machine types on a fixed schedule, we can automatically ensure that the docs reflect the latest version info, rather than requiring manual updates on each dev cycle. The first patch in this series removes the hack which postponed automatic removal of version

[PATCH v3 2/5] include/hw/boards: cope with dev/rc versions in deprecation checks

2025-05-06 Thread Daniel P . Berrangé via Devel
When VERSION is set to a development snapshot (micro >= 50), or a release candidate (micro >= 90) we have an off-by-1 in determining deprecation and deletion thresholds for versioned machine types. In such cases we need to use the next major/minor version in threshold checks. This adapts the depre

[PATCH v3 5/5] include/hw/boards: add warning about changing deprecation logic

2025-05-06 Thread Daniel P . Berrangé via Devel
If we change the deprecation logic in include/hw/boards.h, we must make a corresponding change to docs/conf.py and docs/about/deprecated.rst. Add comments to these files as a warning to future maintainers to keep these files in sync. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé ---

[PATCH v3 3/5] docs/about/deprecated: auto-generate a note for versioned machine types

2025-05-06 Thread Daniel P . Berrangé via Devel
We deprecate versioned machine types on a fixed schedule. This allows us to auto-generate a paragraph in the deprecated.rst document that always has accurate version info. Signed-off-by: Daniel P. Berrangé --- docs/about/deprecated.rst | 7 +++ docs/conf.py | 33 +++

[PATCH v3 4/5] docs/about/removed-features: auto-generate a note for versioned machine types

2025-05-06 Thread Daniel P . Berrangé via Devel
We remove versioned machine types on a fixed schedule. This allows us to auto-generate a paragraph in the removed-features.rst document that always has accurate version info. Signed-off-by: Daniel P. Berrangé --- docs/about/removed-features.rst | 10 ++ docs/conf.py|

Re: [PATCH v4 4/5] cpu_map: Add POWER11 cpu model support

2025-05-06 Thread Daniel P . Berrangé via Devel
On Mon, May 05, 2025 at 09:07:52AM -0300, Daniel Henrique Barboza wrote: > > > On 5/5/25 5:58 AM, Andrea Bolognani wrote: > > On Tue, Apr 29, 2025 at 05:41:43PM +0200, Jiří Denemark wrote: > > > On Tue, Apr 29, 2025 at 13:03:12 +0100, Daniel P. Berrangé wrote: > > > > On Tue, Apr 29, 2025 at 01:4

Re: [PATCH] rpm: Enable KVM for riscv64 on RHEL 10+

2025-04-24 Thread Daniel P . Berrangé via Devel
On Wed, Apr 23, 2025 at 11:39:34AM -0700, Andrea Bolognani wrote: > On Fri, Mar 14, 2025 at 10:13:49AM +, Daniel P. Berrangé wrote: > > On Fri, Mar 14, 2025 at 11:01:21AM +0100, Andrea Bolognani wrote: > > > %define arches_qemu_kvm %{ix86} x86_64 %{power64} %{arm} aarch64 > > > s390x

Re: [PATCH 0/3] Preper noipa attribute over noinline

2025-04-28 Thread Daniel P . Berrangé via Devel
On Mon, Apr 28, 2025 at 03:20:55PM +0200, Michal Privoznik via Devel wrote: > Somewhat green-ish pipeline: > > https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1790043585 > > Jobs that failed are unrelated. > > Thing is, our upstream pipeline started failing on Rawhide + gcc because > of I

Re: [PATCH 1/2] util: Add missing G_NO_INLINE annotation

2025-04-28 Thread Daniel P . Berrangé via Devel
On Mon, Apr 28, 2025 at 01:47:49PM +0200, Michal Privoznik via Devel wrote: > From: Michal Privoznik > > There are two functions that are mocked, but are missing required > G_NO_INLINE attribute: virFirewallDIsRegistered() and > virHostCPUGetPhysAddrSize(). Add it. > > Signed-off-by: Michal Priv

Re: [PATCH 2/2] scripts: Fix reading list of files in mock-noinline.py

2025-04-28 Thread Daniel P . Berrangé via Devel
On Mon, Apr 28, 2025 at 01:47:50PM +0200, Michal Privoznik via Devel wrote: > From: Michal Privoznik > > The mock-noinline.py script is fed list of files through its > stdin, each file on its own line. Unfortunately, the way the > script is written does nothing as the trailing newline character >

Re: [RFC PATCH 0/3] single-binary: make QAPI generated files common

2025-04-29 Thread Daniel P . Berrangé via Devel
On Tue, Apr 29, 2025 at 11:20:59AM +0200, Thomas Huth via Devel wrote: > On 29/04/2025 10.23, Markus Armbruster wrote: > ... > > I don't wish to derail this thread, but we've been dancing around the > > question of how to best fix the target for some time. I think we should > > talk about it for r

Re: [RFC PATCH 0/3] single-binary: make QAPI generated files common

2025-04-29 Thread Daniel P . Berrangé via Devel
On Tue, Apr 29, 2025 at 11:35:52AM +0200, Philippe Mathieu-Daudé wrote: > On 29/4/25 10:23, Markus Armbruster wrote: > > Pierrick Bouvier writes: > > > > > On 4/28/25 4:07 AM, Markus Armbruster wrote: > > > > Peter Krempa writes: > > > > > > > > > So what should libvirt do once multiple targets

Re: [PATCH 16/20] util: remove use hardcoded TC path

2025-04-29 Thread Daniel P . Berrangé via Devel
On Tue, Apr 29, 2025 at 02:38:45PM +0200, Peter Krempa wrote: > On Tue, Apr 29, 2025 at 12:14:16 +0100, Daniel P. Berrangé via Devel wrote: > > From: Daniel P. Berrangé > > > > Allow virCommand to find 'tc' in $PATH. This command is only used > > when runni

[PATCH v2 0/5] docs: automated info about machine deprecation/removal info

2025-04-29 Thread Daniel P . Berrangé via Devel
Since we deprecate and remove versioned machine types on a fixed schedule, we can automatically ensure that the docs reflect the latest version info, rather than requiring manual updates on each dev cycle. The first patch in this series removes the hack which postponed automatic removal of version

[PATCH v2 1/5] Revert "include/hw: temporarily disable deletion of versioned machine types"

2025-04-29 Thread Daniel P . Berrangé via Devel
This reverts commit c9fd2d9a48ee3c195cf83cc611b87b09f02f0013. When we introduced the specialized machine type deprecation policy, we allow automatic deprecation to take effect immediately, but blocked the automatic deletion of machine types for 2 releases. This ensured we complied with the histori

[PATCH v2 2/5] include/hw/boards: cope with dev/rc versions in deprecation checks

2025-04-29 Thread Daniel P . Berrangé via Devel
When VERSION is set to a development snapshot (micro >= 50), or a release candidate (micro >= 90) we have an off-by-1 in determining deprecation and deletion thresholds for versioned machine types. In such cases we need to use the next major/minor version in threshold checks. This adapts the depre

[PATCH v2 5/5] include/hw/boards: add warning about changing deprecation logic

2025-04-29 Thread Daniel P . Berrangé via Devel
If we change the deprecation logic in include/hw/boards.h, we must make a corresponding change to docs/conf.py and docs/about/deprecated.rst. Add comments to these files as a warning to future maintainers to keep these files in sync. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé ---

[PATCH v2 3/5] docs/about/deprecated: auto-generate a note for versioned machine types

2025-04-29 Thread Daniel P . Berrangé via Devel
We deprecate versioned machine types on a fixed schedule. This allows us to auto-generate a paragraph in the deprecated.rst document that always has accurate version info. Signed-off-by: Daniel P. Berrangé --- docs/about/deprecated.rst | 7 +++ docs/conf.py | 33 +++

[PATCH v2 4/5] docs/about/removed-features: auto-generate a note for versioned machine types

2025-04-29 Thread Daniel P . Berrangé via Devel
We remove versioned machine types on a fixed schedule. This allows us to auto-generate a paragraph in the removed-features.rst document that always has accurate version info. Signed-off-by: Daniel P. Berrangé --- docs/about/removed-features.rst | 10 ++ docs/conf.py|

[PATCH 00/20] Finish the work to stop hardcoding paths at build time

2025-04-29 Thread Daniel P . Berrangé via Devel
Over the years we've made various changes to stop hardcoding paths at build time, but the work is incomplete. This bit us significantly in Fedora 42 where they have merged the 'sbin' and 'bin' dirs together. In the build environment we have a clean install where '/sbin' and '/usr/sbin' are simply

[PATCH 01/20] storage: stop hardcoding paths for mkfs, mount, umount

2025-04-29 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé This was always undesirable but now causes problems on Fedora 42 where at build time we detect a /sbin path but at runtime this will only exist on upgraded machines, not fresh installs. Signed-off-by: Daniel P. Berrangé --- meson.build | 13 ---

[PATCH 03/20] util: stop hardcoding numad path

2025-04-29 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé Change the meson rules to always enable numad if on a Linux host, unless the meson options say not to. Signed-off-by: Daniel P. Berrangé --- meson.build| 10 +++--- src/util/virnuma.c | 2 +- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/m

[PATCH 02/20] tests: storage hardcoding paths for mount & vgchange

2025-04-29 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé This is redundant since the tests will strip any path component from the binary name before comparison. Signed-off-by: Daniel P. Berrangé --- tests/storagepoolxml2argvtest.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/tests/storage

[PATCH 04/20] util: stop hardcoding bhyve, bhyvectl, bhyveload paths

2025-04-29 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé Change the meson rules to always enable numad if on a FreeBSD host, unless the meson options say not to. Signed-off-by: Daniel P. Berrangé --- meson.build | 11 +-- src/bhyve/bhyve_command.c | 6 +++--- 2 files changed, 4 insertions(+), 13 deleti

Re: [PATCH v4 4/5] cpu_map: Add POWER11 cpu model support

2025-04-29 Thread Daniel P . Berrangé via Devel
On Tue, Apr 15, 2025 at 04:13:08AM -0400, Narayana Murty N wrote: > Add POWER11 as a supported cpu model for ppc64. > > Signed-off-by: Narayana Murty N > --- > src/cpu_map/index.xml | 1 + > src/cpu_map/meson.build| 1 + > src/cpu_map/ppc64_POWER11.xml

Re: [PATCH v4 5/5] cpu_ppc64: Add POWER11 hostmodel support and accept case insensitive

2025-04-29 Thread Daniel P . Berrangé via Devel
On Tue, Apr 15, 2025 at 04:13:09AM -0400, Narayana Murty N wrote: > QEMU has historically used uppercase CPU model names like "POWER8", > "POWER9", etc. However, starting with commit c5354f54aa60 ("ppc: make > cpu_model translation to type consistent"), QEMU began using lowercase > CPU model names

[PATCH 20/20] openvz: stop hardcoding vzlist/vzctl/vzmigrate paths

2025-04-29 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé Allow virCommand to find them in $PATH, which will always include 'sbin' since the openvz driver only operates in system mode. Signed-off-by: Daniel P. Berrangé --- src/openvz/openvz_conf.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/o

Re: [PATCH 00/20] Finish the work to stop hardcoding paths at build time

2025-04-29 Thread Daniel P . Berrangé via Devel
On Tue, Apr 29, 2025 at 02:57:13PM +0200, Ján Tomko wrote: > On a Tuesday in 2025, Daniel P. Berrangé via Devel wrote: > > Over the years we've made various changes to stop hardcoding paths at > > build time, but the work is incomplete. > > > > This bit us signi

[PATCH 05/20] util: stop hardcoding 'ifconfig' path

2025-04-29 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé Change the source to assume use of 'ifconfig' on FreeBSD builds, allowing virCommand to report missing commands at runtime. Signed-off-by: Daniel P. Berrangé --- meson.build| 4 src/util/virnetdevip.c | 8 2 files changed, 4 insertions(+), 8 d

[PATCH 06/20] docs: stop setting vars for docs tools

2025-04-29 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé Nothing in the tree references RST2MAN or RST2HTML5 variables, only rst2man_prog & rst2html5_prog, so the former can be removed. Signed-off-by: Daniel P. Berrangé --- docs/meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/meson.build b/docs/meson.buil

[PATCH 09/20] util: remove use hardcoded DMIDECODE path

2025-04-29 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé Allow virCommand to find 'dmidecode' in $PATH. This command is only usable when running privileged since it relies on reading from a privileged kernel file. Thus we can assume both 'bin' and 'sbin' dirs will be in $PATH and virFindFileInPath will do the right thing to fin

[PATCH 07/20] build-aux: add missing definition of PERL variable

2025-04-29 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé Currently $(PERL) is expanding to nothing, but the spacing-check.pl test luckily still works via the shebang. Signed-off-by: Daniel P. Berrangé --- build-aux/Makefile.in | 1 + build-aux/meson.build | 1 + 2 files changed, 2 insertions(+) diff --git a/build-aux/Makefi

[PATCH 08/20] meson: stop setting conf var for required programs

2025-04-29 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé There is no reference to PERL, PYTHON3, XMLLINT or XSLTPROC conf variables anywhere, only the ${name}_prog meson variables are used. Signed-off-by: Daniel P. Berrangé --- meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/meson.build b/meson.build index ea3

[PATCH 11/20] util: remove hardcoded ISCSIADM command path

2025-04-29 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé Allow virCommand to find 'dmidecode' in $PATH. This command is only usable when running privileged since it relies on reading from a privileged kernel file. Thus we can assume both 'bin' and 'sbin' dirs will be in $PATH and virFindFileInPath will do the right thing to fin

[PATCH 10/20] meson: remove check for 'ip' program

2025-04-29 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé There are no references to an "IP" conf variable nor a meson 'ip_prog' variable so the check serves no purpose. Signed-off-by: Daniel P. Berrangé --- meson.build| 1 - src/util/virnetdevip.c | 6 +++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff

[PATCH 12/20] nodedev: remove use hardcoded MDEVCTL path

2025-04-29 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé Allow virCommand to find 'mdevctl' in $PATH. This command is only used when running privileged in which case both 'bin' and 'sbin' dirs will be in $PATH, so virFindFileInPath will do the right thing to find it. Signed-off-by: Daniel P. Berrangé --- src/node_device/node

[PATCH 15/20] util: remove use hardcoded OVS_VSCTL path

2025-04-29 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé Allow virCommand to find 'ovs-vsctl' in $PATH. This command is only used when running privileged in which case both 'bin' and 'sbin' dirs will be in $PATH, so virFindFileInPath will do the right thing to find it. Signed-off-by: Daniel P. Berrangé --- meson.build

[PATCH 17/20] meson: stop setting conf var for optional programs

2025-04-29 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé There is no reference to AUGPARSE, BLACK, FLAKE8, PDWTAGS or PYTEST conf variables anywhere, only the ${name}_prog meson variables are used. Signed-off-by: Daniel P. Berrangé --- meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/meson.build b/meson.build i

[PATCH 14/20] util: remove use hardcoded MODPROBE/RMMOD paths

2025-04-29 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé Allow virCommand to find 'modprobe' & 'rmmod' in $PATH. These commands are only used when running privileged in which case both 'bin' and 'sbin' dirs will be in $PATH, so virFindFileInPath will do the right thing to find them. Signed-off-by: Daniel P. Berrangé --- meso

[PATCH 13/20] util: remove use hardcoded MM_CTL path

2025-04-29 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé Allow virCommand to find 'mm-ctl' in $PATH. This command is only used when running privileged in which case both 'bin' and 'sbin' dirs will be in $PATH, so virFindFileInPath will do the right thing to find it. Signed-off-by: Daniel P. Berrangé --- meson.build

[PATCH 16/20] util: remove use hardcoded TC path

2025-04-29 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé Allow virCommand to find 'tc' in $PATH. This command is only used when running privileged in which case both 'bin' and 'sbin' dirs will be in $PATH, so virFindFileInPath will do the right thing to find it. Signed-off-by: Daniel P. Berrangé --- meson.build

[PATCH 18/20] storage: stop hardcoding LVM tool paths

2025-04-29 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé Change the mesonm rules to always enable the LVM driver if on a Linux host, unless the meson options say not to. The virCommand APIs will return suitable runtime errors if the tools are not installed. Signed-off-by: Daniel P. Berrangé --- meson.build

[PATCH 19/20] util: stop hardcoding pkttyagent path

2025-04-29 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé Allow virCommand to find it in $PATH Signed-off-by: Daniel P. Berrangé --- src/util/virpolkit.c | 8 +--- src/util/virpolkit.h | 2 -- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/util/virpolkit.c b/src/util/virpolkit.c index 0a637db9ba..81fa5

  1   2   3   >