[libvirt PATCH 3/4] gitpublish: update for new devel mailing list address

2023-10-30 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- .gitpublish | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitpublish b/.gitpublish index 457c8c676b..1c89c0039e 100644 --- a/.gitpublish +++ b/.gitpublish @@ -1,5 +1,5 @@ [gitpublishprofile "default"] base = master -to

[libvirt PATCH 4/4] docs: update search form to use hyperkitty search

2023-10-30 Thread Daniel P . Berrangé
The hyperkitty search facility does a massively better job than google docs for mailing lists. Signed-off-by: Daniel P. Berrangé --- docs/js/main.js | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/docs/js/main.js b/docs/js/main.js

[libvirt PATCH 0/4] Update for mailing list move

2023-10-30 Thread Daniel P . Berrangé
A surprising number of places mention the mailing lists Daniel P. Berrangé (4): src: update log/error messages pointing to old mailing list addr docs: update docs pointing to old mailing list addrs gitpublish: update for new devel mailing list address docs: update search form to use

[libvirt PATCH 1/4] src: update log/error messages pointing to old mailing list addr

2023-10-30 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- src/conf/domain_capabilities.c| 2 +- src/storage_file/storage_file_probe.c | 2 +- src/util/virarch.c| 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/conf/domain_capabilities.c b/src/conf

[libvirt PATCH 2/4] docs: update docs pointing to old mailing list addrs

2023-10-30 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- README.rst | 4 ++-- docs/bindings.rst | 2 +- docs/contact.rst| 18 +- docs/downloads.rst | 2 +- docs/newreposetup.rst | 2 +- docs/securityprocess.rst| 2 +- docs/submitting

ANNOUNCE: Mailing list move complete

2023-10-30 Thread Daniel P . Berrangé
This is an announcement to the effect that the mailing list move is now complete. TL;DR the new list addresses are: * annou...@lists.libvirt.org(formerly libvirt-annou...@redhat.com) Low volume, announcements of releases and other important info * us...@lists.libvirt.org (formerl

Re: [libvirt PATCH 2/4] docs: update docs pointing to old mailing list addrs

2023-10-30 Thread Daniel P . Berrangé
On Mon, Oct 30, 2023 at 10:48:27AM +0100, Ján Tomko wrote: > On a Monday in 2023, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > > --- > > README.rst | 4 ++-- > > docs/bindings.rst | 2 +- > >

Re: [PATCH V2] support for hotplug/hotunplug in test hypervisor

2023-10-30 Thread Daniel P . Berrangé
On Mon, Oct 30, 2023 at 03:16:49PM +, Thanos Makatos wrote: > Signed-off-by: Thanos Makatos > --- > src/test/test_driver.c | 59 ++ > 1 file changed, 59 insertions(+) > > diff --git a/src/test/test_driver.c b/src/test/test_driver.c > index e87d7cfd44..

Re: [PATCH V3] support for hotplug/hotunplug in test hypervisor

2023-10-31 Thread Daniel P . Berrangé
On Tue, Oct 31, 2023 at 10:12:51AM +, John Levon wrote: > On Tue, Oct 31, 2023 at 10:49:31AM +0100, Michal Prívozník wrote: > > > > +VIR_APPEND_ELEMENT(vm->def->hostdevs, vm->def->nhostdevs, > > > > But anyway, I think we want more elaborate approach. The whole point of > > the test drive

Re: RFC: Switch to a date-based versioning scheme

2023-10-31 Thread Daniel P . Berrangé
On Tue, Oct 31, 2023 at 04:20:24AM -0700, Andrea Bolognani wrote: > On Tue, Oct 31, 2023 at 12:13:14PM +0100, Michal Prívozník wrote: > > On 10/26/23 15:48, Andrea Bolognani wrote: > > > Since we're just a few months away from the 10.0.0 release, I thought > > > it would be a good time to bring up

Re: RFC: Switch to a date-based versioning scheme

2023-10-31 Thread Daniel P . Berrangé
On Mon, Oct 30, 2023 at 04:31:38AM -0500, Andrea Bolognani wrote: > On Thu, Oct 26, 2023 at 03:15:06PM +0100, Daniel P. Berrangé wrote: > > On Thu, Oct 26, 2023 at 06:48:28AM -0700, Andrea Bolognani wrote: > > > Since we're just a few months away from the 10.0.0 release, I

Re: Versioned CPU types in libvirt

2023-10-31 Thread Daniel P . Berrangé
On Sat, Oct 28, 2023 at 09:49:32AM -0500, Jonathon Jongsma wrote: > > I'm currently looking at getting libvirt working with AMD's SEV-SNP > encrypted virtualization technology. I have access to a test machine with an > AMD EPYC 7713 processor which I can use to launch SNP guests with qemu, but > o

Re: RFC: Switch to a date-based versioning scheme

2023-11-01 Thread Daniel P . Berrangé
On Wed, Nov 01, 2023 at 06:35:06AM -0400, Neal Gompa wrote: > On Tue, Oct 31, 2023 at 8:56 AM Andrea Bolognani wrote: > > > > On Tue, Oct 31, 2023 at 11:58:01AM +0000, Daniel P. Berrangé wrote: > > > On Tue, Oct 31, 2023 at 04:20:24AM -0700, Andrea Bolognani wrote: > &g

[libvirt PATCH v2] rpc: don't try to spawn non-existant daemon

2023-11-01 Thread Daniel P . Berrangé
it will now report error: binary 'virtqemud' does not exist in $PATH: No such file or directory and will skip all the socket connect retries Signed-off-by: Daniel P. Berrangé --- Last time it was suggested that virCommandGetBinaryPath could be extended to always check whether the binary

Re: [libvirt PATCH 2/3] qemu: Implement VIR_MIGRATE_ASSUME_SHARED_STORAGE support

2023-11-01 Thread Daniel P . Berrangé
On Tue, Oct 31, 2023 at 06:12:59PM +0100, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > src/qemu/qemu_migration.c | 5 + > src/qemu/qemu_migration.h | 1 + > 2 files changed, 6 insertions(+) > > diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c > index ac

Re: [libvirt PATCH 0/3] Introduce VIR_MIGRATE_ASSUME_SHARED_STORAGE

2023-11-01 Thread Daniel P . Berrangé
On Wed, Nov 01, 2023 at 01:42:07PM +0100, Peter Krempa wrote: > On Tue, Oct 31, 2023 at 18:12:57 +0100, Andrea Bolognani wrote: > > This was initially motivated by a KubeVirt issue[1] concerning > > integration with the Portworx storage provide, but it turns out to be > > more generally applicable:

Re: mingw rpm build busted? (was: Release of libvirt-9.9.0)

2023-11-01 Thread Daniel P . Berrangé
On Wed, Nov 01, 2023 at 10:54:25AM -0400, Cole Robinson wrote: > On 11/1/23 5:44 AM, Jiri Denemark wrote: > > The 9.9.0 release of both libvirt and libvirt-python is tagged and > > signed tarballs and source RPMs are available at > > > > https://download.libvirt.org/ > > https://download.l

Re: ANNOUNCE: Mailing list move complete

2023-11-01 Thread Daniel P . Berrangé
On Wed, Nov 01, 2023 at 06:04:17PM +0100, Zeeshan Ali Khan wrote: > > In my original announcement[1] I mentioned that people would need to > > manually > > re-subscribe. Due to a mixup in communications, our IT admins went ahead and > > migrated across the existing entire subscriber base for all l

Re: [libvirt PATCH 1/2] rpc: Drop support for portable-rpcgen

2023-11-03 Thread Daniel P . Berrangé
On Fri, Nov 03, 2023 at 12:37:17AM +0100, Andrea Bolognani wrote: > We use the native version of rpcgen everywhere. This is true of our CI systems, but not true of user environments. For our Mingw CI we're able to run the Linux native rpcgen since we're cross compiling. For someone using MSys to

Re: [PATCH] tests: ignore $__CF_USER_TEXT_ENCODING in env during commandtest

2023-11-03 Thread Daniel P . Berrangé
ould throw the tests off. > + * Also ignore __CF_USER_TEXT_ENCODING, which is set by MacOS. */ > +if (!STRPREFIX(newenv[i], "LD_") && > + !STRPREFIX(newenv[i], "__CF_USER_TEXT_ENCODING=")) { > fprintf(log, "ENV:%s\n&q

Re: [libvirt PATCH 01/11] rpm: Disable expensive tests for MinGW builds

2023-11-03 Thread Daniel P . Berrangé
ned-off-by: Andrea Bolognani > --- > libvirt.spec.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

Re: [libvirt PATCH 02/11] rpm: Explicitly enable NLS support

2023-11-03 Thread Daniel P . Berrangé
On Thu, Nov 02, 2023 at 11:37:24PM +0100, Andrea Bolognani wrote: > We want it both for native builds and MinGW ones. > > Signed-off-by: Andrea Bolognani > --- > libvirt.spec.in | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Wi

Re: [libvirt PATCH 04/11] rpm: Explain a couple of BuildRequires

2023-11-03 Thread Daniel P . Berrangé
On Thu, Nov 02, 2023 at 11:37:26PM +0100, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > libvirt.spec.in | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flick

Re: [libvirt PATCH 03/11] rpm: Rename module-init-tools -> kmod

2023-11-03 Thread Daniel P . Berrangé
On Thu, Nov 02, 2023 at 11:37:25PM +0100, Andrea Bolognani wrote: > The old package name is only kept around for compatibility > reasons. > > Signed-off-by: Andrea Bolognani > --- > libvirt.spec.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Dani

Re: [libvirt PATCH 05/11] rpm: Add libxml2 BuildRequires for xmllint

2023-11-03 Thread Daniel P . Berrangé
> Signed-off-by: Andrea Bolognani > --- > libvirt.spec.in | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-http

Re: [libvirt PATCH 00/11] ci: Build RPMs on MinGW

2023-11-03 Thread Daniel P . Berrangé
On Thu, Nov 02, 2023 at 11:37:22PM +0100, Andrea Bolognani wrote: > Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1059447352 > > The openSUSE Leap 15 job failed, but that's caused by an unrelated > packaging issue: > > $ pkg-config --cflags libtirpc > -I/usr/include/tirpc >

Re: [PATCH] tests: ignore $__CF_USER_TEXT_ENCODING in env during commandtest

2023-11-03 Thread Daniel P . Berrangé
On Fri, Nov 03, 2023 at 03:19:17AM -0700, Andrea Bolognani wrote: > On Fri, Nov 03, 2023 at 03:11:07AM -0700, Andrea Bolognani wrote: > > On Fri, Nov 03, 2023 at 12:00:30AM -0400, Laine Stump wrote: > > > [*] There may be a better way to suppress this environment setting > > > (maybe something

Re: [PATCH] tests: ignore $__CF_USER_TEXT_ENCODING in env during commandtest

2023-11-03 Thread Daniel P . Berrangé
On Fri, Nov 03, 2023 at 10:41:51AM +, Daniel P. Berrangé wrote: > On Fri, Nov 03, 2023 at 03:19:17AM -0700, Andrea Bolognani wrote: > > On Fri, Nov 03, 2023 at 03:11:07AM -0700, Andrea Bolognani wrote: > > > On Fri, Nov 03, 2023 at 12:00:30AM -0400, Laine Stump wrote: > &

Re: [libvirt PATCH v2 1/1] rpc: Make rpcgen produce ANSI C code

2023-11-03 Thread Daniel P . Berrangé
rsions of rpcgen shipped with our target > platforms seem to support the -C option. > > Signed-off-by: Andrea Bolognani > --- > src/rpc/genprotocol.pl | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com

Re: [PATCH] tests: ignore $__CF_USER_TEXT_ENCODING in env during commandtest

2023-11-03 Thread Daniel P . Berrangé
On Fri, Nov 03, 2023 at 04:13:12AM -0700, Andrea Bolognani wrote: > On Fri, Nov 03, 2023 at 10:47:11AM +0000, Daniel P. Berrangé wrote: > > On Fri, Nov 03, 2023 at 10:41:51AM +0000, Daniel P. Berrangé wrote: > > > On Fri, Nov 03, 2023 at 03:19:17AM -0700, Andrea Bolognani w

Re: [PATCH 00/16] Farewell rpcgen

2023-11-03 Thread Daniel P . Berrangé
ng to push this series, minus the last patch. On Wed, Mar 08, 2023 at 11:38:57AM -0500, Daniel P. Berrangé wrote: > This series something I was hacking on a little while back in an > attempt to make our RPC layer more maintainable. There are many > aspects I'm unhappy about w

[PATCH] ci: workaround broken opensuse leap 15.5 tirpc

2023-11-03 Thread Daniel P . Berrangé
Temporarily disable '-Wmissing-include-dirs' becuase the libtirpc pkg-confog file has a bogus include dir. The headers can fortunately still be found since they are in the system include dir. Signed-off-by: Daniel P. Berrangé --- ci/gitlab/builds.yml | 2 ++ ci/manifest.yml | 2 +

Re: [PATCH] build: suppress "ignoring duplicate libraries" warning on macOS

2023-11-03 Thread Daniel P . Berrangé
d files already have examples of adding an > option to the ld commandline if it's available. > > Signed-off-by: Laine Stump > --- > meson.build | 4 > src/meson.build | 1 + > tests/meson.build | 1 + > tools/meson.build | 1 + > 4 files changed, 7 insertion

[PATCH] ci: drop mipsel on Debian Sid

2023-11-03 Thread Daniel P . Berrangé
This port was discontinued and purged from the archives: https://lists.debian.org/debian-devel-announce/2023/09/msg0.html Signed-off-by: Daniel P. Berrangé --- ci/buildenv/debian-sid-cross-mipsel.sh| 115 - .../debian-sid-cross-mipsel.Dockerfile| 121

Re: [libvirt PATCH] rpcgen: use proper operators when comparing types

2023-11-06 Thread Daniel P . Berrangé
generator.py | 26 ++-- > scripts/rpcgen/rpcgen/lexer.py | 2 +- > scripts/rpcgen/rpcgen/parser.py| 68 +++--- > 4 files changed, 50 insertions(+), 50 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com

Re: [PATCH] ci: workaround broken opensuse leap 15.5 tirpc

2023-11-06 Thread Daniel P . Berrangé
On Mon, Nov 06, 2023 at 10:37:28AM +0100, Martin Kletzander wrote: > On Mon, Nov 06, 2023 at 10:19:23AM +0100, Martin Kletzander wrote: > > On Fri, Nov 03, 2023 at 09:37:19AM -0400, Daniel P. Berrangé wrote: > > > Temporarily disable '-Wmissing-include-dirs' becuase t

Re: [PATCH] virhostmem: Get total memory on macOS properly

2023-11-06 Thread Daniel P . Berrangé
://github.com/apple-oss-distributions/xnu/blob/xnu-10002.1.13/bsd/sys/sysctl.h > > Reported-by: Jaroslav Suchanek > Signed-off-by: Michal Privoznik > --- > src/util/virhostmem.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With re

Re: [PATCH] ci: workaround broken opensuse leap 15.5 tirpc

2023-11-06 Thread Daniel P . Berrangé
On Mon, Nov 06, 2023 at 01:47:20AM -0800, Andrea Bolognani wrote: > On Mon, Nov 06, 2023 at 10:37:28AM +0100, Martin Kletzander wrote: > > On Mon, Nov 06, 2023 at 10:19:23AM +0100, Martin Kletzander wrote: > > > On Fri, Nov 03, 2023 at 09:37:19AM -0400, Daniel

Re: [PATCH] ci: workaround broken opensuse leap 15.5 tirpc

2023-11-06 Thread Daniel P . Berrangé
On Mon, Nov 06, 2023 at 02:21:16AM -0800, Andrea Bolognani wrote: > On Mon, Nov 06, 2023 at 09:58:02AM +0000, Daniel P. Berrangé wrote: > > On Mon, Nov 06, 2023 at 01:47:20AM -0800, Andrea Bolognani wrote: > > > On Mon, Nov 06, 2023 at 10:37:28AM +0100, Martin Kletzander wrote:

Re: [PATCH] ci: workaround broken opensuse leap 15.5 tirpc

2023-11-06 Thread Daniel P . Berrangé
On Mon, Nov 06, 2023 at 12:45:22PM +0100, Michal Prívozník wrote: > On 11/6/23 11:54, Andrea Bolognani wrote: > > On Mon, Nov 06, 2023 at 10:26:36AM +0000, Daniel P. Berrangé wrote: > >> On Mon, Nov 06, 2023 at 02:21:16AM -0800, Andrea Bolognani wrote: > >>> So do

Re: [libvirt PATCH 0/5] ci: Add macOS 13 & 14, drop macOS 12

2023-11-06 Thread Daniel P . Berrangé
On Mon, Nov 06, 2023 at 12:04:09PM +0100, Andrea Bolognani wrote: > Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1062214982 > > Assumes that > > https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/444 > > has been merged, which it hasn't yet, but I don't expect it to be >

Re: [libvirt PATCH 2/5] ci: Drop rpcgen override from macOS $PATH

2023-11-06 Thread Daniel P . Berrangé
On Mon, Nov 06, 2023 at 12:04:11PM +0100, Andrea Bolognani wrote: > We no longer use rpcgen. > > Signed-off-by: Andrea Bolognani > --- > ci/gitlab/builds.yml | 2 +- > ci/manifest.yml | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Danie

Re: [libvirt PATCH 3/5] ci: Add macOS 13

2023-11-06 Thread Daniel P . Berrangé
(+) > create mode 100644 ci/cirrus/macos-13.vars Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-phot

Re: [libvirt PATCH 5/5] ci: Drop macOS 12

2023-11-06 Thread Daniel P . Berrangé
(-) > delete mode 100644 ci/cirrus/macos-12.vars Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-phot

Re: [libvirt PATCH 4/5] ci: Add macOS 14

2023-11-06 Thread Daniel P . Berrangé
(+) > create mode 100644 ci/cirrus/macos-14.vars Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-phot

Re: [libvirt PATCH 0/5] ci: Add macOS 13 & 14, drop macOS 12

2023-11-06 Thread Daniel P . Berrangé
On Mon, Nov 06, 2023 at 07:38:13AM -0800, Andrea Bolognani wrote: > On Mon, Nov 06, 2023 at 12:42:58PM +0000, Daniel P. Berrangé wrote: > > On Mon, Nov 06, 2023 at 12:04:09PM +0100, Andrea Bolognani wrote: > > > Test pipeline: https://gitlab.com/abologna/libvirt/-/pi

Re: [libvirt PATCH] systemd: More tweaks to Description and Documentation lines

2023-11-06 Thread Daniel P . Berrangé
irt-guests.service.in | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.co

[libvirt PATCH] src: reject empty string for 'dname' in migrate APIs

2023-11-08 Thread Daniel P . Berrangé
which mistakenly hardcoded 'dname' to the empty string. Fixes: https://gitlab.com/libvirt/libvirt-rust/-/issues/11 Signed-off-by: Daniel P. Berrangé --- src/internal.h | 14 +++ src/libvirt-domain.c | 97 +++- 2 files changed, 100 inserti

Re: [libvirt PATCH 2/3] qemu: Implement VIR_MIGRATE_ASSUME_SHARED_STORAGE support

2023-11-13 Thread Daniel P . Berrangé
On Mon, Nov 13, 2023 at 09:03:53AM -0800, Andrea Bolognani wrote: > On Wed, Nov 01, 2023 at 12:52:15PM +0000, Daniel P. Berrangé wrote: > > On Tue, Oct 31, 2023 at 06:12:59PM +0100, Andrea Bolognani wrote: > > > if ((rc = virFileIsSharedFS(src)) < 0) { > >

Re: [libvirt PATCH] rpc: Pass GPG_TTY and TERM environment variables

2023-11-17 Thread Daniel P . Berrangé
t.c | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.o

Re: Kernel issue or libvirt issue? Where to report?

2023-11-20 Thread Daniel P . Berrangé
On Sun, Nov 12, 2023 at 04:50:22PM +0100, Koos Pol wrote: > Hi, > > After upgrading the VM host (os + kernel) a VM client can no longer use a > pass-through USB device. The syslog of the VM host is flooded with: > > nov 08 19:59:46 vmhost kernel: usb 1-3: usbfs: process 1729 > (qemu-system-x86) d

Re: [libvirt PATCH 5/6] remote: Expose granularPolkit attribute to rules

2023-11-20 Thread Daniel P . Berrangé
On Mon, Nov 20, 2023 at 03:49:56PM +0100, Andrea Bolognani wrote: > This makes it possible to write Polkit rules that won't > accidentally grant undesired privileges to users. > > To understand why this is necessary, suppose we wanted to > grant user "fred" full access to the QEMU domain "demo". >

[libvirt PATCH] gitlab: adjust url to Coverity tools

2023-11-21 Thread Daniel P . Berrangé
The URL to the Coverity tools download has changed; the old one points to an obsolete version that is not supported anymore. Adjust to point to the correct and supported tools. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH 2/2] nwfilterxml2firewalltest: Use virqsortmock for stable sorting

2023-11-22 Thread Daniel P . Berrangé
On Wed, Nov 22, 2023 at 11:49:55AM +0100, Michal Privoznik wrote: > The way that nwfilterxml2firewalltest works is: it loads a > NWFilter XML from a file, parses it and then calls > ebiptablesApplyNewRules() recording all commands that would be > executed when instantiating the rule. This is then c

Re: [libvirt RFCv11 00/33] multifd save restore prototype

2023-11-27 Thread Daniel P . Berrangé
On Mon, Nov 27, 2023 at 11:40:29AM +0100, Claudio Fontana wrote: > On 11/27/23 11:18, Daniel P. Berrangé wrote: > > On Mon, Nov 27, 2023 at 10:43:58AM +0100, Claudio Fontana wrote: > >> Hi all, > >> > >> I understand there has been some movement in this top

Re: [PATCH 2/2] Report better error message in remoteGetUNIXSocket

2023-11-28 Thread Daniel P . Berrangé
On Tue, Nov 28, 2023 at 01:02:40PM +0100, Martin Kletzander wrote: > Before this patch users might be confused with the error when no daemon > nor systemd socket unit is running due to the error message being a bit > vague when running as root with no URI: > > # virsh list > error: failed to c

Re: [PATCH 4/4] ch: Don't leak ch_driver->chCaps

2023-11-28 Thread Daniel P . Berrangé
On Tue, Nov 28, 2023 at 11:43:11AM -0600, Praveen K Paladugu wrote: > > > On 11/28/2023 9:59 AM, Michal Privoznik wrote: > > During CH driver initialization (chStateInitialize()) the > > driver's capabilities bitmap is allocated > > (virCHCapsInitCHVersionCaps()), but corresponding free call is >

Re: [libvirt PATCH] rpm: Drop rpcgen Build-Requires once again

2023-11-28 Thread Daniel P . Berrangé
> Signed-off-by: Andrea Bolognani > --- > libvirt.spec.in | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-ht

[libvirt PATCH] scripts/rpcgen: fix 64 unsigned int test on macOS

2023-11-30 Thread Daniel P . Berrangé
macOS XDR library is an oddball using xdr_u_int64_t instead of xdr_uint64_t which everyone else has. The code generator already does the right thing, but the test program previously generated with the Linux rpcgen program does not compile on macOS due to this. Signed-off-by: Daniel P. Berrangé

Re: [libvirt PATCH 0/5] rpcgen: Fix test coverage

2023-11-30 Thread Daniel P . Berrangé
On Wed, Nov 29, 2023 at 06:18:27PM +0100, Andrea Bolognani wrote: > Right now we don't have pytest installed in any of the CI build > environments, and tests are only executed when pytest is present, so > the test coverage is exactly zero. > > This series changes things so that we actually run the

Re: [libvirt PATCH] scripts/rpcgen: fix 64 unsigned int test on macOS

2023-11-30 Thread Daniel P . Berrangé
On Thu, Nov 30, 2023 at 05:17:09AM -0500, Andrea Bolognani wrote: > On Thu, Nov 30, 2023 at 09:24:15AM +0000, Daniel P. Berrangé wrote: > > macOS XDR library is an oddball using xdr_u_int64_t instead of > > xdr_uint64_t which everyone else has. > > > > The code gener

Re: [libvirt PATCH] rpcgen: Pass 3 arguments to xdrproc_t calls

2023-11-30 Thread Daniel P . Berrangé
Way back in 2013, commit 9fa3a8ab6fd8 handled this situation > for the main library code. Apply the same fix here. > > Signed-off-by: Andrea Bolognani > --- > scripts/rpcgen/tests/test_demo.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Daniel P. B

Re: [libvirt PATCH] scripts/rpcgen: fix 64 unsigned int test on macOS

2023-11-30 Thread Daniel P . Berrangé
On Thu, Nov 30, 2023 at 09:00:02AM -0500, Andrea Bolognani wrote: > On Thu, Nov 30, 2023 at 11:40:17AM +0000, Daniel P. Berrangé wrote: > > On Thu, Nov 30, 2023 at 05:17:09AM -0500, Andrea Bolognani wrote: > > > On Thu, Nov 30, 2023 at 09:24:15AM +, Daniel P. Berrangé wr

[libvirt PATCH v2] scripts/rpcgen: fix 64 unsigned int test on macOS

2023-11-30 Thread Daniel P . Berrangé
macOS XDR library is an oddball using xdr_u_int64_t instead of xdr_uint64_t which everyone else has. The code generator already does the right thing, but the test program previously generated with the Linux rpcgen program does not compile on macOS due to this. Signed-off-by: Daniel P. Berrangé

Re: [libvirt PATCH v2] scripts/rpcgen: fix 64 unsigned int test on macOS

2023-11-30 Thread Daniel P . Berrangé
On Thu, Nov 30, 2023 at 09:30:28AM -0500, Andrea Bolognani wrote: > On Thu, Nov 30, 2023 at 02:07:55PM +0000, Daniel P. Berrangé wrote: > > +++ b/scripts/rpcgen/tests/test_demo.c > > @@ -3,6 +3,10 @@ > > #include > > #include > > > > +#ifdef __APPLE__ &

Re: [libvirt PATCH v2] scripts/rpcgen: fix 64 unsigned int test on macOS

2023-11-30 Thread Daniel P . Berrangé
On Thu, Nov 30, 2023 at 10:05:43AM -0500, Andrea Bolognani wrote: > On Thu, Nov 30, 2023 at 09:30:28AM -0500, Andrea Bolognani wrote: > > On Thu, Nov 30, 2023 at 02:07:55PM +0000, Daniel P. Berrangé wrote: > > > +++ b/scripts/rpcgen/tests/test_demo.c > > > @@ -3

Re: [libvirt PATCH v2] scripts/rpcgen: fix 64 unsigned int test on macOS

2023-11-30 Thread Daniel P . Berrangé
On Thu, Nov 30, 2023 at 04:10:00PM +0100, Michal Prívozník wrote: > On 11/30/23 16:05, Andrea Bolognani wrote: > > On Thu, Nov 30, 2023 at 09:30:28AM -0500, Andrea Bolognani wrote: > >> On Thu, Nov 30, 2023 at 02:07:55PM +, Daniel P. Berrangé wrote: > >>> +++ b/sc

Re: [libvirt PATCH 1/1] rpcgen: Skip generator tests on macOS

2023-12-01 Thread Daniel P . Berrangé
suite on macOS, simply skip the > generator tests on that platform for now. > > Signed-off-by: Andrea Bolognani > --- > scripts/rpcgen/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://ber

Re: [PATCH rfcv3 00/11] LIBVIRT: X86: TDX support

2023-12-04 Thread Daniel P . Berrangé
On Mon, Dec 04, 2023 at 03:38:30AM +, Duan, Zhenzhong wrote: > > > >-Original Message- > >From: Jonathon Jongsma > >Sent: Saturday, December 2, 2023 6:30 AM > >Subject: Re: [PATCH rfcv3 00/11] LIBVIRT: X86: TDX support > > > >Hello, > > > >Thanks for the submission. A few initial gen

Re: [PATCH rfcv3 00/11] LIBVIRT: X86: TDX support

2023-12-04 Thread Daniel P . Berrangé
On Mon, Dec 04, 2023 at 11:30:54AM +0100, Peter Krempa wrote: > On Mon, Dec 04, 2023 at 10:28:17 +0000, Daniel P. Berrangé wrote: > > On Mon, Dec 04, 2023 at 03:38:30AM +, Duan, Zhenzhong wrote: > > > > > > > > > >-Original Message- >

Re: [PATCH v1] qemu_driver: Don't handle the EOF event if monitor changed

2023-12-06 Thread Daniel P . Berrangé
On Wed, Nov 29, 2023 at 07:44:19PM +0800, t...@chinatelecom.cn wrote: > From: Guoyi Tu > > Currently, libvirt creates a thread pool with only on thread to handle all > qemu monitor events for virtual machines, In the cases that if the thread > gets stuck while handling a monitor EOF event, such a

Re: [PATCH v1] qemu_driver: Don't handle the EOF event if monitor changed

2023-12-07 Thread Daniel P . Berrangé
On Thu, Dec 07, 2023 at 03:42:07PM +0800, Guoyi Tu wrote: > > > On 2023/12/7 0:01, Daniel 【外部账号】P. Berrangé wrote: > > On Wed, Nov 29, 2023 at 07:44:19PM +0800, t...@chinatelecom.cn wrote: > > > From: Guoyi Tu > > > > > > Currently, libvirt creates a thread pool with only on thread to handle al

Re: [PATCH] remote: Fix cached hypervisor type

2023-12-08 Thread Daniel P . Berrangé
; Ths change also fixes random SIGABRT from perl processes running > libvirt-tck tests. > > Signed-off-by: Jim Fehlig > --- > src/remote/remote_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé > > diff --git a/src/rem

Re: [PATCH v2 0/9] RFC: Add versioned CPUs to libvirt

2023-12-08 Thread Daniel P . Berrangé
On Thu, Dec 07, 2023 at 04:07:48PM -0600, Jonathon Jongsma wrote: > For SEV-SNP support we will need to be able to specify versioned CPU models > that are not yet available in libvirt. Rather than just adding a versioned CPU > or two that would satisfy that immediate need, I decided to try to add >

Re: Public virErrorPreserveLast()/virErrorRestore()

2023-12-15 Thread Daniel P . Berrangé
On Thu, Dec 14, 2023 at 05:55:41PM +0100, Peter Krempa wrote: > On Thu, Dec 14, 2023 at 12:03:55 +, John Levon wrote: > Using the global error handler function is not a very good idea in > multithreaded applications, so I'd really suggest to have a generic > handler function that you'll call af

Re: Public virErrorPreserveLast()/virErrorRestore()

2023-12-15 Thread Daniel P . Berrangé
On Wed, Dec 13, 2023 at 11:04:54AM +, John Levon wrote: > > These two functions are currently private to libvirt, hence not available to > consumers. Would it be possible to make them public? Without them, there's no > way to do any libvirt call without stomping on an existing error that you m

Re: [PATCH 3/3] rpc: Rework rpc notifications in main and side thread

2023-12-15 Thread Daniel P . Berrangé
On Fri, Dec 15, 2023 at 02:32:19AM +0800, Fima Shevrin wrote: > RPC client implementation uses the following paradigm. The critical > section is organized via virObjectLock(client)/virObjectUnlock(client) > braces. Though this is potentially problematic as > main thread:

Re: Public virErrorPreserveLast()/virErrorRestore()

2023-12-15 Thread Daniel P . Berrangé
On Wed, Dec 13, 2023 at 11:04:54AM +, John Levon wrote: > > These two functions are currently private to libvirt, hence not available to > consumers. Would it be possible to make them public? Without them, there's no > way to do any libvirt call without stomping on an existing error that you m

Re: [PATCH 3/3] rpc: Rework rpc notifications in main and side thread

2023-12-15 Thread Daniel P . Berrangé
On Fri, Dec 15, 2023 at 01:48:09PM +, Efim Shevrin wrote: > Hello, > > here are call traces with two threads generated by python script > // == > [root@dandreev-vz-6-0-0-243-master libvirt]# gdb -p 288985 > (gdb) t a a bt > > Thread 2 (Thread 0x7f2112862640 (LWP 28

Re: [PATCH 3/3] rpc: Rework rpc notifications in main and side thread

2023-12-15 Thread Daniel P . Berrangé
On Fri, Dec 15, 2023 at 03:51:19PM +0100, Denis V. Lunev wrote: > On 12/15/23 14:48, Efim Shevrin wrote: > > *From:* Daniel P. Berrangé > > *Sent:* Friday, December 15, 2023 19:09 > > *To:* Efim Shevrin > > *Cc:* devel@lists.libvirt.org ; d...@openvz.org > > &

Re: [PATCH 3/3] rpc: Rework rpc notifications in main and side thread

2023-12-18 Thread Daniel P . Berrangé
On Fri, Dec 15, 2023 at 02:32:19AM +0800, Fima Shevrin wrote: > RPC client implementation uses the following paradigm. The critical > section is organized via virObjectLock(client)/virObjectUnlock(client) > braces. Though this is potentially problematic as > main thread:

Re: [PATCH 3/3] rpc: Rework rpc notifications in main and side thread

2023-12-18 Thread Daniel P . Berrangé
On Mon, Dec 18, 2023 at 10:32:07AM +, Daniel P. Berrangé wrote: > On Fri, Dec 15, 2023 at 02:32:19AM +0800, Fima Shevrin wrote: > > RPC client implementation uses the following paradigm. The critical > > section is organized via virObjectLock(client)/virObjectUnlock(client) >

[PATCH] rpc: fix race in waking up client event loop

2023-12-18 Thread Daniel P . Berrangé
o run the quit function from within the first thread. This guarantees that the first thread will see the wakeup. Signed-off-by: Daniel P. Berrangé --- src/rpc/virnetclient.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/rpc/virnetclient.c b/sr

Re: [PATCH] ci: Switch from FreeBSD 12.0 to FreeBSD 14.0

2024-01-03 Thread Daniel P . Berrangé
t; ci/gitlab/builds.yml | 28 +-- > ci/manifest.yml | 4 +-- > 3 files changed, 16 insertions(+), 16 deletions(-) > rename ci/cirrus/{freebsd-12.vars => freebsd-14.vars} (100%) Reviewed-by: Daniel P. Berrangé

Re: [PATCH v2] qemu_driver: Don't handle the EOF event if vm get restarted

2024-01-03 Thread Daniel P . Berrangé
--- > src/qemu/qemu_domain.c | 2 +- > src/qemu/qemu_driver.c | 11 +-- > src/qemu/qemu_process.c | 2 +- > 3 files changed, 11 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berrangé > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index 64

Re: [PATCH 05/10] virDomainBlockResize: Introduce VIR_DOMAIN_BLOCK_RESIZE_CAPACITY

2024-01-03 Thread Daniel P . Berrangé
On Thu, Dec 14, 2023 at 10:19:40AM +0100, Peter Krempa wrote: > Allow users to easily resize 'raw' images on block devices to the full > capacity of the block device. Obviously this won't work on file-backed > storage (filling the remaining capacity is most likely wrong) or for > formats with metad

[PATCH] qemu: tighten semantics of 'size' when resizing block devices

2024-01-03 Thread Daniel P . Berrangé
ize of the underlying block device. The latter gives the management application the ability to sanity check that the block device size matches what they think it should be. Signed-off-by: Daniel P. Berrangé --- src/libvirt-domain.c | 5 +++-- src/qemu/qemu_driver.c | 9 - 2 files changed, 11

Re: Re: [PATCH 3/3] ci: Add notes for integration jobs

2024-01-08 Thread Daniel P . Berrangé
On Mon, Jan 08, 2024 at 02:57:40AM -0800, Andrea Bolognani wrote: > On Mon, Jan 08, 2024 at 11:54:00AM +0100, Peter Krempa wrote: > > On Mon, Jan 08, 2024 at 11:43:24 +0100, Andrea Bolognani wrote: > > > These are special in that, when a new target is introduced, some > > > preparation is needed be

Re: [PATCH 2/2] tests: Add capabilities for QEMU 8.2.0 on aarch64

2024-01-08 Thread Daniel P . Berrangé
On Mon, Jan 08, 2024 at 05:59:06PM +0100, Andrea Bolognani wrote: > Notable changes compared to 7.0.0, the most recent version that > we had capabilities for until now: > > * SPICE support is no longer compiled in; Presumably that's just your dev machine lacking spice-server-devel, since upstre

Re: Re: Re: [PATCH 1/3] ci: Fix upstream-qemu job definitions

2024-01-09 Thread Daniel P . Berrangé
On Tue, Jan 09, 2024 at 01:02:38AM -0800, Andrea Bolognani wrote: > On Tue, Jan 09, 2024 at 12:41:25AM -0800, Andrea Bolognani wrote: > > On Mon, Jan 08, 2024 at 09:07:33PM +0100, Peter Krempa wrote: > > > On Mon, Jan 08, 2024 at 11:43:22 +0100, Andrea Bolognani wrote: > > > > These are jobs are su

Re: [PATCH 0/2] ci: Update to Fedora 39

2024-01-09 Thread Daniel P . Berrangé
On Mon, Jan 08, 2024 at 10:48:58AM +0100, Peter Krempa wrote: > On Mon, Jan 08, 2024 at 10:35:53 +0100, Peter Krempa wrote: > > I've approved and merged > > > > https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/109 > > > > and posted > > > > https://gitlab.com/libvirt/libvirt-python/-/mer

Re: [PATCH] qemu: tighten semantics of 'size' when resizing block devices

2024-01-09 Thread Daniel P . Berrangé
On Thu, Jan 04, 2024 at 05:45:21PM +0100, Peter Krempa wrote: > On Wed, Jan 03, 2024 at 16:39:26 +0000, Daniel P. Berrangé wrote: > > When VIR_DOMAIN_BLOCK_RESIZE_CAPACITY is set, the 'size' parameter > > is currently ignored. Since applications must none the less

Re: [PATCH 0/2] ci: Update to Fedora 39

2024-01-09 Thread Daniel P . Berrangé
On Tue, Jan 09, 2024 at 01:12:35PM +0100, Peter Krempa wrote: > On Tue, Jan 09, 2024 at 11:41:17 +0000, Daniel P. Berrangé wrote: > > On Mon, Jan 08, 2024 at 10:48:58AM +0100, Peter Krempa wrote: > > > On Mon, Jan 08, 2024 at 10:35:53 +0100, Peter Krempa wrote: > > >

Re: [PATCH rfcv3 01/11] qemu: Check if INTEL Trust Domain Extention support is enabled

2024-01-09 Thread Daniel P . Berrangé
IS_X86(arch)) > -return virQEMUCapsKVMSupportsSecureGuestAMD(); > +return virQEMUCapsKVMSupportsSecureGuestAMD() || > + virQEMUCapsKVMSupportsSecureGuestINTEL(); > > return false; > } Reviewed-by: Daniel P. Berrangé With regards, Daniel -

Re: [PATCH rfcv3 02/11] qemu: Add TDX capability

2024-01-09 Thread Daniel P . Berrangé
> 2 files changed, 3 insertions(+) Reviewed-by: Daniel P. Berrangé NB, when the time comes to merge this, it'll probably require an update to some of the QEMU capabilities files in tests/, but that'll require the QEMU pieces to be merged first of course. With regards, Daniel -

Re: [PATCH rfcv3 03/11] conf: expose TDX feature in domain capabilities

2024-01-09 Thread Daniel P . Berrangé
On Mon, Nov 27, 2023 at 04:55:13PM +0800, Zhenzhong Duan wrote: > Extend qemu TDX capability to domain capabilities. > > Signed-off-by: Chenyi Qiang > Signed-off-by: Zhenzhong Duan > --- > docs/formatdomaincaps.rst | 1 + > src/conf/domain_capabilities.c | 1 + > src/conf/domain_capabi

Re: [PATCH rfcv3 04/11] conf: add tdx as launch security type

2024-01-09 Thread Daniel P . Berrangé
On Mon, Nov 27, 2023 at 04:55:14PM +0800, Zhenzhong Duan wrote: > When 'tdx' is used, the VM will launched with Intel TDX feature enabled. > TDX feature supports running encrypted VM (Trust Domain, TD) under the > control of KVM. A TD runs in a CPU model which protects the > confidentiality of its

Re: [PATCH rfcv3 05/11] qemu: Add command line and validation for TDX type

2024-01-09 Thread Daniel P . Berrangé
On Mon, Nov 27, 2023 at 04:55:15PM +0800, Zhenzhong Duan wrote: > QEMU will provides 'tdx-guest' object which is used to launch encrypted > VMs on Intel platform using TDX feature. > > Command line looks like: > $QEMU ... \ > -object > tdx-guest,id=lsec0,debug=on,sept-ve-disable=on,mrconfigid=x

Re: [PATCH rfcv3 06/11] qemu: force special parameters enabled for TDX guest

2024-01-09 Thread Daniel P . Berrangé
On Mon, Nov 27, 2023 at 04:55:16PM +0800, Zhenzhong Duan wrote: > TDX guest requires some special parameters to boot, They are: > > "-machine pc-q35-*" > "kernel_irqchip=split" > > Signed-off-by: Zhenzhong Duan > --- > src/qemu/qemu_validate.c | 10 ++ > 1 file changed, 10 insertions(

Re: [PATCH rfcv3 08/11] qemu: make hard reboot as the TDX default reboot mode

2024-01-09 Thread Daniel P . Berrangé
On Mon, Nov 27, 2023 at 04:55:18PM +0800, Zhenzhong Duan wrote: > From: Chenyi Qiang > > Signed-off-by: Chenyi Qiang > --- > src/qemu/qemu_driver.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index 86e8e

  1   2   3   4   5   6   7   8   9   10   >