domcapabilities output using the same format I use in my proposed patch for the
qemu capabilities file:
...
...
...
Please let me know your thoughts. Once an approach is agreed upon, I will
begin development.
format:
Signed-off-by: Collin Walling
---
src/qemu/qemu_capabilities.c | 30 ++
src/qemu/qemu_monitor.h | 2 ++
src/qemu/qemu_monitor_json.c | 29 -
3 files c
Polite ping. Would like some feedback / discussion on this before I
move forward. Thanks! :)
On 6/3/24 10:40 AM, Jiri Denemark wrote:
> On Tue, May 07, 2024 at 18:24:20 -0400, Collin Walling wrote:
>> QEMU will soon support reporting an optional array of deprecated
>> features for an expanded CPU model via the query-cpu-model-expansion
>> command. The intended use of
On 6/3/24 1:53 PM, Daniel P. Berrangé wrote:
> On Tue, May 07, 2024 at 06:24:20PM -0400, Collin Walling wrote:
>> Notes
>> =
>>
>> - In my example below, I am running on a z14.2 machine.
>>
>> - The features that are flagged as deprecated for
On 6/13/24 7:22 AM, Jiri Denemark wrote:
> On Tue, Jun 04, 2024 at 11:42:25 -0400, Collin Walling wrote:
>> The QEMU portion is designed for s390x such that there is a static list
>> of hardcoded feature bits that are flagged for deprecation. This list
>> can be updated in
rted (trimmed):
z14.2-base
Collin Walling (5):
qemuMonitorJSONGetCPUModelExpansion: refactor parsing functions
qemu: parse deprecated-props from query-cpu-model-expansion response
qemu_capabilities: query deprecated features for host-model
virsh: add --disable-deprecated-featu
e virsh domcapabilities command with the
--disable-deprecated-features argument present.
It is recommended to define a domain XML with this attribute set to
'off' to ensure migration to machines that may outright drop these
features in the future.
Signed-off-by: Collin Walling
Add a new flag, --disable-deprecated-features, to the domcapabilities
command. This will modify the output to show the 'host-model' CPU
with features flagged as deprecated paired with the 'disable' policy.
virsh domcapabilities --disable-deprecated-features
Signed-of
) deprecated_props field resulting from the command.
Signed-off-by: Collin Walling
---
src/qemu/qemu_monitor_json.c | 46 ++--
1 file changed, 39 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index c594b33106
(e.g. model
name, etc) is ignored.
The new capabilities flag is used to fence off the extra query for
architectures/QEMU binaries that do not report deprecated CPU model
features.
Signed-off-by: Collin Walling
---
src/qemu/qemu_capabilities.c | 38 ++
src/qemu/qemu_capabilit
parsed, and cached. The data
will be utilized in a subsequent patch.
Signed-off-by: Collin Walling
---
src/qemu/qemu_capabilities.c | 31 +++
src/qemu/qemu_monitor.c | 10 ++
src/qemu/qemu_monitor.h | 1 +
sr
parsed, and cached. The data
will be utilized in a subsequent patch.
Signed-off-by: Collin Walling
---
src/qemu/qemu_capabilities.c | 31 +++
src/qemu/qemu_monitor.c | 10 ++
src/qemu/qemu_monitor.h | 1 +
sr
rted (trimmed):
z14.2-base
Collin Walling (5):
qemuMonitorJSONGetCPUModelExpansion: refactor parsing functions
qemu: parse deprecated-props from query-cpu-model-expansion response
qemu_capabilities: query
Add a new flag, --disable-deprecated-features, to the domcapabilities
command. This will modify the output to show the 'host-model' CPU
with features flagged as deprecated paired with the 'disable' policy.
virsh domcapabilities --disable-deprecated-features
Signed-of
(e.g. model
name, etc) is ignored.
The new capabilities flag is used to fence off the extra query for
architectures/QEMU binaries that do not report deprecated CPU model
features.
Signed-off-by: Collin Walling
---
src/qemu/qemu_capabilities.c | 38 ++
src/qemu/qemu_capabilit
e virsh domcapabilities command with the
--disable-deprecated-features argument present.
It is recommended to define a domain XML with this attribute set to
'off' to ensure migration to machines that may outright drop these
features in the future.
Signed-off-by: Collin Walling
) deprecated_props field resulting from the command.
Signed-off-by: Collin Walling
---
src/qemu/qemu_monitor_json.c | 46 ++--
1 file changed, 39 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index 1b4288b744
On 11/26/24 11:59 AM, Jiri Denemark wrote:
> On Mon, Nov 25, 2024 at 14:46:34 -0500, Collin Walling wrote:
>> # Changelog
>>
>> v2
>> - rebased on latest master changes
>
> I started reviewing the v1 yesterday with a plan to push this in time
> for the r
s started (trimmed):
z14.2-base
Collin Walling (7):
qemuMonitorJSONGetCPUModelExpansion: refactor parsing functions
qemu: parse deprecated-props from query-cpu-model-expansion response
qemu_capabilities: query deprecated features for
) deprecated_props field resulting from the command.
Signed-off-by: Collin Walling
Reviewed-by: Boris Fiuczynski
Reviewed-by: Jiri Denemark
---
src/qemu/qemu_monitor_json.c | 46 ++--
1 file changed, 39 insertions(+), 7 deletions(-)
diff --git a/src/qemu
(e.g. model
name, etc) is ignored.
The new capabilities flag is used to fence off the extra query for
architectures/QEMU binaries that do not report deprecated CPU model
features.
Signed-off-by: Collin Walling
Reviewed-by: Boris Fiuczynski
Reviewed-by: Jiri Denemark
---
src
parsed, and cached. The data
will be utilized in a subsequent patch.
Signed-off-by: Collin Walling
Reviewed-by: Boris Fiuczynski
---
src/qemu/qemu_capabilities.c | 31 +++
src/qemu/qemu_monitor.c | 7 +
src/qemu/qemu_mon
Add a new flag, --disable-deprecated-features, to the domcapabilities
command. This will modify the output to show the 'host-model' CPU
with features flagged as deprecated paired with the 'disable' policy.
virsh domcapabilities --disable-deprecated-features
Signed-of
If flag VIR_CONNECT_GET_DOMAIN_CAPABILITIES_DISABLE_DEPRECATED_FEATURES
is passed to qemuConnectGetDomainCapabilities, then the domain's CPU
model features will be updated to set any deprecated features to the
'disabled' policy.
Signed-off-by: Collin Walling
---
src/qemu/qemu
Introduce domain flag used to filter deprecated features from the
domain's CPU model.
Signed-off-by: Collin Walling
---
include/libvirt/libvirt-domain.h | 12
src/libvirt-domain.c | 2 +-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/include/li
e virsh domcapabilities command with the
--disable-deprecated-features argument present.
It is recommended to define a domain XML with this attribute set to
'off' to ensure migration to machines that may outright drop these
features in the future.
Signed-off-by: Collin Walling
---
src
On 12/17/24 5:46 AM, Jiri Denemark wrote:
> On Mon, Dec 16, 2024 at 18:03:51 -0500, Collin Walling wrote:
>> # Changelog
>>
>> v3
>> - added reviewed-by's on appropriate patches
>> - split patch #4 into three:
>>
On 1/17/25 11:15 AM, Daniel P. Berrangé wrote:
> On Fri, Jan 17, 2025 at 04:08:40PM -, wall...@linux.ibm.com wrote:
>>> Indeed I did say that a virsh command based on GetDomainCapabilities
>>> was OK, but that is not what this series is doing.
>>>
>>> This is essentially the same as the old ser
On 3/6/25 2:07 PM, Collin Walling wrote:
Ping and adding Daniel et al on CC :)
> From: David Judkovics
>
> Add new virsh command 'hypervisor-cpu-models'. Command pulls from the
> existing domcapabilities XML and uses xpath to parse CPU model strings.
> By default
On 3/18/25 1:13 PM, Ján Tomko wrote:
> On a Thursday in 2025, Collin Walling wrote:
>> From: David Judkovics
>>
>> Add new virsh command 'hypervisor-cpu-models'. Command pulls from the
>> existing domcapabilities XML and uses xpath to parse CPU model strings
On 3/19/25 4:15 AM, Peter Krempa via Devel wrote:
> On Tue, Mar 18, 2025 at 18:13:57 +0100, Ján Tomko via Devel wrote:
>> On a Thursday in 2025, Collin Walling wrote:
>>> From: David Judkovics
>>>
>>> Add new virsh command 'hypervisor-cpu-mode
;--all" to also print
models which are not supported on the host.
Signed-off-by: David Judkovics
Signed-off-by: Boris Fiuczynski
Signed-off-by: Collin Walling
Reviewed-by: Ján Tomko
---
Changelog:
v2
- Corrected virsh.rst documentation
- Removed unwanted_positional
On 3/17/25 2:49 AM, Collin Walling wrote:
> On 3/6/25 2:07 PM, Collin Walling wrote:
>
> Ping and adding Daniel et al on CC :)
>
Take-two. Apparently my CC list didn't take Daniel's email. Apologies.
--
Regards,
Collin
get-go
by disabling deprecated features by default. They may still be disabled
for other model types via the respective attribute, or reenabled if
desired.
Collin Walling (2):
qemu: caps: add virCPUFeaturePolicy param to
virQEMUCapsUpdateCPUDeprecatedFeatures
qemu: caps: disable deprecated feat
cide what happens to these features.
Additionally, group the relevant code in qemu_process.c.
Signed-off-by: Collin Walling
---
src/qemu/qemu_capabilities.c | 6 +++---
src/qemu/qemu_capabilities.h | 3 ++-
src/qemu/qemu_driver.c | 3 ++-
src/qemu/qemu_process.c | 19
To ease the user with defining a guest with a migratable CPU model,
let's disable the deprecated features from the get-go. If these
features are still desired, they may be reenabled via the
deprecated_features='on' attribute.
Signed-off-by: Collin Walling
---
src/qemu/qemu
;--all" to also print
models which are not supported on the host.
Signed-off-by: David Judkovics
Signed-off-by: Boris Fiuczynski
Signed-off-by: Collin Walling
---
This is a continuation of a previous series found here:
https://lists.libvirt.org/archives/list/devel@lists
On 5/1/25 4:17 PM, Collin Walling wrote:
Ping.
> The intention of reporting deprecated features and modifying the guest
> CPU model was to alleviate the user from the burden of preparing a guest
> with the necessary amendments to assure migration to newer hardware.
> While that goa
cide what happens to these features.
Add a test with guest XML using deprecated_features='on' to ensure the
API is working properly.
Signed-off-by: Collin Walling
---
src/qemu/qemu_capabilities.c | 6 ++--
src/qemu/qemu_capabilities.h |
ive attribute, or reenabled if
desired.
Collin Walling (3):
qemu: caps: add virCPUFeaturePolicy param to
virQEMUCapsUpdateCPUDeprecatedFeatures
qemu: process: refactor deprecated features code
qemu: process: disable deprecated features for s390 models by default
src/qemu/qemu_capabi
ze this updated behavior, so update the CPU
features on the corresponding args files.
Signed-off-by: Collin Walling
---
src/qemu/qemu_process.c | 9 +
.../default-video-type-s390x.s390x-latest.args | 2 +-
.../hostdev-vfio-zpci-ccw-memballoon.s390x-la
Group up the deprecated features code into a single block to keep things
clean; only check if the deprecated_features attribute is present
once and then do relevent work.
Signed-off-by: Collin Walling
---
src/qemu/qemu_process.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions
On 5/22/25 1:33 AM, Collin Walling wrote:
> Group up the deprecated features code into a single block to keep things
> clean; only check if the deprecated_features attribute is present
> once and then do relevent work.
>
> Signed-off-by: Collin Walling
> ---
> src/qem
to resolve.
These patches make s390 CPU host models migration ready from the get-go
by disabling deprecated features by default. They may still be disabled
for other model types via the respective attribute, or reenabled if
desired.
Collin Walling (3):
qemu
update the CPU
features on the corresponding args files.
Signed-off-by: Collin Walling
---
src/qemu/qemu_process.c | 11 +++
.../default-video-type-s390x.s390x-latest.args| 2 +-
...hostdev-vfio-zpci-ccw-memballoon.s390x-latest.args | 2 +-
.../launc
cide what happens to these features.
Add a test with guest XML using deprecated_features='on' to ensure the
API is working properly.
Signed-off-by: Collin Walling
---
src/qemu/qemu_capabilities.c | 6 ++--
src/qemu/qemu_capabilities.h |
Group up the deprecated features code into a single block to keep things
clean; only check if the deprecated_features attribute is present
once and then do relevent work.
Signed-off-by: Collin Walling
---
src/qemu/qemu_process.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions
On 5/22/25 1:33 AM, Collin Walling wrote:
Please refer to v3 and ignore this version. I found an issue after
posting. It is fixed in v3.
--
Regards,
Collin
e attribute within the
guest XML.
Boris Fiuczynski (1):
tests: new qemuxmlactive tests for s390x
Collin Walling (4):
docs: domain: document deprecated_features attribute
qemu: caps: add virCPUFeaturePolicy param to
virQEMUCapsUpdateCPUDeprecatedFeatures
qemu: process: refac
Provide documentation for the deprecated_features XML attribute.
Available since 11.0.0, and supported for S390.
Signed-off-by: Collin Walling
---
docs/formatdomain.rst | 8
1 file changed, 8 insertions(+)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index c7c75ae219
te the CPU
features on the corresponding args files.
Signed-off-by: Boris Fiuczynski
Signed-off-by: Collin Walling
---
src/qemu/libvirtd_qemu.aug| 3 ++
src/qemu/qemu.conf.in | 14
src/qemu/qemu_conf.c | 33 ++
cide what happens to these features.
Add a test with guest XML using deprecated_features='on' to ensure the
API is working properly.
Signed-off-by: Collin Walling
Reviewed-by: Boris Fiuczynski
---
src/qemu/qemu_capabilities.c | 6 ++--
src/qemu/qemu_capabilities.h
Group up the deprecated features code into a single block to keep things
clean; only check if the deprecated_features attribute is present
once and then do relevent work.
Signed-off-by: Collin Walling
Reviewed-by: Boris Fiuczynski
---
src/qemu/qemu_process.c | 13 ++---
1 file changed
es disabled when the domain
XML does not contain the attribute.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Collin Walling
---
...ated-features-none-active.s390x-latest.xml | 25 +++
...ed-features-none-inactive.s390x-latest.xml | 25 +++
...cated-features-off-active.s
On 6/29/25 11:19 PM, Collin Walling wrote:
Pinging this series once. Would like to know if there's any further
feedback or if these patches are good enough. Thanks for your time.
[...]
--
Regards,
Collin
fault_cpu_deprecated_features configuration option
Collin Walling (3):
docs: domain: document deprecated_features attribute
qemu: caps: add virCPUFeaturePolicy param to
virQEMUCapsUpdateCPUDeprecatedFeatures
qemu: process: refactor deprecated features code
docs/formatdomain.rst
Provide documentation for the deprecated_features XML attribute.
Available since 11.0.0, and supported for S390.
Signed-off-by: Collin Walling
---
docs/formatdomain.rst | 8
1 file changed, 8 insertions(+)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index 9a2f065590
Group up the deprecated features code into a single block to keep things
clean; only check if the deprecated_features attribute is present
once and then do relevent work.
Signed-off-by: Collin Walling
Reviewed-by: Boris Fiuczynski
---
src/qemu/qemu_process.c | 13 ++---
1 file changed
cide what happens to these features.
Add a test with guest XML using deprecated_features='on' to ensure the
API is working properly.
Signed-off-by: Collin Walling
Reviewed-by: Boris Fiuczynski
---
src/qemu/qemu_capabilities.c | 6 ++--
src/qemu/qemu_capabilities.h
d behavior, so update the CPU
features on the corresponding args files.
Signed-off-by: Boris Fiuczynski
Signed-off-by: Collin Walling
---
src/qemu/libvirtd_qemu.aug| 3 ++
src/qemu/qemu.conf.in | 14
src/qemu/qemu_conf.c
ent. This is due to
the fact that the tests never touch the code path in qemu_process that
trigger this change in the domain definition.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Collin Walling
---
...cated-features-off-active.s390x-latest.xml | 25 +++
...ted-features-off-inac
On 6/29/25 23:19, Collin Walling wrote:
Pinging again, since it's been about three weeks since the last bump.
Unless these patches are satisfactory, please inform on what needs to
change.
--
Regards,
Collin
Signed-off-by: Collin Walling
---
NEWS.rst | 8
1 file changed, 8 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index e5e8626729..6cc8f23225 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -32,6 +32,14 @@ v11.6.0 (unreleased)
that is liable to cause crashes of the source QEMU when
On 7/24/25 03:35, Thomas Huth via Devel wrote:
> On 30/06/2025 05.19, Collin Walling wrote:
>> Changelog
>>
>> v5
>> - dropped the "none" test in qemuxmlactivetest (see commit for
>> details)
>> - reordere
On 7/25/25 09:53, Jiri Denemark via Devel wrote:
> On Thu, Jul 24, 2025 at 14:39:02 -0400, Collin Walling wrote:
>> On 7/24/25 03:35, Thomas Huth via Devel wrote:
>>> On 30/06/2025 05.19, Collin Walling wrote:
>>>> Changelog
>>>>
>>&
66 matches
Mail list logo
