Reviewed-by: Boris Fiuczynski
On 11/21/23 9:53 AM, Peter Krempa wrote:
Reword the error message to clearly state that the machine type doesn't
support the address type. It doesn't matter which device it's for.
Additionally the alias may be still NULL at the point when the
Michal,
thanks for fixing this.
I might want to add into the commit message that this was introduced
with commit:
40cbaa8fbe rpcgen: add test case for XDR serialization
Reviewed-by: Boris Fiuczynski
and tested as well.
On 11/29/23 13:00, Michal Privoznik wrote:
There are some platforms
Reviewed-by: Boris Fiuczynski
and tested.
On 11/29/23 13:00, Michal Privoznik wrote:
The test_demo program compares whether XDR encoded data match the
expected output as read from a file. But the file path is not
absolute and thus relative to CWD which means the program can run
only from one
Commit 26136e3 allowed to use option all with option tree but did not update
the manpage.
Signed-off-by: Boris Fiuczynski
---
docs/manpages/virsh.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index 4bcfbc230b
. mdevctl supports with callout scripts to do an
attribute retrieval of started mdevs which is already implemented in
libvirt.
Signed-off-by: Boris Fiuczynski
---
include/libvirt/libvirt-nodedev.h | 11
src/conf/node_device_conf.c | 53 ++--
src/conf
virBufferEscapeString already contains the null check.
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index 68924b3027..9a0fc68e67 100644
--- a
Implement the API functions in the node device driver by using
mdevctl modify with the options defined and live.
Increase the minimum mdevctl version to 1.3.0 in spec file to ensure
support exists in mdevctl.
Signed-off-by: Boris Fiuczynski
---
libvirt.spec.in | 2
Refactor attribute handling code into methods for easier reuse.
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c | 27 ---
src/node_device/node_device_driver.c | 108 ---
2 files changed, 83 insertions(+), 52 deletions(-)
diff --git a/src
Allow to filter node devices based on their persisted or transient states.
Signed-off-by: Boris Fiuczynski
---
include/libvirt/libvirt-nodedev.h | 2 ++
src/conf/node_device_conf.h | 7 ++-
src/conf/virnodedeviceobj.c | 8
3 files changed, 16 insertions(+), 1 deletion
Allow to dump the XML of the persisted mdev when the mdev has been
started instead of the current state only.
Signed-off-by: Boris Fiuczynski
---
docs/manpages/virsh.rst | 7 +--
tools/virsh-nodedev.c | 15 ++-
2 files changed, 19 insertions(+), 3 deletions(-)
diff --git a
Now that we can filter persisted and transient node devices in
virConnectListAllNodeDevices(), add these switches also to the
virsh nodedev-list command.
Signed-off-by: Boris Fiuczynski
---
docs/manpages/virsh.rst | 8 ++--
tools/virsh-nodedev.c | 24 ++--
2 files
the node device is active a new option is
added.
The last three patches add the capability to update a mdev node device.
This can be done on the persisted state, on the active state or on both.
To support this v1.3.0 of mdevctl is required.
Boris Fiuczynski (11):
virmdev: prepare type and
Create a new structure holding type and attributes as these are
modifable in a persisted mdev configuration and run out of sync with the
active mdev configuration.
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c | 18 +++
src/conf/node_device_conf.h | 4
Add ability to update node devices.
Signed-off-by: Boris Fiuczynski
---
docs/manpages/virsh.rst | 19
tools/virsh-nodedev.c | 98 +
2 files changed, 117 insertions(+)
diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index
This public API is implemented for almost all other objects that have
a concept of persistent definition and activatability. Node devices
(mdevs) that can be defined and inactive, it will be useful to be
able to update defined and active node devices as well.
Signed-off-by: Boris Fiuczynski
On 1/31/24 22:03, Jonathon Jongsma wrote:
On 1/19/24 10:38 AM, Boris Fiuczynski wrote:
Refactor attribute handling code into methods for easier reuse.
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c | 27 ---
src/node_device/node_device_driver.c | 108
On 1/31/24 22:30, Jonathon Jongsma wrote:
On 1/19/24 10:38 AM, Boris Fiuczynski wrote:
The configuration of a defined mdev can be modified after the mdev is
started. The defined configuration and the active configuration can
therefore run out of sync. Handle this by storing the modifiable data
On 1/31/24 22:34, Jonathon Jongsma wrote:
On 1/19/24 10:38 AM, Boris Fiuczynski wrote:
Allow to dump the XML of the persisted mdev when the mdev has been
started instead of the current state only.
Signed-off-by: Boris Fiuczynski
---
docs/manpages/virsh.rst | 7 +--
tools/virsh
On 1/31/24 22:38, Jonathon Jongsma wrote:
On 1/19/24 10:38 AM, Boris Fiuczynski wrote:
Allow to filter node devices based on their persisted or transient
states.
Signed-off-by: Boris Fiuczynski
---
include/libvirt/libvirt-nodedev.h | 2 ++
src/conf/node_device_conf.h | 7
On 1/31/24 22:38, Jonathon Jongsma wrote:
On 1/19/24 10:38 AM, Boris Fiuczynski wrote:
Now that we can filter persisted and transient node devices in
virConnectListAllNodeDevices(), add these switches also to the
virsh nodedev-list command.
Signed-off-by: Boris Fiuczynski
---
docs/manpages
from the exceptional GetXMLDesc pattern. :D
--
Mit freundlichen Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böbli
;mdev_c60cc60c_c60c_c60c_c60c_c60cc60cc60c_0_0_0008' is not persistent
Do you want it removed?
I think the first error message is fine, and it's more maintainable to
not keep the precondition checks within the function itself.
Ok, I removed the precheck.
--
Mit freundlichen
On 1/31/24 22:41, Jonathon Jongsma wrote:
On 1/19/24 10:38 AM, Boris Fiuczynski wrote:
Implement the API functions in the node device driver by using
mdevctl modify with the options defined and live.
Increase the minimum mdevctl version to 1.3.0 in spec file to ensure
support exists in mdevctl
requirement for v1.3.0 of mdevctl by a dynamic
support check and an unsupported message if not available.
* removed persisted precheck in virsh
* renamed persisted and persist into persistent
* addressed all other review comments made on v1
* added NEWS
Boris Fiuczynski (11):
virmdev: prepare
virBufferEscapeString already contains the null check.
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index a8554102fc..febc58afd1 100644
--- a
Allow to filter node devices based on their persisted or transient states.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
include/libvirt/libvirt-nodedev.h | 2 ++
src/conf/node_device_conf.h | 7 ++-
src/conf/virnodedeviceobj.c | 8
3 files changed
Commit 26136e3 allowed to use option all with option tree but did not
update the manpage.
Signed-off-by: Boris Fiuczynski
---
docs/manpages/virsh.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index 248807d0e9
This public API is implemented for almost all other objects that have
a concept of persistent definition and activatability. Node devices
(mdevs) that can be defined and inactive, it will be useful to be
able to update defined and active node devices as well.
Signed-off-by: Boris Fiuczynski
Create a new structure holding type and attributes as these are
modifable in a persisted mdev configuration and run out of sync with the
active mdev configuration.
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c | 18 +++
src/conf/node_device_conf.h | 4
Add ability to update node devices.
Signed-off-by: Boris Fiuczynski
---
docs/manpages/virsh.rst | 19
tools/virsh-nodedev.c | 98 +
2 files changed, 117 insertions(+)
diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index
Now that we can filter persisted and transient node devices in
virConnectListAllNodeDevices(), add these switches also to the
virsh nodedev-list command.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
docs/manpages/virsh.rst | 8 ++--
tools/virsh-nodedev.c | 24
Refactor attribute handling code into methods for easier reuse.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
src/conf/node_device_conf.c | 27 ---
src/node_device/node_device_driver.c | 104 ---
2 files changed, 80 insertions(+), 51
Allow to dump the XML of the persisted mdev when the mdev has been
started instead of the current state only.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
docs/manpages/virsh.rst | 7 +--
tools/virsh-nodedev.c | 10 +-
2 files changed, 14 insertions(+), 3
: Boris Fiuczynski
---
NEWS.rst | 7 +
libvirt.spec.in | 1 +
src/node_device/node_device_driver.c | 256 +-
src/node_device/node_device_driver.h | 11 +
src/node_device/node_device_udev.c
. mdevctl supports with callout scripts to do an
attribute retrieval of started mdevs which is already implemented in
libvirt.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
include/libvirt/libvirt-nodedev.h | 11
src/conf/node_device_conf.c
On 2/9/24 23:45, Jonathon Jongsma wrote:
On 2/7/24 7:39 AM, Boris Fiuczynski wrote:
Implement the API functions in the node device driver by using
mdevctl modify with the options defined and live.
Instead of increasing the minimum mdevctl version to 1.3.0 in spec file
to ensure support exists
On 2/9/24 23:13, Jonathon Jongsma wrote:
On 2/7/24 7:39 AM, Boris Fiuczynski wrote:
This public API is implemented for almost all other objects that have
a concept of persistent definition and activatability. Node devices
(mdevs) that can be defined and inactive, it will be useful to be
able to
On 2/13/24 14:43, Boris Fiuczynski wrote:
Tangentially related:
Almost all of the other API objects can update their persistent
definition from an XML file by calling the $(OBJECT)DefineXML command
to replace the existing definition. The Node device API does not yet
support doing that, maybe
On 2/14/24 19:00, Jonathon Jongsma wrote:
On 2/14/24 6:59 AM, Boris Fiuczynski wrote:
On 2/13/24 14:43, Boris Fiuczynski wrote:
Tangentially related:
Almost all of the other API objects can update their persistent
definition from an XML file by calling the $(OBJECT)DefineXML
command to
On 2/14/24 20:07, Jonathon Jongsma wrote:
On 2/13/24 3:04 AM, Boris Fiuczynski wrote:
On 2/9/24 23:45, Jonathon Jongsma wrote:
On 2/7/24 7:39 AM, Boris Fiuczynski wrote:
Implement the API functions in the node device driver by using
mdevctl modify with the options defined and live.
Instead of
ts/qemuxmlconfdata/s390-usb-address.s390x-latest.xml
@@ -17,11 +17,7 @@
destroy
/usr/bin/qemu-system-s390x
-
-
-
-
-
+
Reviewed-by: Boris Fiuczynski
--
Mit freundlichen Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Resear
Create a new structure holding type and attributes as these are
modifable in a persisted mdev configuration and run out of sync with the
active mdev configuration.
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c | 18 +++
src/conf/node_device_conf.h | 4
devices as well.
Signed-off-by: Boris Fiuczynski
---
include/libvirt/libvirt-nodedev.h | 18 +
src/access/viraccessperm.c| 1 +
src/access/viraccessperm.h| 6 +
src/conf/virnodedeviceobj.c | 42 +
src/conf/virnodedeviceobj.h
Allow to dump the XML of the persisted mdev when the mdev has been
started instead of the current state only.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
docs/manpages/virsh.rst | 7 +--
tools/virsh-nodedev.c | 10 +-
2 files changed, 14 insertions(+), 3
support check and an unsupported message if not available
* removed persisted precheck in virsh
* renamed persisted and persist into persistent
* addressed all other review comments made on v1
* added NEWS
Boris Fiuczynski (12):
virmdev: prepare type and attributes for dual state
node_device
Allow to modify a node device by using virNodeDeviceDefineXML() to align
its behavior with other drivers define methods.
Signed-off-by: Boris Fiuczynski
---
NEWS.rst | 5 +++
src/libvirt-nodedev.c| 4 +-
src/node_device/node_device_driver.c | 64
Commit 26136e3 allowed to use option all with option tree but did not
update the manpage.
Signed-off-by: Boris Fiuczynski
---
docs/manpages/virsh.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index 248807d0e9
virBufferEscapeString already contains the null check.
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index a8554102fc..febc58afd1 100644
--- a
Refactor attribute handling code into methods for easier reuse.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
src/conf/node_device_conf.c | 27 ---
src/node_device/node_device_driver.c | 104 ---
2 files changed, 80 insertions(+), 51
Now that we can filter persisted and transient node devices in
virConnectListAllNodeDevices(), add these switches also to the
virsh nodedev-list command.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
docs/manpages/virsh.rst | 8 ++--
tools/virsh-nodedev.c | 24
. mdevctl supports with callout scripts to do an
attribute retrieval of started mdevs which is already implemented in
libvirt.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
include/libvirt/libvirt-nodedev.h | 11
src/conf/node_device_conf.c
Allow to filter node devices based on their persisted or transient states.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
include/libvirt/libvirt-nodedev.h | 2 ++
src/conf/node_device_conf.h | 7 ++-
src/conf/virnodedeviceobj.c | 8
3 files changed
Add ability to update node devices.
Signed-off-by: Boris Fiuczynski
---
docs/drvnodedev.rst | 4 +-
docs/manpages/virsh.rst | 19
tools/virsh-nodedev.c | 98 +
3 files changed, 120 insertions(+), 1 deletion(-)
diff --git a/docs
: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
NEWS.rst | 7 +
libvirt.spec.in | 1 +
src/node_device/node_device_driver.c | 224 +-
src/node_device/node_device_driver.h | 11 +
src
since v1:
* replaced spec file requirement for v1.3.0 of mdevctl by a dynamic
support check and an unsupported message if not available
* removed persisted precheck in virsh
* renamed persisted and persist into persistent
* addressed all other review comments made on v1
* added NEWS
Boris
Create a new structure holding type and attributes as these are
modifiable in a persistent mdev configuration and run out of sync with
the active mdev configuration.
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c | 18 +++
src/conf/node_device_conf.h | 4
virBufferEscapeString already contains the null check.
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index a8554102fc..febc58afd1 100644
--- a
Commit 26136e3 allowed to use option all with option tree but did not
update the manpage.
Signed-off-by: Boris Fiuczynski
---
docs/manpages/virsh.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index 248807d0e9
Allow to dump the XML of the persistent mdev when the mdev has been
started instead of the current state only.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
docs/manpages/virsh.rst | 7 +--
tools/virsh-nodedev.c | 10 +-
2 files changed, 14 insertions(+), 3
Refactor attribute handling code into methods for easier reuse.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
src/conf/node_device_conf.c | 27 ---
src/node_device/node_device_driver.c | 104 ---
2 files changed, 80 insertions(+), 51
Allow to filter node devices based on their persistent or transient
states.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
include/libvirt/libvirt-nodedev.h | 2 ++
src/conf/node_device_conf.h | 7 ++-
src/conf/virnodedeviceobj.c | 8
3 files changed
Allow to modify a node device by using virNodeDeviceDefineXML() to align
its behavior with other drivers define methods.
Signed-off-by: Boris Fiuczynski
---
NEWS.rst | 5 +++
src/libvirt-nodedev.c| 4 +-
src/node_device/node_device_driver.c | 62
Now that we can filter persistent and transient node devices in
virConnectListAllNodeDevices(), add these switches also to the
virsh nodedev-list command.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
docs/manpages/virsh.rst | 8 ++--
tools/virsh-nodedev.c | 24
: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
NEWS.rst | 7 +
libvirt.spec.in | 1 +
src/node_device/node_device_driver.c | 224 +-
src/node_device/node_device_driver.h | 11 +
src
. mdevctl supports with callout scripts to do an
attribute retrieval of started mdevs which is already implemented in
libvirt.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
include/libvirt/libvirt-nodedev.h | 11
src/conf/node_device_conf.c
devices as well.
Signed-off-by: Boris Fiuczynski
---
include/libvirt/libvirt-nodedev.h | 18 +
src/access/viraccessperm.c| 1 +
src/access/viraccessperm.h| 6 +
src/conf/virnodedeviceobj.c | 42 +
src/conf/virnodedeviceobj.h
Add ability to update node devices.
Signed-off-by: Boris Fiuczynski
---
docs/drvnodedev.rst | 4 +-
docs/manpages/virsh.rst | 19
tools/virsh-nodedev.c | 98 +
3 files changed, 120 insertions(+), 1 deletion(-)
diff --git a/docs
On 2/20/24 23:23, Jonathon Jongsma wrote:
Minor nit: the commit subject still says "persisted" instead of
"persistent"
Sorry I missed these. I have sent a v4 fixing these.
On 2/16/24 8:52 AM, Boris Fiuczynski wrote:
Allow to filter node devices based on their persisted
On 2/21/24 18:27, Jonathon Jongsma wrote:
On 2/16/24 8:52 AM, Boris Fiuczynski wrote:
Allow to modify a node device by using virNodeDeviceDefineXML() to align
its behavior with other drivers define methods.
Signed-off-by: Boris Fiuczynski
---
NEWS.rst | 5
Now that we can filter persistent and transient node devices in
virConnectListAllNodeDevices(), add these switches also to the
virsh nodedev-list command.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
docs/manpages/virsh.rst | 8 ++--
tools/virsh-nodedev.c | 24
devices as well.
Signed-off-by: Boris Fiuczynski
---
include/libvirt/libvirt-nodedev.h | 18 +
src/access/viraccessperm.c| 1 +
src/access/viraccessperm.h| 6 +
src/conf/virnodedeviceobj.c | 42 +
src/conf/virnodedeviceobj.h
Commit 26136e3 allowed to use option all with option tree but did not
update the manpage.
Signed-off-by: Boris Fiuczynski
---
docs/manpages/virsh.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index 248807d0e9
Allow to modify a node device by using virNodeDeviceDefineXML() to align
its behavior with other drivers define methods.
Signed-off-by: Boris Fiuczynski
---
NEWS.rst | 5 +++
src/libvirt-nodedev.c| 4 ++-
src/node_device/node_device_driver.c | 47
. mdevctl supports with callout scripts to do an
attribute retrieval of started mdevs which is already implemented in
libvirt.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
include/libvirt/libvirt-nodedev.h | 11
src/conf/node_device_conf.c
: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
NEWS.rst | 7 +
libvirt.spec.in | 1 +
src/node_device/node_device_driver.c | 224 +-
src/node_device/node_device_driver.h | 11 +
src
available
* renamed persisted and persist into persistent
* removed persistent precheck in virsh
* addressed all other review comments made on v1
* added NEWS
Boris Fiuczynski (12):
virmdev: prepare type and attributes for dual state
node_device: refactor mdev attributes handling
node_device
Add ability to update node devices.
Signed-off-by: Boris Fiuczynski
---
docs/drvnodedev.rst | 4 +-
docs/manpages/virsh.rst | 19
tools/virsh-nodedev.c | 98 +
3 files changed, 120 insertions(+), 1 deletion(-)
diff --git a/docs
Allow to dump the XML of the persistent mdev when the mdev has been
started instead of the current state only.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
docs/manpages/virsh.rst | 7 +--
tools/virsh-nodedev.c | 10 +-
2 files changed, 14 insertions(+), 3
Refactor attribute handling code into methods for easier reuse.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
src/conf/node_device_conf.c | 27 ---
src/node_device/node_device_driver.c | 104 ---
2 files changed, 80 insertions(+), 51
virBufferEscapeString already contains the null check.
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index a8554102fc..febc58afd1 100644
--- a
Allow to filter node devices based on their persistent or transient
states.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Jonathon Jongsma
---
include/libvirt/libvirt-nodedev.h | 2 ++
src/conf/node_device_conf.h | 7 ++-
src/conf/virnodedeviceobj.c | 8
3 files changed
Create a new structure holding type and attributes as these are
modifiable in a persistent mdev configuration and run out of sync with
the active mdev configuration.
Signed-off-by: Boris Fiuczynski
---
src/conf/node_device_conf.c | 18 +++
src/conf/node_device_conf.h | 4
eries
before the freeze. Thanks.
On 2/22/24 7:01 AM, Boris Fiuczynski wrote:
The series adds a dual state to the mdev node devices as these objects
can be active and defined at the same time. These two states can
become different. To be able to also introspect the persistent and
transient nod
Michal,
thanks for fixing this.
Reviewed-by: Boris Fiuczynski
On 2/26/24 13:22, Michal Privoznik wrote:
There are two memleaks inside of nodedevmdevctltest:
1) In the testCommandDryRunCallback() - when appending lines to
stdinbuf the pointer is overwritten without freeing the old
On 2/26/24 15:21, Ján Tomko wrote:
On a Thursday in 2024, Boris Fiuczynski wrote:
A public API method which allows to update or modify objects is
implemented for almost all other objects that have a concept of
persistent definition and activatability. Currently node devices of type
mdev can be
Adding 'save' ACL to REMOTE_PROC_NODE_DEVICE_DEFINE_XML to make
REMOTE_PROC_NODE_DEVICE_UPDATE ACLs meaningful.
Fixes: 69f9e7dbc24657e85761f03574779540d0f18315
Signed-off-by: Boris Fiuczynski
---
src/remote/remote_protocol.x | 1 +
1 file changed, 1 insertion(+)
diff --git a/
When a mdev device is destroyed or stopped the udev remove event
handling needs to reset the active config data of the node object
representing a persisted mdev.
Signed-off-by: Boris Fiuczynski
---
src/node_device/node_device_driver.c | 22 ++
src/node_device
When an udev add event occurs the mdev active config data requires an
update via mdevctl as the udev does not contain all config data.
This update needs to occur immediate and to be finished before the
libvirt CREATE event is issued to keep the API usage reliable.
Signed-off-by: Boris Fiuczynski
invalid data. Instead copying the defined config data will
store valid data into the newly added node object.
Signed-off-by: Boris Fiuczynski
---
src/node_device/node_device_udev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/node_device/node_device_udev.c
b/src
These patches fix copying the configuration data when starting a
persistent mdev and improve the reliability of configuration data
being up to date when mdev configuration data is changed.
Boris Fiuczynski (3):
nodedev: fix mdev add udev event data handling
nodedev: immediate update of active
onfig->nattributes = 0;
+}
+
+
A good portion of this function is duplicating code that exists in
virNodeDevCapsDefFree(). Let's just factor that code out into a
virMediatedDeviceConfigClear() function and then use it from both
locations.
OK, will do.
--
Mit freundlichen Grüßen/Ki
On 4/9/24 17:09, Michal Prívozník wrote:
On 4/9/24 16:56, Cole Robinson wrote:
The virt-manager test suite is busted with libvirt 10.1.0+ after
this commit:
commit e67bca23e4fe38a3491749f724b9edf743d0e916
Author: Boris Fiuczynski
Date: Thu Feb 22 14:02:01 2024 +0100
nodedev: add an
Reviewed-by: Boris Fiuczynski
On 4/9/24 16:56, Cole Robinson wrote:
$ virsh --connect test:///default nodedev-list
error: Failed to list node devices
error: unsupported flags (0x8000) in function testConnectListAllNodeDevices
The test driver handles the nodedev state flags, we just need
Reviewed-by: Boris Fiuczynski
On 4/9/24 16:56, Cole Robinson wrote:
Signed-off-by: Cole Robinson
---
src/test/test_driver.c | 16
1 file changed, 16 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 852a084bce..f9bd6f4e67 100644
--- a/src
Reviewed-by: Boris Fiuczynski
On 4/9/24 16:56, Cole Robinson wrote:
Signed-off-by: Cole Robinson
---
src/test/test_driver.c | 16
1 file changed, 16 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index f9bd6f4e67..41828f86b6 100644
--- a/src
requirement to mock dumping transient mdevs.
virNodeDeviceObjSetSkipUpdateCaps(obj, true);
virNodeDeviceObjEndAPI(&obj);
}
--
Mit freundlichen Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wol
attr);
- }
-}
}
if (!(actual = virNodeDeviceDefFormat(dev, flags)))
--
Mit freundlichen Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: Davi
Reviewed-by: Boris Fiuczynski
On 4/3/24 16:03, Marc Hartmayer wrote:
Remove the timeout when the udevEventData is disposed, analogous to priv->watch.
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/node_dev
Reviewed-by: Boris Fiuczynski
On 4/3/24 16:03, Marc Hartmayer wrote:
It is done a little differently everywhere in libvirt, but most common is to
test for != -1.
Signed-off-by: Marc Hartmayer
---
src/node_device/node_device_udev.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions
Reviewed-by: Boris Fiuczynski
On 4/3/24 16:03, Marc Hartmayer wrote:
Commit a99d876a0f58 ("node_device: Use automatic mutex management") replaced the
locking mechanism and accidentally removed the comment with the reason why the
lock is taken. Restore this comment and add a new com
1 - 100 of 226 matches
Mail list logo
