New features tests fails

Hi, I'm trying to implement the libvirt part of a new feature that has landed in QEMU staging [1]. The current draft of this implementations is the following [2]. It compiles on top of master. But when I want to run the tests suites, I hit an issue I don't managed to find the problem. It run

Re: New features tests fails

Hi Peter, > These test cases parse an XML and format it back. > > You've got a bug in the code formatting the socket into the XML: > > if (def->kvm_features->socket == NULL) { > virBufferAsprintf(&childBuf, " socket='%s'/>\n", >

[PATCH] qemu: Add support for RAPL MSRs feature

/0418f90809aea5b375c859e744c8e8610e9be446 Signed-off-by: Anthony Harivel --- docs/formatdomain.rst | 2 ++ src/conf/domain_conf.c| 30 +++ src/conf/domain_conf.h| 2 ++ src/conf/schemas/domaincommon.rng

[PATCH v2 0/1] Add support for RAPL MSRs feature in QEMU

nything to honour the _OFF state, because it is not necessary to explicitly disable it. That's about it. Regards, Anthony Anthony Harivel (1): qemu: Add support for RAPL MSRs feature docs/formatdomain.rst | 2 ++ src/conf/domain_conf.c

[PATCH v2 1/1] qemu: Add support for RAPL MSRs feature

/0418f90809aea5b375c859e744c8e8610e9be446 Signed-off-by: Anthony Harivel --- docs/formatdomain.rst | 2 ++ src/conf/domain_conf.c | 18 ++ src/conf/domain_conf.h | 2 ++ src/conf/schemas/domaincommon.rng

Re: [PATCH v2 1/1] qemu: Add support for RAPL MSRs feature

Peter Krempa, Sep 02, 2024 at 15:09: > On Thu, Aug 22, 2024 at 17:59:47 +0200, Anthony Harivel wrote: > > Add the support in libvirt to activate the RAPL feature in QEMU. > > > > This feature is activated with -accel kvm,rapl=true,path=/path/sock.sock > > in QE

Re: [PATCH v2 1/1] qemu: Add support for RAPL MSRs feature

Daniel P. Berrangé, Sep 03, 2024 at 12:08: > On Mon, Sep 02, 2024 at 03:09:42PM +0200, Peter Krempa wrote: > > On Thu, Aug 22, 2024 at 17:59:47 +0200, Anthony Harivel wrote: > > > Add the support in libvirt to activate the RAPL feature in QEMU. > > I suppose that the &

Re: [PATCH v2 1/1] qemu: Add support for RAPL MSRs feature

Daniel P. Berrangé, Sep 03, 2024 at 14:24: > On Tue, Sep 03, 2024 at 02:16:58PM +0200, Peter Krempa wrote: > > On Tue, Sep 03, 2024 at 13:29:28 +0200, Anthony Harivel wrote: > > > Daniel P. Berrangé, Sep 03, 2024 at 12:08: > > > > On Mon, Sep 02, 2024 at 03:09:

Re: [PATCH v2 1/1] qemu: Add support for RAPL MSRs feature

Hi, Anthony Harivel, Sep 03, 2024 at 14:41: > Daniel P. Berrangé, Sep 03, 2024 at 14:24: > > On Tue, Sep 03, 2024 at 02:16:58PM +0200, Peter Krempa wrote: > > > On Tue, Sep 03, 2024 at 13:29:28 +0200, Anthony Harivel wrote: > > > > Daniel P. Berrangé, Sep 03, 2

Re: [PATCH v2 1/1] qemu: Add support for RAPL MSRs feature

Hi, Anthony Harivel, Sep 05, 2024 at 13:01: > > Hi, > > Anthony Harivel, Sep 03, 2024 at 14:41: > > Daniel P. Berrangé, Sep 03, 2024 at 14:24: > > > On Tue, Sep 03, 2024 at 02:16:58PM +0200, Peter Krempa wrote: > > > > On Tue, Sep 03, 2024 a

Re: [PATCH v2 1/1] qemu: Add support for RAPL MSRs feature

Hi, Peter Krempa, Oct 03, 2024 at 17:33: >> Anthony Harivel, Sep 03, 2024 at 14:41: > [...] > >> If I may resume the conversation: >> >> 1) The helper daemon is primarily needed for security reasons to prevent >>potential leaks of confidential informati

Re: [PATCH v2 1/1] qemu: Add support for RAPL MSRs feature

Peter Krempa, Oct 07, 2024 at 15:42: > On Mon, Oct 07, 2024 at 12:03:17 +0200, Anthony Harivel wrote: >> Hi, >> >> Peter Krempa, Oct 03, 2024 at 17:33: >> >> Anthony Harivel, Sep 03, 2024 at 14:41: >> > [...] >> > >> >> If I ma

[PATCH v3 1/1] qemu: Add support for RAPL MSRs feature

/0418f90809aea5b375c859e744c8e8610e9be446 Signed-off-by: Anthony Harivel --- docs/formatdomain.rst | 2 ++ src/conf/domain_conf.c | 18 ++ src/conf/domain_conf.h | 2 ++ src/conf/schemas/domaincommon.rng

[PATCH v3 0/1] add RAPL feature in libvirt

experience. Thank you for your consideration. Anthony Anthony Harivel (1): qemu: Add support for RAPL MSRs feature docs/formatdomain.rst | 2 ++ src/conf/domain_conf.c | 18 ++ src/conf/domain_conf.h

[PATCH v4 0/1] add RAPL feature in libvirt

naged'). Thanks Anthony Anthony Harivel (1): qemu: Add support for RAPL MSRs feature docs/formatdomain.rst | 15 +++ src/conf/domain_conf.c | 18 ++ src/conf/domain_conf.h | 2 ++ src/co

[PATCH v4 1/1] qemu: Add support for RAPL MSRs feature

/0418f90809aea5b375c859e744c8e8610e9be446 Signed-off-by: Anthony Harivel --- docs/formatdomain.rst | 15 +++ src/conf/domain_conf.c | 18 ++ src/conf/domain_conf.h | 2 ++ src/conf/schemas

Re: [PATCH v3 1/1] qemu: Add support for RAPL MSRs feature

Hi Peter, Peter Krempa, Feb 12, 2025 at 17:17: > On Wed, Feb 12, 2025 at 16:36:48 +0100, Anthony Harivel wrote: >> Add the support in libvirt to activate the RAPL feature in QEMU. >> >> This feature is activated with -accel kvm,rapl=true,path=/path/sock.sock >> in

Re: [PATCH v3 1/1] qemu: Add support for RAPL MSRs feature

Hi Peter, >> @@ -7062,6 +7065,15 @@ qemuBuildAccelCommandLine(virCommand *cmd, >> def->kvm_features->features[VIR_DOMAIN_KVM_DIRTY_RING] == >> VIR_TRISTATE_SWITCH_ON) { >> virBufferAsprintf(&buf, ",dirty-ring-size=%d", >> def->kvm_features->dirty_ring_size); >>