[PATCH v3 1/2] Fix virtio console port assignment on vioserial bus

exists with id 0 error. Therefore, the data needs to be passed back into info when allowZero is true Fixes: 16db8d2ec540 ("Add functions to track virtio-serial addresses") Reviewed-by: Boris Fiuczynski Signed-off-by: Aaron M. Brown --- src/conf/domain_addr.c | 6 ++ 1 file changed, 6

[PATCH v3 0/2] Fix virtio console port assignment issue

applying this patch, one can add multiple console ports under a single vioserial bus. Here is a link to CI results for this series: https://gitlab.com/aaronbmalik/libvirt/-/pipelines/1831901334 Aaron M. Brown (2): Fix virtio console port assignment on vioserial bus Updates console port

[PATCH v3 2/2] Updates console port reservation comment and changes the allowZero variable to allowPortZero for clarity

Reviewed-by: Boris Fiuczynski Signed-off-by: Aaron M. Brown --- src/conf/domain_addr.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index bc2b0f50e8..86f5cfc337 100644 --- a/src/conf/domain_addr.c

[PATCH v4 0/2] Fix virtio console port assignment issue

on a single vioserial bus. After applying this patch, one can add multiple console ports under a single vioserial bus. Here is a link to CI results for this series: https://gitlab.com/aaronbmalik/libvirt/-/pipelines/1832324065 Aaron M. Brown (2): virDomainVirtioSerialAddrAssign: Fix virtio

[PATCH v4 2/2] domain_addr.c: Update console port reservation comment and allowZero variable for clarity

Reviewed-by: Boris Fiuczynski Signed-off-by: Aaron M. Brown --- src/conf/domain_addr.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index bc2b0f50e8..86f5cfc337 100644 --- a/src/conf/domain_addr.c

[PATCH v4 1/2] virDomainVirtioSerialAddrAssign: Fix virtio console port assignment on vioserial bus

exists with id 0 error. Therefore, the data needs to be passed back into info when allowZero is true Fixes: 16db8d2ec540 ("Add functions to track virtio-serial addresses") Reviewed-by: Boris Fiuczynski Signed-off-by: Aaron M. Brown --- src/conf/domain_addr.c | 6 ++ 1 file changed, 6

[PATCH v5 1/3] qemuxmlconftest: Add console-virtio-vioserial tests

Signed-off-by: Aaron M. Brown --- ...onsole-virtio-vioserial.x86_64-latest.args | 44 + ...console-virtio-vioserial.x86_64-latest.xml | 63 +++ .../console-virtio-vioserial.xml | 48 ++ tests/qemuxmlconftest.c | 1 + 4

[PATCH v5 0/3] Fix virtio console port assignment issue

is a link to CI results for this series: https://gitlab.com/aaronbmalik/libvirt/-/pipelines/1855918840 Aaron M. Brown (3): qemuxmlconftest: Add console-virtio-vioserial tests virDomainVirtioSerialAddrAssign: Fix virtio console port auto assignment on vioserial bus domain_addr.c: upd

[PATCH v5 2/3] virDomainVirtioSerialAddrAssign: Fix virtio console port auto assignment on vioserial bus

exists at id 0` Therefore, the data needs to be passed back into info when allowZero is true Fixes: 16db8d2ec540 ("Add functions to track virtio-serial addresses") Reviewed-by: Boris Fiuczynski Signed-off-by: Aaron M. Brown --- src/conf/domain_addr.c | 7 +++ 1 file changed, 7

[PATCH v5 3/3] domain_addr.c: update console port reservation comment and allowZero var to allowPortZero for clarity

Reviewed-by: Boris Fiuczynski Signed-off-by: Aaron M. Brown --- src/conf/domain_addr.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index 76e11c0dde..1d417ac36d 100644 --- a/src/conf/domain_addr.c

[PATCH v6 0/3] Fix virtio console port assignment issue

ter applying this patch, one can add multiple console ports under a single virtio-serial bus. Here is a link to CI results for this series: https://gitlab.com/aaronbmalik/libvirt/-/pipelines/1942021076 Aaron M. Brown (3): tests: Add console-virtio-vioserial tests domain_addr: Fix virtio cons

[PATCH v6 3/3] domain_addr: update virtconsole port reservation comment and allowZero var

Rename variable "allowZero" to "allowPortZero" for clarity and update the virtconsole port reservation comment, as port 0 is reserved for the first virtconsole unless specified. Signed-off-by: Aaron M. Brown --- src/conf/domain_addr.c | 28 ++--

[PATCH v6 1/3] tests: Add console-virtio-vioserial tests

Add test coverage for multiple virtio consoles on a virtio-serial controller. This test makes sure that multiple virtconsoles get auto-assigned appropriate port numbers on a virtio-serial-bus Signed-off-by: Aaron M. Brown --- ...rial-autoassign-address.x86_64-latest.args | 44

[PATCH v6 2/3] domain_addr: Fix virtio console port autoassign on virtio-serial bus

t;Add functions to track virtio-serial addresses") Signed-off-by: Aaron M. Brown --- src/conf/domain_addr.c| 30 --- ...rial-autoassign-address.x86_64-latest.args | 4 +-- ...erial-autoassign-address.x86_64-latest.xml | 4 +-- 3 files changed, 30 insert

[PATCH v1] virBitmapNextClearBit: Correct virBitmapNextClearBit function header comment

(virBitmapNextClearBIt(bitmap, -1) != 0) return -1 Because this is a zero set, this case would fail if the header statement was true as is. Signed-off-by: Aaron M. Brown --- src/util/virbitmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virbitmap.c b/src