Re: [PATCH v5 0/5] Disable Deprecated Features by Default on s390 CPU Models

On 6/29/25 23:19, Collin Walling wrote: Pinging again, since it's been about three weeks since the last bump. Unless these patches are satisfactory, please inform on what needs to change. -- Regards, Collin

[PATCH] qemu: driver: Reformat function headers for block job APIs

From: Peter Krempa Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 7c203e32fe..a0f770b053 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_

Re: [PATCH] bhyve: don't reset domain autostart flag on destroy

On 7/20/25 19:04, Roman Bogorodskiy wrote: > Currently, virBhyveProcessStop() uses the virDomainDeleteConfig() > helper to clean up domain status. It passes BHYVE_STATE_DIR as > a configuration dir and NULL as autostart dir, so the helper does its > job, even though it has a different purpose. Howe

Re: [PATCH] bhyve: implement timeout for bhyveload

On 7/19/25 13:30, Roman Bogorodskiy wrote: > The bhyveload(8) command does not have a native non-interactive mode. > It means that in case of errors, e.g. invalid boot media, it > just drops into a loader prompt and waits for user input. This behaviour > makes it tricky for users to understand what

[PATCH 17/19] virSecuritySELinuxRestoreInputLabel: Return values directly

From: Peter Krempa Skip the use of temporary variable. Signed-off-by: Peter Krempa --- src/security/security_selinux.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index b390e0c95f..b16ab14dfe 100644

[PATCH 18/19] virSecuritySELinuxGenImageLabel: Refactor cleanup

From: Peter Krempa Automatically free temporary variables in order to remove 'cleanup' section. Signed-off-by: Peter Krempa --- src/security/security_selinux.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/src/security/security_selinux.c b/src/secur

[PATCH 14/19] virSecuritySELinuxReserveLabel: Refactor cleanup

From: Peter Krempa Automatically free temporary variables in order to remove 'cleanup' section. Signed-off-by: Peter Krempa --- src/security/security_selinux.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/src/security/security_selinux.c b/src/securi

[PATCH 12/19] virSecuritySELinuxContextAddRange: Refactor cleanup of 'context_t'

From: Peter Krempa Use the new autoptr helper to free the temporary variables and refactor cleanup. Signed-off-by: Peter Krempa --- src/security/security_selinux.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/src/security/security_selinux.c b/src/se

[PATCH 15/19] virSecuritySELinuxGetProcessLabel: Automatically free 'ctx' temp variable

From: Peter Krempa Signed-off-by: Peter Krempa --- src/security/security_selinux.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 3004320380..54f12d044f 100644 --- a/src/security/security_selinux.c

[PATCH 16/19] virSecuritySELinuxSetFilecon: Automatically free 'econ' temp variable

From: Peter Krempa Signed-off-by: Peter Krempa --- src/security/security_selinux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 54f12d044f..b390e0c95f 100644 --- a/src/security/security_selinux.c ++

[PATCH 19/19] virSecuritySELinuxGetSecurityMountOptions: refactor printing

From: Peter Krempa Fix linebreaks and remove the use of ternary operator. Signed-off-by: Peter Krempa --- src/security/security_selinux.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 9d14e33

[PATCH 00/19] security_selinux: Refactor temporary variable cleanup

Some cleanups resutling from analyzing some selinux code. Peter Krempa (19): security/security_driver.c/h: Fix function header formatting virSecuritySELinuxTransactionRun: Refactor cleanup virSecuritySELinuxMCSFind: Refactor variable clearing virSecuritySELinuxRestoreFileLabel: Refactor cl

[PATCH 01/19] security/security_driver.c/h: Fix function header formatting

From: Peter Krempa Fix the misaligned arguments by switching over to modern style. Signed-off-by: Peter Krempa --- src/security/security_driver.c | 5 +++-- src/security/security_driver.h | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/security/security_driver.c b

[PATCH 03/19] virSecuritySELinuxMCSFind: Refactor variable clearing

From: Peter Krempa Use automatic freeing for 'mcs' and adjust the code. Signed-off-by: Peter Krempa --- src/security/security_selinux.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 0326073810

[PATCH 05/19] virSecuritySELinux(Set|Restore)TPMFileLabel: Automatically free 'cancel_path'

From: Peter Krempa Signed-off-by: Peter Krempa --- src/security/security_selinux.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 75ad5803a9..f042da4a13 100644 --- a/src/security/security_selinux.

[PATCH 02/19] virSecuritySELinuxTransactionRun: Refactor cleanup

From: Peter Krempa Automatically free 'paths' and remove temporary variable. Signed-off-by: Peter Krempa --- src/security/security_selinux.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index

[PATCH 04/19] virSecuritySELinuxRestoreFileLabel: Refactor cleanup

From: Peter Krempa Automatically free 'fcon' and 'newpath' and remove the 'cleanup' label and 'ret' variable. Signed-off-by: Peter Krempa --- src/security/security_selinux.c | 30 +++--- 1 file changed, 11 insertions(+), 19 deletions(-) diff --git a/src/security/securi

[PATCH 07/19] virSecuritySELinux(Set|Restore)HostdevCapsLabel: Refactor cleanup

From: Peter Krempa Declare 'path' only in blocks where it's used and autofree it. Signed-off-by: Peter Krempa --- src/security/security_selinux.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c ind

[PATCH 06/19] virSecuritySELinuxRestoreFileLabels: Refactor variable freeing

From: Peter Krempa Declare 'filename' inside the loop that is using it and use automatic freeing. Signed-off-by: Peter Krempa --- src/security/security_selinux.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/security/security_selinux.c b/src/security/security_selin

[PATCH 08/19] virSecuritySELinux(Set|Restore)ChardevLabel: Refactor cleanup

From: Peter Krempa Declare 'in'/'out' only in the bocks which use them and automatically free them. Since cleanup section was removed we don't need a 'ret' variable any more. Signed-off-by: Peter Krempa --- src/security/security_selinux.c | 87 +++-- 1 file changed,

[PATCH 09/19] virSecuritySELinuxSet(Daemon)SocketLabel: Refactor cleanup

From: Peter Krempa Automatically free temporary variables and change 'cleanup' label to 'error'. Signed-off-by: Peter Krempa --- src/security/security_selinux.c | 37 +++-- 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/src/security/security_selinux

[PATCH 10/19] virSecuritySELinuxSetTapFDLabel: Refactor cleanup

From: Peter Krempa Automatically free temporary variables and remove the need for 'cleanup' section. Signed-off-by: Peter Krempa --- src/security/security_selinux.c | 35 ++--- 1 file changed, 15 insertions(+), 20 deletions(-) diff --git a/src/security/security_sel

[PATCH 11/19] security_selinux: Declare internal autoptr cleanup helper for 'context_t'

From: Peter Krempa The selinux headers have a 'typedef context_s_t *context_t;' definition in the header so we declare autoptr cleanup function for 'context_s_t' and use it instead of 'context_t' definitions. Signed-off-by: Peter Krempa --- src/security/security_selinux.c | 3 +++ 1 file chang

[PATCH 13/19] virSecuritySELinuxGenNewContext: Refactor cleanup

From: Peter Krempa Use automatic freeing of temporary variables and remove cleanup section. Signed-off-by: Peter Krempa --- src/security/security_selinux.c | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/src/security/security_selinux.c b/sr