[PATCH v2 1/3] ch: Add config file support

2025-05-27 Thread Stefan Kober
Similar to the QEMU driver, the ch driver receives support for configuration files that allows doing certain configuration on the virtchd daemon. The initial use case will be setting the verbosity of the cloud hypervisor instances started by virtchd, but the implementation allows for adding furthe

[PATCH 8/9] qemuProcessStartValidateGraphics: Remove redundant checks for RDP protocol features

2025-05-27 Thread Peter Krempa via Devel
From: Peter Krempa Both the 'replaceUser' and 'multiUser' field are already validated in qemuValidateDomainDeviceDefRDPGraphics. Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_proces

[PATCH 1/2] qemu: Fix crash when resuming failed post-copy migration

2025-05-27 Thread Jiri Denemark via Devel
From: Jiri Denemark Since commit 28a06215280 (released in 11.2.0) resuming a failed post-copy migration calls qemuProcessIncomingDefNew with fd == NULL rather than -1. The function does not expect to be called with NULL file descriptor and tries to dereference it causing virtqemud on the destinat

[PATCH 2/2] NEWS: Fix virtqemud crash when resuming failed post-copy migration

2025-05-27 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- NEWS.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 636fcbd573..a880524ca2 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -42,6 +42,13 @@ v11.4.0 (unreleased) The only workaround is to avoid the broke

[PATCH 0/2] qemu: Fix crash when resuming failed post-copy migration

2025-05-27 Thread Jiri Denemark via Devel
Jiri Denemark (2): qemu: Fix crash when resuming failed post-copy migration NEWS: Fix virtqemud crash when resuming failed post-copy migration NEWS.rst | 7 +++ src/qemu/qemu_migration.c | 3 ++- 2 files changed, 9 insertions(+), 1 deletion(-) -- 2.49.0

[PATCH 9/9] qemuProcessStartValidateGraphics: Move RDP validation logic to qemu_validate.c

2025-05-27 Thread Peter Krempa via Devel
From: Peter Krempa Move the rest of the RDP graphics validation code to qemuValidateDomainDeviceDefRDPGraphics together with the rest of the validation. Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 54 src/qemu/qemu_validate.c | 20 +++

Re: [PATCH 2/2] NEWS: Fix virtqemud crash when resuming failed post-copy migration

2025-05-27 Thread Peter Krempa via Devel
On Tue, May 27, 2025 at 12:28:21 +0200, Jiri Denemark via Devel wrote: > From: Jiri Denemark > > Signed-off-by: Jiri Denemark > --- > NEWS.rst | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index 636fcbd573..a880524ca2 100644 > --- a/NEWS.rst > +++ b/NEWS

Re: [PATCH 1/2] qemu: Fix crash when resuming failed post-copy migration

2025-05-27 Thread Peter Krempa via Devel
On Tue, May 27, 2025 at 12:28:20 +0200, Jiri Denemark via Devel wrote: > From: Jiri Denemark > > Since commit 28a06215280 (released in 11.2.0) resuming a failed > post-copy migration calls qemuProcessIncomingDefNew with fd == NULL > rather than -1. The function does not expect to be called with N

Re: [PATCH] NEWS: Make sure releases are separated by two blank lines

2025-05-27 Thread Peter Krempa via Devel
On Tue, May 27, 2025 at 12:59:01 +0200, Jiri Denemark via Devel wrote: > From: Jiri Denemark > > Signed-off-by: Jiri Denemark > --- > NEWS.rst | 2 ++ > 1 file changed, 2 insertions(+) Trivial. Reviewed-by: Peter Krempa

[PATCH] NEWS: Make sure releases are separated by two blank lines

2025-05-27 Thread Jiri Denemark via Devel
From: Jiri Denemark Signed-off-by: Jiri Denemark --- NEWS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index a880524ca2..0ba2d20191 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -533,6 +533,7 @@ v10.9.0 (2024-11-01) element is added for that CPU model listin

[PATCH] passt: Define backend hostname and fqdn

2025-05-27 Thread Enrique Llorente via Devel
This commit introduces a feature enhancement for configuring hostnames in virtual machines (VMs) using DHCP. It adds new options to the "passt" tool to set the hostname and fully qualified domain name (FQDN) for VMs. These map to DHCP option 12 for the hostname and options 81 (IPv4) and 39 (IPv6) f

[PATCH 7/9] qemu: Move checks for number of listening sockets of graphics to validation code

2025-05-27 Thread Peter Krempa via Devel
From: Peter Krempa Move the checks from 'qemuProcessStartValidateGraphics' to the correspodning graphics validation functions in qemu_validate.c: - qemuValidateDomainDeviceDefSPICEGraphics - qemuValidateDomainDeviceDefVNCGraphics - qemuValidateDomainDeviceDefRDPGraphics Signed-off-by: Peter

[PATCH 5/9] qemu: conf: Drop handling of 'vxhs' config options

2025-05-27 Thread Peter Krempa via Devel
From: Peter Krempa Remove the config file handling for the config options we no longer use. Signed-off-by: Peter Krempa --- src/qemu/qemu_conf.c| 17 - src/qemu/qemu_conf.h| 4 tests/qemuxmlconftest.c | 4 tests/testutilsqemu.c | 2 -- 4 files changed, 27

[PATCH 6/9] qemu: Move logic from qemuProcessStartValidateShmem to qemuValidateDomainDeviceDefShmem

2025-05-27 Thread Peter Krempa via Devel
From: Peter Krempa Move the check to the appropriate central place. Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 23 --- src/qemu/qemu_validate.c | 7 +++ 2 files changed, 7 insertions(+), 23 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/q

[PATCH 0/9] qemu: Move config validation out of qemu_process.c

2025-05-27 Thread Peter Krempa via Devel
Some more cleanups for misplaced validation of config that I've noticed when I was looking for the code validating floppies in my previous series. Peter Krempa (9): qemuDomainValidateStorageSource: Rework protocol validation into a switch statement qemu: Move disk backend validation checks

[PATCH v2 2/3] ch: add log level configuration option

2025-05-27 Thread Stefan Kober
Allow a user to set the verbosity of the cloud hypervisor instances by specifying it in the ch.conf configuration file. --- src/ch/ch.conf | 8 src/ch/ch_conf.c | 9 + src/ch/ch_conf.h | 15 +++ src/ch/ch_monitor.c

[PATCH v2 0/3] CH: Add support for a configuration file and log level configuration

2025-05-27 Thread Stefan Kober
Similar to the qemu.conf file that allows QEMU specific configurations we add the possibility to specify a ch.conf file for Cloud Hypervisor configuration. The initial single config option is the log level, which sets the verbosity of the Cloud Hypervisor process. This allows for simpler debugging

Re: [PATCH 0/4] An overdue deprecation, a doc fix, a bit of cleanup

2025-05-27 Thread Markus Armbruster via Devel
Queued.

[PATCH 1/9] qemuDomainValidateStorageSource: Rework protocol validation into a switch statement

2025-05-27 Thread Peter Krempa via Devel
From: Peter Krempa Move the validation of TFTP and NFS into a new switch statement which will be used for validating also other protocol config in the future. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 68 +++--- 1 file changed, 44 insertions(+

[PATCH 3/9] qemu: block: Drop code for 'vxhs' storage protocol

2025-05-27 Thread Peter Krempa via Devel
From: Peter Krempa qemu-5.2 dropped support for the 'vxhs' protocol. We require qemu-5.2 since commit ce48d584cc4 and thus the block code for vxhs is now dead. Remove it. Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c | 41 + src/qemu/qemu_domain

Re: [PATCH 0/9] qemu: Move config validation out of qemu_process.c

2025-05-27 Thread Pavel Hrdina via Devel
On Tue, May 27, 2025 at 09:48:56AM +0200, Peter Krempa via Devel wrote: > Some more cleanups for misplaced validation of config that I've noticed > when I was looking for the code validating floppies in my previous > series. > > Peter Krempa (9): > qemuDomainValidateStorageSource: Rework protoco

[PATCH v2 3/3] NEWS: ch: announce log_level config option

2025-05-27 Thread Stefan Kober
--- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 636fcbd573..cfeddd10df 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,11 @@ v11.4.0 (unreleased) * **New features** + * Allow setting the log level of Cloud Hypervisor + +Users can now conf

[PATCH 4/9] qemu.conf: Document options for VxHS block network protocol TLS config as ignored

2025-05-27 Thread Peter Krempa via Devel
From: Peter Krempa qemu-5.2 dropped support for VxHS. As we now require at least qemu-6.2, the qemu.conf option for setting up TLS for VxHS are no longer used. Document them as such. Signed-off-by: Peter Krempa --- src/qemu/libvirtd_qemu.aug | 2 ++ src/qemu/qemu.conf.in | 42 +++

Entering freeze for libvirt-11.4.0

2025-05-27 Thread Jiri Denemark via Devel
I have just tagged v11.4.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue

[PATCH 2/9] qemu: Move disk backend validation checks from qemuProcessStartValidateDisks to qemuDomainValidateStorageSource

2025-05-27 Thread Peter Krempa via Devel
From: Peter Krempa Move the check forbidding VXHS disks and checking the NVME backend capability to the validation code. Remove the now unused qemuProcessStartValidateDisks. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 9 - src/qemu/qemu_process.c | 35 --

Re: [PATCH 3/4] docs/about/deprecated: Move deprecation notes to tidy up order

2025-05-27 Thread Eric Blake via Devel
On Wed, May 21, 2025 at 08:37:10AM +0200, Markus Armbruster via Devel wrote: > The deprecation notes within a section are mostly in version order. > Move the few that aren't so they are. > > Signed-off-by: Markus Armbruster > --- > docs/about/deprecated.rst | 32

Re: [PATCH 1/4] docs/about: Belatedly document tightening of QMP device_add checking

2025-05-27 Thread Eric Blake via Devel
On Wed, May 21, 2025 at 08:37:08AM +0200, Markus Armbruster via Devel wrote: > Commit 4d8b0f0a9536 (v6.2.0) deprecate incorrectly typed device_add deprecated > arguments. Commit be93fd53723c (qdev-monitor: avoid QemuOpts in QMP > device_add) fixed them for v9.2.0, but neglected to update > docum

Re: [PATCH 1/4] docs/about: Belatedly document tightening of QMP device_add checking

2025-05-27 Thread Markus Armbruster via Devel
Eric Blake writes: > On Wed, May 21, 2025 at 08:37:08AM +0200, Markus Armbruster via Devel wrote: >> Commit 4d8b0f0a9536 (v6.2.0) deprecate incorrectly typed device_add > > deprecated Yes. Thank you! >> arguments. Commit be93fd53723c (qdev-monitor: avoid QemuOpts in QMP >> device_add) fixed t

[PATCH 1/1] NEWS : update NEWS for POWER11 support

2025-05-27 Thread Narayana Murty N
Update NEWS.rst with the now added POWER11 processor support Signed-off-by: Narayana Murty N --- NEWS.rst | 4 1 file changed, 4 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 0ba2d20191..fd577021b3 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,10 @@ v11.4.0 (unreleased) * **N

Re: [PATCH 4/4] docs/about/removed-features: Move removal notes to tidy up order

2025-05-27 Thread Eric Blake via Devel
On Wed, May 21, 2025 at 08:37:11AM +0200, Markus Armbruster via Devel wrote: > The removal notes within a section are mostly in version order. Move > the few that aren't so they are. > > Signed-off-by: Markus Armbruster > --- > docs/about/removed-features.rst | 60 --

Re: [RFC PATCH 0/5] qemu: Implement support for iommufd and multiple vSMMUs

2025-05-27 Thread Nathan Chen via Devel
On 5/16/2025 3:19 AM, Shameerali Kolothum Thodi wrote: Hi, This is a follow up to the first RFC patchset [0] for supporting multiple vSMMU instances in a qemu VM. This patchset also introduces support for using iommufd to propagate DMA mappings to kernel for assigned devices. This patchset i

Re: [RFC PATCH 1/5] conf: Support multiple smmuv3Dev IOMMU devices

2025-05-27 Thread Nathan Chen via Devel
On 5/20/2025 4:20 AM, Daniel P. Berrangé wrote: Add support for "smmuv3Dev" IOMMU model, and add support for parsing multiple IOMMU devices from the VM definition when "smmuv3Dev" is the IOMMU model. Enable plugging smmuv3Dev into pcie-root and pcie-expander-bus. Signed-off-by: Nathan Chen --

Re: [RFC PATCH 2/5] conf: Add an iommufd member struct to virDomainIOMMUDef

2025-05-27 Thread Nathan Chen via Devel
On 5/20/2025 6:01 AM, Daniel P. Berrangé wrote: Add support for an "iommufd" virDomainIOMMUDef member that will be translated to a qemu "-object iommufd" command line argument. This iommufd struct has an "id" member to specify the iommufd object id that can be associated with a passthrough dev

Re: [PATCH v4 1/2] virDomainVirtioSerialAddrAssign: Fix virtio console port assignment on vioserial bus

2025-05-27 Thread Ján Tomko via Devel
On a Monday in 2025, Peter Krempa via Devel wrote: On Thu, May 22, 2025 at 21:27:34 -0400, Aaron M. Brown wrote: This change fixes an issue with virito console port assignment on vioserial buses. s/viritio/virtio/ Jano Currently, a virtio console device cannot be assigned to a port greater

Re: [RFC PATCH 0/5] qemu: Implement support for iommufd and multiple vSMMUs

2025-05-27 Thread Nathan Chen via Devel
Hi Daniel, On 5/20/2025 5:51 AM, Daniel P. Berrangé wrote: Hi, This is a follow up to the first RFC patchset [0] for supporting multiple vSMMU instances in a qemu VM. This patchset also introduces support for using iommufd to propagate DMA mappings to kernel for assigned devices. This patchset

Re: [RFC PATCH 3/5] qemu: Implement support for associating iommufd to hostdev

2025-05-27 Thread Nathan Chen via Devel
On 5/20/2025 6:05 AM, Daniel P. Berrangé wrote: Implement "iommufdId" and "iommufdFd" attributes for "hostdev" devices that can be used to specify associated iommufd object and fd for externally opening the /dev/iommu and VFIO cdev, when launching a qemu VM. What does it mean if we enable iom