On Fri, May 09, 2025 at 08:34:42 -, ray wang wrote:
> >
> > Generally patches adding a capability flag should only add the
> > capability flag. Thus you'll need to split this patch.
> >
> > 1) capability addition
> > - move it ahead to the beginning of the series (doing that will
> >
On Fri, May 09, 2025 at 08:38:43 -, ray wang wrote:
> >
> > So here the 'serial' is declared as mandatory. It's optional in the XML
> > parser/formatter and mandatory in the commandline formatter. With other
> > devices it's optional so it's most likely going to need an
> > block.
> >
> > Th
On Fri, May 09, 2025 at 07:29:04PM +, Matt Ochs wrote:
> > On May 9, 2025, at 9:59 AM, Daniel P. Berrangé wrote:
> >
> > On Fri, Apr 11, 2025 at 08:40:54AM -0700, Matthew R. Ochs via Devel wrote:
> >> Resending: Series has been re-based over latest upstream.
> >>
> >> This patch series adds
> On May 12, 2025, at 5:19 AM, Daniel P. Berrangé wrote:
> On Fri, May 09, 2025 at 07:29:04PM +, Matt Ochs wrote:
>>
>> Would it make sense to just use the existing pcihole64 since [I think]
>> it more or less represents the same concept (setting 64bit MMIO window)?
>
> I'm not sure. I've be
Peter Krempa (2):
qemuDomainPrepareHostdevPCI: Fix return values after conversion from
bool to int
qemuDomainPrepareHostdevPCI: Simplify error messages
src/qemu/qemu_domain.c | 43 +-
1 file changed, 17 insertions(+), 26 deletions(-)
--
2.49.0
From: Peter Krempa
Rework the error reporting. Unify on one message about device assignment
modes not supported by the qemu driver and move and reword the messages
for VFIO device assignment.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 37 ++---
1 f
On Thu, May 08, 2025 at 11:32:18 +0200, Andrea Bolognani wrote:
> The borzoi machine type was dropped in QEMU 9.2.0, so let's
> use a different machine type with no ACPI support and no
> implicit USB controller instead.
>
> Signed-off-by: Andrea Bolognani
> ---
Reviewed-by: Peter Krempa
On Thu, May 08, 2025 at 11:32:19 +0200, Andrea Bolognani wrote:
> From: "Matthew R. Ochs"
>
> Notable differences:
>
> * various machine types, notably vexpress-a9, have stopped
> accepting user-specified CPU models in QEMU 9.0;
>
> * the command line for raw devices is slightly differe
On 5/12/25 15:30, Peter Krempa via Devel wrote:
> Peter Krempa (2):
> qemuDomainPrepareHostdevPCI: Fix return values after conversion from
> bool to int
> qemuDomainPrepareHostdevPCI: Simplify error messages
>
> src/qemu/qemu_domain.c | 43 +-
> 1 f
On Mon, May 12, 2025 at 03:51:09PM +0200, Peter Krempa wrote:
> On Thu, May 08, 2025 at 11:32:19 +0200, Andrea Bolognani wrote:
> > From: "Matthew R. Ochs"
> >
> > Notable differences:
> >
> > * various machine types, notably vexpress-a9, have stopped
> > accepting user-specified CPU models
On Fri, May 09, 2025 at 08:32:42 -, ray wang wrote:
> Thanks a lot for the detailed review and suggestions.
Please for the next time include more context to your replies. I've
already forgotten what I was refering to in most contexts that you are
replying below so I'll have hard time following
On 29/04/25 4:50 PM, Peter Krempa wrote:
On Tue, Apr 15, 2025 at 04:13:07 -0400, Narayana Murty N wrote:
Add the qemu test capabilities xml and reply files for
QEMU v10.0.0-rc2 on ppc64. A QEMU v10.0.0-rc2 was used for generating
this data.The tests with the 'latest' suffix, which expect
the l
From: Peter Krempa
Historically when the code was in 'qemuHostdevPreparePCIDevicesCheckSupport'
the function returned bools. Later it was refactored and moved to
'qemuDomainPrepareHostdevPCI' the return values were not changed.
Thus the function now returned '-1', 'false', and 'true'. Callers
ch
Resolves: https://gitlab.com/libvirt/libvirt/-/issues/770
While the original issue report describes scenario where libnl devel
package wasn't installed, it's perfectly reproducible with
-Dlibnl=disabled passed to meson.
Michal Prívozník (5):
libvirt_private.syms: Export virNetlinkBridgeVlanFilt
From: Michal Privoznik
The function was introduced in v11.0.0-rc1~23 but corresponding
change to the private syms file was missing.
Signed-off-by: Michal Privoznik
---
src/libvirt_private.syms | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.sy
From: Michal Privoznik
The whole point of virnetlink.h is that it hides away the build
time dependency on netlink. It wraps netlink functions in our
functions which then have a stub implementation in case netlink
support was disabled.
Signed-off-by: Michal Privoznik
---
src/util/virnetdevbridg
From: Michal Privoznik
In virnetlink.c there are two sections: the first one when
building WITH_LIBNL support, the other that provides stubs for
functions declared in the corresponding header file when building
without netlink support. But the stub implementation for
virNetlinkBridgeVlanFilterSet
From: Michal Privoznik
We still use C89 style of comments. Fix C99 style of comments
used in virNetDevBridgeSetupVlans().
Signed-off-by: Michal Privoznik
---
src/util/virnetdevbridge.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/util/virnetdevbridge.c b/src/ut
From: Michal Privoznik
Currently, virNetlinkBridgeVlanFilterSet() takes @cmd as the
second argument where either RTM_SETLINK or RTM_DELLINK is
expected. Both of these constants come from linux/rtnetlink.h and
thus are undefined when building without netlink. This design
also clashes with the whol
19 matches
Mail list logo
