Re: RFC: libvirt-tck bhyve/FreeBSD support

2025-05-09 Thread Daniel P . Berrangé via Devel
On Tue, Apr 22, 2025 at 05:15:32PM +0200, Roman Bogorodskiy wrote: > > > As long as bhyve can do the auto-fill of UEFI path from this attribute > > > I think that's sufficiently simple. > > > > > > When using bhyveload, is there any firmware at all ? Or is it fully > > > paravirtualized in some wa

Re: RFC: libvirt-tck bhyve/FreeBSD support

2025-05-09 Thread Roman Bogorodskiy
Daniel P. Berrangé wrote: > > I imagine that this is a valid configuration for qemu and probably other > > drivers, but not for bhyve, because it doesn't support direct kernel > > boot (neither for Linux nor FreeBSD). However, I wasn't able to find > > anything similar in the driver's capabiliti

Re: [PATCH] rpm: disable zfs on Fedora >= 43

2025-05-09 Thread Michal Prívozník via Devel
On 5/8/25 12:20, Daniel P. Berrangé via Devel wrote: > From: Daniel P. Berrangé > > The zfs-fuse package has been dead upstream for a long time and is > now retired in Fedora rawhide. > > Signed-off-by: Daniel P. Berrangé > --- > libvirt.spec.in | 7 +-- > 1 file changed, 5 insertions(+),

Re: [PATCH RESEND 0/6] Add support for configuring PCI high memory MMIO size

2025-05-09 Thread Matt Ochs via Devel
> On May 9, 2025, at 9:59 AM, Daniel P. Berrangé wrote: > > On Fri, Apr 11, 2025 at 08:40:54AM -0700, Matthew R. Ochs via Devel wrote: >> Resending: Series has been re-based over latest upstream. >> >> This patch series adds support for configuring the PCI high memory MMIO >> window size for aar

Re: RFC: libvirt-tck bhyve/FreeBSD support

2025-05-09 Thread Daniel P . Berrangé via Devel
On Mon, Apr 14, 2025 at 07:38:18PM +0200, Roman Bogorodskiy wrote: > Daniel P. Berrangé wrote: > > > On Mon, Apr 14, 2025 at 02:36:11PM +0200, Roman Bogorodskiy wrote: > > > Hi, > > > > > > I'd like to test the bhyve driver using libvirt-tck, which seems to be > > > very useful both from the co

[PATCH 4/5] bhyve: introduce bhyveDomainDefValidate()

2025-05-09 Thread Roman Bogorodskiy
Add the bhyveDomainDefValidate() validation which currently checks whether the requested NVRAM is supported. Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_domain.c | 43 1 file changed, 43 insertions(+) diff --git a/src/bhyve/bhyve_domain.c b/src/

[PATCH 5/5] bhyve: support removing NVRAM on domain undefine

2025-05-09 Thread Roman Bogorodskiy
Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_driver.c | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 684346952d..db7d440a97 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve

[PATCH 1/5] bhyve: conf: introduce nvramDir

2025-05-09 Thread Roman Bogorodskiy
As a preparation for NVRAM support, introduce nvramDir configuration item. Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_conf.c | 4 src/bhyve/bhyve_utils.h | 2 ++ src/bhyve/meson.build | 5 + 3 files changed, 11 insertions(+) diff --git a/src/bhyve/bhyve_conf.c b/src/bhyve/

[PATCH 3/5] bhyve: firmware: try to guess NVRAM settings

2025-05-09 Thread Roman Bogorodskiy
Extend bhyveFirmwareFillDomain() so that when we find the default edk2 firmware, also look for its matching template file, and use it as a nvramTemplate if found. Extend bhyvexml2argvtest to verify various NVRAM configurations. Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_firmware.c

Re: [PATCH v3 0/6] qemu: acpi-generic-initiator support

2025-05-09 Thread Michal Prívozník via Devel
On 4/2/25 10:25, Andrea Righi via Devel wrote: > = Overview = > > This patch set introduces support for acpi-generic-initiator devices, > supported by QEMU [1]. > > The acpi-generic-initiator object is required to support Multi-Instance GPU > (MIG) configurations on NVIDIA GPUs [2]. MIG enables p

Re: [PATCH 2/6] conf: Introduce acpi-generic-initiator device

2025-05-09 Thread Michal Prívozník via Devel
On 4/2/25 10:25, Andrea Righi via Devel wrote: > Introduce apci-generic-initiator device to the domain XML. > > Example definition: > > > > dev0 > 1 > > > This enables partitioning of PCI resources into multiple isolated > instances, each requiring a dedicated NUMA node defini

Re: [PATCH RESEND 0/6] Add support for configuring PCI high memory MMIO size

2025-05-09 Thread Daniel P . Berrangé via Devel
On Fri, Apr 11, 2025 at 08:40:54AM -0700, Matthew R. Ochs via Devel wrote: > Resending: Series has been re-based over latest upstream. > > This patch series adds support for configuring the PCI high memory MMIO > window size for aarch64 virt machine types. This feature has been merged > into the Q

Re: [PATCH v3 0/5] docs: automated info about machine deprecation/removal info

2025-05-09 Thread Michael S. Tsirkin via Devel
On Tue, May 06, 2025 at 05:00:19PM +0100, Daniel P. Berrangé wrote: > Since we deprecate and remove versioned machine types on a fixed > schedule, we can automatically ensure that the docs reflect the > latest version info, rather than requiring manual updates on each > dev cycle. > > The first pa

Re: [PATCHv2 2/5] qemu_capabilities: Add support for nvme-ns bus capabilities

2025-05-09 Thread ray wang
> > Generally patches adding a capability flag should only add the > capability flag. Thus you'll need to split this patch. > > 1) capability addition > - move it ahead to the beginning of the series (doing that will > allow you to do capability checks when adding the code instead >

[PATCH 0/5] bhyve: introduce NVRAM support

2025-05-09 Thread Roman Bogorodskiy
Roman Bogorodskiy (5): bhyve: conf: introduce nvramDir bhyve: generate NVRAM bhyve arguments bhyve: firmware: try to guess NVRAM settings bhyve: introduce bhyveDomainDefValidate() bhyve: support removing NVRAM on domain undefine src/bhyve/bhyve_command.c | 8 +- sr

[PATCH 2/5] bhyve: generate NVRAM bhyve arguments

2025-05-09 Thread Roman Bogorodskiy
Currently, bhyve bootrom specification looks like this: bhyve ... -l bootrom,/path/to/firmware.fd In addition to that, it supports specifying the VARS files using: -l bootrom,/path/to/firmware.fd,/path/to/my_domain_VARS.fd Update virBhyveProcessBuildBhyveCmd() to include the VARS file if NVRA

Re: [PATCH 1/6] schema: Introduce acpi-generic-initiator definition

2025-05-09 Thread Michal Prívozník via Devel
On 4/2/25 10:25, Andrea Righi via Devel wrote: > Introduce the definition of a new acpi-generic-initiator object that can > be used to link a PCI device with multiple NUMA nodes. > > Link: https://mail.gnu.org/archive/html/qemu-arm/2024-03/msg00358.html > > Signed-off-by: Andrea Righi > --- > s

Re: [PATCHv2 1/5] qemu: Add support for NVMe namespace disk bus type

2025-05-09 Thread ray wang
Thanks a lot for the detailed review and suggestions. > > Reviewing this would likely be simpler if addition of the controller > was split from the addition of the disk. > Okay, I will split the patch into two parts as suggested—one for introducing the controller and another for the disk. > >

Re: [PATCHv2 3/5] schema: Add nvme controller and nvme-ns bus defination

2025-05-09 Thread ray wang
> > So here the 'serial' is declared as mandatory. It's optional in the XML > parser/formatter and mandatory in the commandline formatter. With other > devices it's optional so it's most likely going to need an > block. > > This series is also completely lacking documentation > (docs/formatdomai

Re: [PATCHv2 0/5] qemu: Introduce nvme disk emulation support

2025-05-09 Thread Martin Kletzander via Devel
On Wed, May 07, 2025 at 04:43:29PM +0200, Peter Krempa wrote: On Wed, May 07, 2025 at 15:56:52 +0200, Martin Kletzander wrote: On Sun, Apr 27, 2025 at 07:48:02PM +0800, honglei.w...@smartx.com wrote: > From: hongleiwang > > QEMU has supported nvme disk emulation for a long time, > see: https://