Re: [PATCH] virbitmap: Change return type of virBitmapToData to void

2025-04-16 Thread Jiri Denemark via Devel
On Wed, Mar 26, 2025 at 14:58:02 +0300, Alexander Kuznetsov wrote: > This function return value is invariant since e59b8f9, so change > its type and remove all dependent checks. > > Found by Linux Verification Center (linuxtesting.org) with Svace. > > Signed-off-by: Artem Chernyshev > Signed-off

Re: [PATCH] virbitmap: Change return type of virBitmapToData to void

2025-04-16 Thread Alexander Kuznetsov
kindly reminder about these cosmetics :)

[PATCH 2/3] python: Do not explicitly state variables are global when only read

2025-04-16 Thread Martin Kletzander via Devel
From: Martin Kletzander If a variable is not modified in a scope there is no need for the use of global in such scope. Without this patch build fails with: F824 `global ...` is unused: name is never assigned in scope It is a bit difficult to find more information on that message and error code

[PATCH 0/3] Fix CI, build, and a typo

2025-04-16 Thread Martin Kletzander via Devel
Each in its respecive commit, obviously. Martin Kletzander (3): nwfilter: Fix erroneous pointer passing to g_clear_pointer python: Do not explicitly state variables are global when only read qemu_rdp: Fix a typo existance -> existence scripts/apibuild.py| 6 -- src/

[PATCH 1/3] nwfilter: Fix erroneous pointer passing to g_clear_pointer

2025-04-16 Thread Martin Kletzander via Devel
From: Martin Kletzander Commit 5de27c32a18f wanted to fix a possible double free, but by mistake did not pass a reference to the variable. This made virtnwfilterd coredump in our daily CI build. Signed-off-by: Martin Kletzander --- src/nwfilter/nwfilter_gentech_driver.c | 4 ++-- 1 file chang

[PATCH 3/3] qemu_rdp: Fix a typo existance -> existence

2025-04-16 Thread Martin Kletzander via Devel
From: Martin Kletzander Signed-off-by: Martin Kletzander --- src/qemu/qemu_rdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_rdp.c b/src/qemu/qemu_rdp.c index 0c48b87e7bad..919f5788bf8f 100644 --- a/src/qemu/qemu_rdp.c +++ b/src/qemu/qemu_rdp.c @@ -432,6 +4

Re: [PATCH 0/3] Fix CI, build, and a typo

2025-04-16 Thread Jiri Denemark via Devel
On Wed, Apr 16, 2025 at 10:06:52 +0200, Martin Kletzander wrote: > Each in its respecive commit, obviously. > > Martin Kletzander (3): > nwfilter: Fix erroneous pointer passing to g_clear_pointer > python: Do not explicitly state variables are global when only read > qemu_rdp: Fix a typo exi