Re: [PATCH] rpc: Re-read the data if EAGAIN or EINTR were captured

2025-04-11 Thread Daniel P . Berrangé via Devel
On Tue, Apr 08, 2025 at 12:55:04AM +0800, yong.hu...@smartx.com wrote: > From: Hyman Huang > > If EAGAIN or EINTR are returned from the gnutls_record_recv, > GNU TLS suggests calling the gnutls_record_recv once again to > get the data. Refer to the following link to see details: > https://www.gnu

Re: [PATCH v1 1/1] rpc: Add the retry argument for virNetTLSSession{Read,Write}

2025-04-11 Thread Daniel P . Berrangé via Devel
On Tue, Apr 08, 2025 at 10:27:51AM +0800, yong.hu...@smartx.com wrote: > From: Hyman Huang > > As advised by the GNU TLS, the caller should attempt again > if the gnutls_record_{recv,send} return EAGAIN or EINTR; > check the following link to view the details: > https://www.gnutls.org/manual/html

Re: [PATCH V1 0/6] fast qom tree get

2025-04-11 Thread Daniel P . Berrangé via Devel
On Wed, Apr 09, 2025 at 09:58:13AM +0200, Peter Krempa via Devel wrote: > On Wed, Apr 09, 2025 at 09:39:02 +0200, Markus Armbruster via Devel wrote: > > Hi Steve, I apologize for the slow response. > > > > Steve Sistare writes: > > > > > Using qom-list and qom-get to get all the nodes and proper

Management applications and CPU feature flags (was: [PATCH V1 0/6] fast qom tree get)

2025-04-11 Thread Markus Armbruster via Devel
Daniel P. Berrangé writes: > On Wed, Apr 09, 2025 at 09:58:13AM +0200, Peter Krempa via Devel wrote: >> On Wed, Apr 09, 2025 at 09:39:02 +0200, Markus Armbruster via Devel wrote: >> > Hi Steve, I apologize for the slow response. >> > >> > Steve Sistare writes: >> > >> > > Using qom-list and qo

Re: Management applications and CPU feature flags (was: [PATCH V1 0/6] fast qom tree get)

2025-04-11 Thread Daniel P . Berrangé via Devel
On Fri, Apr 11, 2025 at 12:40:46PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Wed, Apr 09, 2025 at 09:58:13AM +0200, Peter Krempa via Devel wrote: > >> On Wed, Apr 09, 2025 at 09:39:02 +0200, Markus Armbruster via Devel wrote: > >> > Hi Steve, I apologize for the slow r

Re: Management applications and CPU feature flags

2025-04-11 Thread Markus Armbruster via Devel
Daniel P. Berrangé writes: > On Fri, Apr 11, 2025 at 12:40:46PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Wed, Apr 09, 2025 at 09:58:13AM +0200, Peter Krempa via Devel wrote: >> >> On Wed, Apr 09, 2025 at 09:39:02 +0200, Markus Armbruster via Devel wrote: >> >> >

[PATCH 1/3] qemu: block: Don't crash if qemuBlockThrottleFiltersDetach gets NULL @data

2025-04-11 Thread Peter Krempa via Devel
From: Peter Krempa 'qemuBlockThrottleFiltersDetach' crashes if @data is NULL. That can happen in 'qemuDomainAttachDiskGeneric' as it's used as a rollback path in cases when we didn't yet initialize the filter struct. Fix it by tolerating NULL @data. Closes: https://gitlab.com/libvirt/libvirt/-/

[PATCH 2/3] qemuDomainAttachDiskGeneric: Report errors from 'qemuBuildThrottleFiltersAttachPrepareBlockdev'

2025-04-11 Thread Peter Krempa via Devel
From: Peter Krempa 'qemuBuildThrottleFiltersAttachPrepareBlockdev' can fail when constructing JSON props, but otherwise always retruns a pointer even if there's nothing to do. The code in 'qemuDomainAttachDiskGeneric' didn't handle this properly as it considered NULL as "nothing to do". Return t

[PATCH 3/3] NEWS: Mention fix of crash on disk hotplug failure

2025-04-11 Thread Peter Krempa via Devel
From: Peter Krempa Signed-off-by: Peter Krempa --- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 4f1e8ecbdf..7b4dbd795b 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -50,6 +50,11 @@ v11.3.0 (unreleased) to be logged in the system log. It is safe to i

Re: Management applications and CPU feature flags

2025-04-11 Thread David Hildenbrand via Devel
On 11.04.25 13:43, Markus Armbruster wrote: Daniel P. Berrangé writes: On Fri, Apr 11, 2025 at 12:40:46PM +0200, Markus Armbruster wrote: Daniel P. Berrangé writes: On Wed, Apr 09, 2025 at 09:58:13AM +0200, Peter Krempa via Devel wrote: On Wed, Apr 09, 2025 at 09:39:02 +0200, Markus Armbr

Re: [PATCH] USB hostdev: allow addressing by port

2025-04-11 Thread Michal Prívozník via Devel
On 3/17/25 21:59, Maximilian Martin via Devel wrote: > From: Maximilian Martin > > Currently, only vendor/product and bus/device matching are supported for USB > host > devices. Neither of these provide a stable and persistent way of assigning a > guest > a specific host device. Vendor/product

[PATCH 0/3] qemu: Fix crash on disk hotplug rollback

2025-04-11 Thread Peter Krempa via Devel
Peter Krempa (3): qemu: block: Don't crash if qemuBlockThrottleFiltersDetach gets NULL @data qemuDomainAttachDiskGeneric: Report errors from 'qemuBuildThrottleFiltersAttachPrepareBlockdev' NEWS: Mention fix of crash on disk hotplug failure NEWS.rst| 5 + src/qemu

Re: [PATCH 0/3] qemu: Fix crash on disk hotplug rollback

2025-04-11 Thread Michal Prívozník via Devel
On 4/11/25 13:57, Peter Krempa via Devel wrote: > Peter Krempa (3): > qemu: block: Don't crash if qemuBlockThrottleFiltersDetach gets NULL > @data > qemuDomainAttachDiskGeneric: Report errors from > 'qemuBuildThrottleFiltersAttachPrepareBlockdev' > NEWS: Mention fix of crash on disk h

Re: Management applications and CPU feature flags

2025-04-11 Thread Jiri Denemark via Devel
On Fri, Apr 11, 2025 at 13:43:39 +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > On Fri, Apr 11, 2025 at 12:40:46PM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > Considering the bigger picture QMP design, when libvirt is trying to > >> > understand QEMU's

Re: [PATCH] conf: use const virDomainDef pointers

2025-04-11 Thread Michal Prívozník via Devel
On 4/10/25 16:48, Roman Bogorodskiy wrote: > Some virDomainNet* functions use virDomainDef pointers even though they > don't modify the domain config, so switch to const pointers there. > > This also allows to use the const pointer again in > bhyveBuildNetArgStr() after it was changed in e1e40b503

[PATCH RESEND 0/6] Add support for configuring PCI high memory MMIO size

2025-04-11 Thread Matthew R. Ochs via Devel
Resending: Series has been re-based over latest upstream. This patch series adds support for configuring the PCI high memory MMIO window size for aarch64 virt machine types. This feature has been merged into the QEMU upstream master branch [1] and will be available in QEMU 10.0. It allows users to

[PATCH RESEND 1/6] domain: Add PCI configuration feature infrastructure

2025-04-11 Thread Matthew R. Ochs via Devel
Add basic infrastructure for PCI configuration feature including: - New PCI configuration structure in domain_conf.h - Add VIR_DOMAIN_FEATURE_PCI enum and string conversion - Add pci field to virDomainDef to store PCI configuration This will be used to support QEMU's highmem-mmio-size machine prop

[PATCH RESEND 2/6] schema: Add PCI configuration feature schema

2025-04-11 Thread Matthew R. Ochs via Devel
Add schema definition for PCI configuration feature including: - Add element under - Add element with scaledInteger type - Support unit attribute for size specification This allows XML configuration of PCI high memory MMIO size for aarch64 virt machines. Signed-off-by: Matthew R. Ochs --- sr

[PATCH RESEND 4/6] qemu: Add capability for PCI high memory MMIO size

2025-04-11 Thread Matthew R. Ochs via Devel
Add QEMU capability for PCI high memory MMIO size configuration: - Add QEMU_CAPS_MACHINE_VIRT_HIGHMEM_MMIO_SIZE capability - Add capability to virt machine properties - Add highmem-mmio-size virt machine property to aarch64 qemu 10.0.0 capabilities This allows detecting support for the highmem-m

[PATCH RESEND 5/6] qemu: Add command line support for PCI high memory MMIO size

2025-04-11 Thread Matthew R. Ochs via Devel
Add support for generating QEMU command line with PCI high memory MMIO size: - Add highmem-mmio-size to machine command line generation - Add validation for aarch64/virt machine type requirement - Add capability check for QEMU support - Add feature validation in qemu_validate.c This enables config

[PATCH RESEND 6/6] tests: Add tests for machine PCI features

2025-04-11 Thread Matthew R. Ochs via Devel
Add test coverage for machine-specific PCI features: - Add XML tests for aarch64 virt highmem-mmio-size - Add command line generation tests This ensures proper handling of machine-specific PCI features like the high memory MMIO window size configuration. Signed-off-by: Matthew R. Ochs --- ...rc

[PATCH RESEND 3/6] conf: Add PCI configuration XML parsing and formatting

2025-04-11 Thread Matthew R. Ochs via Devel
Add XML parsing and formatting support for PCI configuration: - Add virDomainFeaturesPCIDefParseXML function - Add virDomainFeaturesPCIDefFormat function - Wire up parsing in virDomainFeaturesDefParse - Wire up formatting in virDomainDefFormatFeatures - Use g_steal_pointer for memory management Th

Re: Management applications and CPU feature flags

2025-04-11 Thread Cornelia Huck via Devel
On Fri, Apr 11 2025, Jiri Denemark wrote: > On Fri, Apr 11, 2025 at 13:43:39 +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> > On Fri, Apr 11, 2025 at 12:40:46PM +0200, Markus Armbruster wrote: >> >> Daniel P. Berrangé writes: >> >> > Considering the bigger picture QMP design,