On a Thursday in 2025, Peter Krempa via Devel wrote:
Three patches fixing various bits in block copy job setup.
Peter Krempa (3):
qemu: domain: Unexport
'qemuDomainPrepareStorageSourceBlockdevNodename'
qemuDomainBlockCopyCommon: Reorder setup of 'mirror' data
qemuDomainBlockCopyCommon: Don
On a Thursday in 2025, Peter Krempa via Devel wrote:
From: Peter Krempa
While exploring an idea that modified the setup of the mirror I've
noticed that the code setting up the 'discard' field in the block copy
job happens after setup of the stroage source, while normally e.g. in
*storage
qe
From: Peter Krempa
While exploring an idea that modified the setup of the mirror I've
noticed that the code setting up the 'discard' field in the block copy
job happens after setup of the stroage source, while normally e.g. in
qemuDomainPrepareStorageSource() it happens before.
Reorder it despit
From: Ján Tomko
Make it match the errors in bhyve and QEMU drivers, where it was copied
from.
Fixes: 9d6e2d127e673642b0fb135b6d58539a8e332e08
Signed-off-by: Ján Tomko
---
Pushed as trivial.
src/ch/ch_monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ch/
From: Jiri Denemark
When migrating a domain with TPM state on a shared disk, we need to skip
TPM cleanup on both ends. So far the code only handled successful
migration and skipped the cleanup on the source host. But if the
migration failed for some reason, the cleanup would be incorrectly
called
From: Peter Krempa
The function is referenced only from within qemu_domain.c
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 2 +-
src/qemu/qemu_domain.h | 5 -
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index c3ca
From: Peter Krempa
If the copy job fails to start up when calling the 'blockdev-mirror'
command the code would call qemuDomainStorageSourceChainAccessRevoke()
twice; once right after the monitor call and the second time in the
'endjob' section.
Remove the one directly after the monitor call and
On a Wednesday in 2025, Kirill Shchetiniuk via Devel wrote:
When new volume was created using 'vol-create' and '--validate' option
an error occured due to invalid flags passed downward.
Resolves:
https://lists.libvirt.org/archives/list/us...@lists.libvirt.org/thread/7WQ2IRSPWKKV5S3N3YJTFOMAJTZJ
On 4/10/25 2:55 AM, Jiri Denemark wrote:
On Thu, Apr 10, 2025 at 02:58:30 -0400, Laine Stump wrote:
When "original passt" support was added, we decided that we always
wanted to reconnect (i.e. restart the passt process) if it was somehow
terminated. Generic vhost-user only turns on reconnect if
Some virDomainNet* functions use virDomainDef pointers even though they
don't modify the domain config, so switch to const pointers there.
This also allows to use the const pointer again in
bhyveBuildNetArgStr() after it was changed in e1e40b5035.
Signed-off-by: Roman Bogorodskiy
---
src/bhyve/
On Thu, Apr 10, 2025 at 11:45:15 -0400, Laine Stump wrote:
> On 4/10/25 2:55 AM, Jiri Denemark wrote:
> > On Thu, Apr 10, 2025 at 02:58:30 -0400, Laine Stump wrote:
> >> When "original passt" support was added, we decided that we always
> >> wanted to reconnect (i.e. restart the passt process) if i
On Thu, Apr 10, 2025 at 02:58:26 -0400, Laine Stump wrote:
> By definition QEMU will never send a NETDEV_STREAM_DISCONNECTED event
> if it doesn't support the reconnect option for a stream netdev (and
Hmm, nested parenthesis and with a closing one missing :-) I suggest
just s/ (a/. A/
> even if,
From: Michal Privoznik
When the network driver initializes itself, it tries to subscribe
to signals from Firewalld sent over system D-Bus. Well, the code
is written in best effort mode, i.e. lack of D-Bus is not
considered an error. Problem is, virGDBusGetSystemBus() which is
used to obtain syste
On Thu, Apr 10, 2025 at 11:21:58 +0200, Michal Privoznik wrote:
> This is basically a follow up to [1] as new places were identified which
> suffer the same problem.
>
> 1:
> https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/WGFBRXMSTXJOOIS3QGRD4HUL27VSFWRQ/
>
> Michal Prívo
On Thu, Apr 10, 2025 at 02:58:27 -0400, Laine Stump wrote:
> We will be adding a new event whose response will be *exactly* the
> same as the response to NETDEV_STREAM_DISCONNECTED. Rather than doing
> a copy-paste of the complete function that does the processing, turn
> that function into somethi
This is basically a follow up to [1] as new places were identified which
suffer the same problem.
1:
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/WGFBRXMSTXJOOIS3QGRD4HUL27VSFWRQ/
Michal Prívozník (2):
virinhibitor: Suppress reporting an error when D-Bus is unavailabl
On Thu, Apr 10, 2025 at 02:58:28 -0400, Laine Stump wrote:
> This response to this event is identical to NETDEV_STREAM_DISCONNECTED
> (start a new passt process to replace the one that just disappeared -
> see commitf62ce81b8a5), except that the new passt process will have
> "--vhost-user" appended
On 4/10/25 08:58, Laine Stump via Devel wrote:
> This brings behavior of passt+vhostuser in line with trad-passt - if
> the passt process is somehow terminated, libvirt will start a new
> passt process that qemu will connect to.
>
> You'll notice no change in behavior if your QEMU binary doesn't h
From: Jiri Denemark
The parameter is used to skip TPM state cleanup on outgoing migration
with shared storage. But we also need to skip the cleanup after a failed
incoming migration. Let's call the parameter "migration" to reflect its
usage on both sides of migration.
Signed-off-by: Jiri Denemar
Jiri Denemark (2):
qemu: Rename outgoingMigration parameter in various TPM functions
qemu: Properly propagate migration state to TPM cleanup code
src/qemu/qemu_domain.c| 8
src/qemu/qemu_domain.h| 2 +-
src/qemu/qemu_driver.c| 7 +--
src/qemu/qemu_extdevice.c | 8
On a Thursday in 2025, Jiri Denemark via Devel wrote:
Jiri Denemark (2):
qemu: Rename outgoingMigration parameter in various TPM functions
qemu: Properly propagate migration state to TPM cleanup code
src/qemu/qemu_domain.c| 8
src/qemu/qemu_domain.h| 2 +-
src/qemu/qemu_driver
This response to this event is identical to NETDEV_STREAM_DISCONNECTED
(start a new passt process to replace the one that just disappeared -
see commitf62ce81b8a5), except that the new passt process will have
"--vhost-user" appended to the commandline. Fortunately that
difference is already handled
When "original passt" support was added, we decided that we always
wanted to reconnect (i.e. restart the passt process) if it was somehow
terminated. Generic vhost-user only turns on reconnect if specified in
the config, but there is no reason to require this if the other end of
the vhost-user sock
Rather than duplicating these two lines of chr device object setup for
hotplug and domain start, put them in a helper function that's called
from both places. That way when we need to setup *more* stuff specific
to passt+vhostuser, we can just add it in that one place.
Signed-off-by: Laine Stump
Signed-off-by: Roman Bogorodskiy
---
src/bhyve/bhyve_parse_command.c | 29 +++
.../bhyveargv2xml-virtio-rnd.args | 8 +
.../bhyveargv2xml-virtio-rnd.xml | 20 +
tests/bhyveargv2xmltest.c | 1 +
4 files ch
From: Hyman Huang
If EAGAIN or EINTR are returned from the gnutls_record_recv,
GNU TLS suggests calling the gnutls_record_recv once again to
get the data. Refer to the following link to see details:
https://www.gnutls.org/manual/html_node/Data-transfer-and-termination.html
To follow this guidanc
Three patches fixing various bits in block copy job setup.
Peter Krempa (3):
qemu: domain: Unexport
'qemuDomainPrepareStorageSourceBlockdevNodename'
qemuDomainBlockCopyCommon: Reorder setup of 'mirror' data
qemuDomainBlockCopyCommon: Don't revoke access to file twice on
failure
src
On 4/7/25 15:24, Peter Krempa via Devel wrote:
> Patches 1,2 cleanup the code the rest deals with docs.
>
> Peter Krempa (5):
> virHostCPUGetInfoPopulateLinux: Use automatic memory freeing
> virHostCPUGetInfoPopulateLinux: Remove 'cleanup'
> libvirt-host: Clarify/fix description of the CPU f
From: Peter Krempa
As the cleanup section is empty; the code can now return directly on
errors.
Signed-off-by: Peter Krempa
---
src/util/virhostcpu.c | 31 +--
1 file changed, 13 insertions(+), 18 deletions(-)
diff --git a/src/util/virhostcpu.c b/src/util/virhostcp
I've discussed this with Michal Privoznik and we decided it's better to
mask the flag rather than adding it to the virCheckFlags, as
virStorageVolDefParseXML do not validate anything and we did not want to
have useless flag inside it, as it not really obvious why it would be
there, when function do
From: Peter Krempa
qemuRdpAvailable() is called from the capability filing code, thus:
- it must not report spurious errors
- it should not call any extra processes
We can solve the above by just checking existance of 'qemu-rdp' in the
path as:
- at the time of adding of qemuRdpAvailable() there
Typo in subject, make it "deprecate".
Vladimir Sementsov-Ogievskiy writes:
> For change, pause, resume, complete, dismiss and finalize actions
> corresponding job- and block-job commands are almost equal. The
> difference is in find_block_job_locked() vs find_job_locked()
> functions. What's dif
On Thu, Apr 10, 2025 at 02:58:30 -0400, Laine Stump wrote:
> When "original passt" support was added, we decided that we always
> wanted to reconnect (i.e. restart the passt process) if it was somehow
> terminated. Generic vhost-user only turns on reconnect if specified in
> the config, but there i
On 4/9/2025 10:44 AM, Markus Armbruster wrote:
Steven Sistare writes:
On 4/9/2025 9:34 AM, Markus Armbruster wrote:
Steven Sistare writes:
On 4/9/2025 3:39 AM, Markus Armbruster wrote:
Hi Steve, I apologize for the slow response.
Steve Sistare writes:
Using qom-list and qom-get to get
Thanks Jiri! and Peter!
On 04/03/25 11:16 PM, Jiri Denemark wrote:
On Tue, Mar 04, 2025 at 17:40:59 +0100, Peter Krempa wrote:
On Tue, Mar 04, 2025 at 10:40:23 -0500, Narayana Murty N wrote:
Add POWER11 as a supported cpu model for ppc64.
Signed-off-by: Narayana Murty N
---
src/cpu_map/in
Support for the pseries-2.7 machine type in QEMU was officially removed in
version 9.2 with qemu commit 445d3facffe8 ("ppc/spapr: remove deprecated
machine pseries-2.7"). Instead of removing related tests, they are now pinned
to the latest available capabilities version 7.0.0 to ensure continued
fu
This patch series introduces the necessary changes to
support the power11 CPU and power11 host in libvirt.
Additionally, it updates the QEMU capabilities with
the latest QEMU version v10.0.0-rc2 to include power11
in the capabilities tests.During testing of v2 patches
found a bug in qemu which sets
QEMU has historically used uppercase CPU model names like "POWER8",
"POWER9", etc. However, starting with commit c5354f54aa60 ("ppc: make
cpu_model translation to type consistent"), QEMU began using lowercase
CPU model names (e.g., "power8") for newer POWER generations.
This shift in naming conven
The commit 140ff3c5141 ("tests: qemuhotplugtest: Fix arch-specific
parts of 'ppc64' test XMLs") fixated on the POWER9 in results xml which
actually would be the host-cpu at the moment on the source tree. With updates
to higher cpu versions this has to continuously be updated. Instead, update
the te
Add POWER11 as a supported cpu model for ppc64.
Signed-off-by: Narayana Murty N
---
src/cpu_map/index.xml | 1 +
src/cpu_map/meson.build| 1 +
src/cpu_map/ppc64_POWER11.xml | 6 ++
tests/domaincapsdata/qemu_10.0.0.ppc64.xml | 1 +
4 files
On Thu, Apr 10, 2025 at 02:58:29 -0400, Laine Stump wrote:
> Rather than duplicating these two lines of chr device object setup for
> hotplug and domain start, put them in a helper function that's called
> from both places. That way when we need to setup *more* stuff specific
> to passt+vhostuser,
On 4/9/25 10:43, Kirill Shchetiniuk via Devel wrote:
> Signed-off-by: Kirill Shchetiniuk
> ---
> NEWS.rst | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/NEWS.rst b/NEWS.rst
> index e2dc4e508b..dd345bad7b 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -28,6 +28,11 @@ v11.3.0 (unrele
On 07.04.25 18:28, Eric Blake wrote:
On Fri, Apr 04, 2025 at 10:31:53PM +0300, Vladimir Sementsov-Ogievskiy wrote:
Actualize documentation and synchronize it for commands which actually
call the same functions internally.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
qapi/block-core.json |
From: Michal Privoznik
At the beginning of virInhibitorAcquire() the system D-Bus
connection is obtained by calling virGDBusGetSystemBus(). If
there's no D-Bus available then an debug message is printed out
and function returns early. Problem is, in case of no D-Bus an
error message was reported
44 matches
Mail list logo
