Re: [PATCH v2 1/2] qapi: synchronize jobs and block-jobs documentation

2025-04-08 Thread Markus Armbruster via Devel
Vladimir Sementsov-Ogievskiy writes: > Actualize documentation and synchronize it for commands which actually > call the same functions internally. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/block-core.json | 59 +--- > qapi/job.json

Re: [PATCH] qemu: rdp: Fix 'qemuRdpAvailable()'

2025-04-08 Thread Boris Fiuczynski
On 4/7/25 18:22, Peter Krempa via Devel wrote: From: Peter Krempa qemuRdpAvailable() is called from the capability filing code, thus: - it must not report spurious errors - it should not call any extra processes We can solve the above by just checking existance of 'qemu-rdp' in the path as: - a

Re: [PATCH 0/4] qemu: Remove legacy 'nbd-export-add' code and deprecate corresponding capabilities

2025-04-08 Thread Ján Tomko via Devel
On a Tuesday in 2025, Peter Krempa via Devel wrote: Peter Krempa (4): qemu: block: Always assume support for 'block-export-add' qemu: monitor: Drop wrappers for 'nbd-server-add' qemu: capabilities: Retire QEMU_CAPS_BLOCK_EXPORT_ADD qemu: capabilities: Retire QEMU_CAPS_NBD_BITMAP src/qemu/qem

Re: [PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix

2025-04-08 Thread Kirill Shchetiniuk via Devel
On Mon, Apr 07, 2025 at 03:59:25PM +0200, Peter Krempa wrote: > On Mon, Apr 07, 2025 at 15:45:24 +0200, Michal Prívozník wrote: > > On 4/7/25 15:11, Peter Krempa via Devel wrote: > > > On Mon, Apr 07, 2025 at 14:49:14 +0200, Peter Krempa via Devel wrote: > > >> On Mon, Apr 07, 2025 at 14:25:43 +020

[PATCH 2/4] qemu: monitor: Drop wrappers for 'nbd-server-add'

2025-04-08 Thread Peter Krempa via Devel
From: Peter Krempa The code is no longer used. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.c | 17 - src/qemu/qemu_monitor.h | 5 - src/qemu/qemu_monitor_json.c | 28 src/qemu/qemu_monitor_json.h | 6 -- tests/qemumonit

[PATCH 4/4] qemu: capabilities: Retire QEMU_CAPS_NBD_BITMAP

2025-04-08 Thread Peter Krempa via Devel
From: Peter Krempa The capability wasn't used since it's inception. It now refers to a deprecated QMP command. Drop it. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 3 +-- src/qemu/qemu_capabilities.h | 2 +- tests/qemuc

[PATCH 3/4] qemu: capabilities: Retire QEMU_CAPS_BLOCK_EXPORT_ADD

2025-04-08 Thread Peter Krempa via Devel
From: Peter Krempa The 'block-export-add' command was added in qemu-5.2 so we now use it unconditionally. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 3 +-- src/qemu/qemu_capabilities.h | 2 +- tests/qemucapabilitiesdat

Re: [PATCH] docs: drvqemu: Fix required minimum qemu version to 6.2.0

2025-04-08 Thread Ján Tomko via Devel
On a Tuesday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa Commit 8824af826d3 (and also commit 073bf167843 before it) which bumped minimu, qemu version forgot to update the qemu driver documentation page Fixes: 8824af826d3 Signed-off-by: Peter Krempa --- docs/drvqemu.rst | 2 +- 1

[PATCH] docs: drvqemu: Fix required minimum qemu version to 6.2.0

2025-04-08 Thread Peter Krempa via Devel
From: Peter Krempa Commit 8824af826d3 (and also commit 073bf167843 before it) which bumped minimu, qemu version forgot to update the qemu driver documentation page Fixes: 8824af826d3 Signed-off-by: Peter Krempa --- docs/drvqemu.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[PATCH 1/3] bhyve: support random number generator device

2025-04-08 Thread Roman Bogorodskiy
Bhyve supports the Virtio RNG interface. It's always using the /dev/random device and doesn't have any configuration options. Thus, in XML it's represented as: So extend the bhyve driver to support that and add a set of tests for this feature. Signed-off-by: Roman Bogorodskiy --- s

[PATCH 0/3] bhyve: support random number generator device

2025-04-08 Thread Roman Bogorodskiy
Roman Bogorodskiy (3): bhyve: support random number generator device bhyve: argv2xml: support virtio-rnd devices bhyve: extend RNG device validation src/bhyve/bhyve_capabilities.c| 15 src/bhyve/bhyve_capabilities.h| 2 + src/bhyve/bhyve_command.c

[PATCH 3/3] bhyve: extend RNG device validation

2025-04-08 Thread Roman Bogorodskiy
Add a bunch of device def validation to catch unsupported RNG device configurations early. Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_domain.c | 21 +++ ...yvexml2argv-virtio-rnd-backend-builtin.xml | 26 +++ ...io-rnd-backend-random-non

[PATCH 0/4] qemu: Remove legacy 'nbd-export-add' code and deprecate corresponding capabilities

2025-04-08 Thread Peter Krempa via Devel
Peter Krempa (4): qemu: block: Always assume support for 'block-export-add' qemu: monitor: Drop wrappers for 'nbd-server-add' qemu: capabilities: Retire QEMU_CAPS_BLOCK_EXPORT_ADD qemu: capabilities: Retire QEMU_CAPS_NBD_BITMAP src/qemu/qemu_block.c | 7 - src

[PATCH 1/4] qemu: block: Always assume support for 'block-export-add'

2025-04-08 Thread Peter Krempa via Devel
From: Peter Krempa 'block-export-add' QMP command which replaces 'nbd-server-add' was introduced in qemu-5.2. We can thus drop the old code now. Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu

[PATCH] esx: Accept empty "path" URI component same way as "/"

2025-04-08 Thread Peter Krempa via Devel
From: Peter Krempa When connecting to "esx://" URI there's code which prints a warning that the path is not "empty". The check validates that "uri->path" is "/". In case when the user uses URI such as: esx://hostname the warning is printed as well. Since there is no effective difference betwe

[PATCH] NEWS: Mention fix for 'qemu-rdp' error being logged

2025-04-08 Thread Peter Krempa via Devel
From: Peter Krempa Add the news entry stating that it's safe to ignore the error. Signed-off-by: Peter Krempa --- NEWS.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 2608086717..18b873abe9 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -34,6 +34,16 @@ v1

Re: [PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix

2025-04-08 Thread Peter Krempa via Devel
On Tue, Apr 08, 2025 at 20:21:13 +0200, Kirill Shchetiniuk wrote: > On Mon, Apr 07, 2025 at 03:59:25PM +0200, Peter Krempa wrote: > > On Mon, Apr 07, 2025 at 15:45:24 +0200, Michal Prívozník wrote: > > > On 4/7/25 15:11, Peter Krempa via Devel wrote: > > > > On Mon, Apr 07, 2025 at 14:49:14 +0200,