[PATCH v1 1/1] rpc: Add the retry argument for virNetTLSSession{Read,Write}

2025-04-07 Thread yong . huang
From: Hyman Huang As advised by the GNU TLS, the caller should attempt again if the gnutls_record_{recv,send} return EAGAIN or EINTR; check the following link to view the details: https://www.gnutls.org/manual/html_node/Data-transfer-and-termination.html Add the retry parameter for virNetTLSSess

[PATCH v1 0/1] rpc: Re-read the data if EAGAIN or EINTR were captured

2025-04-07 Thread yong . huang
From: Hyman Huang v1: 1. Encapsulate the retry logic inside virNetTLSSession{Read,Write} 2. Use VIR_DEBUG instead of VIR_WARN to log the retry operation rfc: https://patchew.org/Libvirt/d716a59dc2c61916917c6d2e07d62055745606d5.1744044211.git.yong.hu...@smartx.com/ Please review, thanks. Yong

RE: [PATCH v1 00/18] LIBVIRT: X86: TDX support

2025-04-07 Thread Duan, Zhenzhong
>-Original Message- >From: Peter Krempa >Subject: Re: [PATCH v1 00/18] LIBVIRT: X86: TDX support > >On Thu, Apr 03, 2025 at 18:28:23 +0800, Zhenzhong Duan wrote: > >[...] > >> >> Zhenzhong Duan (18): >> tools: Secure guest check for Intel in virt-host-validate >> qemu: Check if INTE

Re: [PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix

2025-04-07 Thread Peter Krempa via Devel
On Mon, Apr 07, 2025 at 15:25:58 +0200, Kirill Shchetiniuk wrote: Please do not top-post on technical lists [1]. > I've discussed this with Michal Privoznik and we decided it's better to > mask the flag rather than adding it to the virCheckFlags, as > virStorageVolDefParseXML do not validate anyt

Re: [PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix

2025-04-07 Thread Peter Krempa via Devel
On Mon, Apr 07, 2025 at 15:45:24 +0200, Michal Prívozník wrote: > On 4/7/25 15:11, Peter Krempa via Devel wrote: > > On Mon, Apr 07, 2025 at 14:49:14 +0200, Peter Krempa via Devel wrote: > >> On Mon, Apr 07, 2025 at 14:25:43 +0200, Kirill Shchetiniuk via Devel wrote: [...] > >> Either way this hu

Re: [PATCH 0/3] cpu_map: Install Ampere-1 ARM CPU models

2025-04-07 Thread Michal Prívozník via Devel
On 4/4/25 14:49, Jiri Denemark via Devel wrote: > BTW, the added test will not actually detect similar issues in the > future (I'm thinking about such test, though), but it will help with > other issues with the ARM CPU map as it hasn't been covered at all. > > Jiri Denemark (3): > tests: Add a

[PATCH 3/5] libvirt-host: Clarify/fix description of the CPU frequency field

2025-04-07 Thread Peter Krempa via Devel
From: Peter Krempa The 'virNodeInfo' field for CPU frequency is named 'mhz'. The docs were mentioning 'mHZ', which is neither the field name nor proper spelling of the unit. Reword the paragraph to mention "CPU frequency" instead and explicitly name the field in virNodeInfo struct. Signed-off-b

Re: [PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix

2025-04-07 Thread Michal Prívozník via Devel
On 4/7/25 15:11, Peter Krempa via Devel wrote: > On Mon, Apr 07, 2025 at 14:49:14 +0200, Peter Krempa via Devel wrote: >> On Mon, Apr 07, 2025 at 14:25:43 +0200, Kirill Shchetiniuk via Devel wrote: >>> When the new storage was created using virsh with --validate option >>> following errors occurred

Re: [PATCH v3 18/20] qemu: add 'rdp' capability if qemu-rdp is available

2025-04-07 Thread Peter Krempa via Devel
On Sun, Mar 16, 2025 at 12:18:39 +0400, marcandre.lureau--- via Devel wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Reviewed-by: Martin Kletzander > --- > diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c > index ca99e61896..2c137bb663 100644 >

[PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix

2025-04-07 Thread Kirill Shchetiniuk via Devel
When the new storage was created using virsh with --validate option following errors occurred: # virsh vol-create default --file vol-def.xml --validate error: Failed to create vol from vol-def.xml error: unsupported flags (0x4) in function virStorageVolDefParseXML and after virStorageVolDefParse

Re: [PATCH v2 2/2] qapi/block-core: derpecate some block-job- APIs

2025-04-07 Thread Eric Blake via Devel
On Fri, Apr 04, 2025 at 10:31:54PM +0300, Vladimir Sementsov-Ogievskiy wrote: In the subject line: s/derpecate/deprecate/ > For change, pause, resume, complete, dismiss and finalize actions > corresponding job- and block-job commands are almost equal. The > difference is in find_block_job_locked(

Re: [PATCH v2 1/2] qapi: synchronize jobs and block-jobs documentation

2025-04-07 Thread Eric Blake via Devel
On Fri, Apr 04, 2025 at 10:31:53PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Actualize documentation and synchronize it for commands which actually > call the same functions internally. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/block-core.json | 59 +

Re: [PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix

2025-04-07 Thread Peter Krempa via Devel
On Mon, Apr 07, 2025 at 14:25:43 +0200, Kirill Shchetiniuk via Devel wrote: > When the new storage was created using virsh with --validate option > following errors occurred: > > # virsh vol-create default --file vol-def.xml --validate > error: Failed to create vol from vol-def.xml > error: unsupp

[PATCH 0/5] virNodeGetInfo: Fix docs and propagate them to 'virsh nodeinfo'

2025-04-07 Thread Peter Krempa via Devel
Patches 1,2 cleanup the code the rest deals with docs. Peter Krempa (5): virHostCPUGetInfoPopulateLinux: Use automatic memory freeing virHostCPUGetInfoPopulateLinux: Remove 'cleanup' libvirt-host: Clarify/fix description of the CPU frequency field virNodeGetInfo: Improve description of the

[PATCH 1/5] virHostCPUGetInfoPopulateLinux: Use automatic memory freeing

2025-04-07 Thread Peter Krempa via Devel
From: Peter Krempa Use 'g_autfree' for the two temporary strings. 'sysfs_cpudir' was used in two places, one of which is in a loop. Add another helper variable for it and declare the other one in the loop. Signed-off-by: Peter Krempa --- src/util/virhostcpu.c | 16 ++-- 1 file cha

[PATCH 4/5] virNodeGetInfo: Improve description of the case when fake data is reported

2025-04-07 Thread Peter Krempa via Devel
From: Peter Krempa virNodeGetInfo due to the rigid desing of the filled struct can't faithfully represent all topologies. Improve the description when that happens and outline the fallback topology. The function docs already state that users ought to use virConnectGetCapabilities() instead. Sig

[PATCH 5/5] manpages: virsh: Use disclaimer from 'virNodeGetInfo()' for 'virsh nodeinfo'

2025-04-07 Thread Peter Krempa via Devel
From: Peter Krempa Adapt the disclarimer about the data not being accurate in many cases from the API docs to the virsh command using the aforementioned API. Signed-off-by: Peter Krempa --- docs/manpages/virsh.rst | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-)

Re: [PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix

2025-04-07 Thread Peter Krempa via Devel
On Mon, Apr 07, 2025 at 14:49:14 +0200, Peter Krempa via Devel wrote: > On Mon, Apr 07, 2025 at 14:25:43 +0200, Kirill Shchetiniuk via Devel wrote: > > When the new storage was created using virsh with --validate option > > following errors occurred: > > > > # virsh vol-create default --file vol-d

Re: [PATCH] rpc: Re-read the data if EAGAIN or EINTR were captured

2025-04-07 Thread Peter Krempa via Devel
On Tue, Apr 08, 2025 at 00:55:04 +0800, yong.hu...@smartx.com wrote: > From: Hyman Huang > > If EAGAIN or EINTR are returned from the gnutls_record_recv, > GNU TLS suggests calling the gnutls_record_recv once again to Since the guidance is about 'gnutls_record_recv' ... > get the data. Refer to

Re: [PATCH] qemu: rdp: Fix 'qemuRdpAvailable()'

2025-04-07 Thread Marc-André Lureau
On Mon, Apr 7, 2025 at 8:22 PM Peter Krempa via Devel wrote: > > From: Peter Krempa > > qemuRdpAvailable() is called from the capability filing code, thus: > - it must not report spurious errors > - it should not call any extra processes > > We can solve the above by just checking existance of 'q