Re: [PATCH] virt-aa-helper: delete dynamic files

2025-04-01 Thread Alessandro
On Tue, 1 Apr 2025 at 14:22, Andrea Bolognani wrote: > > On Tue, Apr 01, 2025 at 10:55:28AM +0200, Alessandro wrote: > > We attempted multiple ways to clean up dynamic files; however, we must > > preserve user overrides, which requires keeping the file > > /etc/apparmor.d/libvirt/libvirt-uuid > >

Re: [PATCH] virt-aa-helper: delete dynamic files

2025-04-01 Thread Daniel P . Berrangé via Devel
On Tue, Apr 01, 2025 at 08:12:11AM -0700, Andrea Bolognani wrote: > On Tue, Apr 01, 2025 at 03:24:10PM +0100, Daniel P. Berrangé wrote: > > On Tue, Apr 01, 2025 at 07:15:46AM -0700, Andrea Bolognani via Devel wrote: > > > More importantly, I'm not convinced that you can just start deleting > > > th

[PATCH] virt-aa-helper: delete dynamic files

2025-04-01 Thread Alessandro
We attempted multiple ways to clean up dynamic files; however, we must preserve user overrides, which requires keeping the file /etc/apparmor.d/libvirt/libvirt-uuid This commit proposes to move user overrides into /etc/apparmor.d/libvirt/libvirt-uuid.local and include it, if present, unconditional

Re: [libvirt PATCH] tools: virsh: metadata: do not report error on missing metadata

2025-04-01 Thread Peter Krempa via Devel
On Fri, Feb 21, 2025 at 14:36:50 +0100, Michal Prívozník wrote: > On 2/20/25 23:26, Ján Tomko wrote: > > Similarly to `desc` and `net-desc`, return an empty string if > > there is no metadata to be returned. > > > > https://issues.redhat.com/browse/RHEL-27172 > > > > Signed-off-by: Ján Tomko > >

[no subject]

2025-04-01 Thread Alessandro
>> tmp = g_strdup_printf(" #include %s\n", >> ifexists, ctl->uuid); >> +tmp_local = g_strdup_printf(" #include >> %s\n", ifexists, ctl->uuid); >> +new_tmp = g_strconcat(tmp, tmp_local, NULL); >> +g_free(tmp); >> +tmp = g_steal_point

Re: [libvirt PATCH 0/7] Deprecate the QEMU driver

2025-04-01 Thread Martin Kletzander via Devel
On Tue, Apr 01, 2025 at 05:12:35AM +0200, Ján Tomko via Devel wrote: See patch 3/7 (7/3 for Americans) for the reasoning Ján Tomko (7): Add a copy of the Sandwich license remote: do not generate the qemu protocol header Deprecate the QEMU driver meson: remove all references to QEMU Remove s

Release of libvirt-11.2.0

2025-04-01 Thread Jiri Denemark via Devel
The 11.2.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is

[libvirt PATCH 7/7] NEWS: Document the QEMU driver removal

2025-04-01 Thread Ján Tomko via Devel
From: Ján Tomko Signed-off-by: Ján Tomko --- NEWS.rst | 64 +++- 1 file changed, 40 insertions(+), 24 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index 03efead80f..9a8611ccb0 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -8,7 +8,23 @@ the changes

Re: [PATCH 2/8] virDomainStorageNetworkParseHost: Refactor cleanup

2025-04-01 Thread Ján Tomko via Devel
On a Friday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa Use a 'switch' statement instead of a bunch of if statements to do validation and selection what to parse. Remove the pre-clearing of the struct as we always alocate cleared allocate memory for it and we can reorder assi

[PATCH] news: document dropping apparmor < 3.0.0

2025-04-01 Thread Daniel P . Berrangé via Devel
From: Daniel P. Berrangé Signed-off-by: Daniel P. Berrangé --- NEWS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 0cb11313cd..d359bc5a32 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -15,6 +15,8 @@ v11.3.0 (unreleased) * **Removed features** + * Support for

Re: [PATCH] virt-aa-helper: delete dynamic files

2025-04-01 Thread Andrea Bolognani via Devel
On Tue, Apr 01, 2025 at 10:55:28AM +0200, Alessandro wrote: > We attempted multiple ways to clean up dynamic files; however, we must > preserve user overrides, which requires keeping the file > /etc/apparmor.d/libvirt/libvirt-uuid > > This commit proposes to move user overrides into > /etc/apparmor

Re: [PATCH 1/5] virpci: Switch to an implementation using libpciaccess

2025-04-01 Thread Roman Bogorodskiy
Alexander Shursha wrote: > The current virpci code uses the Linux-specific sysfs subsystem, which makes > it impossible to use on other Unix-like systems. The libpciaccess library > provides a cross-platform API for accessing the PCI bus. Employ it to make > the code portable. > > This makes li

Re: [PATCH] virt-aa-helper: delete dynamic files

2025-04-01 Thread Andrea Bolognani via Devel
On Tue, Apr 01, 2025 at 03:24:10PM +0100, Daniel P. Berrangé wrote: > On Tue, Apr 01, 2025 at 07:15:46AM -0700, Andrea Bolognani via Devel wrote: > > More importantly, I'm not convinced that you can just start deleting > > that file unconditionally. Since, as you note, it's explicitly > > documente

Re: [PATCH] [for-10.1] qapi/block-core: derpecate some block-job- APIs

2025-04-01 Thread Peter Krempa via Devel
On Tue, Apr 01, 2025 at 18:57:30 +0300, Vladimir Sementsov-Ogievskiy wrote: > For change, pause, resume, complete, dismiss and finalize actions > corresponding job- and block-job commands are almost equal. The > difference is in find_block_job_locked() vs find_job_locked() > functions. What's diffe

Re: [PATCH 5/5] bhyve: Tie the 'passthru' option to the 'hostdev' XML config

2025-04-01 Thread Roman Bogorodskiy
Alexander Shursha wrote: > Signed-off-by: Alexander Shursha > --- > src/bhyve/bhyve_parse_command.c | 60 +++ > .../bhyveargv2xml-passthru.args | 7 +++ > .../bhyveargv2xml-passthru.xml| 22 +++ > tests/bhyveargv2xmltest.c

Re: [PATCH 4/5] bhyve: Support passing the 'passthru' command line option

2025-04-01 Thread Roman Bogorodskiy
Alexander Shursha wrote: > It is used to pass a PCI device from the host to a bhyve guest > > Signed-off-by: Alexander Shursha > --- > src/bhyve/bhyve_command.c | 24 > .../bhyvexml2argv-passthru.args | 9 ++ > .../bhyvexml2argv-passthru

RE: [PATCH rfcv4 06/13] qemu: Add command line and validation for TDX type

2025-04-01 Thread Duan, Zhenzhong
>-Original Message- >From: Jim Fehlig >Subject: Re: [PATCH rfcv4 06/13] qemu: Add command line and validation for TDX >type > >On 5/24/24 00:21, Zhenzhong Duan wrote: >> QEMU will provides 'tdx-guest' object which is used to launch encrypted >> VMs on Intel platform using TDX feature. >>

Re: [PATCH 0/8] Support FD passing for the NBD server socket used for backup

2025-04-01 Thread Ján Tomko via Devel
On a Friday in 2025, Peter Krempa via Devel wrote: See 6/8 for justification. Peter Krempa (8): virDomainStorageNetworkParseHost: Remove unpopulated 'transport' variable virDomainStorageNetworkParseHost: Refactor cleanup conf: Introduce VIR_STORAGE_NET_HOST_TRANS_FD virStorageNetHostDefCl

Re: [PATCH] news: document dropping apparmor < 3.0.0

2025-04-01 Thread Ján Tomko via Devel
On a Tuesday in 2025, Daniel P. Berrangé via Devel wrote: From: Daniel P. Berrangé Signed-off-by: Daniel P. Berrangé --- NEWS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 0cb11313cd..d359bc5a32 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -15,6 +15,8 @@ v11.3.0

Re: [PATCH] virt-aa-helper: delete dynamic files

2025-04-01 Thread Daniel P . Berrangé via Devel
On Mon, Mar 31, 2025 at 07:30:02PM +0200, Alessandro wrote: > We attempted multiple ways to clean up dynamic files; however, we must > preserve user overrides, which requires keeping the file > /etc/apparmor.d/libvirt/libvirt-uuid > > This commit proposes to move user overrides into > /etc/apparmo

Re: [PATCH] virt-aa-helper: delete dynamic files

2025-04-01 Thread Andrea Bolognani via Devel
On Tue, Apr 01, 2025 at 04:00:42PM +0200, Alessandro wrote: > On Tue, 1 Apr 2025 at 14:22, Andrea Bolognani wrote: > > On Tue, Apr 01, 2025 at 10:55:28AM +0200, Alessandro wrote: > > > We attempted multiple ways to clean up dynamic files; however, we must > > > preserve user overrides, which requi

Re: [PATCH] virt-aa-helper: delete dynamic files

2025-04-01 Thread Daniel P . Berrangé via Devel
On Tue, Apr 01, 2025 at 07:15:46AM -0700, Andrea Bolognani via Devel wrote: > On Tue, Apr 01, 2025 at 04:00:42PM +0200, Alessandro wrote: > > On Tue, 1 Apr 2025 at 14:22, Andrea Bolognani wrote: > > > On Tue, Apr 01, 2025 at 10:55:28AM +0200, Alessandro wrote: > > > > We attempted multiple ways to

[PATCH] [for-10.1] qapi/block-core: derpecate some block-job- APIs

2025-04-01 Thread Vladimir Sementsov-Ogievskiy
For change, pause, resume, complete, dismiss and finalize actions corresponding job- and block-job commands are almost equal. The difference is in find_block_job_locked() vs find_job_locked() functions. What's different? 1. find_block_job_locked() do check, is found job a block-job. This OK whe