Re: [PATCH V4 09/18] qemu: Add support for mapped-ram on save

2025-03-27 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:18PM -0700, Jim Fehlig via Devel wrote: > Introduce support for QEMU's new mapped-ram stream format [1]. > mapped-ram can be enabled by setting the 'save_image_format' > setting in qemu.conf to 'sparse'. > > To use mapped-ram with QEMU: > - The 'mapped-ram' migration

[PATCH 7/8] qemuAgentCheckError: Rewort error if neither return nor error is found

2025-03-27 Thread Peter Krempa via Devel
From: Peter Krempa Disambiguate the case from other types of error. Signed-off-by: Peter Krempa --- src/qemu/qemu_agent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index d4eb4897a4..ee0921eca6 100644 --- a/src/qemu/qemu_ag

[PATCH] virsh: make virshPrintJobProgress tty-aware

2025-03-27 Thread Vincent Caron via Devel
virshPrintJobProgress pretty-prints a migration progress indicator on stderr presuming it's tied to a tty, which is not always true. In the case without the tty, I still find the progress indication useful (for instance it ends in a timestamped log, which is useful for debug/perf analysis). And mo

[PATCH v2 1/2] libxl_conf: Implement hyperv domain flags for Xen

2025-03-27 Thread Will
Adds support for configuring flags for domains running under Xen. The following flags, making use of QEMU's existing flags, are now configurable for Xen: vapic, synic, stimer, frequencies, tlbflush and ipi Tests have been added validating translation to libxl's viridian flags Updated docs secti

[PATCH v2 0/2] libxl_conf: Implement hyperv domain flags for Xen

2025-03-27 Thread Will
Hello Jim, Thank you for taking the time to review this patch. I've updated the patch with the changes you requested: * Split NEWS.rst change into separate patch. * Addressed line length issues in docs/formatdomain.rst * Addressed line length issues in src/libxl/libxl_conf.c * Corrected comment s

[PATCH v2 2/2] Add NEWS item for flags with Xen

2025-03-27 Thread Will
Signed-off-by: Will --- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 1fc80e2496..075fbd2d6c 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -67,6 +67,11 @@ v11.2.0 (unreleased) restore. Using multiple channels can reduce the time required to save a

Re: [PATCH V4 13/18] qemu: Support O_DIRECT with mapped-ram on save

2025-03-27 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:22PM -0700, Jim Fehlig via Devel wrote: > When using the mapped-ram migration capability, direct IO is > enabled by setting the "direct-io" migration parameter to > "true" and passing QEMU an additional fd with O_DIRECT set. > > Signed-off-by: Jim Fehlig > --- > src

Re: [PATCH] Add NEWS item for auto-shutdown feature

2025-03-27 Thread Jiri Denemark via Devel
On Thu, Mar 20, 2025 at 13:44:41 -0400, Laine Stump wrote: > On 3/20/25 10:57 AM, Daniel P. Berrangé via Devel wrote: > > From: Daniel P. Berrangé > > > > Signed-off-by: Daniel P. Berrangé > > --- > > NEWS.rst | 17 + > > 1 file changed, 17 insertions(+) > > > > diff --git a/

[libvirt PATCH] NEWS: fix even more typos

2025-03-27 Thread Ján Tomko via Devel
From: Ján Tomko The 'editting one' was: Reported-by: Martin Kletzander I found the rest myself. Signed-off-by: Ján Tomko --- Pushed as trivial. NEWS.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index 484333e55a..6ab34aa756 100644 --- a/NEW

[PATCH 3/4] qemu: use configurable dump format in doCoreDumpToAutoDumpPath()

2025-03-27 Thread Nikolai Barybin via Devel
Instead of doing dump in raw format, let's use configurable vm->def->coredumpFormat, which is either way will be raw by default. Signed-off-by: Nikolai Barybin --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_dr

[PATCH 1/4] conf: schemas: add coredump_format element to events section

2025-03-27 Thread Nikolai Barybin via Devel
Signed-off-by: Nikolai Barybin --- src/conf/schemas/domaincommon.rng | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincommon.rng index 5597d5a66b..dc8f708779 100644 --- a/src/conf/schemas/domaincommon.rng +++ b/sr

[PATCH 4/4] docs: formatdomain: document 'coredump_format' element

2025-03-27 Thread Nikolai Barybin via Devel
Signed-off-by: Nikolai Barybin --- docs/formatdomain.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 3be7ee0ff4..edd9762fd4 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -1957,6 +1957,15 @@ The ``on_crash`` e

[PATCH 2/4] src: conf: add parsing/formatting for 'coredump_format' value

2025-03-27 Thread Nikolai Barybin via Devel
Signed-off-by: Nikolai Barybin --- src/conf/domain_conf.c | 64 src/conf/domain_conf.h | 2 ++ src/libvirt_private.syms | 2 ++ 3 files changed, 68 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 99ecb03067..89dceacf

[PATCH 0/4] Allow xml-configured coredump format on VM crash

2025-03-27 Thread Nikolai Barybin via Devel
When libvirt processes VM crash event it always dumps core in raw format. This series makes it possible to configure dump format via domain xml. This would be especcialy helpful for Windows guests, because it requires a lot effort to convert raw dump into wingdb. Nikolai Barybin (4): conf: sche