On a Thursday in 2025, Peter Krempa via Devel wrote:
From: Peter Krempa
Signed-off-by: Peter Krempa
---
NEWS.rst | 10 ++
1 file changed, 10 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 98ca838642..b2f3415001 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -37,6 +37,16 @@ v11.2.0 (unre
On a Thursday in 2025, Martin Kletzander via Devel wrote:
From: Martin Kletzander
In commit dbfb96d18c04 libvirt started connecting to the daemon to set
RDP credentials, but our configuration file did not allow connections
from the root user, so the connection failed and the VM failed to start.
On 3/20/25 10:57 AM, Daniel P. Berrangé via Devel wrote:
From: Daniel P. Berrangé
Signed-off-by: Daniel P. Berrangé
---
NEWS.rst | 17 +
1 file changed, 17 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 98ca838642..45d48c1485 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -3
On Thu, Mar 20, 2025 at 01:44:41PM -0400, Laine Stump wrote:
> On 3/20/25 10:57 AM, Daniel P. Berrangé via Devel wrote:
> > From: Daniel P. Berrangé
> >
> > Signed-off-by: Daniel P. Berrangé
> > ---
> > NEWS.rst | 17 +
> > 1 file changed, 17 insertions(+)
> >
> > diff --git
On Thu, Mar 20, 2025 at 14:57:48 +, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> Signed-off-by: Daniel P. Berrangé
> ---
> NEWS.rst | 17 +
> 1 file changed, 17 insertions(+)
Reviewed-by: Peter Krempa
On Thu, 2025-03-20 at 10:28 +, Daniel P. Berrangé wrote:
> On Thu, Mar 20, 2025 at 11:09:41AM +0100, Maximilian Immanuel
> Brandtner wrote:
> > On Thu, 2025-03-20 at 09:58 +, Daniel P. Berrangé wrote:
> > > On Thu, Mar 20, 2025 at 08:56:04AM +0100, Maximilian Immanuel
> > > Brandtner wrote:
On 3/20/25 17:07, Pavel Hrdina via Devel wrote:
Pavel Hrdina (6):
tools: remove --parallel from virsh restore command
tools: remote --parallel from virsh save command
qemu: remove VIR_DOMAIN_SAVE_PARALLEL flag
Heh, I'm having one of those "why did I not realize that" moments :-).
From: Pavel Hrdina
There is no need to have --parallel and --parallel-channels especially
when --parallel on its own is the same as not used at all. In both cases
libvirt will default to single channel.
Signed-off-by: Pavel Hrdina
---
docs/manpages/virsh.rst | 11 +--
tools/virsh-domai
Commits c2518f7bc7 and 28a0621528 introduced build failures on 32-bit
platforms by using incorrect format specifiers with g_strdup_printf.
In one case, an 'unsigned long' format specifier is used with a
'long long int' variable. Fix by changing the format specifier to
'uintmax_t', and casting the
Commit f0169f4d caused a build failure with CLang due to potentially
uninitialized variable
../src/qemu/qemu_migration_params.c:825:17: error: variable 'nchannels'
is used uninitialized whenever '&&' condition is false
[-Werror,-Wsometimes-uninitialized]
825 | if (params && virTypedP
From: Pavel Hrdina
There is no need to have --parallel and --parallel-channels especially
when --parallel on its own is the same as not used at all. In both cases
libvirt will default to single channel.
Signed-off-by: Pavel Hrdina
---
docs/manpages/virsh.rst | 8
tools/virsh-domain.c
Patches to fix the recent build failures caused by merging the mapped-ram
series. They get a green light from a CI run in my fork
https://gitlab.com/jfehlig/libvirt/-/pipelines/1727301916
I would push them as build-breakers, but the first one does raise a
question that should be answered beforeha
From: Pavel Hrdina
We should use the newest API only when user sets parallel-channels.
Signed-off-by: Pavel Hrdina
---
tools/virsh-domain.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index c21cf847c8..
From: Pavel Hrdina
There is no need to use extra flag in addition to the new
"parallel.channels" param.
Using the flag without param would result in using uninitialized
variable. Fixing it would result in error that parallel channels cannot
be less then 1 or setting 1 as default.
Using the para
On Thu, Mar 20, 2025 at 08:56:04AM +0100, Maximilian Immanuel Brandtner wrote:
> I've been working on an RFC patch-set to implement resizing for
> consoles in QEMU. Now that the patch-set is in review I've turned my
> attention to bringing this feature to libvirt.
Can you point to the QEMU patchse
On Thu, Mar 20, 2025 at 11:05:04AM +0100, Peter Krempa via Devel wrote:
>
> Libvirt supports console also for unix-socket backed chardevs. I presume
> that would require the QMP command approach instead. That will likely
> reuqire more plumbing because on the first glance we don't seem to
> have t
I've been working on an RFC patch-set to implement resizing for
consoles in QEMU. Now that the patch-set is in review I've turned my
attention to bringing this feature to libvirt.
With the QEMU patch-set there are two ways to resize a pty chardev.
1. send a TIOCSWINSZ ioctl
2. send a QMP msg
The
On Wed, Mar 19, 2025 at 05:09:01PM -0600, Jim Fehlig wrote:
> On 3/19/25 06:49, Daniel P. Berrangé wrote:
> > On Wed, Mar 05, 2025 at 03:48:17PM -0700, Jim Fehlig via Devel wrote:
> > > Move the code in qemuSaveImageCreate that opens, labels, and wraps the
> > > save image fd to a helper function,
On Thu, Mar 20, 2025 at 11:09:41AM +0100, Maximilian Immanuel Brandtner wrote:
> On Thu, 2025-03-20 at 09:58 +, Daniel P. Berrangé wrote:
> > On Thu, Mar 20, 2025 at 08:56:04AM +0100, Maximilian Immanuel
> > Brandtner wrote:
> > > I've been working on an RFC patch-set to implement resizing for
From: Martin Kletzander
In commit dbfb96d18c04 libvirt started connecting to the daemon to set
RDP credentials, but our configuration file did not allow connections
from the root user, so the connection failed and the VM failed to start.
In order to avoid such issue allow root to connect if the
On a Thursday in 2025, Collin Walling wrote:
From: David Judkovics
Add new virsh command 'hypervisor-cpu-models'. Command pulls from the
existing domcapabilities XML and uses xpath to parse CPU model strings.
By default, only models reported as usable by the hypervisor on the
host system are p
From: Peter Krempa
When the agent disappears after geting a proper command we ought to
report the same error code as if we timed out as it's uncertain whether
the guest agent did anything.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_agent.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(
From: Peter Krempa
As the guest agent code uses timeouts it is possible that we stop
waiting before the guest agent replies. If this happens while syncing
everything is okay because we didn't send any state-changing command.
In case when the timeout happens after a real command was transmitted
i
On Wed, Mar 19, 2025 at 03:00:47 +0100, Ján Tomko wrote:
> On a Tuesday in 2025, Peter Krempa via Devel wrote:
> > v9 of the throttle filtering series with my reviews and R-b tags
> > applied.
> >
> > Requires
> >
> > [PATCH 0/5] qemu: Two block job fixes
> > https://lists.libvirt.org/archives/li
From: Daniel P. Berrangé
Signed-off-by: Daniel P. Berrangé
---
NEWS.rst | 17 +
1 file changed, 17 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 98ca838642..45d48c1485 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -35,6 +35,23 @@ v11.2.0 (unreleased)
or even map them to s
From: Peter Krempa
Introduce a new special error code for guest agent commands.
The error code will be specifically reported only when an actual command
(not a sync) was issued to the guest agent and the timeout time was
reached.
This will allow users and management applications to differentiat
From: Peter Krempa
Signed-off-by: Peter Krempa
---
NEWS.rst | 10 ++
1 file changed, 10 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 98ca838642..b2f3415001 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -37,6 +37,16 @@ v11.2.0 (unreleased)
* **Improvements**
+ * qemu: Improved gue
From: Peter Krempa
In addition to the error constant appearing add docs hinting that this
new error code can be produced on timeouts.
The most relevant place is to do it when setting the timeout.
Signed-off-by: Peter Krempa
---
docs/manpages/virsh.rst | 3 +++
src/libvirt-domain.c| 4
From: Peter Krempa
Add a special error code for when the guest agent returned a failure
message.
Allow management applications to deterministically detect failure of the
guest agent command.
Signed-off-by: Peter Krempa
---
include/libvirt/virterror.h | 2 ++
src/util/virerror.c | 3 ++
29 matches
Mail list logo
