Re: [PATCH] virsh: Introduce new hypervisor-cpu-models command

2025-03-19 Thread Ján Tomko via Devel
On a Thursday in 2025, Collin Walling wrote: From: David Judkovics Add new virsh command 'hypervisor-cpu-models'. Command pulls from the existing domcapabilities XML and uses xpath to parse CPU model strings. By default, only models reported as usable by the hypervisor on the host system are p

[PATCH v9 16/17] virsh: Add support for throttle group operations

2025-03-19 Thread Peter Krempa via Devel
From: Chun Feng Wu Implement new throttle cmds * Add new virsh cmds: domthrottlegroupset, domthrottlegrouplist, domthrottlegroupinfo, domthrottlegroupdel * Add doc for new cmds at docs/manpages/virsh.rst * Add cmd helper "virshDomainThrottleGroupCompleter", which is used by domthrottlegroups

Re: [PATCH 0/5] qemu: Two block job fixes

2025-03-19 Thread Pavel Hrdina via Devel
On Mon, Mar 17, 2025 at 06:27:27PM +0100, Peter Krempa via Devel wrote: > Peter Krempa (5): > qemu: monitor: Wire up 'replaces' attribute for 'blockdev-mirror' > qemu: Do not replace filter nodes with virDomainBlockCopy > qemu: Remove return value from 'qemuHotplugRemoveManagedPR' > qemuDom

Re: [PATCH V4 11/18] qemu: Apply migration parameters in qemuMigrationDstRun

2025-03-19 Thread Jim Fehlig via Devel
On 3/19/25 09:45, Daniel P. Berrangé wrote: On Wed, Mar 05, 2025 at 03:48:20PM -0700, Jim Fehlig via Devel wrote: Similar to qemuMigrationSrcRun, apply migration parameters in qemuMigrationDstRun. This allows callers to create customized migration parameters, but delegates their application to t

Re: [PATCH V4 08/18] qemu: Add helper function for creating save image fd

2025-03-19 Thread Jim Fehlig via Devel
On 3/19/25 06:49, Daniel P. Berrangé wrote: On Wed, Mar 05, 2025 at 03:48:17PM -0700, Jim Fehlig via Devel wrote: Move the code in qemuSaveImageCreate that opens, labels, and wraps the save image fd to a helper function, providing more flexibility for upcoming mapped-ram support. Signed-off-by:

Re: [PATCH] virsh: Introduce new hypervisor-cpu-models command

2025-03-19 Thread Collin Walling
On 3/18/25 1:13 PM, Ján Tomko wrote: > On a Thursday in 2025, Collin Walling wrote: >> From: David Judkovics >> >> Add new virsh command 'hypervisor-cpu-models'. Command pulls from the >> existing domcapabilities XML and uses xpath to parse CPU model strings. >> By default, only models reported a

Re: [PATCH] virsh: Introduce new hypervisor-cpu-models command

2025-03-19 Thread Collin Walling
On 3/19/25 4:15 AM, Peter Krempa via Devel wrote: > On Tue, Mar 18, 2025 at 18:13:57 +0100, Ján Tomko via Devel wrote: >> On a Thursday in 2025, Collin Walling wrote: >>> From: David Judkovics >>> >>> Add new virsh command 'hypervisor-cpu-models'. Command pulls from the >>> existing domcapabiliti

[PATCH v2] virsh: Introduce new hypervisor-cpu-models command

2025-03-19 Thread Collin Walling
From: David Judkovics Add new virsh command 'hypervisor-cpu-models'. Command pulls from the existing domcapabilities XML and uses xpath to parse CPU model strings. By default, only models reported as usable by the hypervisor on the host system are printed. User may specify "--all" to also print

Re: [PATCH] virsh: Introduce new hypervisor-cpu-models command

2025-03-19 Thread Peter Krempa via Devel
On Tue, Mar 18, 2025 at 18:13:57 +0100, Ján Tomko via Devel wrote: > On a Thursday in 2025, Collin Walling wrote: > > From: David Judkovics > > > > Add new virsh command 'hypervisor-cpu-models'. Command pulls from the > > existing domcapabilities XML and uses xpath to parse CPU model strings. >

Re: [PATCH V4 01/18] lib: virDomain{Save,Restore}Params: Ensure absolute path

2025-03-19 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:10PM -0700, Jim Fehlig via Devel wrote: > When invoking virDomainSaveParams with a relative path, the image is > saved to the daemon's CWD. Similarly, when providing virDomainRestoreParams > with a relative path, it attempts to restore from the daemon's CWD. In most >

Re: [PATCH V4 08/18] qemu: Add helper function for creating save image fd

2025-03-19 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:17PM -0700, Jim Fehlig via Devel wrote: > Move the code in qemuSaveImageCreate that opens, labels, and wraps the > save image fd to a helper function, providing more flexibility for > upcoming mapped-ram support. > > Signed-off-by: Jim Fehlig > --- > src/qemu/qemu_s

Re: [PATCH V4 07/18] qemu_saveimage: add "sparse" to supported save image formats

2025-03-19 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:16PM -0700, Jim Fehlig via Devel wrote: > Extend the list of formats to include "sparse", which uses QEMU's mapped-ram > stream format [1] to write guest memory blocks at fixed offsets in the save > image file. > > [1] > https://gitlab.com/qemu-project/qemu/-/blob/ma

Re: [PATCH V4 18/18] tools: add parallel parameter to virsh restore command

2025-03-19 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:27PM -0700, Jim Fehlig via Devel wrote: > From: Claudio Fontana > > Signed-off-by: Claudio Fontana > Signed-off-by: Jim Fehlig > --- > docs/manpages/virsh.rst | 9 +++-- > tools/virsh-domain.c| 39 +++ > 2 files changed

Re: [PATCH V4 11/18] qemu: Apply migration parameters in qemuMigrationDstRun

2025-03-19 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:20PM -0700, Jim Fehlig via Devel wrote: > Similar to qemuMigrationSrcRun, apply migration parameters in > qemuMigrationDstRun. This allows callers to create customized > migration parameters, but delegates their application to the > function performing the migration. >

Re: [PATCH V4 12/18] qemu: Add support for mapped-ram on restore

2025-03-19 Thread Daniel P . Berrangé via Devel
On Wed, Mar 05, 2025 at 03:48:21PM -0700, Jim Fehlig via Devel wrote: > Add support for the mapped-ram migration capability on restore. > > Signed-off-by: Jim Fehlig > --- > src/qemu/qemu_driver.c| 27 +++--- > src/qemu/qemu_migration.c | 12 ++-- > src/qemu/qemu_