On Mon, Mar 17, 2025 at 10:24:54AM +, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> Most, but not all, files in scripts have execute permission. While we
> don't need this in order to launch them via meson/ninja build rules,
> it is nice to direct execution if they have e
On Mon, Mar 17, 2025 at 10:04:17AM +, Daniel P. Berrangé via Devel wrote:
> The glib adoption docs was suggesting avoidance of certain APIs that
> were obsoleted by glib, during the transition period. Now that the
> referenced APIs no longer exist in libvirt code, they can also be
> removed fro
On Mon, Mar 17, 2025 at 09:27:51AM -0400, Laine Stump wrote:
> On 3/17/25 7:29 AM, Jiri Denemark via Devel wrote:
> > On Mon, Mar 17, 2025 at 11:23:00 +, Daniel P. Berrangé via Devel wrote:
> > > From: Daniel P. Berrangé
> > >
> > > If a contributor's email domain has a DMARC policy of 'p=qua
On Fri, Mar 14, 2025 at 04:20:25PM +0100, Ján Tomko wrote:
On a Friday in 2025, Martin Kletzander wrote:
I've bisected it to 28d4703a1f12711ab180e72db08a83bae59941df which is
what I thought was the patch that changed the behaviour.
What is that commit?
Well, that's because you did not chec
From: Thomas Huth
Found with the codespell utility.
Signed-off-by: Thomas Huth
---
docs/formatcaps.rst| 2 +-
docs/formatdomain.rst | 4 ++--
docs/glib-adoption.rst | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/docs/formatcaps.rst b/docs/formatcaps.rst
index da6b2
The glib adoption docs was suggesting avoidance of certain APIs that
were obsoleted by glib, during the transition period. Now that the
referenced APIs no longer exist in libvirt code, they can also be
removed from the docs.
NB, the virStringListRemoveDuplicates method remains since there is
no gl
Original RFC:
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/U274MIGIYRGFTPCAPG237JH3P2EGCWIG/#IWFCKHLWHAOIJPJGYKJE7X666FODUM53
Changes since:
1) instead of overwriting the original `address` attribute, new attribute
(`guestAddress`) is invented so that both new and old
The aim off this event is to notify management application that
guest changed MAC address on one of its vNICs so the app can
update its internal records, e.g. for finding match between
guest/host view of vNICs.
Signed-off-by: Michal Privoznik
---
examples/c/misc/event-test.c| 14 +
i
So far, we only process NIC_RX_FILTER_CHANGED event when the
corresponding device has 'trustGuestRxFilters' enabled. And the
event is emitted only for virtio model. IOW, this is fairly
limited situation and other scenarios don't emit any event (e.g.
change of MAC address on a PCI passthrough device
From: Daniel P. Berrangé
If a contributor's email domain has a DMARC policy of 'p=quarantine'
or 'p=reject', mailman will apply DMARC countermeasures on all mails
sent to lists.libvirt.org rewriting the "From" header to remove the
sender's email address. e.g.
From: Your Name via
If these cou
On Mon, Mar 17, 2025 at 11:41:20AM +0100, Thomas Huth via Devel wrote:
From: Thomas Huth
Found with the codespell utility.
If you did that typo in the subject on purpose, then hat's off to you.
Anyway, before pushing it, s/types/typos/ please
Reviewed-by: Martin Kletzander
Signed-off-by
If a guest changes MAC address on its vNIC, then QEMU emits
NIC_RX_FILTER_CHANGED event (the event is emitted in other cases
too, but that's not important right now). Now, domain XML allows
users to chose whether to trust these events or not:
For the 'no' case no action is performed and the ev
On 3/17/25 12:29, Martin Kletzander via Devel wrote:
> On Mon, Mar 17, 2025 at 11:41:20AM +0100, Thomas Huth via Devel wrote:
>> From: Thomas Huth
>>
>> Found with the codespell utility.
>>
>
> If you did that typo in the subject on purpose, then hat's off to you.
> Anyway, before pushing it, s/t
From: Daniel P. Berrangé
Most, but not all, files in scripts have execute permission. While we
don't need this in order to launch them via meson/ninja build rules,
it is nice to direct execution if they have execution permission. This
makes the practice consistent across all scripts.
Signed-off-
On 17/03/2025 12.29, Martin Kletzander wrote:
On Mon, Mar 17, 2025 at 11:41:20AM +0100, Thomas Huth via Devel wrote:
From: Thomas Huth
Found with the codespell utility.
If you did that typo in the subject on purpose, then hat's off to you.
Anyway, before pushing it, s/types/typos/ please
On Fri, Mar 14, 2025 at 09:07:52AM +0100, Pavel Hrdina wrote:
On Mon, Mar 03, 2025 at 02:32:01PM +0100, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander
---
NEWS.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 9c940b1a8176..d7d40cf5546d 100644
--- a
On 3/14/25 12:51, Kirill Shchetiniuk wrote:
> During fixing some other issue found out a few minor bugs
> related to CH driver.
>
> First bug is related to monitor object ref count
> in virCHStartEventHandler and virCHEventHandlerLoop, as
> object was unrefed by parent while is still used by child
On Mon, Mar 17, 2025 at 12:28:48PM +0100, Michal Privoznik via Devel wrote:
If a guest changes MAC address on its vNIC, then QEMU emits
NIC_RX_FILTER_CHANGED event (the event is emitted in other cases
too, but that's not important right now). Now, domain XML allows
users to chose whether to trust
On Fri, Mar 14, 2025 at 12:50:45PM +0400, Marc-André Lureau wrote:
Hi
On Thu, Mar 13, 2025 at 4:58 PM Martin Kletzander wrote:
>> $ virsh start fedora39
>> error: Failed to start domain 'fedora39'
>> error: operation failed: Failed to connect to dbus-daemon: The connection is
closed
>
>Hmm, I
From: Peter Krempa
The block copy operation is supposed to just move the disk to a new
destination. While in certain scenarios it'd make sense to drop the
copy-on-read layer, the definition would not correspond to it.
This was caused by a fix to the behaviour of the block job after
conversion to
Peter Krempa (5):
qemu: monitor: Wire up 'replaces' attribute for 'blockdev-mirror'
qemu: Do not replace filter nodes with virDomainBlockCopy
qemu: Remove return value from 'qemuHotplugRemoveManagedPR'
qemuDomainChangeEjectableMedia: Separate rollback and success code
paths
qemuHotplu
From: Peter Krempa
The 'replaces' field controls which node will be replaced by the job.
This can be used to e.g. keep filter nodes in place after the copy
finishes.
This will be used to keep the 'copy-on-read' and 'throttle' layers in
place after a copy.
This patch wires up the monitor and tes
On Wed, Feb 19, 2025 at 22:27:04 +0530, Harikumar Rajkumar wrote:
> *** Support block disk along with throttle filters ***
>
> Chun Feng Wu (17):
> schema: Add new domain elements to support multiple throttle groups
> schema: Add new domain elements to support multiple throttle filters
> con
From: Peter Krempa
The only place which actually checked the return value would skip code
e.g. to delete unused files or stop no longer used services. The rest of
the callers ignored the value.
As this is expected to be used on cleanup code paths which have no
possibility to report errors we sho
From: Peter Krempa
Calls to 'qemuHotplugRemoveManagedPR' needed to be guarded by a check if
the removed elements actually caused us to add the manager in the first
place.
The two new calls added in commit 1697323bfe6000c2f5a2519c06f0ba81 were
not guarded by such check and thus would spam the deb
From: Peter Krempa
Do not use the rollback code path on success just to avoid extra call to
qemuHotplugRemoveManagedPR.
Rename the label and use it only when rolling back.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 37 +++--
1 file changed, 15 in
On Mon, Mar 17, 2025 at 12:28:50PM +0100, Michal Privoznik via Devel wrote:
So far, we only process NIC_RX_FILTER_CHANGED event when the
corresponding device has 'trustGuestRxFilters' enabled. And the
event is emitted only for virtio model. IOW, this is fairly
limited situation and other scenario
On Mon, Mar 17, 2025 at 11:23:00 +, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> If a contributor's email domain has a DMARC policy of 'p=quarantine'
> or 'p=reject', mailman will apply DMARC countermeasures on all mails
> sent to lists.libvirt.org rewriting the "From" h
On Mon, Mar 17, 2025 at 12:28:49PM +0100, Michal Privoznik via Devel wrote:
The aim off this event is to notify management application that
guest changed MAC address on one of its vNICs so the app can
update its internal records, e.g. for finding match between
guest/host view of vNICs.
Signed-of
On 3/17/25 7:29 AM, Jiri Denemark via Devel wrote:
On Mon, Mar 17, 2025 at 11:23:00 +, Daniel P. Berrangé via Devel wrote:
From: Daniel P. Berrangé
If a contributor's email domain has a DMARC policy of 'p=quarantine'
or 'p=reject', mailman will apply DMARC countermeasures on all mails
sent
On 3/17/25 2:49 AM, Collin Walling wrote:
> On 3/6/25 2:07 PM, Collin Walling wrote:
>
> Ping and adding Daniel et al on CC :)
>
Take-two. Apparently my CC list didn't take Daniel's email. Apologies.
--
Regards,
Collin
31 matches
Mail list logo
