[PATCH v3 00/20] Add qemu RDP server support

From: Marc-André Lureau Hi, This patch series offers an out-of-process Remote Desktop Protocol (RDP) server solution utilizing QEMU's -display dbus interface, offering improved modularity and potential security benefits compared to built-in server. This initiative was spearheaded by Mihnea Buza

[PATCH v3 01/20] build-sys: drop -Winline when optimization=g

From: Marc-André Lureau The warning is triggered when compiling with various build options, such as -Doptimization=g. >From gcc(1) man page about -Winline: seemingly insignificant changes in the source program can cause the warnings produced by -Winline to appear or disappear. Such flaky behav

[PATCH v3 02/20] build: fix -Werror=maybe-uninitialized

From: Marc-André Lureau When compiled with -Doptimization=g ../tools/nss/libvirt_nss_macs.c:155:8: error: ‘jerr’ may be used uninitialized [-Werror=maybe-uninitialized] 155 | if (jerr == json_tokener_continue) { |^ Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Be

[PATCH v3 05/20] qemu: add rdp state directory

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Reviewed-by: Martin Kletzander --- src/qemu/qemu_conf.c | 2 ++ src/qemu/qemu_conf.h | 1 + src/qemu/qemu_driver.c | 12 tests/testutilsqemu.c | 2 ++ 4 files changed, 17 insertions(+

[PATCH v3 04/20] util: annotate non-null arguments for virGDBusCallMethod()

From: Marc-André Lureau Helps avoid/debug a potential SEGV if conn is NULL, since gio will not set the "gerror" in that case and we will crash later at: virReportError(VIR_ERR_DBUS_SERVICE, "%s", gerror->message); Signed-off-by: Marc-André Lureau Reviewed-by: Martin Kletzander --- src/util/

[PATCH v3 03/20] qemu-slirp: drop unneeded check for OOM

From: Marc-André Lureau glib anti-pattern, since it aborts on OOM. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Reviewed-by: Martin Kletzander --- src/qemu/qemu_slirp.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/qemu/qemu_slirp.c b/src/qemu/qemu_slirp.c

[PATCH v3 09/20] qemu: use virDomainDefHasGraphics

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Reviewed-by: Martin Kletzander --- src/qemu/qemu_validate.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index ef217f

[PATCH v3 13/20] qemu/dbus: keep a connection to the VM D-Bus

From: Marc-André Lureau The following changes are going to communicate with the qemu-rdp server through the VM D-Bus bus, keep a connection for that and further usage. Signed-off-by: Marc-André Lureau Reviewed-by: Martin Kletzander --- src/qemu/qemu_dbus.c| 35

[PATCH v3 12/20] qemu/virtiofs: use domainLogContext

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Martin Kletzander --- src/qemu/qemu_virtiofs.c | 53 +--- 1 file changed, 12 insertions(+), 41 deletions(-) diff --git a/src/qemu/qemu_virtiofs.c b/src/qemu/qemu_virtiofs.c index dd3e0dd9

[PATCH v3 10/20] qemu: add RDP ports range allocator

From: Marc-André Lureau RDP server uses port 3389 by default. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Reviewed-by: Martin Kletzander --- src/qemu/qemu_conf.c | 6 ++ src/qemu/qemu_conf.h | 6 ++ src/qemu/qemu_driver.c | 8 3 files changed, 20 ins

[PATCH v3 11/20] qemu: limit to one

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Martin Kletzander --- src/qemu/qemu_command.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index ead2307ed7..84ff62cd6c 100644 --- a/src/qemu/q

[PATCH v3 18/20] qemu: add 'rdp' capability if qemu-rdp is available

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Martin Kletzander --- src/qemu/qemu_capabilities.c | 15 +++ src/qemu/qemu_capabilities.h | 3 ++- src/qemu/qemu_rdp.c | 11 +++ sr

[PATCH v3 19/20] qemu: add RDP support

From: Marc-André Lureau Wire the external server RDP support with QEMU. Check the configuration, allocate a port, start the process and set the credentials. Signed-off-by: Marc-André Lureau Reviewed-by: Martin Kletzander --- docs/formatdomain.rst | 25 +++--- src/conf/domain_conf.h|

[PATCH v3 06/20] qemu: add qemu RDP configuration

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Reviewed-by: Martin Kletzander --- src/qemu/libvirtd_qemu.aug | 7 ++ src/qemu/qemu.conf.in | 31 src/qemu/qemu_conf.c | 39 +++

[PATCH v3 08/20] conf: generalize virDomainDefHasSpiceGraphics

From: Marc-André Lureau Generalize the function, broaden its potential usage. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Reviewed-by: Martin Kletzander --- src/conf/domain_conf.c | 15 --- src/conf/domain_conf.h | 2 +- src/libvirt_private.syms | 2 +-

[PATCH v3 07/20] conf: parse optional RDP username & password

From: Marc-André Lureau Like VNC, allow to set credentials for RDP. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Reviewed-by: Martin Kletzander --- src/conf/domain_conf.c| 13 + src/conf/domain_conf.h| 2 ++ src/conf/schemas/domaincomm

[PATCH v3 16/20] qemu: add qemu-rdp helper unit

From: Marc-André Lureau Helpers to start the qemu-rdp server and set it up. Signed-off-by: Marc-André Lureau Reviewed-by: Martin Kletzander --- po/POTFILES| 1 + src/qemu/meson.build | 1 + src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain.h | 2 + src/qemu/qemu_rdp.c

[PATCH v3 17/20] qemu: pass virQEMUDriverConfig to capabilities

From: Marc-André Lureau This will help with the following patch, which also requires config access. Signed-off-by: Marc-André Lureau Reviewed-by: Martin Kletzander --- src/qemu/qemu_capabilities.c | 9 + src/qemu/qemu_capabilities.h | 9 + src/qemu/qemu_conf.c | 9

[PATCH v3 15/20] qemu: validate RDP configuration

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Reviewed-by: Martin Kletzander --- src/qemu/qemu_validate.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_vali

[PATCH v3 14/20] qemu/dbus: log daemon stdout/err, use domainLogContext

From: Marc-André Lureau Currently, if dbus-daemon writes on errfd, it will SIGPIPE. Signed-off-by: Marc-André Lureau Reviewed-by: Martin Kletzander --- src/qemu/qemu_dbus.c | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_d

[PATCH v3 20/20] tests: add qemu test

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Martin Kletzander --- .../graphics-rdp.x86_64-latest.args | 35 +++ .../graphics-rdp.x86_64-latest.xml| 1 + tests/qemuxmlconfdata/graphics-rdp.xml| 43 +++ tests/qe

Re: [PATCH] virsh: Introduce new hypervisor-cpu-models command

On 3/6/25 2:07 PM, Collin Walling wrote: Ping and adding Daniel et al on CC :) > From: David Judkovics > > Add new virsh command 'hypervisor-cpu-models'. Command pulls from the > existing domcapabilities XML and uses xpath to parse CPU model strings. > By default, only models reported as usabl