[libvirt PATCH 3/4] domain_conf: refactor virDomainLoaderDefFormatNvram

2025-03-15 Thread Pavel Hrdina
Use the new virXMLFormatDirect in order to remove usage of virXMLFormatInternal. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 94f456a362..0bcbf3

Re: [PATCH v2 17/21] qemu: add qemu-rdp helper unit

2025-03-15 Thread Marc-André Lureau
Hi On Fri, Mar 7, 2025 at 6:40 PM Martin Kletzander wrote: > > On Tue, Feb 18, 2025 at 02:16:22PM +0400, marcandre.lur...@redhat.com wrote: > >From: Marc-André Lureau > > > >Helpers to start the qemu-rdp server and set it up. > > > >Signed-off-by: Marc-André Lureau > >--- > > po/POTFILES

Re: [PATCH v2 00/21] Add qemu RDP server support

2025-03-15 Thread Martin Kletzander
On Thu, Mar 13, 2025 at 02:08:47PM +0400, Marc-André Lureau wrote: Hi On Thu, Mar 13, 2025 at 1:07 PM Martin Kletzander wrote: On Thu, Mar 13, 2025 at 11:59:41AM +0400, Marc-André Lureau wrote: >Hi > >On Tue, Mar 11, 2025 at 5:28 PM Martin Kletzander wrote: >> So I tried testing it and I fou

Re: [PATCH v8 15/18] test_driver: Test throttle group lifecycle APIs

2025-03-15 Thread Harikumar Rajkumar
Thanks for the update and for your efforts on the review. We understand your approach and we'll wait until it's completed.

Re: [PATCH] rpm: Enable KVM for riscv64 on RHEL 10+

2025-03-15 Thread Andrea Bolognani
On Fri, Mar 14, 2025 at 10:13:49AM +, Daniel P. Berrangé wrote: > On Fri, Mar 14, 2025 at 11:01:21AM +0100, Andrea Bolognani wrote: > > Signed-off-by: Andrea Bolognani > > --- > > libvirt.spec.in | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/libvirt.spec.in

[PATCH 14/16] qemu: block: Drop 'sheepdog' protocol support

2025-03-15 Thread Peter Krempa
As now no supported qemu version supports the 'sheepdog' protocol drop the code for configuring the blockdev layer. Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c | 44 ++- 1 file changed, 6 insertions(+), 38 deletions(-) diff --git a/src/qemu/qemu

Re: [PATCH 1/4] virpci: changed the work with PCI via libpciaccess

2025-03-15 Thread Martin Kletzander
On Wed, Feb 12, 2025 at 09:42:44AM +0300, Alexander Shursha wrote: Sponsored by: Future Crew, LLC Signed-off-by: Alexander Shursha Hi, thanks for your contribution, but please be aware of our contribution guidelines: https://libvirt.org/hacking.html and some pages linked from there: https:/

Re: [PATCH v1 0/3] Introduce qemuDomainSetVcpuTuneParameters API

2025-03-15 Thread Martin Kletzander
On Sat, Feb 15, 2025 at 04:35:50PM +0800, yong.hu...@smartx.com wrote: From: Hyman Huang This patchset is the prerequisite for the vCPU dirty-limit feature: https://patchew.org/Libvirt/cover.1703135535.git.yong.hu...@smartx.com/ Is the dirty limit migration strategy dependent on setting the

[PATCH v2 09/22] qemu: add config parameter to control auto-save bypass cache

2025-03-15 Thread Daniel P . Berrangé
When doing managed save of VMs, triggered by OS shutdown, it may be desirable to control cache usage. Reviewed-by: Peter Krempa Signed-off-by: Daniel P. Berrangé --- src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf.in | 8 src/qemu/qemu_conf.c | 3

Re: [PATCH 00/16] qemu: Bump minimum qemu to qemu-6.2.0 and clean up capabilities

2025-03-15 Thread Pavel Hrdina
On Mon, Mar 10, 2025 at 11:02:47AM +0100, Peter Krempa wrote: > Summary: > > This series was originally just meant to clean up non-release > capabilities but it grew since we dropped debian-11 and Michal asked me > to add dev-version for amdsev variant. > > Some of the long patches were truncated

Re: [PATCH 14/19] src: add constants for domain stats 'perf.' parameters

2025-03-15 Thread Peter Krempa
On Tue, Mar 04, 2025 at 14:04:09 +, Daniel P. Berrangé wrote: > Contrary to most APIs returning typed parameters, there are no constants > defined for the domain stats data keys. This is was because many of the > keys needs to be dynamically constructed using one or more array index > values. >

Re: [PATCH v2 05/22] qemu: support automatic VM managed save in system daemon

2025-03-15 Thread Daniel P . Berrangé
On Thu, Mar 13, 2025 at 01:31:41PM +0100, Pavel Hrdina wrote: > On Wed, Mar 12, 2025 at 05:17:45PM +, Daniel P. Berrangé wrote: > > Currently automatic VM managed save is only performed in session > > daemons, on desktop session close, or host OS shutdown request. > > > > With this change it i

Re: [PATCH] util: netdevvlan: Change return type of virNetDevVlanCopy to void

2025-03-15 Thread Martin Kletzander
On Wed, Jan 22, 2025 at 05:37:31PM +0300, Alexander Kuznetsov wrote: This function return value is invariant since 1022e0ee, so change its type and remove all dependent checks. Found by Linux Verification Center (linuxtesting.org) with Svace. Reported-by: Alexander Rudyuk Signed-off-by: Alexan

[libvirt PATCH 09/16] domain_conf: graphics: extract EGL-Headless formatting to separate function

2025-03-15 Thread Pavel Hrdina
virDomainGraphicsDefFormat function was way too long so split it into separate functions for each graphics type. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.