On Wed, Mar 12, 2025 at 17:17:45 +, Daniel P. Berrangé wrote:
> Currently automatic VM managed save is only performed in session
> daemons, on desktop session close, or host OS shutdown request.
>
> With this change it is possible to control shutdown behaviour for
> all daemons. A recommended
On Wed, Mar 12, 2025 at 05:17:45PM +, Daniel P. Berrangé wrote:
> Currently automatic VM managed save is only performed in session
> daemons, on desktop session close, or host OS shutdown request.
>
> With this change it is possible to control shutdown behaviour for
> all daemons. A recommende
On Wed, Mar 12, 2025 at 17:17:57 +, Daniel P. Berrangé wrote:
> Currently the remote daemon code is responsible for calling virStateStop
> in a background thread. The virNetDaemon code wants to synchronize with
> this during shutdown, however, so the virThreadPtr must be passed over.
>
> Even
On Wed, Mar 12, 2025 at 17:18:01 +, Daniel P. Berrangé wrote:
> The service unit "TimeoutStopSec" setting controls how long systemd
> waits for a service to stop before aggressively killing it, defaulting
> to 30 seconds if not set.
>
> When we're processing shutdown of VMs in response to OS s
On Wed, Mar 12, 2025 at 17:18:02 +, Daniel P. Berrangé wrote:
> Since processing running VMs on OS shutdown can take a while, it is
> beneficial to send systemd status messages about the progress.
>
> The systemd status is a point-in-time message, with no ability to
> look at the history of re
On Thu, Mar 13, 2025 at 15:26:52 +0100, Peter Krempa wrote:
> On Thu, Mar 13, 2025 at 14:44:35 +0100, Michal Privoznik wrote:
> > There are some members of the virCHDomainObjPrivate struct that
> > are allocated at various stages of domain lifecycle but then are
> > never freed:
> >
> > 1) cgroup
On Wed, Feb 19, 2025 at 22:27:15 +0530, Harikumar Rajkumar wrote:
> From: Chun Feng Wu
>
> For hot attaching/detaching
> * Leverage qemuBlockThrottleFiltersData to prepare attaching/detaching
> throttle filter data for qemuMonitorBlockdevAdd and qemuMonitorBlockdevDel
> * For hot attaching, wit
Also from qemuBuildGraphicsVNCCommandLine
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 4f0a9a517c..ef1ba9269c 100644
--- a/src/qemu/qemu_command.c
+++ b
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index ae187dac78..4f0a9a517c 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -1220,8 +1220,7 @@
No longer required since we don't require driver->privileged anymore.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_validate.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index 4ef944addb..af334aa96a 100644
--- a/src/qemu
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 4b178cac71..456df9ae0e 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -7296,8 +7296,7 @@ qem
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 65 ++---
1 file changed, 29 insertions(+), 36 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index e2e19743d8..ae187dac78 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/q
Signed-off-by: Ján Tomko
---
src/qemu/qemu_cgroup.c | 2 --
src/qemu/qemu_command.c | 6 +++---
src/qemu/qemu_driver.c | 1 -
src/qemu/qemu_hotplug.c | 1 -
src/qemu/qemu_monitor_json.c | 1 -
src/security/security_apparmor.c | 1 -
src/vmx/vmx.c
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index ef1ba9269c..4b178cac71 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -1964,8 +19
On Wed, Feb 19, 2025 at 22:27:16 +0530, Harikumar Rajkumar wrote:
> From: Chun Feng Wu
>
> Refactor iotune verification, and verify some rules
>
> * Disk iotune validation can be reused for throttle group validation,
> refactor it into common method "virDomainDiskIoTuneValidate"
> * Add "virDo
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 0b618e5c88..92560d381f 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -9681,7 +9681,7 @@ qemu
On Wed, Mar 12, 2025 at 17:18:00 +, Daniel P. Berrangé wrote:
> The daemons are wired up to shutdown in responsible to UNIX process
> signals, as well as in response to login1 dbus signals, or loss of
> desktop session. The latter two options can optionally preserve state
> (ie running VMs).
>
On Wed, Mar 12, 2025 at 17:17:51 +, Daniel P. Berrangé wrote:
> This is maintained in the same way as the autostart flag, using a
> symlink. The difference is that instead of '.xml', the symlink
> suffix is '.xml.once'. The link is also deleted immediately after
> it has been read.
The last se
Patches 4-9/10 all depend on patch 3/10
10/10 can be pushed independently
Ján Tomko (10):
qemu: seccomp sandbox: remove incorect G_GNUC_UNUSED marker
qemu: validate: fs: remove unneeded parameter
qemu: remove qemuCaps from qemuBuildObjectCommandlineFromJSON
qemu: remove qemuCaps from qemuB
qemuCaps is obviously used.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 51e428e017..e2e19743d8 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@
On Wed, Feb 19, 2025 at 22:27:13 +0530, Harikumar Rajkumar wrote:
> From: Chun Feng Wu
>
> ThrottleGroup lifecycle implementation, note, in QOM, throttlegroup name is
> prefixed with
> "throttle-" to clearly separate throttle group objects into their own
> namespace.
> * "qemuDomainSetThrottleG
On Wed, Feb 19, 2025 at 22:27:19 +0530, Harikumar Rajkumar wrote:
> From: Chun Feng Wu
>
> Test throttle group APIs
>
> * Extract common methods for both "testDomainSetThrottleGroup" and
> "testDomainSetBlockIoTune":
> testDomainValidateBlockIoTune, testDomainSetBlockIoTuneFields,
> testDomain
On Thu, Mar 13, 2025 at 16:30:18 +0100, Ján Tomko wrote:
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_command.c | 9 +++--
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index ae187dac78..4f0a9a517c 100644
> --- a/sr
On Thu, Mar 13, 2025 at 04:30:14PM +0100, Ján Tomko wrote:
Patches 4-9/10 all depend on patch 3/10
10/10 can be pushed independently
Ján Tomko (10):
qemu: seccomp sandbox: remove incorect G_GNUC_UNUSED marker
qemu: validate: fs: remove unneeded parameter
qemu: remove qemuCaps from qemuBuildOb
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 456df9ae0e..0b618e5c88 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -9643,8 +9643,7 @@ qem
Introduce a new ninja target
ninja -C build regen-{PROTO}
eg
ninja -C build regen-admin_protocol
that will re-create the reference output file based on what the
current pdwtags command emits. A small change is made to squash
whitespace on enum declarations so that introducing a new longer
On Thu, Mar 13, 2025 at 16:30:14 +0100, Ján Tomko wrote:
> Patches 4-9/10 all depend on patch 3/10
> 10/10 can be pushed independently
>
> Ján Tomko (10):
> qemu: seccomp sandbox: remove incorect G_GNUC_UNUSED marker
> qemu: validate: fs: remove unneeded parameter
> qemu: remove qemuCaps fro
This introduces a new target:
ninja -C build regen-admin_protocol
and equiv for other protocol files
Daniel P. Berrangé (2):
src: normalize whitespace in protocol structs files
src: add new target for regenerating protocol structs files
scripts/check-remote-protocol.py | 27 +++
This makes the output match what current pdwtags will emit,
modulo some whitespace changes made by the check script
before comparison.
Signed-off-by: Daniel P. Berrangé
---
src/admin_protocol-structs | 2 +-
src/qemu_protocol-structs | 2 +-
src/remote_protocol-structs | 6 +++---
3 files cha
On Thu, Mar 13, 2025 at 04:52:13PM +0100, Martin Kletzander wrote:
> On Thu, Mar 13, 2025 at 04:30:14PM +0100, Ján Tomko wrote:
> > Patches 4-9/10 all depend on patch 3/10
> > 10/10 can be pushed independently
> >
> > Ján Tomko (10):
> > qemu: seccomp sandbox: remove incorect G_GNUC_UNUSED marker
On Thu, Mar 13, 2025 at 14:44:37 +0100, Michal Privoznik wrote:
> At the beginning of virCHProcessStop() the ref to driver config
> is obtained (via virCHDriverGetConfig()), but corresponding unref
> call is lacking. Use g_autoptr() to make sure the config is
> unrefed always.
>
> Signed-off-by: M
On Thu, Mar 13, 2025 at 14:44:35 +0100, Michal Privoznik wrote:
> There are some members of the virCHDomainObjPrivate struct that
> are allocated at various stages of domain lifecycle but then are
> never freed:
>
> 1) cgroup - allocated in virDomainCgroupSetupCgroup()
> 2) autoCpuset - this one i
On a Wednesday in 2025, Peter Krempa wrote:
The QAPIfication of objects removed the extra warapper object which we
wrapper
were adding in the monitor code to simplify the other callers.
Now that we support only qemus which don't require this we can drop the
support code.
Signed-off-by: Pete
On a Wednesday in 2025, Peter Krempa wrote:
'blockdev-reopen' is supported since qemu-6.1, thus we can now remove
the interlocks.
Document the change to 'mirror' as this patch removes the last clue why
we overwrite the mirror's readonly state to false unconditionally.
Signed-off-by: Peter Kremp
On Thu, Mar 13, 2025 at 14:44:36 +0100, Michal Privoznik wrote:
> When the CH driver starts a domain virCHProcessSetupIOThreads()
> is called eventually which in turn calls
> virCHMonitorGetIOThreads(). The latter returns an array of
> iothreads which is never freed leading to a memleak:
>
> 130 (
On Thu, Mar 13, 2025 at 14:44:34 +0100, Michal Privoznik wrote:
> There are two places where curl_slist_append() is called but
> corresponding call to curl_slist_free_all() is missing:
> virCHMonitorPutNoContent() and virCHMonitorGet() which leads to
> memleaks:
>
> 41 (16 direct, 25 indirect) byt
On a Wednesday in 2025, Peter Krempa wrote:
The recent bump of minimum qemu version resulted into some capabilities
always being present. I've noticed one while doing a review and from
there I removed a few others, mostly storage related ones as well.
Peter Krempa (17):
qemuBuildCompatDeprecate
On Thu, Mar 13, 2025 at 14:44:38 +0100, Michal Privoznik wrote:
> Firstly, let's switch from explicit virCHDriverGetConfig() +
> virObjectUnref() combo to g_autoptr(virCHDriverConfig). This
> leaves us with the @monitor variable which is initialized to NULL
> only to be then set to the retval of vi
On Thu, Mar 13, 2025 at 02:08:47PM +0400, Marc-André Lureau wrote:
Hi
On Thu, Mar 13, 2025 at 1:07 PM Martin Kletzander wrote:
On Thu, Mar 13, 2025 at 11:59:41AM +0400, Marc-André Lureau wrote:
>Hi
>
>On Tue, Mar 11, 2025 at 5:28 PM Martin Kletzander wrote:
>> So I tried testing it and I fou
On Wed, Mar 12, 2025 at 17:17:50 +, Daniel P. Berrangé wrote:
> When a domain is marked for autostart, it will be started on every
> subsequent host OS boot. There may be times when it is desirable to
> mark a domain to be autostarted, on the next boot only.
>
> Thus we add virDomainSetAutosta
On Wed, Mar 12, 2025 at 17:17:56 +, Daniel P. Berrangé wrote:
> The next patch will be introducing a new callback, so rename the method
> to virNetDaemonSetLifecycleCallbacks to reflect the more general usage.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> src/libvirt_remote.syms| 2 +-
>
On Wed, Mar 12, 2025 at 17:17:55 +, Daniel P. Berrangé wrote:
> It is not documented what the various virStateNNN methods are each
> responsible for doing and the names give little guidance either.
> Provide some useful documentation comments to explain the intended
> usage of each.
>
> Signed
On Wed, Mar 12, 2025 at 17:17:59 +, Daniel P. Berrangé wrote:
> The preserving of state (ie running VMs) requires a fully functional
> daemon and hypervisor driver. If any part has started shutting down
> then saving state may fail, or worse, hang.
>
> The current shutdown sequence does not gu
On Thu, Mar 13, 2025 at 03:57:36PM +, Daniel P. Berrangé wrote:
This makes the output match what current pdwtags will emit,
modulo some whitespace changes made by the check script
before comparison.
Signed-off-by: Daniel P. Berrangé
Reviewed-by: Martin Kletzander
signature.asc
Descript
On Thu, Mar 13, 2025 at 03:57:37PM +, Daniel P. Berrangé wrote:
Introduce a new ninja target
ninja -C build regen-{PROTO}
eg
ninja -C build regen-admin_protocol
that will re-create the reference output file based on what the
current pdwtags command emits. A small change is made to squ
On Thu, Mar 13, 2025 at 03:59:07PM +, Daniel P. Berrangé wrote:
On Thu, Mar 13, 2025 at 04:52:13PM +0100, Martin Kletzander wrote:
On Thu, Mar 13, 2025 at 04:30:14PM +0100, Ján Tomko wrote:
> Patches 4-9/10 all depend on patch 3/10
> 10/10 can be pushed independently
>
> Ján Tomko (10):
> q
*** BLURB HERE ***
Michal Prívozník (6):
network: Free inhibitor in networkStateCleanup()
ch: Free retval of curl_slist_append()
ch: Don't leak virCHDomainObjPrivate struct members
ch: Free @iothreads array in virCHProcessSetupIOThreads()
ch: Unref @cfg in virCHProcessStop()
ch: Rework
The shutdown inhibitor is created in networkStateInitialize() but
corresponding call to virInhibitorFree() is missing in
networkStateCleanup() leading to a memleak:
116 (72 direct, 44 indirect) bytes in 1 blocks are definitely lost in loss
record 1,769 of 1,998
at 0x484CEF3: calloc (vg_replace
There are two places where curl_slist_append() is called but
corresponding call to curl_slist_free_all() is missing:
virCHMonitorPutNoContent() and virCHMonitorGet() which leads to
memleaks:
41 (16 direct, 25 indirect) bytes in 1 blocks are definitely lost in loss
record 992 of 1,998
at 0x4845
At the beginning of virCHProcessStop() the ref to driver config
is obtained (via virCHDriverGetConfig()), but corresponding unref
call is lacking. Use g_autoptr() to make sure the config is
unrefed always.
Signed-off-by: Michal Privoznik
---
src/ch/ch_process.c | 2 +-
1 file changed, 1 insertio
When the CH driver starts a domain virCHProcessSetupIOThreads()
is called eventually which in turn calls
virCHMonitorGetIOThreads(). The latter returns an array of
iothreads which is never freed leading to a memleak:
130 (104 direct, 26 indirect) bytes in 1 blocks are definitely lost in loss
reco
Firstly, let's switch from explicit virCHDriverGetConfig() +
virObjectUnref() combo to g_autoptr(virCHDriverConfig). This
leaves us with the @monitor variable which is initialized to NULL
only to be then set to the retval of virCHMonitorNew() and
returned instantly. Well, the variable is now useles
On Thu, Mar 13, 2025 at 14:44:33 +0100, Michal Privoznik wrote:
> The shutdown inhibitor is created in networkStateInitialize() but
> corresponding call to virInhibitorFree() is missing in
> networkStateCleanup() leading to a memleak:
good that it's a "singleton"
>
> 116 (72 direct, 44 indirect)
On Wed, Feb 19, 2025 at 22:27:17 +0530, Harikumar Rajkumar wrote:
> From: Chun Feng Wu
>
> * Add tests for throttlegroup domain xml processing, including
> groups referenced and not referenced by filters
> * Add tests for throttlefilter domain xml processing, including
> throttle group referenced
There are some members of the virCHDomainObjPrivate struct that
are allocated at various stages of domain lifecycle but then are
never freed:
1) cgroup - allocated in virDomainCgroupSetupCgroup()
2) autoCpuset - this one is actually never allocated (and thus is
always NULL, but soo
Hi All,
Any comments on this addition to NEWS?
Regards,
Jim
On 3/3/25 11:34, Jim Fehlig wrote:
Signed-off-by: Jim Fehlig
---
NEWS.rst | 8
1 file changed, 8 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 9c940b1a81..d08a18dc02 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -17,6 +
On Thu, Mar 13, 2025 at 16:30:19 +0100, Ján Tomko wrote:
> Also from qemuBuildGraphicsVNCCommandLine
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_command.c | 11 ---
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.
Hi Will,
Thanks for the patch! Looks good. I only have some minor comments.
On 3/4/25 02:11, Will wrote:
Adds support for configuring flags for domains
running under Xen.
The following flags, making use of QEMU's existing flags, are now
configurable for Xen: vapic, synic, stimer, frequencies,
Hi All,
Does anyone have time to review this series? QEMU has supported mapped-ram for a
few releases now. Adding support in libvirt allows us to build parallel
save/restore on top. Would be a nice feature for the next release :-).
Regards,
Jim
On 3/5/25 15:48, Jim Fehlig wrote:
V4 series a
On Thu, Mar 13, 2025 at 11:59:41AM +0400, Marc-André Lureau wrote:
Hi
On Tue, Mar 11, 2025 at 5:28 PM Martin Kletzander wrote:
So I tried testing it and I found a couple of issues. Those might be on
my side, maybe caused by misunderstanding of it all. First of all
fails with these patches f
On Thu, Mar 13, 2025 at 09:00:58AM +0100, Peter Krempa wrote:
> On Wed, Mar 12, 2025 at 17:17:43 +, Daniel P. Berrangé wrote:
> > The auto shutdown code can currently only perform managed save,
> > which may fail in some cases, for example when PCI devices are
> > assigned. On failure, shutdown
* Thomas Huth (th...@redhat.com) wrote:
> On 09/03/2025 19.55, Pierrick Bouvier wrote:
> > On 6/3/24 05:18, Daniel P. Berrangé wrote:
> > > On Fri, May 31, 2024 at 06:47:45AM +0200, Thomas Huth wrote:
> > > > On 30/05/2024 09.45, Philippe Mathieu-Daudé wrote:
> > > > > We are trying to unify all qe
On Thu, 6 Mar 2025 13:51:35 +0100
Anthony Harivel wrote:
> Hi,
>
> The enhancement in this new version based on last feedback are:
>
> * add more documentation on limitation of the feature
> * no more double check of the vmsr socket, once is enough
> * virQEMUBuildBufferEscapeComma() is used f
On Thu, Mar 13, 2025 at 12:13:44AM +0400, Marc-André Lureau wrote:
Hi
On Fri, Mar 7, 2025 at 6:40 PM Martin Kletzander wrote:
On Tue, Feb 18, 2025 at 02:16:22PM +0400, marcandre.lur...@redhat.com wrote:
>From: Marc-André Lureau
>
>Helpers to start the qemu-rdp server and set it up.
>
>Signed
On Thu, Mar 13, 2025 at 12:18:04AM +0400, Marc-André Lureau wrote:
Hi
On Fri, Mar 7, 2025 at 7:03 PM Martin Kletzander wrote:
On Tue, Feb 18, 2025 at 02:16:25PM +0400, marcandre.lur...@redhat.com wrote:
>From: Marc-André Lureau
>
>Wire the external server RDP support with QEMU.
>
>Check the
Hi
On Tue, Mar 11, 2025 at 5:28 PM Martin Kletzander wrote:
> So I tried testing it and I found a couple of issues. Those might be on
> my side, maybe caused by misunderstanding of it all. First of all
> fails with these patches for me even without
How does it fail? (it works on my end)
> .
On Wed, Mar 12, 2025 at 17:17:43 +, Daniel P. Berrangé wrote:
> The auto shutdown code can currently only perform managed save,
> which may fail in some cases, for example when PCI devices are
> assigned. On failure, shutdown inhibitors remain in place which
> may be undesirable.
>
> This expa
Hi
On Thu, Mar 13, 2025 at 1:07 PM Martin Kletzander wrote:
>
> On Thu, Mar 13, 2025 at 11:59:41AM +0400, Marc-André Lureau wrote:
> >Hi
> >
> >On Tue, Mar 11, 2025 at 5:28 PM Martin Kletzander
> >wrote:
> >> So I tried testing it and I found a couple of issues. Those might be on
> >> my side,
On Wed, Mar 12, 2025 at 17:17:44 +, Daniel P. Berrangé wrote:
> It may be desirable to treat transient VMs differently from persistent
> VMs. For example, while performing managed save on persistent VMs makes
> sense, the same not usually true of transient VMs, since by their
> nature they will
On Thu, Mar 13, 2025 at 12:18:28PM +0100, Peter Krempa wrote:
> On Wed, Mar 12, 2025 at 17:17:44 +, Daniel P. Berrangé wrote:
> > It may be desirable to treat transient VMs differently from persistent
> > VMs. For example, while performing managed save on persistent VMs makes
> > sense, the sam
70 matches
Mail list logo
