Re: [PATCH 2/3] tests: add capabilities for QEMU 9.2.0 on s390x

2025-03-11 Thread Boris Fiuczynski
On 3/7/25 15:57, Peter Krempa wrote: On Thu, Nov 07, 2024 at 17:44:05 +0100, Boris Fiuczynski wrote: On 11/7/24 17:19, Peter Krempa wrote: On Wed, Nov 06, 2024 at 15:31:56 +0100, Boris Fiuczynski wrote: Let us introduce the xml and reply files for QEMU 9.2.0 on s390x. [...] Additionally if

Re: [PATCH v1 2/3] qemu_driver: Implement qemuDomainSetVcpuTuneParameters

2025-03-11 Thread Yong Huang
On Thu, Mar 6, 2025 at 11:57 PM Peter Krempa wrote: > On Sat, Feb 15, 2025 at 16:35:52 +0800, yong.hu...@smartx.com wrote: > > From: Hyman Huang > > > > Support hotplug/hotunplug of virtual CPU by wrapping the > > existing interface qemuDomainSetVcpu. > > > > Signed-off-by: Hyman Huang > > ---

Re: [PATCH v1] tests: update capabilities for QEMU 9.2.0 on s390x

2025-03-11 Thread Peter Krempa
On Tue, Mar 11, 2025 at 13:49:10 +0100, Shalini Chellathurai Saroja wrote: > Update the replies and xml files for QEMU 9.2.0 on s390x based on > the released QEMU tag v9.2.0 with commit Id > ae35f033b874c627d81d51070187fbf55f0bf1a7. > > Signed-off-by: Shalini Chellathurai Saroja > Reviewed-by: Bo

Re: [PATCH] security: Don't stop restoring labels too early

2025-03-11 Thread Peter Krempa
On Tue, Mar 11, 2025 at 13:56:44 +0100, Michal Privoznik wrote: > The point of virSecurityManagerRestoreAllLabel() function is to > restore ALL labels and be tolerant to possible errors, i.e. > continue restoring seclabels and NOT return early. > > Well, in two implementations of this internal API

Re: [PATCH 11/19] src: add constants for domain stats 'vcpu.' parameters

2025-03-11 Thread Peter Krempa
On Tue, Mar 11, 2025 at 14:01:38 +, Daniel P. Berrangé wrote: > On Thu, Mar 06, 2025 at 03:43:18PM +0100, Peter Krempa wrote: > > On Tue, Mar 04, 2025 at 14:04:06 +, Daniel P. Berrangé wrote: > > > Contrary to most APIs returning typed parameters, there are no constants > > > defined for th

[PATCH v2 07/23] src: add constants for guest info 'if.' parameters

2025-03-11 Thread Daniel P . Berrangé
Contrary to most APIs returning typed parameters, there are no constants defined for the guest info data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array inde

[PATCH v2 16/23] src: add constants for domain stats 'block.' parameters

2025-03-11 Thread Daniel P . Berrangé
Contrary to most APIs returning typed parameters, there are no constants defined for the domain stats data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array in

[PATCH v2 15/23] src: add constants for domain stats 'net.' parameters

2025-03-11 Thread Daniel P . Berrangé
Contrary to most APIs returning typed parameters, there are no constants defined for the domain stats data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array in

[PATCH v2 00/23] Add typed param constants for guest info and domain stats APIs

2025-03-11 Thread Daniel P . Berrangé
Contrary to most APIs returning typed parameters, there are no constants defined for the domain stats data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array in

[PATCH v2 01/23] src: add constants for guest info 'user.' parameters

2025-03-11 Thread Daniel P . Berrangé
Contrary to most APIs returning typed parameters, there are no constants defined for the guest info data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array inde

Re: [PATCH 2/3] qemu: Replace usb-storage with usb-bot

2025-03-11 Thread Daniel P . Berrangé
On Mon, Mar 10, 2025 at 10:10:53AM +0100, Peter Krempa wrote: > On Mon, Mar 10, 2025 at 09:05:28 +, Daniel P. Berrangé wrote: > > On Sat, Mar 08, 2025 at 02:57:41PM +0900, Akihiko Odaki wrote: > > > usb-storage is a compound device that automatically creates a USB mass > > > storage device and

[PATCH 1/3] qemuxmlconftest: Include shared memory 'net-vhostuser' test cases

2025-03-11 Thread Peter Krempa
The vhost-user protocol requires shared memory support to work properly. Our test XMLs didn't have it configured as for interface the check if shared memory is present only produces a warning instead of a proper error. Upcoming patches will be moving the check to become fatal so the test cases ne

[PATCH 3/3] qemu: process: Remove un-updated 'qemuProcessStartWarnShmem'

2025-03-11 Thread Peter Krempa
The checks in qemuProcessStartWarnShmem are no longer current. Since previous patch made it fatal for vhost-user interfaces to be configured without shared memory this warning code can be deleted. Resolves: https://issues.redhat.com/browse/RHEL-80533 Signed-off-by: Peter Krempa --- src/qemu/qemu

[PATCH 2/3] qemuDomainGetLaunchSecurityInfo: Use virTypedParamList to construct return value

2025-03-11 Thread Peter Krempa
Simplify the code by using the modern helpers. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 42 ++ 1 file changed, 14 insertions(+), 28 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 45bb3c09aa..a40db1dd2e 1006

[PATCH 1/3] qemuDomainGetLaunchSecurityInfo: Don't forget unlock VM object on (impossible) error

2025-03-11 Thread Peter Krempa
If 'vm->def->sec->sectype' would be invalid; which is currently not possible; we'd not unlock the domain object. Fix the logic even when the bug currently can't happen. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/

[PATCH 0/3] qemu: Refactor typed parameter list construction in SEV apis

2025-03-11 Thread Peter Krempa
Peter Krempa (3): qemuDomainGetLaunchSecurityInfo: Don't forget unlock VM object on (impossible) error qemuDomainGetLaunchSecurityInfo: Use virTypedParamList to construct return value qemuNodeGetSEVInfo: Use virTypedParamList to construct return value src/qemu/qemu_driver.c | 107 ++

[PATCH 3/3] qemuNodeGetSEVInfo: Use virTypedParamList to construct return value

2025-03-11 Thread Peter Krempa
Simplify the code by using the modern helpers. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 63 +++--- 1 file changed, 16 insertions(+), 47 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a40db1dd2e..2cabc7ee2f 1006

[PATCH v2 10/23] src: expand docs for guest info constant version handling

2025-03-11 Thread Daniel P . Berrangé
Explain that the 11.2.0 release dates are mostly reflecting when the constant was first added, not when the key was introduced. Signed-off-by: Daniel P. Berrangé --- src/libvirt-domain.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index

Re: [PATCH v2 02/11] virXMLNodeGetSubelementList: Document return value semantics

2025-03-11 Thread Ján Tomko
On a Monday in 2025, Peter Krempa wrote: The returned value is always non-NULL. Callers need to check the lenght length of the returned array instead. Signed-off-by: Peter Krempa --- src/util/virxml.c | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc De

Re: [PATCH v2 03/11] virDomainIothreadMappingDefParse: Fix usage of virXMLNodeGetSubelementList

2025-03-11 Thread Ján Tomko
On a Monday in 2025, Peter Krempa wrote: virXMLNodeGetSubelementList always returns a non-NULL pointers thus we should check the lenght instead. *length Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) Reviewed-by: Ján To

Re: [PATCH v2 04/11] docs: formatdomain: Clarify configuration of iothread <-> virtqueue mapping

2025-03-11 Thread Ján Tomko
On a Monday in 2025, Peter Krempa wrote: Add an example for the automatic/round-robin mapping of iothreads which users should preferrably use. Until now the example contained even the full mapping which could push users to use that instead. Mention that the queues are then automatically distribu

[PATCH] security: Don't stop restoring labels too early

2025-03-11 Thread Michal Privoznik
The point of virSecurityManagerRestoreAllLabel() function is to restore ALL labels and be tolerant to possible errors, i.e. continue restoring seclabels and NOT return early. Well, in two implementations of this internal API this type of problem was found: 1) virSecurityDACRestoreAllLabel() retur

[PATCH v2 11/23] src: add constants for domain stats 'state.' parameters

2025-03-11 Thread Daniel P . Berrangé
Contrary to most APIs returning typed parameters, there are no constants defined for the domain stats data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array in

Re: [PATCH 1/3] qemuDomainGetLaunchSecurityInfo: Don't forget unlock VM object on (impossible) error

2025-03-11 Thread Michal Prívozník
On 3/11/25 12:59, Peter Krempa wrote: > If 'vm->def->sec->sectype' would be invalid; which is currently not > possible; we'd not unlock the domain object. Fix the logic even when the > bug currently can't happen. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_driver.c | 2 +- > 1 file cha

Re: [PATCH v2 01/23] src: add constants for guest info 'user.' parameters

2025-03-11 Thread Peter Krempa
On Tue, Mar 11, 2025 at 14:24:07 +, Daniel P. Berrangé wrote: > Contrary to most APIs returning typed parameters, there are no constants > defined for the guest info data keys. This is was because many of the > keys needs to be dynamically constructed using one or more array index > values. >

Re: [PATCH v2 02/23] src: add constants for guest info 'os.' parameters

2025-03-11 Thread Peter Krempa
On Tue, Mar 11, 2025 at 14:24:08 +, Daniel P. Berrangé wrote: > Contrary to most APIs returning typed parameters, there are no constants > defined for the guest info data keys. This is was because many of the > keys needs to be dynamically constructed using one or more array index > values. >

Re: [PATCH v2 03/23] src: add constants for guest info 'timezone.' parameters

2025-03-11 Thread Peter Krempa
On Tue, Mar 11, 2025 at 14:24:09 +, Daniel P. Berrangé wrote: > Contrary to most APIs returning typed parameters, there are no constants > defined for the guest info data keys. This is was because many of the > keys needs to be dynamically constructed using one or more array index > values. >

Re: [PATCH v2 04/23] src: add constant for the guest info 'hostname' parameter

2025-03-11 Thread Peter Krempa
On Tue, Mar 11, 2025 at 14:24:10 +, Daniel P. Berrangé wrote: > Contrary to most APIs returning typed parameters, there are no constants > defined for the guest info data keys. This is was because many of the > keys needs to be dynamically constructed using one or more array index > values. >

Re: [PATCH v2 05/23] src: add constants for guest info 'fs.' parameters

2025-03-11 Thread Peter Krempa
On Tue, Mar 11, 2025 at 14:24:11 +, Daniel P. Berrangé wrote: > Contrary to most APIs returning typed parameters, there are no constants > defined for the guest info data keys. This is was because many of the > keys needs to be dynamically constructed using one or more array index > values. >

[PATCH] esx: Refactor esxVI_LookupHostScsiTopologyLunListByTargetName

2025-03-11 Thread Jiri Denemark
With a specific combination of compiler options gcc reported the following bogus warning (I added a context to it to make the issue visible): ../src/esx/esx_vi.c: In function ‘esxVI_LookupHostScsiTopologyLunListByTargetName’: ../src/esx/esx_vi.c:4674:32: error: potential null pointer dereference

[PATCH 0/3] qemu: fix shared memory validation for vhost-user interfaces

2025-03-11 Thread Peter Krempa
Use the common check which produces hard errors instead of the post-start check adding a warning which wasn't updated with the new logic. Peter Krempa (3): qemuxmlconftest: Include shared memory 'net-vhostuser' test cases qemuValidateDomainDeviceDefNetwork: Require shared memory for all vh

Re: [PATCH 0/3] qemu: fix shared memory validation for vhost-user interfaces

2025-03-11 Thread Michal Prívozník
On 3/11/25 09:12, Peter Krempa wrote: > Use the common check which produces hard errors instead of the > post-start check adding a warning which wasn't updated with the new > logic. > > Peter Krempa (3): > qemuxmlconftest: Include shared memory 'net-vhostuser' test cases > qemuValidateDomainDe

Re: [PATCH] esx: Refactor esxVI_LookupHostScsiTopologyLunListByTargetName

2025-03-11 Thread Peter Krempa
On Tue, Mar 11, 2025 at 11:48:41 +0100, Jiri Denemark wrote: > With a specific combination of compiler options gcc reported the > following bogus warning (I added a context to it to make the issue > visible): > > ../src/esx/esx_vi.c: In function > ‘esxVI_LookupHostScsiTopologyLunListByTargetName’

[PATCH] docs: Correct dbus graphics' accepted p2p values

2025-03-11 Thread Martin Kletzander
The attribute is used (and formatted) as virTristateBool() and even in schema defined as virYesNo, so the values are supposed to be `yes` and `no`. Signed-off-by: Martin Kletzander --- docs/formatdomain.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.rst

Re: [PATCH 0/3] qemu: Refactor typed parameter list construction in SEV apis

2025-03-11 Thread Michal Prívozník
On 3/11/25 12:59, Peter Krempa wrote: > Peter Krempa (3): > qemuDomainGetLaunchSecurityInfo: Don't forget unlock VM object on > (impossible) error > qemuDomainGetLaunchSecurityInfo: Use virTypedParamList to construct > return value > qemuNodeGetSEVInfo: Use virTypedParamList to constr

Re: [PATCH] docs: Correct dbus graphics' accepted p2p values

2025-03-11 Thread Michal Prívozník
On 3/11/25 13:16, Martin Kletzander wrote: > The attribute is used (and formatted) as virTristateBool() and even in > schema defined as virYesNo, so the values are supposed to be `yes` and > `no`. > > Signed-off-by: Martin Kletzander > --- > docs/formatdomain.rst | 2 +- > 1 file changed, 1 inse

Re: [PATCH v2 00/21] Add qemu RDP server support

2025-03-11 Thread Martin Kletzander
On Fri, Mar 07, 2025 at 04:22:46PM +0100, Martin Kletzander wrote: On Tue, Feb 18, 2025 at 02:16:05PM +0400, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Hi, This patch series offers an out-of-process Remote Desktop Protocol (RDP) server solution utilizing QEMU's -display dbus i

[PATCH 13/16] qemu: capabilities: Bump minimum qemu to qemu-6.2

2025-03-11 Thread Peter Krempa
Following minimum versions are needed based on our support policy: CentOS Stream 9: 9.1 Debian 12: 7.2 Fedora 40: 8.2 openSUSE Leap 15.6: 8.2 Ubuntu 22.04: 6.2 FreeBSD ports: 9.2 macOS homebre

Re: [PATCH v2 22/23] src: expand docs for guest info array handling

2025-03-11 Thread Peter Krempa
On Tue, Mar 11, 2025 at 14:24:28 +, Daniel P. Berrangé wrote: > Give an overview of how arrays are handled and represented in > the typed parameters returned by the guest info API. > > Signed-off-by: Daniel P. Berrangé > --- > src/libvirt-domain.c | 50 +++

Re: [PATCH v2 23/23] src: expand docs for guest stats constant version handling

2025-03-11 Thread Peter Krempa
On Tue, Mar 11, 2025 at 14:24:29 +, Daniel P. Berrangé wrote: > Explain that the 11.2.0 release dates are mostly reflecting when the > constant was first added, not when the key was introduced. > > Signed-off-by: Daniel P. Berrangé > --- > src/libvirt-domain.c | 7 +++ > 1 file changed,

[PATCH 4/5] bhyve: Support passing the 'passthru' command line option

2025-03-11 Thread Alexander Shursha
It is used to pass a PCI device from the host to a bhyve guest Signed-off-by: Alexander Shursha --- src/bhyve/bhyve_command.c | 24 .../bhyvexml2argv-passthru.args | 9 ++ .../bhyvexml2argv-passthru.ldargs | 4 +++ .../bhyvexml

Re: [PATCH v8 05/18] qemu: monitor: Add support for ThrottleGroup operations

2025-03-11 Thread Peter Krempa
On Wed, Feb 19, 2025 at 22:27:09 +0530, Harikumar Rajkumar wrote: > From: Chun Feng Wu > > This change contains QMP requests for ThrottleGroup > > * ThrottleGroup is updated through "qemuMonitorJSONUpdateThrottleGroup" > * ThrottleGroup is retrieved through "qemuMonitorJSONGetThrottleGroup" > *

[libvirt PATCH 14/16] domain_conf: graphics: move remaining VNC formatting

2025-03-11 Thread Pavel Hrdina
Now we are able to move the rest into virDomainGraphicsDefFormatVNC without breaking order of elements in the resulting XML. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_co

Re: [PATCH v2 07/23] src: add constants for guest info 'if.' parameters

2025-03-11 Thread Peter Krempa
On Tue, Mar 11, 2025 at 14:24:13 +, Daniel P. Berrangé wrote: > Contrary to most APIs returning typed parameters, there are no constants > defined for the guest info data keys. This is was because many of the > keys needs to be dynamically constructed using one or more array index > values. >

Re: [PATCH v2 09/23] src: expand docs for guest info array handling

2025-03-11 Thread Peter Krempa
On Tue, Mar 11, 2025 at 14:24:15 +, Daniel P. Berrangé wrote: > Give an overview of how arrays are handled and represented in > the typed parameters returned by the guest info API. > > Signed-off-by: Daniel P. Berrangé > --- > src/libvirt-domain.c | 50 +++

[PATCH 16/16] qemucapabilitiestest: Add data for the qemu-10.0 dev cycle on x86_64 for the '+amdsev' variant

2025-03-11 Thread Peter Krempa
Add data based on 'v9.2.0-2369-g98c7362b1e'. Signed-off-by: Peter Krempa --- .../qemu_10.0.0-q35.x86_64+amdsev.xml | 852 + .../qemu_10.0.0-tcg.x86_64+amdsev.xml | 1821 + .../qemu_10.0.0.x86_64+amdsev.xml | 852 + .../caps_10.0.0_x86_64+amdsev.replies |

Re: [PATCH v2 10/23] src: expand docs for guest info constant version handling

2025-03-11 Thread Peter Krempa
On Tue, Mar 11, 2025 at 14:24:16 +, Daniel P. Berrangé wrote: > Explain that the 11.2.0 release dates are mostly reflecting when the > constant was first added, not when the key was introduced. > > Signed-off-by: Daniel P. Berrangé > --- > src/libvirt-domain.c | 7 +++ > 1 file changed,

Re: [PATCH 2/3] qemu: Replace usb-storage with usb-bot

2025-03-11 Thread Peter Krempa
On Mon, Mar 10, 2025 at 09:13:11 +, Daniel P. Berrangé wrote: > On Mon, Mar 10, 2025 at 10:10:53AM +0100, Peter Krempa wrote: > > On Mon, Mar 10, 2025 at 09:05:28 +, Daniel P. Berrangé wrote: > > > On Sat, Mar 08, 2025 at 02:57:41PM +0900, Akihiko Odaki wrote: > > > > usb-storage is a compo

Re: [PATCH 0/5] qemu: Introduce nvme disk emulation support

2025-03-11 Thread Martin Kletzander
On Thu, Feb 20, 2025 at 11:35:01AM -, honglei.w...@smartx.com wrote: On Tue, Feb 18, 2025 at 07:45:45PM +0800, honglei.wang(a)smartx.com wrote: What is the reason for wanting to have both these config approaches ? With the first appearing to be a subset of the second, the first seems to lack

[libvirt PATCH 11/16] domain_conf: graphics: extract listen formatting to separate function

2025-03-11 Thread Pavel Hrdina
This will be used in specific graphics types that are using listen elements. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 67 -- 1 file changed, 39 insertions(+), 28 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c ind

Re: [PATCH v8 07/18] remote: New APIs for ThrottleGroup lifecycle management

2025-03-11 Thread Peter Krempa
On Wed, Feb 19, 2025 at 22:27:11 +0530, Harikumar Rajkumar wrote: > From: Chun Feng Wu > > Defined new public APIs: > * virDomainSetThrottleGroup to add or update throttlegroup within specific > domain, > it will be referenced by throttlefilter later in disk to do limits > * virDomainGetThrott

[PATCH v2 13/23] src: add constants for domain stats 'balloon.' parameters

2025-03-11 Thread Daniel P . Berrangé
Contrary to most APIs returning typed parameters, there are no constants defined for the domain stats data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array in

Re: [PATCH v2 06/23] src: add constants for guest info 'disk.' parameters

2025-03-11 Thread Peter Krempa
On Tue, Mar 11, 2025 at 14:24:12 +, Daniel P. Berrangé wrote: > Contrary to most APIs returning typed parameters, there are no constants > defined for the guest info data keys. This is was because many of the > keys needs to be dynamically constructed using one or more array index > values. >

[PATCH 3/5] qemu_validate: Check whether UEFI shim is supported

2025-03-11 Thread Michal Privoznik
If UEFI shim is specified in domain XML but QEMU is too old, then report an error. Signed-off-by: Michal Privoznik --- src/qemu/qemu_validate.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index f3ef1be660..6be8c29b75 100644 --- a

[PATCH v2 22/23] src: expand docs for guest info array handling

2025-03-11 Thread Daniel P . Berrangé
Give an overview of how arrays are handled and represented in the typed parameters returned by the guest info API. Signed-off-by: Daniel P. Berrangé --- src/libvirt-domain.c | 50 1 file changed, 50 insertions(+) diff --git a/src/libvirt-domain.c b/s

[PATCH v2 21/23] src: document that no constants are provided for custom VM stats

2025-03-11 Thread Daniel P . Berrangé
Contrary to most APIs returning typed parameters, there are no constants defined for the domain stats data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array in

[PATCH v2 20/23] src: add constants for domain stats 'dirtyrate.' parameters

2025-03-11 Thread Daniel P . Berrangé
Contrary to most APIs returning typed parameters, there are no constants defined for the domain stats data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array in

[PATCH v2 18/23] src: add constants for domain stats 'iothread.' parameters

2025-03-11 Thread Daniel P . Berrangé
Contrary to most APIs returning typed parameters, there are no constants defined for the domain stats data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array in

[PATCH v2 23/23] src: expand docs for guest stats constant version handling

2025-03-11 Thread Daniel P . Berrangé
Explain that the 11.2.0 release dates are mostly reflecting when the constant was first added, not when the key was introduced. Signed-off-by: Daniel P. Berrangé --- src/libvirt-domain.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index

[PATCH v2 02/23] src: add constants for guest info 'os.' parameters

2025-03-11 Thread Daniel P . Berrangé
Contrary to most APIs returning typed parameters, there are no constants defined for the guest info data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array inde

[PATCH v2 19/23] src: add constants for domain stats 'memory.' parameters

2025-03-11 Thread Daniel P . Berrangé
Contrary to most APIs returning typed parameters, there are no constants defined for the domain stats data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array in

[PATCH v2 03/23] src: add constants for guest info 'timezone.' parameters

2025-03-11 Thread Daniel P . Berrangé
Contrary to most APIs returning typed parameters, there are no constants defined for the guest info data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array inde

[PATCH v2 12/23] src: add constants for domain stats 'cpu.' parameters

2025-03-11 Thread Daniel P . Berrangé
Contrary to most APIs returning typed parameters, there are no constants defined for the domain stats data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array in

Re: [PATCH RFC-v2 00/11] qemu: Add support for iothread to virtqueue mapping for 'virtio-scsi'

2025-03-11 Thread Peter Krempa
On Mon, Mar 03, 2025 at 16:30:38 +0100, Peter Krempa wrote: > Unfortunately still RFC as the qemu support is still not merged. > > Once again there are a few patches that are applicable: > > qemu: Use modern header formatting in 'qemu_command.h' > virXMLNodeGetSubelementList: Document return

Re: [PATCH v2 01/11] qemu: Use modern header formatting in 'qemu_command.h'

2025-03-11 Thread Ján Tomko
On a Monday in 2025, Peter Krempa wrote: The file used intermixed style. Convert the last outliers to the new formatting style. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.h | 85 - 1 file changed, 50 insertions(+), 35 deletions(-) diff --git a/

Re: [PATCH 11/19] src: add constants for domain stats 'vcpu.' parameters

2025-03-11 Thread Daniel P . Berrangé
On Thu, Mar 06, 2025 at 03:43:18PM +0100, Peter Krempa wrote: > On Tue, Mar 04, 2025 at 14:04:06 +, Daniel P. Berrangé wrote: > > Contrary to most APIs returning typed parameters, there are no constants > > defined for the domain stats data keys. This is was because many of the > > keys needs t

[PATCH v2 05/23] src: add constants for guest info 'fs.' parameters

2025-03-11 Thread Daniel P . Berrangé
Contrary to most APIs returning typed parameters, there are no constants defined for the guest info data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array inde

[PATCH v2 04/23] src: add constant for the guest info 'hostname' parameter

2025-03-11 Thread Daniel P . Berrangé
Contrary to most APIs returning typed parameters, there are no constants defined for the guest info data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array inde

[PATCH v2 08/23] src: add constants for guest info 'load.' parameters

2025-03-11 Thread Daniel P . Berrangé
Contrary to most APIs returning typed parameters, there are no constants defined for the guest info data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array inde

[PATCH v2 06/23] src: add constants for guest info 'disk.' parameters

2025-03-11 Thread Daniel P . Berrangé
Contrary to most APIs returning typed parameters, there are no constants defined for the guest info data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array inde

[PATCH v2 09/23] src: expand docs for guest info array handling

2025-03-11 Thread Daniel P . Berrangé
Give an overview of how arrays are handled and represented in the typed parameters returned by the guest info API. Signed-off-by: Daniel P. Berrangé --- src/libvirt-domain.c | 50 1 file changed, 50 insertions(+) diff --git a/src/libvirt-domain.c b/s

[PATCH v2 14/23] src: add constants for domain stats 'vcpu.' parameters

2025-03-11 Thread Daniel P . Berrangé
Contrary to most APIs returning typed parameters, there are no constants defined for the domain stats data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array in

[PATCH v2 17/23] src: add constants for domain stats 'perf.' parameters

2025-03-11 Thread Daniel P . Berrangé
Contrary to most APIs returning typed parameters, there are no constants defined for the domain stats data keys. This is was because many of the keys needs to be dynamically constructed using one or more array index values. It is possible to define constants while still supporting dynamic array in

Re: [libvirt PATCH v2] qemu: snapshot: error out early when reverting snapshot for VM with non-file disk

2025-03-11 Thread Peter Krempa
On Thu, Mar 06, 2025 at 14:39:41 +0100, Pavel Hrdina wrote: > Before this patch the code would start the revert process by destroying > the VM and preparing to revert where it would fail with following error: > > error: unsupported configuration: source for disk 'sdb' is not a regular > file;

Re: [PATCH] util: Require libnl for Linux

2025-03-11 Thread Laine Stump
On 3/10/25 5:02 AM, Daniel P. Berrangé wrote: On Sat, Mar 08, 2025 at 05:02:32PM +0900, Akihiko Odaki wrote: Builds for Linux without libnl is broken since commit 582f0966f9b9e2148d8887d072364e2a91aed000 so make libnl mandatory for Linux. Another option is to fix such builds, but it can bring m

[PATCH 2/3] qemuValidateDomainDeviceDefNetwork: Require shared memory for all vhost-user interfaces

2025-03-11 Thread Peter Krempa
Currently we produce only a warning into the log if a non-passt vhost-user interface is configured with shared memory. Since we do make it fatal with all other vhost-user types, fix the check to trigger also for normal-vhost-user interfaces. Since passt-based vhost-user interfaces are checked sep

Re: [PATCH 2/3] qemu: Replace usb-storage with usb-bot

2025-03-11 Thread Daniel P . Berrangé
On Sat, Mar 08, 2025 at 02:57:41PM +0900, Akihiko Odaki wrote: > usb-storage is a compound device that automatically creates a USB mass > storage device and a SCSI device as its backend. Unfortunately it lacks > some configuration options that are usually present with a SCSI device, > and cannot re

[PATCH 01/16] conf: Drop support for 'sheepdog' disks

2025-03-11 Thread Peter Krempa
In upcoming patches we'll update minimum supported qemu version to qemu-6.2 which no longer supports 'sheepdog'. This was the only hypervisor driver that supported it. Reject any config containing sheepdog disks when validating the XML, remove the positive test cases in qemu and replace them by a

Re: [PATCH v2 08/23] src: add constants for guest info 'load.' parameters

2025-03-11 Thread Peter Krempa
On Tue, Mar 11, 2025 at 14:24:14 +, Daniel P. Berrangé wrote: > Contrary to most APIs returning typed parameters, there are no constants > defined for the guest info data keys. This is was because many of the > keys needs to be dynamically constructed using one or more array index > values. >

[PATCH 11/16] qemucapabilitiesdata: Drop un-updated 'caps_7.0.0_aarch64' data

2025-03-11 Thread Peter Krempa
The aarch-64 qemu-7.0 data were not updated to the release version. Drop them instead of trying to do archaeology. They are not used in any 'qemuxmlconftest' case. Signed-off-by: Peter Krempa --- .../qemu_7.0.0-virt.aarch64.xml | 233 - tests/domaincapsdata/qemu_7.0.0.aarch64.xm

[libvirt PATCH 08/16] domain_conf: graphics: extract Spice formatting to separate function

2025-03-11 Thread Pavel Hrdina
virDomainGraphicsDefFormat function was way too long so split it into separate functions for each graphics type. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 115 ++--- 1 file changed, 62 insertions(+), 53 deletions(-) diff --git a/src/conf/domain

[PATCH 07/16] qemucapabilitiestest: Drop qemu-6.1 data

2025-03-11 Thread Peter Krempa
Soon we'll bump to qemu-6.2 as minimum. Signed-off-by: Peter Krempa --- .../domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 1139 - .../domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 1932 - tests/domaincapsdata/qemu_6.1.0.x86_64.xml| 1139 - .../caps_6.1.0_x86_64.replies | 33507

[PATCH 06/16] qemucapabilitiestest: Drop qemu-6.0 data

2025-03-11 Thread Peter Krempa
Soon we'll bump to qemu-6.2 as minimum. Signed-off-by: Peter Krempa --- .../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 1047 - .../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 1744 - .../qemu_6.0.0-virt.aarch64.xml | 227 - tests/domaincapsdata/qemu_6.0.0.aarch64.xml | 227

Re: [PATCH 25/26] rpc: don't let systemd shutdown daemon while saving VMs

2025-03-11 Thread Daniel P . Berrangé
On Mon, Feb 03, 2025 at 02:17:37PM +0100, Peter Krempa wrote: > On Wed, Jan 08, 2025 at 19:42:58 +, Daniel P. Berrangé wrote: > > The service unit "TimeoutStopSec" setting controls how long systemd > > waits for a service to stop before aggressively killing it, defaulting > > to 30 seconds if n

Re: [PATCH 00/16] qemu: Bump minimum qemu to qemu-6.2.0 and clean up capabilities

2025-03-11 Thread Michal Prívozník
On 3/10/25 11:02, Peter Krempa wrote: > Summary: > > This series was originally just meant to clean up non-release > capabilities but it grew since we dropped debian-11 and Michal asked me > to add dev-version for amdsev variant. > > Some of the long patches were truncated, fetch the proper patch

Re: [PATCH 0/4] hw/s390x: Alias @dump-skeys -> @dump-s390-skey and deprecate

2025-03-11 Thread Daniel P . Berrangé
On Mon, Mar 10, 2025 at 07:50:57AM +0100, Thomas Huth wrote: > On 09/03/2025 19.55, Pierrick Bouvier wrote: > > On 6/3/24 05:18, Daniel P. Berrangé wrote: > > > On Fri, May 31, 2024 at 06:47:45AM +0200, Thomas Huth wrote: > > > > On 30/05/2024 09.45, Philippe Mathieu-Daudé wrote: > > > > > We are t

Re: [PATCH 23/26] rpc: fix shutdown sequence when preserving state

2025-03-11 Thread Daniel P . Berrangé
On Mon, Feb 03, 2025 at 12:04:01PM +0100, Peter Krempa wrote: > On Wed, Jan 08, 2025 at 19:42:56 +, Daniel P. Berrangé wrote: > > The preserving of state (ie running VMs) requires a fully functional > > daemon and hypervisor driver. If any part has started shutting down > > then saving state ma

Re: [PATCH 09/26] hypervisor: expand available shutdown actions

2025-03-11 Thread Daniel P . Berrangé
On Thu, Jan 30, 2025 at 03:10:55PM +, Daniel P. Berrangé wrote: > On Thu, Jan 30, 2025 at 04:02:46PM +0100, Peter Krempa wrote: > > On Wed, Jan 08, 2025 at 19:42:42 +, Daniel P. Berrangé wrote: > > > The auto shutdown code can currently only perform managed save, > > > which may fail in som

Re: [PATCH v3 0/2] Enable SEV SNP support in ch driver

2025-03-11 Thread Michal Prívozník
On 2/11/25 20:18, Praveen K Paladugu wrote: > This version introduces virStringFormatHex method and uses this method while > sending host_data to cloud-hypervisor. > > Praveen K Paladugu (2): > util: Introduce virStringFormatHex > ch: Enable SEV SNP support > > src/ch/ch_monitor.c | 65

[PATCH 09/16] qemucapabilitiestest: Drop unused fake data 'caps_7.0.0_aarch64+hvf'

2025-03-11 Thread Peter Krempa
The 'caps_7.0.0_aarch64+hvf' caps dump is fake; obtained from copying and doctoring the 'caps_7.0.0_aarch64' file (see commit 12aedb414578d3 ) Remove it now that it was superseded by a dump obtained from a proper hvf-enabled host. Signed-off-by: Peter Krempa --- .../qemu_7.0.0-hvf.aarch64+hvf.x

[PATCH 05/16] qemucapabilitiestest: Drop qemu-5.2 data

2025-03-11 Thread Peter Krempa
Soon we'll bump to qemu-6.2 as minimum. Signed-off-by: Peter Krempa --- .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 1014 - .../qemu_5.2.0-tcg-virt.riscv64.xml | 163 - .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 1643 - .../qemu_5.2.0-virt.aarch64.xml | 221

[PATCH 3/5] bhyve: Advertise hostdev support.

2025-03-11 Thread Alexander Shursha
bhyve itself had this feature long ago, but enabling it was blocked by Linux-specific code in virpci Signed-off-by: Alexander Shursha --- src/bhyve/bhyve_capabilities.c | 2 +- tests/domaincapsdata/bhyve_basic.x86_64.xml | 3 ++- tests/domaincapsdata/bhyve_fbuf.x86_64.xml | 3 ++-

Re: [PATCH v2 1/4] tests: Remove pseries-2.7 machine type

2025-03-11 Thread Narayana Murty N
On 04/03/25 9:35 PM, Peter Krempa wrote: On Tue, Mar 04, 2025 at 10:40:21 -0500, Narayana Murty N wrote: Support for the pseries-2.7 machine type in QEMU was officially removed in version 9.2 with commit 445d3facffe8. Signed-off-by: Narayana Murty N --- [...] diff --git a/tests/qemuxmlcon

Re: [PATCH v2 2/4] tests: Add capabilities for QEMU 9.2.0 on ppc64

2025-03-11 Thread Narayana Murty N
On 04/03/25 10:00 PM, Peter Krempa wrote: On Tue, Mar 04, 2025 at 10:40:22 -0500, Narayana Murty N wrote: Add the qemu test capabilities xml and reply files for QEMU 9.2.0 on ppc64. A QEMU v9.2.0 was used for generating this data. That's what would be expected based on the summary, although it

[libvirt PATCH 12/16] domain_conf: graphics: move listens formatting to relevant graphics types

2025-03-11 Thread Pavel Hrdina
Only VNC, RDP and Spice graphics types are using listen elements so call the function only where it is needed. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_co

[PATCH] conf: parse interface/source/@dev for all interface types (with backend type='passt')

2025-03-11 Thread Laine Stump
The original implementation of the passt backend for vhost-user interfaces erroneously forgot to parse: for interface type='vhostuser', so it wasn't being added to the passt commandline, and also wasn't being saved to the domain config. Now we parse it no matter what the interface type, and th

Re: [PATCH 2/3] qemu: Replace usb-storage with usb-bot

2025-03-11 Thread Peter Krempa
On Mon, Mar 10, 2025 at 09:05:28 +, Daniel P. Berrangé wrote: > On Sat, Mar 08, 2025 at 02:57:41PM +0900, Akihiko Odaki wrote: > > usb-storage is a compound device that automatically creates a USB mass > > storage device and a SCSI device as its backend. Unfortunately it lacks > > some configur