Re: Feature Request: --targetdir option on backup-begin

2025-03-10 Thread Peter Krempa
On Sun, Mar 09, 2025 at 23:40:30 +0100, Michael Niehren wrote: > Hi, > > i just playing around with the "new" backup API for switching from the old > way and simply want > to do full backup's in push mode. If i do so, > > virsh backup-begin > > the backup-Image files are always created in t

Re: [PATCH 0/4] hw/s390x: Alias @dump-skeys -> @dump-s390-skey and deprecate

2025-03-10 Thread Thomas Huth
On 09/03/2025 19.55, Pierrick Bouvier wrote: On 6/3/24 05:18, Daniel P. Berrangé wrote: On Fri, May 31, 2024 at 06:47:45AM +0200, Thomas Huth wrote: On 30/05/2024 09.45, Philippe Mathieu-Daudé wrote: We are trying to unify all qemu-system-FOO to a single binary. In order to do that we need to

Re: [PATCH 0/4] hw/s390x: Alias @dump-skeys -> @dump-s390-skey and deprecate

2025-03-10 Thread Pierrick Bouvier
On 6/3/24 05:18, Daniel P. Berrangé wrote: On Fri, May 31, 2024 at 06:47:45AM +0200, Thomas Huth wrote: On 30/05/2024 09.45, Philippe Mathieu-Daudé wrote: We are trying to unify all qemu-system-FOO to a single binary. In order to do that we need to remove QAPI target specific code. @dump-skeys

Re: [PATCH] util: Require libnl for Linux

2025-03-10 Thread Daniel P . Berrangé
On Sat, Mar 08, 2025 at 05:02:32PM +0900, Akihiko Odaki wrote: > Builds for Linux without libnl is broken since commit > 582f0966f9b9e2148d8887d072364e2a91aed000 so make libnl mandatory for > Linux. > > Another option is to fix such builds, but it can bring more problems > than benefits. libnl is

[PATCH 5/5] bhyve: Tie the 'passthru' option to the 'hostdev' XML config

2025-03-10 Thread Alexander Shursha
Signed-off-by: Alexander Shursha --- src/bhyve/bhyve_parse_command.c | 60 +++ .../bhyveargv2xml-passthru.args | 7 +++ .../bhyveargv2xml-passthru.xml| 22 +++ tests/bhyveargv2xmltest.c | 1 + 4 files changed, 9

[PATCH 1/5] virpci: Switch to an implementation using libpciaccess

2025-03-10 Thread Alexander Shursha
The current virpci code uses the Linux-specific sysfs subsystem, which makes it impossible to use on other Unix-like systems. The libpciaccess library provides a cross-platform API for accessing the PCI bus. Employ it to make the code portable. This makes libpciaccess a non-optional dependency of

[PATCH 12/16] qemucapabilitiesdata: Drop un-updated 'qemu_8.0.0_riscv64' data

2025-03-10 Thread Peter Krempa
The riscv64 qemu-8.0 data were not updated to the release version. Drop them instead of trying to do archaeology. They are not used in any 'qemuxmlconftest' case. Signed-off-by: Peter Krempa --- .../qemu_8.0.0-tcg-virt.riscv64.xml | 174 - .../qemu_8.0.0-virt.riscv64.xml

[PATCH 15/16] qemucapabilitiestest: Update 'caps_10.0.0_x86_64' to 'v9.2.0-2369-g98c7362b1e'

2025-03-10 Thread Peter Krempa
Notable changes: - 'uefi-vars-x64', 'uefi-vars-sysbus' qom type added - 'YongFeng-v1-x86_64-cpu' added - 'accel' qom type removed - 'addr' field of devices changed type to 'str' - 'vfio-pci' gained experimental feature 'x-migration-multifd-transfer' Signed-off-by: Peter Krempa --- .../caps_

[PATCH 10/16] qemucapabilitiesdata: Drop un-updated 'qemu_6.2.0_aarch64' data

2025-03-10 Thread Peter Krempa
We'll be bumping to qemu-6.2 as minimum and the aarch64 qemu-6.2 data were not updated to the release version. Drop them instead of trying to do archaeology. Signed-off-by: Peter Krempa --- .../qemu_6.2.0-virt.aarch64.xml | 234 - tests/domaincapsdata/qemu_6.2.0.aarch64.xml |

Re: [PATCH 2/3] qemu: Replace usb-storage with usb-bot

2025-03-10 Thread Akihiko Odaki
On 2025/03/10 18:10, Peter Krempa wrote: On Mon, Mar 10, 2025 at 09:05:28 +, Daniel P. Berrangé wrote: On Sat, Mar 08, 2025 at 02:57:41PM +0900, Akihiko Odaki wrote: usb-storage is a compound device that automatically creates a USB mass storage device and a SCSI device as its backend. Un

Re: [PATCH v3 2/2] ch: Enable SEV SNP support

2025-03-10 Thread Michal Prívozník
On 2/11/25 20:18, Praveen K Paladugu wrote: > Enable SEV-SNP support for ch guests. > > Co-Authored-by: Smit Gardhariya > Signed-off-by: Praveen K Paladugu > --- > src/ch/ch_monitor.c | 65 - > 1 file changed, 53 insertions(+), 12 deletions(-) > > di

Re: [PATCH] conf: parse interface/source/@dev for all interface types (with backend type='passt')

2025-03-10 Thread Laine Stump
On 3/10/25 5:06 PM, Peter Krempa wrote: On Mon, Mar 10, 2025 at 16:11:03 -0400, Laine Stump wrote: The original implementation of the passt backend for vhost-user interfaces erroneously forgot to parse: for interface type='vhostuser', so it wasn't being added to the passt commandline, and

[PATCH 00/16] qemu: Bump minimum qemu to qemu-6.2.0 and clean up capabilities

2025-03-10 Thread Peter Krempa
Summary: This series was originally just meant to clean up non-release capabilities but it grew since we dropped debian-11 and Michal asked me to add dev-version for amdsev variant. Some of the long patches were truncated, fetch the proper patches at git fetch https://gitlab.com/pipo.sk/libvirt

[PATCH 2/5] node_device: Enable previously disabled code paths for FreeBSD

2025-03-10 Thread Alexander Shursha
The code was under #ifdef __linux__ because of sysfs usage. It is now using libpciaccess, which makes it available for, at least, FreeBSD. Signed-off-by: Alexander Shursha --- src/conf/node_device_conf.c | 2 +- src/node_device/node_device_driver.c | 2 +- src/node_device/node_device_ud

Re: [PATCH] conf: parse interface/source/@dev for all interface types (with backend type='passt')

2025-03-10 Thread Peter Krempa
On Mon, Mar 10, 2025 at 16:11:03 -0400, Laine Stump wrote: > The original implementation of the passt backend for vhost-user > interfaces erroneously forgot to parse: > > > > for interface type='vhostuser', so it wasn't being added to the passt > commandline, and also wasn't being saved to the

[PATCH 03/16] qemuxmlconftest: Drop tests pinned to qemu-6.0

2025-03-10 Thread Peter Krempa
Upcoming patches will bump minimum qemu version to 6.2 so we need to purge old tests. Signed-off-by: Peter Krempa --- ...-host-model-fallback-kvm.x86_64-6.0.0.args | 34 - ...u-host-model-fallback-kvm.x86_64-6.0.0.xml | 29 --- ...-host-model-fallback-tcg.x86_64-6.0.0.args |

[PATCH 02/16] qemuxmlconftest: Drop tests pinned to qemu-5.2

2025-03-10 Thread Peter Krempa
Upcoming patches will bump minimum qemu version to 6.2 so we need to purge old tests. Signed-off-by: Peter Krempa --- .../cpu-fallback.x86_64-5.2.0.args| 34 -- .../cpu-fallback.x86_64-5.2.0.xml | 40 --- ...-host-model-fallback-kvm.x86_64-5.2.0.args | 34 -

[PATCH 04/16] qemuxmlconftest: Drop tests pinned to qemu-6.1

2025-03-10 Thread Peter Krempa
Upcoming patches will bump minimum qemu version to 6.2 so we need to purge old tests. Signed-off-by: Peter Krempa --- ...-host-model-fallback-kvm.x86_64-6.1.0.args | 34 - ...u-host-model-fallback-kvm.x86_64-6.1.0.xml | 29 --- ...-host-model-fallback-tcg.x86_64-6.1.0.args |

[PATCH 08/16] qemucapabilitiestest: Add 'qemu_9.2.0.aarch64+hvf' test data

2025-03-10 Thread Peter Krempa
The data is collected from an MacOS host with latest released qemu from homebrew. Signed-off-by: Peter Krempa --- .../qemu_9.2.0-hvf.aarch64+hvf.xml| 227 + .../caps_9.2.0_aarch64+hvf.replies| 35433 .../caps_9.2.0_aarch64+hvf.xml| 494

Re: [PATCH v3 1/2] util: Introduce virStringFormatHex

2025-03-10 Thread Michal Prívozník
On 2/11/25 20:18, Praveen K Paladugu wrote: > virStringFormatHex converts an input byte array into hex string and > returns it. > > Signed-off-by: Praveen K Paladugu > --- > src/libvirt_private.syms | 1 + > src/util/virstring.c | 19 +++ > src/util/virstring.h | 1 + >