[PATCH] util: Check libnl function availability

virNetDevBridgeSetupVlans() calls virNetlinkBridgeVlanFilterSet(), which requires libnl. Use the function only when libnl is available to avoid breaking builds. Signed-off-by: Akihiko Odaki --- src/util/virnetdevbridge.c | 122 ++--- 1 file changed, 61 ins

[libvirt PATCH 05/16] domain_conf: graphics: extract SDL formatting to separate function

virDomainGraphicsDefFormat function was way too long so split it into separate functions for each graphics type. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf

[libvirt PATCH] ci: refresh with 'lcitool manifest'

- Remove EOL Debian 11 Signed-off-by: Pavel Hrdina --- This depends on this MR [1] to update libvirt-ci as well. [1] ci/buildenv/debian-11-cross-aarch64.sh| 117 ci/buildenv/debian-11-cross-armv6l.sh

Re: [PATCH] util: Check libnl function availability

On 2025/03/07 22:11, Laine Stump wrote: On 3/7/25 6:48 AM, Akihiko Odaki wrote: virNetDevBridgeSetupVlans() calls virNetlinkBridgeVlanFilterSet(), which requires libnl. Use the function only when libnl is available to avoid breaking builds. Signed-off-by: Akihiko Odaki I'm curious what is th

[PATCH 2/3] qemu: Replace usb-storage with usb-bot

usb-storage is a compound device that automatically creates a USB mass storage device and a SCSI device as its backend. Unfortunately it lacks some configuration options that are usually present with a SCSI device, and cannot represent CD-ROM in particular. Replace usb-storage with usb-bot, which

[PATCH 0/3] qemu: Replace usb-storage with usb-bot

usb-storage is a compound device that automatically creates a USB mass storage device and a SCSI device as its backend. Unfortunately it lacks some configuration options that are usually present with a SCSI device, and cannot represent CD-ROM in particular. Replace usb-storage with usb-bot, which

Re: [PATCH v2 05/21] qemu: fall-through for unsupported graphics

On Tue, Feb 18, 2025 at 02:16:10PM +0400, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Without an error message, it can be tedious to figure out failure to start, just fall-through the generic range error. Signed-off-by: Marc-André Lureau --- src/qemu/qemu_command.c | 1 - 1 file

[libvirt PATCH 1/4] util: virxml: introduce virXMLFormatElementDirect

This can be used to format XML where the element has direct value instead of any subelement. For example: 1524288 Signed-off-by: Pavel Hrdina --- src/libvirt_private.syms | 1 + src/util/virxml.c| 14 ++ src/util/virxml.h| 6 ++ 3 files changed, 21 insertio

[libvirt PATCH 10/16] domain_conf: graphics: extract DBus formatting to separate function

virDomainGraphicsDefFormat function was way too long so split it into separate functions for each graphics type. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/sr

Re: [PATCH v2 00/21] Add qemu RDP server support

On Tue, Feb 18, 2025 at 02:16:05PM +0400, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Hi, This patch series offers an out-of-process Remote Desktop Protocol (RDP) server solution utilizing QEMU's -display dbus interface, offering improved modularity and potential security benefi

Re: [libvirt PATCH 3/4] domain_conf: refactor virDomainLoaderDefFormatNvram

On a Thursday in 2025, Pavel Hrdina wrote: Use the new virXMLFormatDirect in order to remove usage of virXMLFormatInternal. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/

Re: [PATCH 1/1] nwfilter: Fix deadlock between nwfilter-list and VM startup/migration

On Tue, Feb 18, 2025 at 03:56:32PM +0100, Dion Bosschieter wrote: > A deadlock occurs when `nwfilterBindingCreateXML` and > `nwfilterConnectListAllNWFilters` > acquire locks in an inconsistent order. This patch ensures > `nwfilterBindingCreateXML` > acquires `driverMutex` before `updateLock`, res

Re: [libvirt PATCH 3/4] domain_conf: refactor virDomainLoaderDefFormatNvram

On Fri, Mar 07, 2025 at 01:37:49PM +0100, Ján Tomko wrote: > On a Thursday in 2025, Pavel Hrdina wrote: > > Use the new virXMLFormatDirect in order to remove usage of > > virXMLFormatInternal. > > > > Signed-off-by: Pavel Hrdina > > --- > > src/conf/domain_conf.c | 18 -- > > 1 fil

Re: [PATCH 2/3] tests: add capabilities for QEMU 9.2.0 on s390x

On Thu, Nov 07, 2024 at 17:44:05 +0100, Boris Fiuczynski wrote: > On 11/7/24 17:19, Peter Krempa wrote: > > On Wed, Nov 06, 2024 at 15:31:56 +0100, Boris Fiuczynski wrote: > > > Let us introduce the xml and reply files for QEMU 9.2.0 on s390x. [...] > > Additionally if you want to commit an in-de

Re: [PATCH v2 20/21] qemu: add RDP support

On Tue, Feb 18, 2025 at 02:16:25PM +0400, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Wire the external server RDP support with QEMU. Check the configuration, allocate a port, start the process and set the credentials. Signed-off-by: Marc-André Lureau --- docs/formatdomain.rst

Re: [libvirt PATCH] ci: refresh with 'lcitool manifest'

On Fri, Mar 07, 2025 at 02:03:31PM +0100, Pavel Hrdina wrote: - Remove EOL Debian 11 Signed-off-by: Pavel Hrdina Reviewed-by: Martin Kletzander signature.asc Description: PGP signature

Re: [PATCH v2 0/6] qemu: acpi-generic-initiator support

On Fri, Mar 07, 2025 at 08:13:51 +0100, Andrea Righi via Devel wrote: > Gentle ping. Is there any feedback, comment, suggestion about this? I have a couple points about coding style and some general stuff. This feature is out of interest are and thus I will not try to understand whether the design

Re: [PATCH v2 15/21] qemu/dbus: log daemon stdout/err, use domainLogContext

On Tue, Feb 18, 2025 at 02:16:20PM +0400, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Currently, if dbus-daemon writes on errfd, it will SIGPIPE. Signed-off-by: Marc-André Lureau --- src/qemu/qemu_dbus.c | 34 +++--- 1 file changed, 23 insertions(+),

Re: [PATCH v2 17/21] qemu: add qemu-rdp helper unit

On Tue, Feb 18, 2025 at 02:16:22PM +0400, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Helpers to start the qemu-rdp server and set it up. Signed-off-by: Marc-André Lureau --- po/POTFILES| 1 + src/qemu/meson.build | 1 + src/qemu/qemu_domain.c | 1 + src/qemu/q

Re: [libvirt PATCH 00/16] refactor and fix graphics formatting

On a Thursday in 2025, Pavel Hrdina wrote: Pavel Hrdina (16): domain_conf: graphics: use a function to format gl element domain_conf: graphics: use a function to format audio element domain_conf: modernize graphics formatting domain_conf: graphics: extract VNC formatting to separate function

Re: [libvirt PATCH 0/4] introduce and use virXMLFormatElementDirect

On a Thursday in 2025, Pavel Hrdina wrote: Pavel Hrdina (4): util: virxml: introduce virXMLFormatElementDirect conf: use virXMLFormatElementDirect domain_conf: refactor virDomainLoaderDefFormatNvram util: virxml: unexport virXMLFormatElementInternal src/conf/domain_conf.c | 22 +

Re: [PATCH 1/4] virpci: changed the work with PCI via libpciaccess

On Fri, Mar 07, 2025 at 08:46:23AM +0300, Alexander Shursha wrote: Martin Kletzander writes: I understand you are switching to libpciaccess APIs from our manual handling of PCI devices. That does have the added benefit of working on FreeBSD, but adds a new dependency where it might not have b

Re: [PATCH v2 1/1] util: netdevvlan: Change return type of virNetDevVlanCopy to void

On Fri, Mar 07, 2025 at 12:08:03PM +0300, Alexander Kuznetsov wrote: This function return value is invariant since 1022e0ee, so change its type and remove all dependent checks. Found by Linux Verification Center (linuxtesting.org) with Svace. Reported-by: Alexander Rudyuk Signed-off-by: Alexan

Re: [PATCH v2 0/6] qemu: acpi-generic-initiator support

Hi Peter, On Fri, Mar 07, 2025 at 01:45:01PM +0100, Peter Krempa wrote: > On Fri, Mar 07, 2025 at 08:13:51 +0100, Andrea Righi via Devel wrote: > > Gentle ping. Is there any feedback, comment, suggestion about this? > > I have a couple points about coding style and some general stuff. This > feat

Re: [PATCH] util: Check libnl function availability

On 3/7/25 6:48 AM, Akihiko Odaki wrote: virNetDevBridgeSetupVlans() calls virNetlinkBridgeVlanFilterSet(), which requires libnl. Use the function only when libnl is available to avoid breaking builds. Signed-off-by: Akihiko Odaki I'm curious what is the Linux platform where we don't have libn

Re: [PATCH v2 0/6] qemu: acpi-generic-initiator support

Gentle ping. Is there any feedback, comment, suggestion about this? Thanks, -Andrea

[PATCH v2 0/1] util: netdevvlan: Change return type of virNetDevVlanCopy to void

Thanks for the review! v2: - remove check for source vlan being not NULL and fix wrongly changed statement - remove pointless return at the end of the function Alexander Kuznetsov (1): util: netdevvlan: Change return type of virNetDevVlanCopy to void src/conf/domain_conf.c | 9 +++--

[PATCH v2 1/1] util: netdevvlan: Change return type of virNetDevVlanCopy to void

This function return value is invariant since 1022e0ee, so change its type and remove all dependent checks. Found by Linux Verification Center (linuxtesting.org) with Svace. Reported-by: Alexander Rudyuk Signed-off-by: Alexander Kuznetsov --- src/conf/domain_conf.c | 9 +++-- src/netw

Re: [PATCH] util: Check libnl function availability

On 3/7/25 8:21 AM, Akihiko Odaki wrote: On 2025/03/07 22:11, Laine Stump wrote: On 3/7/25 6:48 AM, Akihiko Odaki wrote: virNetDevBridgeSetupVlans() calls virNetlinkBridgeVlanFilterSet(), which requires libnl. Use the function only when libnl is available to avoid breaking builds. Signed-off-by

[PATCH RESEND 0/6] Add support for configuring PCI high memory MMIO size

Resending this series since it appears my first attempt was not sent to the list due to the "first post" manual moderation delay. =) This patch series adds support for configuring the PCI high memory MMIO window size for aarch64 virt machine types. This feature was recently merged into the QEMU up

[PATCH RESEND 1/6] domain: Add PCI configuration feature infrastructure

Add basic infrastructure for PCI configuration feature including: - New PCI configuration structure in domain_conf.h - Add VIR_DOMAIN_FEATURE_PCI enum and string conversion - Add pci field to virDomainDef to store PCI configuration This will be used to support QEMU's highmem-mmio-size machine prop

[PATCH RESEND 3/6] conf: Add PCI configuration XML parsing and formatting

Add XML parsing and formatting support for PCI configuration: - Add virDomainFeaturesPCIDefParseXML function - Add virDomainFeaturesPCIDefFormat function - Wire up parsing in virDomainFeaturesDefParse - Wire up formatting in virDomainDefFormatFeatures - Use g_steal_pointer for memory management Th

[PATCH RESEND 2/6] schema: Add PCI configuration feature schema

Add schema definition for PCI configuration feature including: - Add element under - Add element with scaledInteger type - Support unit attribute for size specification This allows XML configuration of PCI high memory MMIO size for aarch64 virt machines. Signed-off-by: Matthew R. Ochs --- sr

[PATCH RESEND 5/6] qemu: Add command line support for PCI high memory MMIO size

Add support for generating QEMU command line with PCI high memory MMIO size: - Add highmem-mmio-size to machine command line generation - Add validation for aarch64/virt machine type requirement - Add capability check for QEMU support - Add feature validation in qemu_validate.c This enables config

[PATCH RESEND 6/6] tests: Add tests for machine PCI features

Add test coverage for machine-specific PCI features: - Add XML tests for aarch64 virt highmem-mmio-size - Add command line generation tests This ensures proper handling of machine-specific PCI features like the high memory MMIO window size configuration. Signed-off-by: Matthew R. Ochs --- ...rc

[PATCH RESEND 4/6] qemu: Add capability for PCI high memory MMIO size

Add QEMU capability for PCI high memory MMIO size configuration: - Add QEMU_CAPS_MACHINE_VIRT_HIGHMEM_MMIO_SIZE capability - Add capability to virt machine properties - Add highmem-mmio-size virt machine property to aarch64 qemu 10.0.0 capabilities This allows detecting support for the highmem-m