Hi Laine,
The setting will be ignored after "virsh define" or when you
save after "virsh edit".
Do you think it is a bug?
Details:
SC1: define
# cat rhel.xml | grep /interface -B6
# virsh define rhel.xml
Domain 'rhel' defined from rhel.xml
# virsh
On Tue, Mar 04, 2025 at 01:38:25PM +0100, Peter Krempa wrote:
> As promised in the original patch fixing the schema this is the
> test-case follow up.
>
> As not entirely expected it's a bit more involved and also contains
> fixes for other bugs.
>
> Peter Krempa (8):
> qemu: capabilities: Pars
Fix a typo and update the setting in the example. The documentation
explains that "when passt is the backend,...the
path/type/mode are all implied to be "matching the passt process"
so **must not** be specified." Additionally, this source dev setting is
ignored in practice. Therefore, let's re
Hi,
Just a gentle ping on this patch.
Any feedback would be appreciated.
Thanks!
Dion
On a Wednesday in 2025, Yalan Zhang wrote:
Fix a typo and update the setting in the example. The documentation
explains that "when passt is the backend,...the
path/type/mode are all implied to be "matching the passt process"
so **must not** be specified." Additionally, this source dev settin
Just now took my daily look at the list and saw this patch...
On 3/5/25 11:42 AM, Ján Tomko wrote:
On a Wednesday in 2025, Yalan Zhang wrote:
Fix a typo and update the setting in the example. The documentation
explains that "when passt is the backend,...the
path/type/mode are all implied t
V4 series adding support for QEMU's mapped-ram stream format [1] and
migration capability. The use of mapped-ram is controlled by extending
save_image_format setting in qemu.conf with a new 'sparse' option. The
'raw' format continues to be the default.
Also included are patches that leverage mappe
When invoking virDomainSaveParams with a relative path, the image is
saved to the daemon's CWD. Similarly, when providing virDomainRestoreParams
with a relative path, it attempts to restore from the daemon's CWD. In most
configurations, the daemon's CWD is set to '/'. Ensure a relative path is
conv
Add new function qemuMigrationParamsCapEnabled() to check if a
capability is set in the caller-provided migration parameters.
Signed-off-by: Jim Fehlig
Reviewed-by: Daniel P. Berrangé
---
src/qemu/qemu_migration_params.c | 16
src/qemu/qemu_migration_params.h | 4
2 files
Add new function qemuFDPassNewFromMonitor to get an fdset previously
passed to qemu, based on the 'prefix' provided when the qemuFDPass
object was initially created.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_fd.c | 46 ++
src/qemu/qemu_fd.h | 4
Introduce qemuMigrationParamsForSave() to create a
qemuMigrationParams object initialized with appropriate migration
capabilities and parameters for a save operation.
Note that mapped-ram capability also requires the multifd capability.
For now, the number of multifd channels is set to 1. Future w
Signed-off-by: Jim Fehlig
Reviewed-by: Daniel P. Berrangé
---
src/qemu/qemu_migration_params.c | 18 ++
src/qemu/qemu_migration_params.h | 5 +
2 files changed, 23 insertions(+)
diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c
index 252437e5b
Add the mapped-ram migration capability introduced in QEMU 9.0.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_migration_params.c | 1 +
src/qemu/qemu_migration_params.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/qemu/qemu_migration_params.c b/src/qem
Extend the list of formats to include "sparse", which uses QEMU's mapped-ram
stream format [1] to write guest memory blocks at fixed offsets in the save
image file.
[1]
https://gitlab.com/qemu-project/qemu/-/blob/master/docs/devel/migration/mapped-ram.rst?ref_type=heads
Signed-off-by: Jim Fehlig
Move the code in qemuSaveImageCreate that opens, labels, and wraps the
save image fd to a helper function, providing more flexibility for
upcoming mapped-ram support.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_saveimage.c | 65 +++
1 file changed, 45 insertio
Introduce support for QEMU's new mapped-ram stream format [1].
mapped-ram can be enabled by setting the 'save_image_format'
setting in qemu.conf to 'sparse'.
To use mapped-ram with QEMU:
- The 'mapped-ram' migration capability must be set to true
- The 'multifd' migration capability must be set to
qemuProcessStartWithMemoryState() is the only caller of qemuProcessStart()
that uses the qemuProcessIncomingDef struct. Move creation of the struct
to qemuProcessStartWithMemoryState().
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_process.c | 42 -
src/qemu
Add support for the mapped-ram migration capability on restore.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_driver.c| 27 +++---
src/qemu/qemu_migration.c | 12 ++--
src/qemu/qemu_process.c | 41 ---
src/qemu/qemu_process.h
When using the mapped-ram migration capability, direct IO is
enabled by setting the "direct-io" migration parameter to
"true" and passing QEMU an additional fd with O_DIRECT set.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_driver.c | 10 ++
src/qemu/qemu_migration.c| 32
Similar to qemuMigrationSrcRun, apply migration parameters in
qemuMigrationDstRun. This allows callers to create customized
migration parameters, but delegates their application to the
function performing the migration.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_migration.c | 16 ++-
From: Claudio Fontana
Add a new VIR_DOMAIN_SAVE_PARALLEL flag to the save and restore APIs,
which can be used to specify the use of multiple, parallel channels
for saving and restoring a domain. The number of parallel channels
can be set using the VIR_DOMAIN_SAVE_PARAM_PARALLEL_CHANNELS
typed par
From: Claudio Fontana
Signed-off-by: Claudio Fontana
Signed-off-by: Jim Fehlig
---
docs/manpages/virsh.rst | 12 +++-
tools/virsh-domain.c| 42 +
2 files changed, 49 insertions(+), 5 deletions(-)
diff --git a/docs/manpages/virsh.rst b/docs/m
When using the mapped-ram migration capability, direct IO is
enabled by setting the "direct-io" migration parameter to
"true" and passing QEMU an additional fd with O_DIRECT set.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_migration.c | 11 ++-
src/qemu/qemu_process.c | 27
From: Claudio Fontana
Signed-off-by: Claudio Fontana
Signed-off-by: Jim Fehlig
---
docs/manpages/virsh.rst | 9 +++--
tools/virsh-domain.c| 39 +++
2 files changed, 42 insertions(+), 6 deletions(-)
diff --git a/docs/manpages/virsh.rst b/docs/manpag
Add support for parallel save and restore by mapping libvirt's
"parallel-channels" parameter to QEMU's "multifd-channels"
migration parameter.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_driver.c | 32 +---
src/qemu/qemu_migration_params.c | 31 +
25 matches
Mail list logo