Re: [PATCH v8 00/18] *** qemu: block: Support block disk along with throttle filters ***

2025-03-03 Thread Peter Krempa
On Mon, Mar 03, 2025 at 15:23:15 -, Harikumar Rajkumar wrote: > > Hi Team, > > > > Could you kindly confirm if the new version of the code is currently under > > review? > > > > Thanks and Regards, > > Harikumar R > > I just wanted to follow up on my previous message regarding the new vers

Re: [PATCH v8 01/18] schema: Add new domain elements to support multiple throttle groups

2025-03-03 Thread Peter Krempa
On Wed, Feb 19, 2025 at 22:27:05 +0530, Harikumar Rajkumar wrote: > From: Chun Feng Wu > +Disk Throttle Group Management > +-- > + > +:since:`Since 11.1.0` it is possible to create multiple named throttle groups 11.2.0 > +and then reference them within ``throttlefilte

Re: [PATCH v8 00/18] *** qemu: block: Support block disk along with throttle filters ***

2025-03-03 Thread Harikumar Rajkumar
> Hi Team, > > Could you kindly confirm if the new version of the code is currently under > review? > > Thanks and Regards, > Harikumar R I just wanted to follow up on my previous message regarding the new version of the code. Could you kindly confirm if it’s currently under review? I would

[PATCH RFC-v2 00/11] qemu: Add support for iothread to virtqueue mapping for 'virtio-scsi'

2025-03-03 Thread Peter Krempa
Unfortunately still RFC as the qemu support is still not merged. Once again there are a few patches that are applicable: qemu: Use modern header formatting in 'qemu_command.h' virXMLNodeGetSubelementList: Document return value semantics virDomainIothreadMappingDefParse: Fix usage of vir

[PATCH v2 01/11] qemu: Use modern header formatting in 'qemu_command.h'

2025-03-03 Thread Peter Krempa
The file used intermixed style. Convert the last outliers to the new formatting style. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.h | 85 - 1 file changed, 50 insertions(+), 35 deletions(-) diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_c

[PATCH v2 03/11] virDomainIothreadMappingDefParse: Fix usage of virXMLNodeGetSubelementList

2025-03-03 Thread Peter Krempa
virXMLNodeGetSubelementList always returns a non-NULL pointers thus we should check the lenght instead. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5630a46

[PATCH v2 04/11] docs: formatdomain: Clarify configuration of iothread <-> virtqueue mapping

2025-03-03 Thread Peter Krempa
Add an example for the automatic/round-robin mapping of iothreads which users should preferrably use. Until now the example contained even the full mapping which could push users to use that instead. Mention that the queues are then automatically distributed among the iothreads. Also clarify the

[PATCH v2 07/11] virDomainIothreadMapping: Add support for naming certain virt queues

2025-03-03 Thread Peter Krempa
The 'virtio-scsi' device has two extra queues 'ctrl' and 'event'. Convert the existing code to treat the 'id' virtqueue attribute as a string so that we can use the names of the queues instead of making the user refer to them via magic numbers. This patch converts the code to store the strings ins

[PATCH v2 06/11] qemu: capabilities: Introduce QEMU_CAPS_VIRTIO_SCSI_IOTHREAD_MAPPING

2025-03-03 Thread Peter Krempa
The 'virtio-scsi' controller now supports iothread<->virtqueue mapping configuration. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_10.0.0_x86_64.xml | 1 + 3 file

[PATCH v2 08/11] conf: Add support for iothread to queue mapping config for 'virtio-scsi'

2025-03-03 Thread Peter Krempa
Upcoming qemu release will support configuring mapping iothreads to virtio queues for 'virtio-scsi' controllers in order to improve performance. Reuse the infrastructure we have from the same configuration for 'virti-blk' to implement the conf support for this feature. Signed-off-by: Peter Krempa

[PATCH v2 09/11] qemu: Implement support for iothread <-> virtqueue mapping for 'virtio-scsi' controllers

2025-03-03 Thread Peter Krempa
Similarly to 'virtio-blk' users can map multiple iothreads and pin them appropriately for 'virtio-scsi' controllers to ensure the best performance. Implement the validation and command line generation based on the helpers we have for 'virtio-blk'. Signed-off-by: Peter Krempa --- src/qemu/qemu_c

[PATCH v2 02/11] virXMLNodeGetSubelementList: Document return value semantics

2025-03-03 Thread Peter Krempa
The returned value is always non-NULL. Callers need to check the lenght of the returned array instead. Signed-off-by: Peter Krempa --- src/util/virxml.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/util/virxml.c b/src/util/virxml.c index 670cace4ab..d5c7ebaf22 100644 --- a/src/util/

[PATCH v2 10/11] qemuxmlconftest: Add 'iothreads-virtio-scsi-mapping' case

2025-03-03 Thread Peter Krempa
Test the XML and commandline for iothread<->virtqueue mapping for 'virtio-scsi' controllers. Signed-off-by: Peter Krempa --- ...ads-virtio-scsi-mapping.x86_64-latest.args | 40 ...eads-virtio-scsi-mapping.x86_64-latest.xml | 65 +++ .../iothreads-virtio-scsi-mapping.

[PATCH v2 05/11] qemucapabilitiestest: Update 'caps_10.0.0_x86_64' to XXXXXX

2025-03-03 Thread Peter Krempa
Notable changes: - 'virtio-scsi' supports 'iothread-vq-mapping' - 'nbd-server-start' command supports 'handshake-max-seconds' argument --- tests/qemucapabilitiesdata/caps_10.0.0_x86_64.replies | 7 ++- tests/qemucapabilitiesdata/caps_10.0.0_x86_64.xml | 2 +- 2 files changed, 7 insertion

Re: [PATCH] qemuPrepareNVRAMFile: Fix NVRAM image conversion check

2025-03-03 Thread Jiri Denemark
On Fri, Feb 28, 2025 at 17:18:42 +0100, Peter Krempa wrote: > In case when user provides custom paths (those not covered by the JSON > firmware descriptor files or the default locations) for the > loader and nvram template no auto-detection will be performed and user's > config will be taken at fa

[PATCH v2 11/11] NEWS: Mention multiple iothread support for 'virtio-scsi' controller

2025-03-03 Thread Peter Krempa
Signed-off-by: Peter Krempa --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 9c940b1a81..37233121b6 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,12 @@ v11.2.0 (unreleased) * **New features** + * qemu: Add support for multiple iothreads for

Re: [PATCH v8 02/18] schema: Add new domain elements to support multiple throttle filters

2025-03-03 Thread Peter Krempa
On Wed, Feb 19, 2025 at 22:27:06 +0530, Harikumar Rajkumar wrote: > From: Chun Feng Wu > > Introduce schema for defining '' element which > references throttling groups to form filter chain in qemu for specific > disk > > * Add new elements '' > * can include multiple throttlegroup references t

Re: [PATCH v8 03/18] config: Introduce ThrottleGroup and corresponding XML parsing

2025-03-03 Thread Peter Krempa
On Wed, Feb 19, 2025 at 22:27:07 +0530, Harikumar Rajkumar wrote: > From: Chun Feng Wu > > Introduce throttlegroup into domain and provide corresponding methods > > * Define new struct 'virDomainThrottleGroupDef' and corresponding destructor > * Add operations(Add, Update, Del, ByName, Copy, Fre

Re: [PATCH] schemas: domaincaps: Add missing schema for ''

2025-03-03 Thread Jiri Denemark
On Mon, Mar 03, 2025 at 15:28:12 +0100, Peter Krempa wrote: > Fixes: 0236e6154c46603bc443eda2f05c8ce511c55b08 > Resolves: https://issues.redhat.com/browse/RHEL-81890 > Signed-off-by: Peter Krempa > --- > > I'll also attempt to add tests for this once I'll be able to get to a > capability dump fro

Re: [PATCH v8 00/18] *** qemu: block: Support block disk along with throttle filters ***

2025-03-03 Thread Harikumar Rajkumar
> On Mon, Mar 03, 2025 at 15:23:15 -, Harikumar Rajkumar wrote: > > Sorry I was busy. I'll pick this up. > > Please do not send any new versions until I'm done; I'll be updating > version info and ohter small things. If something larger turns up I'll > give you a branch with the small things

[PATCH 0/6] Add support for configuring PCI high memory MMIO size

2025-03-03 Thread Matthew R. Ochs via Devel
This patch series adds support for configuring the PCI high memory MMIO window size for aarch64 virt machine types. This feature has been merged into the QEMU upstream staging branch [1] and will be available in QEMU 10.0. It allows users to configure the size of the high memory MMIO window above 4

Re: [PATCH 2/2] tests: Add capabilities for QEMU 10.0 (unreleased) on aarch64

2025-03-03 Thread Matt Ochs via Devel
Thanks for updating this Andrea! Tested-by: Matthew R. Ochs

[PATCH 3/6] conf: Add PCI configuration XML parsing and formatting

2025-03-03 Thread Matthew R. Ochs via Devel
Add XML parsing and formatting support for PCI configuration: - Add virDomainFeaturesPCIDefParseXML function - Add virDomainFeaturesPCIDefFormat function - Wire up parsing in virDomainFeaturesDefParse - Wire up formatting in virDomainDefFormatFeatures - Use g_steal_pointer for memory management Th

[PATCH 1/6] domain: Add PCI configuration feature infrastructure

2025-03-03 Thread Matthew R. Ochs via Devel
Add basic infrastructure for PCI configuration feature including: - New PCI configuration structure in domain_conf.h - Add VIR_DOMAIN_FEATURE_PCI enum and string conversion - Add pci field to virDomainDef to store PCI configuration This will be used to support QEMU's highmem-mmio-size machine prop

[PATCH 5/6] qemu: Add command line support for PCI high memory MMIO size

2025-03-03 Thread Matthew R. Ochs via Devel
Add support for generating QEMU command line with PCI high memory MMIO size: - Add highmem-mmio-size to machine command line generation - Add validation for aarch64/virt machine type requirement - Add capability check for QEMU support - Add feature validation in qemu_validate.c This enables config

[PATCH 6/6] tests: Add tests for machine PCI features

2025-03-03 Thread Matthew R. Ochs via Devel
Add test coverage for machine-specific PCI features: - Add XML tests for aarch64 virt highmem-mmio-size - Add command line generation tests This ensures proper handling of machine-specific PCI features like the high memory MMIO window size configuration. Signed-off-by: Matthew R. Ochs --- ...rc

[PATCH 2/6] schema: Add PCI configuration feature schema

2025-03-03 Thread Matthew R. Ochs via Devel
Add schema definition for PCI configuration feature including: - Add element under - Add element with scaledInteger type - Support unit attribute for size specification This allows XML configuration of PCI high memory MMIO size for aarch64 virt machines. Signed-off-by: Matthew R. Ochs --- sr

[PATCH 4/6] qemu: Add capability for PCI high memory MMIO size

2025-03-03 Thread Matthew R. Ochs via Devel
Add QEMU capability for PCI high memory MMIO size configuration: - Add QEMU_CAPS_MACHINE_VIRT_HIGHMEM_MMIO_SIZE capability - Add capability to virt machine properties - Add highmem-mmio-size virt machine property to aarch64 qemu 10.0.0 capabilities This allows detecting support for the highmem-m

Release of libvirt-11.1.0

2025-03-03 Thread Jiri Denemark
The 11.1.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is

[PATCH] news: Add item for guest load averages

2025-03-03 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- NEWS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 9c940b1a8176..d7d40cf5546d 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,8 @@ v11.2.0 (unreleased) * **New features** + * qemu: Added guest load averages to the

[PATCH] schemas: domaincaps: Add missing schema for ''

2025-03-03 Thread Peter Krempa
Fixes: 0236e6154c46603bc443eda2f05c8ce511c55b08 Resolves: https://issues.redhat.com/browse/RHEL-81890 Signed-off-by: Peter Krempa --- I'll also attempt to add tests for this once I'll be able to get to a capability dump from a sev-es enabled box. src/conf/schemas/domaincaps.rng | 5 + 1 fil

Re: [PATCH v3 0/2] Enable SEV SNP support in ch driver

2025-03-03 Thread Praveen K Paladugu
Bubbling up this patchset for review. On 2/11/2025 1:18 PM, Praveen K Paladugu wrote: This version introduces virStringFormatHex method and uses this method while sending host_data to cloud-hypervisor. Praveen K Paladugu (2): util: Introduce virStringFormatHex ch: Enable SEV SNP support

[PATCH] docs/api.rst: revert erroneously change of Once -> OnDevice

2025-03-03 Thread Cleber Rosa
Commit af1b89d1d for some reason changed a perfectly fine statement to one that I could not understand. Let's revert it. Signed-off-by: Cleber Rosa --- docs/api.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/api.rst b/docs/api.rst index cdba642967..243303de68 10064

[PATCH] NEWS: Mention new 'image_format' parameter for virDomainSaveParams

2025-03-03 Thread Jim Fehlig via Devel
Signed-off-by: Jim Fehlig --- NEWS.rst | 8 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 9c940b1a81..d08a18dc02 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,14 @@ v11.2.0 (unreleased) * **New features** + * qemu: Add new 'image_format' parameter to v