Re: [PATCH 00/17] conf/qemu/etc: change several functions to return void instead of 0/-1

On Wed, Feb 26, 2025 at 10:23:12AM +, Daniel P. Berrangé wrote: On Wed, Feb 26, 2025 at 11:04:23AM +0100, Martin Kletzander wrote: On Tue, Feb 11, 2025 at 11:28:53PM -0500, Laine Stump wrote: > This started with me noticing one function call that checked for > failure on something that I kne

Re: [PATCH 00/17] conf/qemu/etc: change several functions to return void instead of 0/-1

On Wed, Feb 26, 2025 at 04:46:34PM +0100, Martin Kletzander wrote: > On Wed, Feb 26, 2025 at 10:23:12AM +, Daniel P. Berrangé wrote: > > On Wed, Feb 26, 2025 at 11:04:23AM +0100, Martin Kletzander wrote: > > > On Tue, Feb 11, 2025 at 11:28:53PM -0500, Laine Stump wrote: > > > > This started wit

Re: [PATCH 02/17] conf: change virDomainNetInsert() to return void

On 2/26/25 7:22 AM, Martin Kletzander wrote: On Tue, Feb 11, 2025 at 11:28:55PM -0500, Laine Stump wrote: It can't fail. I'm looking forward to this being the message in all the other commits =D Signed-off-by: Laine Stump --- src/conf/domain_conf.c   | 4 ++-- src/conf/domain_conf.h   | 2 +

Re: [RFC 1/4] configmake: Check for WIN32 correctly

On a Thursday in 2024, Andrea Bolognani wrote: The macro is only defined on Windows, so we shouldn't check its value but rather whether it's defined at all. Signed-off-by: Andrea Bolognani --- configmake.h.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configmake.h.in b/c

Re: [RFC 0/4] meson: Enable -Wundef

On a Thursday in 2024, Andrea Bolognani wrote: A few days ago I have posted a patch[1] that addresses an issue introduced when a meson check was dropped but some uses of the corresponding WITH_ macro were not removed at the same time. That got me thinking about what we can do to prevent such sce

Re: [PATCH 0/2] cpu_map: arm: Add AmpereOne CPU models

On 2/26/25 13:40, Jiri Denemark wrote: > Jiri Denemark (2): > cpu_arm: Report vendor ID for unknown PVRs > cpu_map: arm: Add AmpereOne CPU models > > src/cpu/cpu_arm.c | 6 -- > src/cpu_map/arm_Ampere-1.xml | 6 ++ > src/cpu_map/arm_Ampere-1a.xml | 6 ++ > src/cpu_map

Re: [PATCH 00/17] conf/qemu/etc: change several functions to return void instead of 0/-1

On Wed, Feb 26, 2025 at 11:04:23AM +0100, Martin Kletzander wrote: The classic Hal fixing a lightbulb moment ;) At least more productive than spending an hour performing the "Hal looking for his glasses" routine (my variation usually concerns my phone, which is invariably in one of my pockets

[PATCH 05/10] qemuAgentFSInfoFormatParams: Convert interface code to virTypedParamList

Also remove stale TODO comment as we already report disk target. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 86 +++--- 1 file changed, 23 insertions(+), 63 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 515577b71

[PATCH 03/10] virDomainInterfaceFormatParams: Convert interface code to virTypedParamList

Also deletes pre-existing broken formatting. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 60 ++ 1 file changed, 14 insertions(+), 46 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 3eabb0e1ed..3ebc712f9a 100644

Re: [PATCH 00/10] qemu: Refactor typed parameter handling in qemuDomainGetGuestInfo

On a Wednesday in 2025, Peter Krempa wrote: Use virTypedParam list to construct the returned data. Note that this applies on top of two patch(sets) that were ACK'd upstream: [PATCH v2 0/4] Add support for getting load averages from guest agent [PATCH] qemu: Report disk bus as reported by agent

Re: [PATCH v8 00/18] *** qemu: block: Support block disk along with throttle filters ***

Hi Team, Could you kindly confirm if the new version of the code is currently under review? Thanks and Regards, Harikumar R

[PATCH 00/10] qemu: Refactor typed parameter handling in qemuDomainGetGuestInfo

Use virTypedParam list to construct the returned data. Note that this applies on top of two patch(sets) that were ACK'd upstream: [PATCH v2 0/4] Add support for getting load averages from guest agent [PATCH] qemu: Report disk bus as reported by agent in virDomainGetGuestInfo You can fetch the

[PATCH 02/10] qemuDomainGetGuestInfo: Convert load code to virTypedParamList

Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 3d2ebd7719..3eabb0e1ed 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19589,9 +19589,9 @@ qe

[PATCH 06/10] qemuAgentGetTimezone: Convert to virTypedParamList

Signed-off-by: Peter Krempa --- src/qemu/qemu_agent.c | 14 -- src/qemu/qemu_agent.h | 4 +--- src/qemu/qemu_driver.c | 2 +- tests/qemuagenttest.c | 39 --- 4 files changed, 22 insertions(+), 37 deletions(-) diff --git a/src/qemu/qemu_agent.c

[PATCH 09/10] qemuDomainGetGuestInfo: Convert hostname code to virTypedParamList

Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index cd07d3eac5..5d91bd1a93 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19356,7 +19356,6 @@ qe

[PATCH 08/10] qemuAgentGetUsers: Convert to virTypedParamList

Signed-off-by: Peter Krempa --- src/qemu/qemu_agent.c | 29 +- src/qemu/qemu_agent.h | 4 +-- src/qemu/qemu_driver.c | 2 +- tests/qemuagenttest.c | 55 +++--- 4 files changed, 33 insertions(+), 57 deletions(-) diff --git a/src/qemu/qe

[PATCH 10/10] qemuDomainGetGuestInfo: Remove temporary infrastructure

Now that the refactor was completed the helper infrastructure can be removed. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 5d91bd1a93..c69074766b 100644 --- a/src/qemu/qemu_dr

[PATCH 07/10] qemuAgentGetOSInfo: Convert to virTypedParamList

Signed-off-by: Peter Krempa --- src/qemu/qemu_agent.c | 9 ++- src/qemu/qemu_agent.h | 4 +--- src/qemu/qemu_driver.c | 2 +- tests/qemuagenttest.c | 54 -- 4 files changed, 30 insertions(+), 39 deletions(-) diff --git a/src/qemu/qemu_agent.c b/s

[PATCH 01/10] qemuDomainGetGuestInfo: Prepare for refactor to virTypedParamList

Use of raw typed param APIs is very clunky. Prepare qemuDomainGetGuestInfo for step-by-step refactor to virTypedParamList. The two lists will coexist until the refactor is complete. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 10 ++ 1 file changed, 10 insertions(+) diff --

[PATCH 04/10] qemuAgentDiskInfoFormatParams: Convert interface code to virTypedParamList

Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 81 +++--- 1 file changed, 21 insertions(+), 60 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 3ebc712f9a..515577b71a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/q

[PATCH v2 7/7] qemu: support MSDM ACPI table type

The MSDM ACPI table is a replacement for the SLIC table type, now preferred by Microsoft for Windows Licensing checks: https://learn.microsoft.com/en-us/previous-versions/windows/hardware/design/dn653305(v=vs.85) Resolves: https://gitlab.com/libvirt/libvirt/-/issues/748 Signed-off-by: Daniel P

[PATCH v2 6/7] conf: support MSDM ACPI table type

The MSDM ACPI table is an alternative for the SLIC table type, sometimes used by Microsoft for Windows Licensing checks: https://learn.microsoft.com/en-us/previous-versions/windows/hardware/design/dn653305(v=vs.85) Signed-off-by: Daniel P. Berrangé --- docs/formatdomain.rst | 4 +

[PATCH v2 3/7] src: introduce 'raw' and 'rawset' ACPI table types

The QEMU driver has only accepted type=slic even though QEMU is able to accept individual tables of any type, without needing to specify a signature. Introduce type=raw to address this usage scenario. Contrary to other types, this one may appear multiple times. The Xen driver has mistakenly accept

[PATCH v2 4/7] qemu: support 'raw' ACPI table type

This allows passing a single ACPI table of any type through to QEMU with the signture autodetected from the header. Signed-off-by: Daniel P. Berrangé --- docs/formatdomain.rst | 2 +- src/qemu/qemu_command.c | 6 ++- src/qemu/qemu_validate.c

[PATCH v2 2/7] src: validate permitted ACPI table types in libxl/qemu drivers

This forces us to update the drivers when defining new table types to avoid incorrectly accepting them by default. Signed-off-by: Daniel P. Berrangé --- src/libxl/libxl_domain.c | 19 +++ src/qemu/qemu_validate.c | 15 +++ 2 files changed, 34 insertions(+) diff --git

[PATCH v2 1/7] conf: introduce support for multiple ACPI tables

Currently we parse ...path... into a flat 'char *slic_table' field which is rather an anti-pattern as it has special cased a single attribute type. This rewrites the internal design to permit multiple table types to be parsed, should we add more in future. Each type is

[PATCH v2 0/7] Add support for more ACPI table types

This was triggered by a request by KubeVirt in https://gitlab.com/libvirt/libvirt/-/issues/748 I've not functionally tested this, since I lack any suitable guest windows environment this is looking for MSDM tables, nor does my machine have MSDM ACPI tables to pass to a guest. I'm blindly assum

[PATCH v2 5/7] libxl: support 'rawset' ACPI table type

This fixes representation of the 'acpi_firmware' config in the Xen driver, which repesents a concatenation of tables of any type. Use of 'type=slic' is accepted on input for backwards compatibility. Signed-off-by: Daniel P. Berrangé --- src/libxl/libxl_domain.c | 5 +++--

Re: [libvirt PATCH] qemu: snapshot: error out early when reverting snapshot for VM with non-file disk

On Wed, Feb 26, 2025 at 11:33:52 +0100, Pavel Hrdina wrote: > Before this patch the code would start the revert process by destroying > the VM and preparing to revert where it would fail with following error: > > error: unsupported configuration: source for disk 'sdb' is not a regular > file;

[PATCH] qemu: Report disk bus as reported by agent in virDomainGetGuestInfo

KubeVirt decided to report this to the users. In order to allow them to use proper APIs expose the field as well. Resolves: https://issues.redhat.com/browse/RHEL-80688 Signed-off-by: Peter Krempa --- docs/manpages/virsh.rst | 1 + src/libvirt-domain.c| 1 + src/qemu/qemu_driver.c | 9 ++

[libvirt PATCH] docs: formatdomain: fix typo in passt section

A mismatch in backticks happened. Fixes: a47a89a9d335c111a9c2fbb3f4e1c3a13001e74b Reported-by: Yalan Zhang Signed-off-by: Ján Tomko --- Pushed. docs/formatdomain.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index fdb3c245

Re: [PATCH 00/17] conf/qemu/etc: change several functions to return void instead of 0/-1

On Tue, Feb 11, 2025 at 11:28:53PM -0500, Laine Stump wrote: This started with me noticing one function call that checked for failure on something that I knew couldn't fail. So I changed that function to return void. But then I noticed another similar function that also should return void, so I c

Re: [PATCH 00/17] conf/qemu/etc: change several functions to return void instead of 0/-1

On Wed, Feb 26, 2025 at 11:04:23AM +0100, Martin Kletzander wrote: > On Tue, Feb 11, 2025 at 11:28:53PM -0500, Laine Stump wrote: > > This started with me noticing one function call that checked for > > failure on something that I knew couldn't fail. So I changed that > > function to return void. B

[libvirt PATCH] qemu: snapshot: error out early when reverting snapshot for VM with non-file disk

Before this patch the code would start the revert process by destroying the VM and preparing to revert where it would fail with following error: error: unsupported configuration: source for disk 'sdb' is not a regular file; refusing to generate external snapshot name and leaving user with of

Re: [PATCH] qemu: Report disk bus as reported by agent in virDomainGetGuestInfo

On a Wednesday in 2025, Peter Krempa wrote: KubeVirt decided to report this to the users. In order to allow them to use proper APIs expose the field as well. Resolves: https://issues.redhat.com/browse/RHEL-80688 Signed-off-by: Peter Krempa --- docs/manpages/virsh.rst | 1 + src/libvirt-domain.c

[PATCH 1/2] virt-aa-helper: Avoid using RUNSTATEDIR

On some systems /run is mounted as: tmpfs on /run type tmpfs (rw,nosuid,nodev,noexec,relatime,size=348508k,mode=755,inode64) and /var/run is then just a symlink: # ls -ld /var/run lrwxrwxrwx 1 root root 4 Apr 23 2024 /var/run -> /run But because we still think it's 2004 and FHS 2.3 is a

Re: [PATCH] virt-aa-helper: Avoid using RUNSTATEDIR

On a Wednesday in 2025, Michal Privoznik wrote: On some systems /run is mounted as: tmpfs on /run type tmpfs (rw,nosuid,nodev,noexec,relatime,size=348508k,mode=755,inode64) and /var/run is then just a symlink: # ls -ld /var/run lrwxrwxrwx 1 root root 4 Apr 23 2024 /var/run -> /run But be

[PATCH 2/2] meson: Generate runstatedir according to newer standard

While previously FHS 2.3 defined /var/run as a place to store runtime information [1] it's no longer 2004 and newer specification was released which favors /run [2]. Since it was released 10 years ago, maybe it's time we start honouring it. On majority of Linux systems (if not all), /var/run is a

Re: [PATCH 06/17] libxl: change xenDomainDefAddImplicitInputDevice() to return void

On Tue, Feb 11, 2025 at 11:28:59PM -0500, Laine Stump wrote: It can't fail. Signed-off-by: Laine Stump Reviewed-by: Martin Kletzander signature.asc Description: PGP signature

Re: [PATCH 07/17] conf: change qemuDomainDefAddImplicitInputDevice() to return void

On Tue, Feb 11, 2025 at 11:29:00PM -0500, Laine Stump wrote: It can't fail. Signed-off-by: Laine Stump Reviewed-by: Martin Kletzander signature.asc Description: PGP signature

Re: [PATCH 08/17] conf: stop checking for NULL return from virDomainControllerDefNew()

On Tue, Feb 11, 2025 at 11:29:01PM -0500, Laine Stump wrote: It can't fail, so the caller doesn't need to check the return. My dream broke, the perfect message is no longer, disappointed ;) On the other hand this commit by itself eliminates so many parentheses that it looks like we ditched li

[PATCH] virt-aa-helper: Avoid using RUNSTATEDIR

On some systems /run is mounted as: tmpfs on /run type tmpfs (rw,nosuid,nodev,noexec,relatime,size=348508k,mode=755,inode64) and /var/run is then just a symlink: # ls -ld /var/run lrwxrwxrwx 1 root root 4 Apr 23 2024 /var/run -> /run But because we still think it's 2004 and FHS 2.3 is a

Re: [PATCH 02/17] conf: change virDomainNetInsert() to return void

On Tue, Feb 11, 2025 at 11:28:55PM -0500, Laine Stump wrote: It can't fail. I'm looking forward to this being the message in all the other commits =D Signed-off-by: Laine Stump --- src/conf/domain_conf.c | 4 ++-- src/conf/domain_conf.h | 2 +- src/libxl/libxl_driver.c | 3 +-- src/lxc/lxc

Re: [PATCH 03/17] conf: change virDomainFSInsert() to return void

On Tue, Feb 11, 2025 at 11:28:56PM -0500, Laine Stump wrote: It can't fail. Signed-off-by: Laine Stump Reviewed-by: Martin Kletzander signature.asc Description: PGP signature

Re: [PATCH 04/17] conf: change virDomainShmemDefInsert() to return void

On Tue, Feb 11, 2025 at 11:28:57PM -0500, Laine Stump wrote: It can't fail. Signed-off-by: Laine Stump Reviewed-by: Martin Kletzander signature.asc Description: PGP signature

Re: [PATCH 1/2] virt-aa-helper: Avoid using RUNSTATEDIR

On Wed, Feb 26, 2025 at 01:27:19PM +0100, Michal Privoznik wrote: > On some systems /run is mounted as: > > tmpfs on /run type tmpfs > (rw,nosuid,nodev,noexec,relatime,size=348508k,mode=755,inode64) > > and /var/run is then just a symlink: > > # ls -ld /var/run > lrwxrwxrwx 1 root root 4

Re: [PATCH 2/2] meson: Generate runstatedir according to newer standard

On Wed, Feb 26, 2025 at 01:27:20PM +0100, Michal Privoznik wrote: > While previously FHS 2.3 defined /var/run as a place to store > runtime information [1] it's no longer 2004 and newer > specification was released which favors /run [2]. Since it was > released 10 years ago, maybe it's time we star

Re: [PATCH 05/17] conf: change virDomainDefMaybeAddInput() to return void

On Tue, Feb 11, 2025 at 11:28:58PM -0500, Laine Stump wrote: It can't fail. Signed-off-by: Laine Stump Reviewed-by: Martin Kletzander --- src/conf/domain_conf.c| 6 ++ src/conf/domain_conf.h| 2 +- src/libxl/xen_common.c| 11 ++- src/qemu/qemu_postparse.c | 27 ++

Re: [PATCH 09/17] conf: stop checking for NULL return from virDomainDefAddController()

On Tue, Feb 11, 2025 at 11:29:02PM -0500, Laine Stump wrote: It can't fail, so the caller doesn't need to check the return. Signed-off-by: Laine Stump Reviewed-by: Martin Kletzander signature.asc Description: PGP signature

Re: [PATCH 10/17] conf: change virDomainDefAddUSBController() to return void

On Tue, Feb 11, 2025 at 11:29:03PM -0500, Laine Stump wrote: It can't fail. Signed-off-by: Laine Stump --- src/conf/domain_conf.c| 8 +++- src/conf/domain_conf.h| 2 +- src/qemu/qemu_postparse.c | 6 ++ 3 files changed, 6 insertions(+), 10 deletions(-) diff --git a/src/conf/domain

[PATCH 2/2] cpu_map: arm: Add AmpereOne CPU models

Signed-off-by: Jiri Denemark --- src/cpu_map/arm_Ampere-1.xml | 6 ++ src/cpu_map/arm_Ampere-1a.xml | 6 ++ src/cpu_map/arm_vendors.xml | 1 + src/cpu_map/index.xml | 5 + 4 files changed, 18 insertions(+) create mode 100644 src/cpu_map/arm_Ampere-1.xml create mode 100644

[PATCH 0/2] cpu_map: arm: Add AmpereOne CPU models

Jiri Denemark (2): cpu_arm: Report vendor ID for unknown PVRs cpu_map: arm: Add AmpereOne CPU models src/cpu/cpu_arm.c | 6 -- src/cpu_map/arm_Ampere-1.xml | 6 ++ src/cpu_map/arm_Ampere-1a.xml | 6 ++ src/cpu_map/arm_vendors.xml | 1 + src/cpu_map/index.xml

[PATCH 1/2] cpu_arm: Report vendor ID for unknown PVRs

Signed-off-by: Jiri Denemark --- src/cpu/cpu_arm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/cpu/cpu_arm.c b/src/cpu/cpu_arm.c index 7a9c8163c8..8e6e11dc57 100644 --- a/src/cpu/cpu_arm.c +++ b/src/cpu/cpu_arm.c @@ -604,6 +604,8 @@ virCPUarmCpuDataFromRegs(virCP

Re: [PATCH 11/17] hyperv: change hypervDomainDefAppendController() to return void

On Tue, Feb 11, 2025 at 11:29:04PM -0500, Laine Stump wrote: It can't fail. And as a result, hypervDomainDefAppendSCSIController() and hypervDomainDefAppendIDEController() can also be changed to return void. Signed-off-by: Laine Stump Reviewed-by: Martin Kletzander signature.asc Descriptio

Re: [libvirt PATCH] qemu: snapshot: error out early when reverting snapshot for VM with non-file disk

On Wed, Feb 26, 2025 at 12:29:14PM +0100, Peter Krempa wrote: > On Wed, Feb 26, 2025 at 11:33:52 +0100, Pavel Hrdina wrote: > > Before this patch the code would start the revert process by destroying > > the VM and preparing to revert where it would fail with following error: > > > > error: un

Re: [PATCH 13/17] conf: change virDomainDefMaybeAddHostdevSCSIcontroller() to return void

On Tue, Feb 11, 2025 at 11:29:06PM -0500, Laine Stump wrote: It can't fail. Signed-off-by: Laine Stump --- src/conf/domain_conf.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 611b6a44c8..d3e95a2f92 100644 -

Re: [PATCH 17/17] conf: change virDomainDefAddImplicitControllers() to return void

On Tue, Feb 11, 2025 at 11:29:10PM -0500, Laine Stump wrote: It can't fail. Signed-off-by: Laine Stump Patches 14-17 are also Reviewed-by: Martin Kletzander signature.asc Description: PGP signature