[libvirt PATCH 2/3] ci: use Fedora 41 to run integration tests

2025-02-25 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- ci/integration.yml | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/ci/integration.yml b/ci/integration.yml index ced3fbc3c2..2c5e5a65bc 100644 --- a/ci/integration.yml +++ b/ci/integration.yml @@ -29,23 +29,23 @@ centos-st

[libvirt PATCH 1/3] ci: use iptables to run libvirt-tck

2025-02-25 Thread Pavel Hrdina
On current Fedora libvirt uses nftables by default but the libvirt-tck tests are not ready for it and most of the nwfilter tests fail. We need to keep using iptables for now. Signed-off-by: Pavel Hrdina --- ci/jobs.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ci/jobs.sh b/ci/jobs.sh

[libvirt PATCH 0/3] ci: patches to make integration tests work

2025-02-25 Thread Pavel Hrdina
I've tested this on our hosts that are using for gitlab integration tests and everything seems to be working now. There were multiple issues I've encountered: - on Fedora 41 current selinux policy silently blocks virtnwfilterd to create_socket_perms for packet_socket resulting in this e

[libvirt PATCH 3/3] ci: refresh with 'lcitool manifest'

2025-02-25 Thread Pavel Hrdina
Replace Alpine Linux v3.19 with v3.21. Signed-off-by: Pavel Hrdina --- ci/buildenv/{alpine-319.sh => alpine-321.sh} | 0 .../{alpine-319.Dockerfile => alpine-321.Dockerfile} | 2 +- ci/gitlab/builds.yml | 8 ci/gitlab/containers.yml

Re: [PATCH] apparmor: Allow SGX if configured

2025-02-25 Thread Ján Tomko
On a Tuesday in 2025, Michal Privoznik wrote: If SGX memory model is configured for domain then we need to allow QEMU access some additional files: 1) /dev/sgx_vepc needs to be RW 2) /dev/sgx_provision needs to be RO We already do this in SELinux driver but not in AppArmor. Resolves: https:/

[PATCH] qemu: Add guest load average to domain stats

2025-02-25 Thread Martin Kletzander
Since this is already in QEMU we can add this stat which might be useful for people. Resolves: https://issues.redhat.com/browse/RHEL-71883 Signed-off-by: Martin Kletzander --- docs/manpages/virsh.rst | 3 +++ src/libvirt-domain.c| 3 +++ src/qemu/qemu_agent.c | 59 +++

[PATCH] apparmor: Allow SGX if configured

2025-02-25 Thread Michal Privoznik
If SGX memory model is configured for domain then we need to allow QEMU access some additional files: 1) /dev/sgx_vepc needs to be RW 2) /dev/sgx_provision needs to be RO We already do this in SELinux driver but not in AppArmor. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/751 Sign

Re: [PATCH] qemu: Add guest load average to domain stats

2025-02-25 Thread Peter Krempa
On Tue, Feb 25, 2025 at 11:51:28 +0100, Martin Kletzander wrote: > Since this is already in QEMU we can add this stat which might be useful > for people. > > Resolves: https://issues.redhat.com/browse/RHEL-71883 > Signed-off-by: Martin Kletzander > --- > docs/manpages/virsh.rst | 3 +++ > src/l

Re: [PATCH 3/4] bhyve: add command line argument "passthru"

2025-02-25 Thread Roman Bogorodskiy
Alexander Shursha wrote: > Signed-off-by: Alexander Shursha > --- > src/bhyve/bhyve_command.c | 24 > .../bhyvexml2argv-passthru.args | 9 ++ > .../bhyvexml2argv-passthru.ldargs | 4 +++ > .../bhyvexml2argv-passthru.xml

Re: [PATCH V2 2/2] qemu: Add support for 'image_format' typed parameter

2025-02-25 Thread Jim Fehlig via Devel
On 2/25/25 07:43, Daniel P. Berrangé wrote: On Thu, Feb 20, 2025 at 05:23:54PM -0700, Jim Fehlig via Devel wrote: Add support for the 'image_format' typed parameter in virDomainSaveParams. The parameter overrides the 'save_image_format' setting in qemu.conf. Signed-off-by: Jim Fehlig --- src

Re: [PATCH 4/4] bhyve: parse "passthru" commandline argument

2025-02-25 Thread Roman Bogorodskiy
Alexander Shursha wrote: > Signed-off-by: Alexander Shursha > --- > src/bhyve/bhyve_parse_command.c | 60 +++ > .../bhyveargv2xml-passthru.args | 7 +++ > .../bhyveargv2xml-passthru.xml| 22 +++ > tests/bhyveargv2xmltest.c

Re: [PATCH V2 2/2] qemu: Add support for 'image_format' typed parameter

2025-02-25 Thread Daniel P . Berrangé
On Tue, Feb 25, 2025 at 11:34:24AM -0700, Jim Fehlig wrote: > On 2/25/25 07:43, Daniel P. Berrangé wrote: > > On Thu, Feb 20, 2025 at 05:23:54PM -0700, Jim Fehlig via Devel wrote: > > > Add support for the 'image_format' typed parameter in virDomainSaveParams. > > > The parameter overrides the 'sav

Re: [PATCH 4/4] bhyve: parse "passthru" commandline argument

2025-02-25 Thread Roman Bogorodskiy
Peter Krempa wrote: > On Tue, Feb 25, 2025 at 19:36:24 +0100, Roman Bogorodskiy wrote: > > Alexander Shursha wrote: > > > > > Signed-off-by: Alexander Shursha > > > --- > > > src/bhyve/bhyve_parse_command.c | 60 +++ > > > .../bhyveargv2xml-passthru.args

Re: [PATCH 4/4] bhyve: parse "passthru" commandline argument

2025-02-25 Thread Peter Krempa
On Tue, Feb 25, 2025 at 19:36:24 +0100, Roman Bogorodskiy wrote: > Alexander Shursha wrote: > > > Signed-off-by: Alexander Shursha > > --- > > src/bhyve/bhyve_parse_command.c | 60 +++ > > .../bhyveargv2xml-passthru.args | 7 +++ > > .../bhyveargv2x

Re: [PATCH v2 0/4] Add support for getting load averages from guest agent

2025-02-25 Thread Peter Krempa
On Tue, Feb 25, 2025 at 17:17:46 +0100, Martin Kletzander wrote: > On Tue, Feb 25, 2025 at 05:02:35PM +0100, Peter Krempa wrote: > > On Tue, Feb 25, 2025 at 15:52:28 +0100, Martin Kletzander wrote: > > > I'm drawing blanks when it comes to commit messages today. But this > > > still has > > > tim

Re: [PATCH v2 0/4] Add support for getting load averages from guest agent

2025-02-25 Thread Ján Tomko
On a Tuesday in 2025, Peter Krempa wrote: On Tue, Feb 25, 2025 at 17:17:46 +0100, Martin Kletzander wrote: On Tue, Feb 25, 2025 at 05:02:35PM +0100, Peter Krempa wrote: > On Tue, Feb 25, 2025 at 15:52:28 +0100, Martin Kletzander wrote: > > I'm drawing blanks when it comes to commit messages toda

Re: [PATCH 4/4] bhyve: parse "passthru" commandline argument

2025-02-25 Thread Peter Krempa
On Tue, Feb 25, 2025 at 21:27:43 +0100, Roman Bogorodskiy wrote: > Peter Krempa wrote: [...] > > > Need to check if hostdev is NULL. > > > > That can't happen: > > > > virDomainHostdevDef * > > virDomainHostdevDefNew(void) > > { > > virDomainHostdevDef *def; > > > > def = g_new0(virD

[PATCH v2 0/4] Add support for getting load averages from guest agent

2025-02-25 Thread Martin Kletzander
I'm drawing blanks when it comes to commit messages today. But this still has time, because even though the patches are in QEMU upstream, but not a part of a release yet. However nothing should break if we add support earlier... Right? O:-) v2: - split patches - add it to guestinfo instead of

[PATCH v2 3/4] qemu: Add support for VIR_DOMAIN_GUEST_INFO_LOAD

2025-02-25 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- src/qemu/qemu_driver.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 80c918312b8f..3b8b2c0a1eda 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @

Re: [libvirt PATCH 0/3] ci: patches to make integration tests work

2025-02-25 Thread Martin Kletzander
On Tue, Feb 25, 2025 at 10:30:46AM +0100, Pavel Hrdina wrote: I've tested this on our hosts that are using for gitlab integration tests and everything seems to be working now. There were multiple issues I've encountered: - on Fedora 41 current selinux policy silently blocks virtnwfilterd

Re: [PATCH V2 2/4] qemu: Don't ignore dump image format errors

2025-02-25 Thread Daniel P . Berrangé
On Thu, Feb 20, 2025 at 05:11:36PM -0700, Jim Fehlig via Devel wrote: > Long ago, without justification, commit 48cb9f0542 changed > qemuGetCompressionProgram (since renamed to > qemuSaveImageGetCompressionProgram) to ignore configuration errors > for dump operations. Like the other save-related op

Re: [PATCH V2 4/4] qemu: Check for valid save image formats when loading driver config

2025-02-25 Thread Daniel P . Berrangé
On Thu, Feb 20, 2025 at 05:11:38PM -0700, Jim Fehlig via Devel wrote: > Checking for valid 'foo_image_format' settings in qemu.conf is not done > until the settings are used. Move the checks to > virQEMUDriverConfigLoadSaveEntry, allowing to report incorrect format > settings at driver startup. >

Re: [PATCH V2 2/2] qemu: Add support for 'image_format' typed parameter

2025-02-25 Thread Daniel P . Berrangé
On Thu, Feb 20, 2025 at 05:23:54PM -0700, Jim Fehlig via Devel wrote: > Add support for the 'image_format' typed parameter in virDomainSaveParams. > The parameter overrides the 'save_image_format' setting in qemu.conf. > > Signed-off-by: Jim Fehlig > --- > src/qemu/qemu_driver.c | 20 +++

Re: [PATCH V2 4/4] qemu: Check for valid save image formats when loading driver config

2025-02-25 Thread Daniel P . Berrangé
On Thu, Feb 20, 2025 at 05:39:17PM -0700, Jim Fehlig via Devel wrote: > On 2/20/25 17:11, Jim Fehlig wrote: > > Checking for valid 'foo_image_format' settings in qemu.conf is not done > > until the settings are used. Move the checks to > > virQEMUDriverConfigLoadSaveEntry, allowing to report incorr

[PATCH v2 4/4] virsh: Add support for VIR_DOMAIN_GUEST_INFO_LOAD

2025-02-25 Thread Martin Kletzander
Resolves: https://issues.redhat.com/browse/RHEL-71883 Signed-off-by: Martin Kletzander --- docs/manpages/virsh.rst | 8 +++- tools/virsh-domain.c| 6 ++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 06c2802b3f9f.

[PATCH v2 2/4] qemu_agent: Add qemuAgentGetLoadAvg()

2025-02-25 Thread Martin Kletzander
With qemu guest agent 9.3 we are able to get the load averages with a new command. Signed-off-by: Martin Kletzander --- src/qemu/qemu_agent.c | 55 +++ src/qemu/qemu_agent.h | 6 + tests/qemuagenttest.c | 53 +

[PATCH v2 1/4] Add load average information type into virDomainGetGuestInfo

2025-02-25 Thread Martin Kletzander
The public API part. Signed-off-by: Martin Kletzander --- include/libvirt/libvirt-domain.h | 1 + src/libvirt-domain.c | 8 2 files changed, 9 insertions(+) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index f5420bca6e23..2d27f96be94d 100

Re: [PATCH] qemu: Add guest load average to domain stats

2025-02-25 Thread Martin Kletzander
On Tue, Feb 25, 2025 at 12:11:21PM +0100, Peter Krempa wrote: On Tue, Feb 25, 2025 at 11:51:28 +0100, Martin Kletzander wrote: Since this is already in QEMU we can add this stat which might be useful for people. Resolves: https://issues.redhat.com/browse/RHEL-71883 Signed-off-by: Martin Kletzan

Re: [PATCH v2 2/4] qemu_agent: Add qemuAgentGetLoadAvg()

2025-02-25 Thread Peter Krempa
On Tue, Feb 25, 2025 at 15:52:30 +0100, Martin Kletzander wrote: > With qemu guest agent 9.3 we are able to get the load averages with a > new command. > > Signed-off-by: Martin Kletzander > --- > src/qemu/qemu_agent.c | 55 +++ > src/qemu/qemu_agent.h |

Re: [PATCH v2 0/4] Add support for getting load averages from guest agent

2025-02-25 Thread Peter Krempa
On Tue, Feb 25, 2025 at 15:52:28 +0100, Martin Kletzander wrote: > I'm drawing blanks when it comes to commit messages today. But this still has > time, because even though the patches are in QEMU upstream, but not a part of > a > release yet. However nothing should break if we add support earli

Re: [PATCH v2 0/4] Add support for getting load averages from guest agent

2025-02-25 Thread Martin Kletzander
On Tue, Feb 25, 2025 at 05:02:35PM +0100, Peter Krempa wrote: On Tue, Feb 25, 2025 at 15:52:28 +0100, Martin Kletzander wrote: I'm drawing blanks when it comes to commit messages today. But this still has time, because even though the patches are in QEMU upstream, but not a part of a release ye