Re: [PATCH RFC] util: pick a better runtime directory when XDG_RUNTIME_DIR isn't set

2025-02-17 Thread Daniel P . Berrangé
On Mon, Feb 17, 2025 at 11:31:32AM +, Richard W.M. Jones wrote: > On Mon, Feb 17, 2025 at 02:14:49AM -0500, Laine Stump wrote: > > == > > > > I'm sending this as an RFC just because what it's doing feels kind of > > dirty - directly examining XDG_RUNTIME_DIR seems like an "end run" > > aro

Re: [PATCH 12/12] docs: document using passt backend with

2025-02-17 Thread Andrea Bolognani
On Sat, Feb 15, 2025 at 12:20:17AM -0500, Laine Stump wrote: > +vhost-user connection with passt backend > + > + > +:since:`Since 11.1.0 (QEMU and KVM only)` passt can be used as the > +other end of the vhost-user connection. This is a compelling > +alternati

Re: [PATCH] utils: Canonicalize paths before comparing them

2025-02-17 Thread Andrea Bolognani
On Mon, Feb 17, 2025 at 04:49:17PM +, Daniel P. Berrangé wrote: > On Mon, Feb 17, 2025 at 05:44:51PM +0100, Andrea Bolognani wrote: > > Resolves: https://issues.redhat.com/browse/RHEL-79165 > > Please explain the problem in the commit message. Issue tracker links > in general should not be reli

Re: [PATCH 12/12] docs: document using passt backend with

2025-02-17 Thread Laine Stump
On 2/17/25 9:13 AM, Andrea Bolognani wrote: On Sat, Feb 15, 2025 at 12:20:17AM -0500, Laine Stump wrote: +vhost-user connection with passt backend + + +:since:`Since 11.1.0 (QEMU and KVM only)` passt can be used as the +other end of the vhost-user connecti

Re: [PATCH 1/3] qemu: Move declaration of virQEMUSaveFormat to header file

2025-02-17 Thread Daniel P . Berrangé
On Fri, Feb 14, 2025 at 03:48:16PM -0700, Jim Fehlig via Devel wrote: > Allow use of the enum outside of qemu_saveimage. > > Signed-off-by: Jim Fehlig > --- > src/qemu/qemu_saveimage.c | 19 --- > src/qemu/qemu_saveimage.h | 19 +++ > 2 files changed, 19 insertion

Re: [PATCH 1/1] RFC: Add Arm CCA support for getting capability information and running Realm VM

2025-02-17 Thread Michal Prívozník
On 2/14/25 02:06, Akio Kakuno (Fujitsu) via Devel wrote: > Hi, all! > > I'm adding three test for CCA compatibility: > domaincapstest, qemucapabilitiestest, and qemuxmlconftest. > This is because SEV-SNP added these three tests. > > I have three questions regarding these tests: > 1. How to add

Re: [PATCH] utils: Canonicalize paths before comparing them

2025-02-17 Thread Daniel P . Berrangé
On Mon, Feb 17, 2025 at 05:44:51PM +0100, Andrea Bolognani wrote: > Resolves: https://issues.redhat.com/browse/RHEL-79165 Please explain the problem in the commit message. Issue tracker links in general should not be relied upon as explanation, as they tend to end up going away over time. The issu

[PATCH] build-aux: squelch trailing blank warnings from binary files

2025-02-17 Thread Daniel P . Berrangé
These files pollute the stderr output when the sc_trailing_blank syntax check fails. Signed-off-by: Daniel P. Berrangé --- build-aux/syntax-check.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index e6afb879be..bd3dd6c

[PATCH] utils: Canonicalize paths before comparing them

2025-02-17 Thread Andrea Bolognani
Resolves: https://issues.redhat.com/browse/RHEL-79165 Signed-off-by: Andrea Bolognani --- src/util/virfile.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 6ac0f4efb3..7cab3d0cd6 100644 --- a/src/util/virfile.c +++ b/src/

Re: [PATCH RFC] util: pick a better runtime directory when XDG_RUNTIME_DIR isn't set

2025-02-17 Thread Laine Stump
On 2/17/25 3:11 PM, Laine Stump wrote: On 2/17/25 5:28 AM, Daniel P. Berrangé wrote: On Mon, Feb 17, 2025 at 02:14:49AM -0500, Laine Stump wrote: But sometimes XDG_RUNTIME_DIR isn't set in the user's environment. Do you have examples of scenarios in which this happens, and yet the /run/user/N

Re: [PATCH RFC 00/13] qemu: Add support for iothread to virtqueue mapping for 'virtio-scsi'

2025-02-17 Thread Stefan Hajnoczi
On Fri, Feb 14, 2025 at 05:29:34PM +0100, Peter Krempa wrote: > The first part of the series refactors the existing code for reuse and > then uses the new helpers to implement the feature. > > Note that this series is in RFC state as the qemu patches are still > being discussed. Thus also the capa

[PATCH] util: fix compile warning in virsystemd.c during mingw builds

2025-02-17 Thread Laine Stump
A function was changed from having no arguments to having a single argument, but the entire body of the function was #ifdefed out for windows builds, leaving that new argument unused. Surprisingly this didn't cause the build to fail, but I happened to notice it flit by during an rpm build. Fixes:

Re: [PATCH RFC] util: pick a better runtime directory when XDG_RUNTIME_DIR isn't set

2025-02-17 Thread Laine Stump
On 2/17/25 5:02 AM, Martin Kletzander wrote: On Mon, Feb 17, 2025 at 02:14:49AM -0500, Laine Stump wrote: == I'm sending this as an RFC just because what it's doing feels kind of dirty - directly examining XDG_RUNTIME_DIR seems like an "end run" around the Glib API. If anyone has a better i

Re: [PATCH RFC] util: pick a better runtime directory when XDG_RUNTIME_DIR isn't set

2025-02-17 Thread Laine Stump
On 2/17/25 5:28 AM, Daniel P. Berrangé wrote: On Mon, Feb 17, 2025 at 02:14:49AM -0500, Laine Stump wrote: But sometimes XDG_RUNTIME_DIR isn't set in the user's environment. Do you have examples of scenarios in which this happens, and yet the /run/user/ directory is still being created, as

Re: [PATCH RFC] util: pick a better runtime directory when XDG_RUNTIME_DIR isn't set

2025-02-17 Thread Daniel P . Berrangé
On Mon, Feb 17, 2025 at 02:14:49AM -0500, Laine Stump wrote: > But sometimes XDG_RUNTIME_DIR isn't set in the user's environment. Do you have examples of scenarios in which this happens, and yet the /run/user/ directory is still being created, as that rather sounds like something is broken out

Re: [PATCH 3/3] qemu: Change return value of SaveImageGetCompressionProgram

2025-02-17 Thread Daniel P . Berrangé
On Fri, Feb 14, 2025 at 03:48:18PM -0700, Jim Fehlig via Devel wrote: > qemuSaveImageGetCompressionProgram is a bit overloaded. Along with > getting a compression program, it checks the validity of the image > format and returns the integer representation of the format. Change > the function to onl

Re: [PATCH 2/3] qemu: Move special handling of invalid dump format to only caller

2025-02-17 Thread Daniel P . Berrangé
On Fri, Feb 14, 2025 at 03:48:17PM -0700, Jim Fehlig via Devel wrote: > The 'use_raw_on_fail' logic in qemuSaveImageGetCompressionProgram is only > used by doCoreDump in qemu_driver.c. Move the logic to the single call site > and remove the parameter from qemuSaveImageGetCompressionProgram. > > Si

Re: [PATCH 2/2] qemu: Add support for 'image_format' typed parameter

2025-02-17 Thread Daniel P . Berrangé
On Fri, Feb 14, 2025 at 08:03:10PM -0700, Jim Fehlig via Devel wrote: > Add support for the 'image_format' typed parameter in virDomainSaveParams. > The parameter overrides the 'save_image_format' setting in qemu.conf. > > Signed-off-by: Jim Fehlig > --- > src/qemu/qemu_driver.c | 12 ++-

Re: [PATCH RFC] util: pick a better runtime directory when XDG_RUNTIME_DIR isn't set

2025-02-17 Thread Richard W.M. Jones
On Mon, Feb 17, 2025 at 02:14:49AM -0500, Laine Stump wrote: > == > > I'm sending this as an RFC just because what it's doing feels kind of > dirty - directly examining XDG_RUNTIME_DIR seems like an "end run" > around the Glib API. If anyone has a better idea of what to do, please > give detai

Re: [PATCH RFC] util: pick a better runtime directory when XDG_RUNTIME_DIR isn't set

2025-02-17 Thread Martin Kletzander
On Mon, Feb 17, 2025 at 02:14:49AM -0500, Laine Stump wrote: == I'm sending this as an RFC just because what it's doing feels kind of dirty - directly examining XDG_RUNTIME_DIR seems like an "end run" around the Glib API. If anyone has a better idea of what to do, please give details :-) ==

Re: [PATCH 1/2] include: Define constant for save image format

2025-02-17 Thread Daniel P . Berrangé
On Fri, Feb 14, 2025 at 08:03:09PM -0700, Jim Fehlig via Devel wrote: > Add a new VIR_DOMAIN_SAVE_PARAM_IMAGE_FORMAT typed parameter for > specifying the save image format. A format specified via the > virDomainSaveParams API overrides the save_image_format setting > in qemu.conf. The 'raw' format