On a Thursday in 2025, Laine Stump wrote:
[...]
This Resolves: https://issues.redhat.com/browse/RHEL-69455
Laine Stump (9):
conf: change virDomainHostdevInsert() to return void
qemu: fix qemu validation to forbid guest-side IP address for
type='vdpa'
qemu: validate that model is virtio f
On 2/14/25 6:03 AM, Andrea Bolognani wrote:
On Thu, Feb 13, 2025 at 01:19:53PM -0500, Laine Stump wrote:
The result is that you can now have:
...
Then as long as you also have the following as a subelement of
:
your passt interfaces will benefit
On 2/13/25 15:09, Boris Fiuczynski wrote:
> Signed-off-by: Boris Fiuczynski
> ---
> NEWS.rst | 11 +++
> 1 file changed, 11 insertions(+)
Reviewed-by: Michal Privoznik
Michal
On Fri, Feb 14, 2025 at 08:49:29AM -0500, Laine Stump wrote:
> On 2/14/25 6:03 AM, Andrea Bolognani wrote:
> > On Thu, Feb 13, 2025 at 01:19:53PM -0500, Laine Stump wrote:
> > > The result is that you can now have:
> > >
> > >
> > >
> > >...
> > >
> > >
> > > Then as lon
On 2/14/25 9:21 AM, Andrea Bolognani wrote:
On Fri, Feb 14, 2025 at 08:49:29AM -0500, Laine Stump wrote:
On 2/14/25 6:03 AM, Andrea Bolognani wrote:
On Thu, Feb 13, 2025 at 01:19:53PM -0500, Laine Stump wrote:
The result is that you can now have:
...
Then as lo
On 2/14/25 6:17 AM, Andrea Bolognani wrote:
On Thu, Feb 13, 2025 at 01:19:44PM -0500, Laine Stump wrote:
passt (https://passt.top) provides a method of connecting QEMU virtual
machines to the external network without requiring special privileges
or capabilities of any participating processes - e
On 2/14/25 8:49 AM, Laine Stump wrote:
On 2/14/25 6:03 AM, Andrea Bolognani wrote:
On Thu, Feb 13, 2025 at 01:19:53PM -0500, Laine Stump wrote:
The result is that you can now have:
...
Then as long as you also have the following as a subelement of
:
On Fri, Feb 14, 2025 at 09:08:36AM -0500, Laine Stump wrote:
> On 2/14/25 6:17 AM, Andrea Bolognani wrote:
> > Speaking of SELinux, with the current policy on Fedora 41 I get a
> > couple of AVC denials related to accessing the shared memory file.
> > I understand that's expected, based on the abov
The code will be also needed for 'virtio-scsi' controller definitions.
Signed-off-by: Peter Krempa
---
src/hypervisor/domain_driver.c | 31 ++-
1 file changed, 18 insertions(+), 13 deletions(-)
diff --git a/src/hypervisor/domain_driver.c b/src/hypervisor/domain_drive
The iothread mapping will be also possible for 'virtio-scsi' controllers
so rename the corresponding structs to a generic name.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 10 +-
src/conf/domain_conf.h | 10 +-
src/hypervisor/domain_driver.c | 2 +-
The function reports libvirt errors so stick with the usual '0' and '-1'
return values.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_validate.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index 8ac3e65e9d..
Extract the code to 'qemuDomainValidateIothreadMapping'. It will be
reused to validate the mapping for 'virtio-scsi' iothreads.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_validate.c | 192 +--
1 file changed, 104 insertions(+), 88 deletions(-)
diff --git a
The first part of the series refactors the existing code for reuse and
then uses the new helpers to implement the feature.
Note that this series is in RFC state as the qemu patches are still
being discussed. Thus also the capability bump is not final.
Also note that we should discuss the libvirt
Prepare for reuse of the code for 'virtio-scsi' controller.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 35a71b73a7..b76fec27c5 100644
--- a/src/qemu/qemu_co
The code will be also needed for 'virtio-scsi' controller definitions.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 143 +++--
1 file changed, 81 insertions(+), 62 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 22b
The schema definition will be reused when adding iotrhead<->virtuqueue
mapping for 'virtio-scsi'.
Signed-off-by: Peter Krempa
---
src/conf/schemas/domaincommon.rng | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/schemas/domaincommon.rng
b/src/conf/schemas/domain
The documentation states:
``iothread``
Supported for controller type ``scsi`` using model ``virtio-scsi`` for
``address`` types ``pci`` and ``ccw`` :since:`since 1.3.5 (QEMU 2.4)`. The
The code itself didn't validate if iothread is specified for any other
controller type.
Add test case
Notable changes:
- 'virtio-scsi' supports 'iothread-vq-mapping'
- 'nbd-server-start' command supports 'handshake-max-seconds' argument
---
.../qemucapabilitiesdata/caps_10.0.0_x86_64.replies | 12 +++-
tests/qemucapabilitiesdata/caps_10.0.0_x86_64.xml| 2 +-
2 files changed, 12 ins
Similarly to 'virtio-blk' users can map multiple iothreads and pin them
appropriately for 'virtio-scsi' controllers to ensure the best
performance.
Implement the validation and command line generation based on the
helpers we have for 'virtio-blk'.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_c
Upcoming qemu release will support configuring mapping iothreads to
virtio queues for 'virtio-scsi' controllers in order to improve
performance.
Reuse the infrastructure we have from the same configuration for
'virti-blk' to implement the conf support for this feature.
Signed-off-by: Peter Krempa
Test the XML and commandline for iothread<->virtqueue mapping for
'virtio-scsi' controllers.
Signed-off-by: Peter Krempa
---
...ads-virtio-scsi-mapping.x86_64-latest.args | 39 ++
...eads-virtio-scsi-mapping.x86_64-latest.xml | 54 +++
.../iothreads-virtio-scsi-mappin
The 'virtio-scsi' controller now supports iothread<->virtqueue mapping
configuration.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_10.0.0_x86_64.xml | 1 +
3 file
Even though my work on supporting mapped-ram is the main motivation for
this small cleanup series, IMO is useful in its own right.
Jim Fehlig (3):
qemu: Move declaration of virQEMUSaveFormat to header file
qemu: Move special handling of invalid dump format to only caller
qemu: Change return
The 'use_raw_on_fail' logic in qemuSaveImageGetCompressionProgram is only
used by doCoreDump in qemu_driver.c. Move the logic to the single call site
and remove the parameter from qemuSaveImageGetCompressionProgram.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_driver.c| 29 +++
Allow use of the enum outside of qemu_saveimage.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_saveimage.c | 19 ---
src/qemu/qemu_saveimage.h | 19 +++
2 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveim
qemuSaveImageGetCompressionProgram is a bit overloaded. Along with
getting a compression program, it checks the validity of the image
format and returns the integer representation of the format. Change
the function to only handle retrieving the specified compression
program, returning success or fa
This series is based on a cleanup of qemuSaveImageGetCompressionProgram [1]
and demonstrates the usefulness of that cleanup. Patch1 adds the
VIR_DOMAIN_SAVE_PARAM_IMAGE_FORMAT typed parameter to virDomainSaveParams,
allowing to specify the image format on a per-operation basis. The format
can still
Add support for the 'image_format' typed parameter in virDomainSaveParams.
The parameter overrides the 'save_image_format' setting in qemu.conf.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_driver.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_dr
Add a new VIR_DOMAIN_SAVE_PARAM_IMAGE_FORMAT typed parameter for
specifying the save image format. A format specified via the
virDomainSaveParams API overrides the save_image_format setting
in qemu.conf. The 'raw' format remains the default.
Signed-off-by: Jim Fehlig
---
include/libvirt/libvirt-
This reorganizes the section about and
describes the differences in behavior between SLIRP and passt.
Resolves: https://issues.redhat.com/browse/RHEL-46601
Signed-off-by: Laine Stump
---
docs/formatdomain.rst | 116 --
1 file changed, 78 insertions(+), 38
This can/should also be done for a traditional vhost-user interface
(ie not backend type='passt') but that will be a separate change.
Signed-off-by: Laine Stump
---
src/qemu/qemu_validate.c | 9 ++-
...vhostuser-passt-no-shmem.x86_64-latest.err | 1 +
.../net-vhostuser-pas
When passt is used with vhostuser, the vhostuser code that builds the
qemu commandline will need to have the same socket path that is given
to the passt command, so this patch makes it visible outside of
qemu_passt.c.
Signed-off-by: Laine Stump
---
src/qemu/qemu_passt.c | 2 +-
src/qemu/qemu_pas
needs to run the
passt command just as is done for interface type='user', but then add
vhostuser bits to the qemu commandline/monitor command.
There are some changes to the parsing/validation along with changes to
the vhostuser codepath do do the extra stuff for passt. I tried
keeping them separa
Almost everything is already there (in the section for using passt
with type='user'), so we just need to point to that from the
type='vhostuser' section (and vice versa), and add a bit of glue.
Also updated a few related details that have changed (e.g. default
model type for vhostuser is now 'virt
On 2/14/25 15:48, Jim Fehlig wrote:
Even though my work on supporting mapped-ram is the main motivation for
this small cleanup series, IMO is useful in its own right.
Here's an example of that usefulness
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/ISSWUH6FM4IMWG5HLUM
Changes from V1:
* fixed missing change to error log message pointed out by abologna
* added a validation check to assure that shared memory is enabled
if there is a type='vhostuser' interface in the domain definition
* included a patch documenting differences between type='user'
Both vhostuser and vdpa interface types must use the virtio model in
the guest (because part of the functionality is implemented in the
guest virtio driver). Due to ["because that's the way it happened"]
this has been validated for vhostuser in the hypervisor-agnostic
validate function, but for vdp
We haven't checked for memalloc failure in many years, and that was
the only reason this function would have ever failed.
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 15 +--
src/conf/domain_conf.h | 2 +-
src/libxl/libxl_domain.c | 5 +
src/libxl/libxl_driver.c
Since vhostuser is only used/supported by the QEMU driver, and all the
rest of the vhostuser-specific validation is done in QEMU's
validation, lets move the final check (to see if they've tried to
enable auto-reconnect when this interface is on the server side of the
vhostuser socket) to the QEMU v
Both vdpa and vhostuser require that the guest device be virtio, and
for interface type='vdpa', we already set if it
is unspecified in the input XML, so let's be just as courteous for
interface type='vhostuser'.
Signed-off-by: Laine Stump
---
src/qemu/qemu_postparse.c | 3 ++-
1 file changed, 2
Because all the checks for VIR_DOMAIN_NET_TYPE_VDPA were inside an
else-if clause that was immediately followed by another else-if clause
that forbid setting guestIP.ips or guestIP.routes, we've been allowing
users to set guestIP.* for vdpa interfaces (but then not doing
validation of the attribute
For some reason, when vhostuser interface support was added in 2014,
the parser required that the XML for the have a
element with type, mode, and path, all 3 also required. This in spite
of the fact that 'unix' is the only possible valid setting for type,
and 95% of the time the mode is set to 'c
qemuProcessPrepareDomain()'s comments say that it should be the only
place to change the "live XML" of a domain (i.e. the public parts of
the virDomainDef object that is shown in the domain's status
XML), and that seems like a reasonable idea (although there aren't
many users of it to date).
qemuP
Hi
On Wed, Jan 29, 2025 at 5:58 PM Daniel P. Berrangé wrote:
>
> On Wed, Jan 29, 2025 at 05:40:34PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > src/qemu/qemu_command.c | 8 ++--
> > 1 file changed, 6 insertions(
On Fri, Feb 14, 2025 at 11:07:17AM +, Daniel P. Berrangé wrote:
> On Fri, Feb 14, 2025 at 03:03:20AM -0800, Andrea Bolognani wrote:
> > How does passt know where the backing file is located in the first
> > place? It's not passed on its command line, and I didn't spot any
> > logic to hand the
Hi
On Wed, Feb 12, 2025 at 8:16 PM Daniel P. Berrangé wrote:
>
> On Wed, Jan 29, 2025 at 05:40:35PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > The following changes are going to communicate with the qemu-rdp server
> > through the VM D-Bus bus, keep a connectio
On Thu, Feb 13, 2025 at 01:19:53PM -0500, Laine Stump wrote:
> The result is that you can now have:
>
>
>
> ...
>
>
> Then as long as you also have the following as a subelement of
> :
>
>
>
>
>
> your passt interfaces will benefit from the greatly improved
>
On Fri, Feb 14, 2025 at 03:03:20AM -0800, Andrea Bolognani wrote:
> On Thu, Feb 13, 2025 at 01:19:53PM -0500, Laine Stump wrote:
> > The result is that you can now have:
> >
> >
> >
> > ...
> >
> >
> > Then as long as you also have the following as a subelement of
> > :
> >
>
Hi
On Wed, Feb 12, 2025 at 7:44 PM Daniel P. Berrangé wrote:
>
> On Wed, Jan 29, 2025 at 05:40:27PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Without an error message, it can be tedious to figure out failure to start.
> >
> > Signed-off-by: Marc-André Lureau
On Thu, Feb 13, 2025 at 01:19:44PM -0500, Laine Stump wrote:
> passt (https://passt.top) provides a method of connecting QEMU virtual
> machines to the external network without requiring special privileges
> or capabilities of any participating processes - even libvirt itself
> can run unprivileged
Hi
On Wed, Feb 12, 2025 at 8:21 PM Daniel P. Berrangé wrote:
>
> On Wed, Jan 29, 2025 at 05:40:38PM +0400, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > We may want to check qemu-rdp presence, instead of failing later?
>
> Yes, we should validate qemu-rdp, because the ca
Hi
On Fri, Feb 14, 2025 at 4:03 PM Marc-André Lureau
wrote:
>
> Hi
>
> On Wed, Feb 12, 2025 at 8:21 PM Daniel P. Berrangé
> wrote:
> >
> > On Wed, Jan 29, 2025 at 05:40:38PM +0400, marcandre.lur...@redhat.com wrote:
> > > From: Marc-André Lureau
> > >
> > > We may want to check qemu-rdp presen
On Fri, 14 Feb 2025 03:17:06 -0800
Andrea Bolognani wrote:
> On Thu, Feb 13, 2025 at 01:19:44PM -0500, Laine Stump wrote:
> > passt (https://passt.top) provides a method of connecting QEMU virtual
> > machines to the external network without requiring special privileges
> > or capabilities of any
On Fri, 14 Feb 2025 06:47:53 -0800
Andrea Bolognani wrote:
> On Fri, Feb 14, 2025 at 09:08:36AM -0500, Laine Stump wrote:
> > On 2/14/25 6:17 AM, Andrea Bolognani wrote:
> > > Speaking of SELinux, with the current policy on Fedora 41 I get a
> > > couple of AVC denials related to accessing the
Hi Peter,
Peter Krempa, Feb 12, 2025 at 17:17:
> On Wed, Feb 12, 2025 at 16:36:48 +0100, Anthony Harivel wrote:
>> Add the support in libvirt to activate the RAPL feature in QEMU.
>>
>> This feature is activated with -accel kvm,rapl=true,path=/path/sock.sock
>> in QEMU.
>>
>> The feature is acti
On Fri, Feb 14, 2025 at 10:59:11AM -0500, Laine Stump wrote:
> On 2/14/25 9:21 AM, Andrea Bolognani wrote:
> > You can restrict the check to just the vhost-user passt case, leaving
> > other vhost-user cases alone, so that we don't have to worry about
> > accidentally breaking existing configuratio
56 matches
Mail list logo
