On Wed, Jan 22, 2025 at 10:18:41AM -, trued...@gmail.com wrote:
> Hi Jonathon,
>
> Do you have any news/updates around SNP compatibility in Libvirt?
It was done 6 months ago
https://libvirt.org/news.html#v10-5-0-2024-07-01
"* New features:
Introduce SEV-SNP support"
With regards,
D
On Wed, Jan 22, 2025 at 09:40:06AM -0300, Daniel Henrique Barboza wrote:
On 1/22/25 8:43 AM, Martin Kletzander wrote:
On Thu, Oct 24, 2024 at 11:08:19AM -0300, Daniel Henrique Barboza wrote:
This feature is implemented as a string that can range from "none",
"aplic" and "aplic-imsic".
If the
On Wed, Jan 22, 2025 at 07:37:22 -, Harikumar Rajkumar wrote:
> Hi Peter Krempa, Could you please prioritize reviews for remaining commits so
> we can create new patch request with all fix. We have a requirement which
> depends on this change and we are currently blocked.
>
Please refer to
On Mon, Nov 18, 2024 at 19:24:17 +0530, Harikumar R wrote:
> From: Chun Feng Wu
>
> ThrottleGroup lifecycle implementation, note, in QOM, throttlegroup name is
> prefixed with
> "throttle-" to clearly separate throttle group objects into their own
> namespace.
> * "qemuDomainSetThrottleGroup",
On Fri, Nov 29, 2024 at 10:56:45PM +0800, kaihuan wrote:
qemuDomainDiskByName() can return a NULL pointer on failure.
But this returned value in qemuSnapshotDeleteValidate is not checked.It will
make libvirtd crash.
Hi, looking through old unreviewed patches I found this one. Sorry for
the w
On Thu, Oct 24, 2024 at 11:08:19AM -0300, Daniel Henrique Barboza wrote:
This feature is implemented as a string that can range from "none",
"aplic" and "aplic-imsic".
If the feature isn't present in the domain XML the hypervisor default
will be used. For QEMU, at least up to 9.2, the default is
The correct compiler define to detect the RISC-V architecture is __riscv.
Fixes: b902cfece0db ("virsysinfo: Try reading DMI table")
Signed-off-by: Heinrich Schuchardt
---
src/util/virsysinfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virsysinfo.c b/src/util/vi
On 1/22/25 8:43 AM, Martin Kletzander wrote:
On Thu, Oct 24, 2024 at 11:08:19AM -0300, Daniel Henrique Barboza wrote:
This feature is implemented as a string that can range from "none",
"aplic" and "aplic-imsic".
If the feature isn't present in the domain XML the hypervisor default
will be u
Hi,
This new version has improvements suggested by Martin in v1. Most
notably we're now doing a proper handling of 'aia=none' by adding a
'default' value that is internal only.
Changes from v1:
- patch 2:
- changed libvirt version to 11.1.0 in 'aia' docs in formatdomain.rst
- added a new in
AIA (Advanced Interrupt Architecture) support was introduced in QEMU 7.0
for the 'virt' machine type. It allows the guest to choose from a more
modern interrupt model than the default (CLINT - Core Logical Interrupt
Controller).
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_capabiliti
At this moment it is not possible to launch a 'riscv64' domain if a CPU
definition is presented in the domain. For example, adding this CPU
definition:
rv64
Will trigger the following error:
$ sudo ./run tools/virsh start riscv-virt1
error: Failed to start domain 'riscv-virt1'
error: t
The 'aia' feature is added as a machine type option for the 'virt'
RISC-V machine, e.g. "-machine virt,aia=".
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 5 +++
...cv64-virt-features-aia.riscv64-latest.args | 31 +++
...scv64-virt-f
This feature is implemented as a string that can range from "none",
"aplic" and "aplic-imsic".
If the feature isn't present in the domain XML the hypervisor default
will be used. For QEMU, at least up to 9.2, the default is "none".
Signed-off-by: Daniel Henrique Barboza
---
docs/formatdomain.rs
Hi Jonathon,
Do you have any news/updates around SNP compatibility in Libvirt? I'm working
on a project around SNP enabled cloud systems, and would be great to have SNP
via Libvirt.
Wondering do you know of any roadmap, or any info on when that might be
supported? Coming up blank on my own res
qemuSnapshotDeleteBlockJobFinishing() returns only 0 and 1. Convert it
to bool and remove the dead code handling -1 return in the caller.
Found by Linux Verification Center (linuxtesting.org) with Svace.
Reported-by: Reported-by: Andrey Slepykh
Signed-off-by: Alexander Kuznetsov
---
src/qemu/q
This function return value is invariant since 1022e0ee, so change
its type and remove all dependent checks.
Found by Linux Verification Center (linuxtesting.org) with Svace.
Reported-by: Alexander Rudyuk
Signed-off-by: Alexander Kuznetsov
---
src/conf/domain_conf.c | 9 +++--
src/netw
On 1/22/25 10:11 AM, Martin Kletzander wrote:
On Wed, Jan 22, 2025 at 09:40:06AM -0300, Daniel Henrique Barboza wrote:
On 1/22/25 8:43 AM, Martin Kletzander wrote:
On Thu, Oct 24, 2024 at 11:08:19AM -0300, Daniel Henrique Barboza wrote:
This feature is implemented as a string that can ran
On Mon, Nov 18, 2024 at 19:24:16 +0530, Harikumar R wrote:
> From: Chun Feng Wu
>
> extract common methods from "qemuDomainSetBlockIoTune" to be reused
> by throttle handling later, common methods include:
> * "qemuDomainValidateBlockIoTune", which is to validate that PARAMS
> contains only rec
Add support for the mapped-ram migration capability on restore.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_driver.c| 26 +-
src/qemu/qemu_migration.c | 12
src/qemu/qemu_process.c | 58 +++
src/qemu/qemu_process.h | 15 ++-
When using the mapped-ram migration capability, direct IO is
enabled by setting the "direct-io" migration parameter to
"true" and passing QEMU an additional fd with O_DIRECT set.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_migration.c | 11 ++-
src/qemu/qemu_process.c | 27
From: Claudio Fontana
Add a new VIR_DOMAIN_SAVE_PARALLEL flag to the save and restore
APIs, which can be used to specify the use of multiple, parallel
channels for saving a domain. The number of parallel channels
can be set using the VIR_DOMAIN_SAVE_PARAM_PARALLEL_CHANNELS
typed parameter.
Signe
I'm claiming this to be V2 of a series to support QEMU's mapped-ram stream
format [1] and migration capability, even though the approach to control
the feature is different than V1. To control mapped-ram in V1, I bumped
the save format version and added a 'features' field to the save image
header.
Add new function qemuFDPassGetId() for retrieving the fdset ID
of provided qemuFDPass object.
Signed-off-by: Jim Fehlig
Reviewed-by: Daniel P. Berrangé
---
src/qemu/qemu_fd.c | 18 ++
src/qemu/qemu_fd.h | 3 +++
2 files changed, 21 insertions(+)
diff --git a/src/qemu/qemu_fd.c
Signed-off-by: Jim Fehlig
Reviewed-by: Daniel P. Berrangé
---
src/qemu/qemu_migration_params.c | 18 ++
src/qemu/qemu_migration_params.h | 5 +
2 files changed, 23 insertions(+)
diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c
index c3c9120c2
When invoking virDomainSaveParams with a relative path, the image is
saved to the daemon's CWD. Similarly, when providing virDomainRestoreParams
with a relative path, it attempts to restore from the daemon's CWD. In most
configurations, the daemon's CWD is set to '/'. Ensure a relative path is
conv
Add new function qemuMigrationParamsCapEnabled() to check if a
capability is set in the caller-provided migration parameters.
Signed-off-by: Jim Fehlig
Reviewed-by: Daniel P. Berrangé
---
src/qemu/qemu_migration_params.c | 16
src/qemu/qemu_migration_params.h | 4
2 files
Move the code in qemuSaveImageCreate that opens, labels, and wraps the
save image fd to a helper function, providing more flexibility for
upcoming mapped-ram support.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_saveimage.c | 65 +++
1 file changed, 45 insertio
Add the mapped-ram migration capability introduced in QEMU 9.0.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_migration_params.c | 1 +
src/qemu/qemu_migration_params.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/qemu/qemu_migration_params.c b/src/qemu
Introduce qemuMigrationParamsForSave() to create a
qemuMigrationParams object initialized with appropriate migration
capabilities and parameters for a save operation.
Note that mapped-ram capability also requires the multifd capability.
For now, the number of multifd channels is set to 1. Future w
Extend the list of formats to include "sparse", which uses QEMU's mapped-ram
stream format [1] to write guest memory blocks at fixed offsets in the save
image file.
[1]
https://gitlab.com/qemu-project/qemu/-/blob/master/docs/devel/migration/mapped-ram.rst?ref_type=heads
Signed-off-by: Jim Fehlig
Split the reading of libvirt's save image metadata from the opening
of the fd that will be passed to QEMU. This provides flexibility for
an upcoming patch adding mapped-ram support for restore.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_driver.c| 37
src/qemu/qemu_saveimage
Allow use of the enum outside of qemu_saveimage.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_saveimage.c | 20
src/qemu/qemu_saveimage.h | 20
2 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_save
qemuProcessStartWithMemoryState() is the only caller of qemuProcessStart()
that uses the qemuProcessIncomingDef struct. Move creation of the struct
to qemuProcessStartWithMemoryState().
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_process.c | 44 -
src/qemu
Introduce support for QEMU's new mapped-ram stream format [1].
mapped-ram is enabled by default if the underlying QEMU advertises
the mapped-ram migration capability. It can be disabled by changing
the 'save_image_version' setting in qemu.conf to version '2'.
To use mapped-ram with QEMU:
- The 'ma
Similar to qemuMigrationSrcRun, apply migration parameters in
qemuMigrationDstRun. This allows callers to create customized
migration parameters, but delegates their application to the
function performing the migration.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_migration.c | 16 ++-
Add support for parallel save and restore by mapping libvirt's
"parallel-connections" parameter to QEMU's "multifd-channels"
migration parameter.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_driver.c | 32 +---
src/qemu/qemu_migration_params.c | 31 ++
From: Claudio Fontana
Signed-off-by: Claudio Fontana
Signed-off-by: Jim Fehlig
---
docs/manpages/virsh.rst | 12 +++-
tools/virsh-domain.c| 41 +
2 files changed, 48 insertions(+), 5 deletions(-)
diff --git a/docs/manpages/virsh.rst b/docs/m
From: Claudio Fontana
Signed-off-by: Claudio Fontana
Signed-off-by: Jim Fehlig
---
docs/manpages/virsh.rst | 9 +++--
tools/virsh-domain.c| 38 ++
2 files changed, 41 insertions(+), 6 deletions(-)
diff --git a/docs/manpages/virsh.rst b/docs/manpage
When using the mapped-ram migration capability, direct IO is
enabled by setting the "direct-io" migration parameter to
"true" and passing QEMU an additional fd with O_DIRECT set.
Signed-off-by: Jim Fehlig
---
src/qemu/qemu_driver.c | 10 ++
src/qemu/qemu_migration.c| 32
39 matches
Mail list logo
