Re: [PATCH v5 04/18] config: Introduce ThrottleFilter and corresponding XML parsing

2025-01-15 Thread Peter Krempa
On Mon, Nov 18, 2024 at 19:24:12 +0530, Harikumar R wrote: > From: Chun Feng Wu > > Introduce throttle filter along with corresponding operations. > > * Define new struct 'virDomainThrottleFilterDef' and corresponding destructor > * Update _virDomainDiskDef to include virDomainThrottleFilterDef

Re: [PATCH v5 01/18] schema: Add new domain elements to support multiple throttle groups

2025-01-15 Thread Peter Krempa
On Fri, Nov 29, 2024 at 14:10:00 +0100, Peter Krempa wrote: > On Mon, Nov 18, 2024 at 19:24:09 +0530, Harikumar R wrote: > > From: Chun Feng Wu > > > > Introduce schema for defining '' element which > > configures throttling groups which can be configured for multiple > > disks. > > > > * Refact

Re: [PATCH v5 00/18] *** qemu: block: Support block disk along with throttle filters ***

2025-01-15 Thread Peter Krempa
On Mon, Jan 06, 2025 at 10:45:16 -, harirajkumar...@gmail.com wrote: > Hi Peter Krempa, any ETA to complete this patch request? I'm sorry. As I've noted multiple times due to personal reasons my work capacity is limited. I can't give you an ETA. As you seem to be only keen to get this featur

Re: [PATCH v5 05/18] qemu: monitor: Add support for ThrottleGroup operations

2025-01-15 Thread Peter Krempa
On Mon, Nov 18, 2024 at 19:24:13 +0530, Harikumar R wrote: > From: Chun Feng Wu > > This change contains QMP requests for ThrottleGroup > > * ThrottleGroup is updated through "qemuMonitorJSONUpdateThrottleGroup" > * ThrottleGroup is retrieved through "qemuMonitorJSONGetThrottleGroup" > * Throttl

Re: [PATCH v5 06/18] tests: Test qemuMonitorJSONGetThrottleGroup and qemuMonitorJSONUpdateThrottleGroup

2025-01-15 Thread Peter Krempa
On Mon, Nov 18, 2024 at 19:24:14 +0530, Harikumar R wrote: > From: Chun Feng Wu > > Within "testQemuMonitorJSONqemuMonitorJSONUpdateThrottleGroup" > * Test qemuMonitorJSONGetThrottleGroup > * Test qemuMonitorJSONUpdateThrottleGroup, which updates limits through > "qom-set" > > Signed-off-by: Ch

Re: [PATCH v2] Support IDE/SATA disk 'product' parameter

2025-01-15 Thread Peter Krempa
On Mon, Dec 30, 2024 at 21:44:20 +0100, Adam Julis wrote: > Since we supported 'product' parameter for SCSI, just expanded existing > solution makes IDE/SATA parameter works too. QEMU requires parameter 'model' > in case of IDE/SATA (instead of 'product'), so the process of making JSON > object is

Re: [PATCH v5 07/18] remote: New APIs for ThrottleGroup lifecycle management

2025-01-15 Thread Peter Krempa
On Mon, Nov 18, 2024 at 19:24:15 +0530, Harikumar R wrote: > From: Chun Feng Wu > > Defined new public APIs: > * virDomainSetThrottleGroup to add or update throttlegroup within specific > domain, > it will be referenced by throttlefilter later in disk to do limits > * virDomainGetThrottleGroup

[PATCH v2] conf: check size of secret file for secret object

2025-01-15 Thread Adam Julis
Since the empty file with a .base64 value wasn't recognized during the loading process (starting of libvirtd), attempting to get a value for the UUID resulted in an undefined error. This patch resolves the issue by checking the size of the file and ensuring that the stored value is as expected (NUL

Release of libvirt-11.0.0

2025-01-15 Thread Jiri Denemark
The 11.0.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is

[PATCH] qemu: Report error from both sides of migration

2025-01-15 Thread Jiri Denemark
When migration fails in Perform phase, we call Finish on the destination host with cancelled=1 and get the error from there and report it to the user. This works well if the error on the destination caused the migration to fail. But in other cases the main error may reported by the source and the d

Re: [PATCH 1/2] qemuxmlconftest: Switch s390-default-cpu-...-virtio-2.7 to virtio-2.9

2025-01-15 Thread Thomas Huth
On 14/01/2025 14.07, Michal Privoznik wrote: In its upstream commit [1], qemu dropped s390-2.7 machine type, then in commit [2] the s390-2.8 machine type was dropped. Therefore, switch both tests to s390-2.9 which is still available (though deprecated). I already posted some patches to remove 2

Re: [PATCH 0/4] Implement virsh hypervisor-cpu-models

2025-01-15 Thread Thomas Huth
On 15/01/2025 11.43, Daniel P. Berrangé wrote: On Wed, Jan 15, 2025 at 11:34:05AM +0100, Boris Fiuczynski wrote: Allows for the query of hypervisor-known CPU models via the simple command: virsh hypervisor-cpu-models. For the QEMU driver, the models are queried via the capabilities file. Each mo

Re: [PATCH 0/4] Implement virsh hypervisor-cpu-models

2025-01-15 Thread Daniel P . Berrangé
On Wed, Jan 15, 2025 at 04:07:38PM +0100, Thomas Huth wrote: > On 15/01/2025 11.43, Daniel P. Berrangé wrote: > > On Wed, Jan 15, 2025 at 11:34:05AM +0100, Boris Fiuczynski wrote: > > > Allows for the query of hypervisor-known CPU models via the simple > > > command: virsh hypervisor-cpu-models. Fo

Re: [PATCH v3 4/4] virt-aa-helper: store dynamically generated rules

2025-01-15 Thread Georgia Garcia
On Tue, 2025-01-14 at 12:13 -0600, Andrea Bolognani wrote: > On Wed, Jan 08, 2025 at 11:06:54AM -0700, Jim Fehlig wrote: > > On 1/8/25 06:50, Georgia Garcia wrote: > > > On Tue, 2025-01-07 at 17:29 -0700, Jim Fehlig wrote: > > > > On 1/7/25 08:23, Georgia Garcia wrote: > > > > > Some rules are gene

[PATCH 0/2] qemu_migration: Do not automatically resume domain after I/O error

2025-01-15 Thread Jiri Denemark
Jiri Denemark (2): qemu_migration: Refactor qemuMigrationSrcRestoreDomainState qemu_migration: Do not automatically resume domain after I/O error src/qemu/qemu_migration.c | 69 +++ 1 file changed, 33 insertions(+), 36 deletions(-) -- 2.47.1

[PATCH 1/2] qemu_migration: Refactor qemuMigrationSrcRestoreDomainState

2025-01-15 Thread Jiri Denemark
None of the callers really care about the return value so we can drop it and simplify the code a bit. Signed-off-by: Jiri Denemark --- Notes: Best viewed with -w src/qemu/qemu_migration.c | 64 +-- 1 file changed, 28 insertions(+), 36 deletions(-) diff

[PATCH 2/2] qemu_migration: Do not automatically resume domain after I/O error

2025-01-15 Thread Jiri Denemark
When an I/O error happens (causing a domain to be paused) during live migration which is later cancelled by a user, trying to resume the domain doesn't make sense. Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_mi

[PATCH 2/4] remote: Implement virConnectGetHypervisorCPUModelNames

2025-01-15 Thread Boris Fiuczynski
From: David Judkovics Adding access to virConnectGetHypervisorCPUModelNames running on a remote machine. Signed-off-by: David Judkovics Reviewed-by: Boris Fiuczynski Signed-off-by: Boris Fiuczynski --- src/remote/remote_daemon_dispatch.c | 62 + src/remote/remote_

[PATCH 4/4] virsh: Introduce new hypervisor-cpu-models command

2025-01-15 Thread Boris Fiuczynski
From: David Judkovics Add new virsh 'host' group command 'hypervisor-cpu-models' to virsh. Signed-off-by: David Judkovics Reviewed-by: Boris Fiuczynski Signed-off-by: Boris Fiuczynski --- docs/manpages/virsh.rst | 20 +++ tools/virsh-host.c | 74 +

[PATCH 0/4] Implement virsh hypervisor-cpu-models

2025-01-15 Thread Boris Fiuczynski
Allows for the query of hypervisor-known CPU models via the simple command: virsh hypervisor-cpu-models. For the QEMU driver, the models are queried via the capabilities file. Each model is printed to the terminal on its own line similar to the cpu-models command, and there is no order to the listi

[PATCH 3/4] qemu_driver: Implement qemuConnectGetHypervisorCPUModelNames

2025-01-15 Thread Boris Fiuczynski
From: David Judkovics This function is utilized by the new virsh hypervisor-cpu-models command. The CPU models are read directly from the QEMU capabilities file, which contains a list of all models queried from the hypervisor. Signed-off-by: David Judkovics Signed-off-by: Collin Walling Review

[PATCH 1/4] libvirt: Introduce virConnectGetHypervisorCPUModelNames public API

2025-01-15 Thread Boris Fiuczynski
From: David Judkovics The new API collects a list of CPU model names supported by the specified hypervisor. This is a more useful version of virConnectGetCPUNames, which does not consider any hypervisor capabilities when querying model names. Signed-off-by: David Judkovics Signed-off-by: Collin

Re: [PATCH 0/4] Implement virsh hypervisor-cpu-models

2025-01-15 Thread Daniel P . Berrangé
On Wed, Jan 15, 2025 at 11:34:05AM +0100, Boris Fiuczynski wrote: > Allows for the query of hypervisor-known CPU models via the simple > command: virsh hypervisor-cpu-models. For the QEMU driver, the models > are queried via the capabilities file. Each model is printed to the > terminal on its own