Re: [PATCH v2 1/3] Revert "qemu: explicit swtpm state locking"

2024-12-11 Thread Stefan Berger
On 12/11/24 5:37 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau This reverts commit bb5e26749fe5b5856a3541be2cbe147701e6e121. swtpm-setup doesn't have "tpmstate-lock", only swtpm. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger --- src/qemu/qemu_tpm.c

Re: [PATCH v2 3/3] qemu_tpm: do not delete parent directory for custom source

2024-12-11 Thread Stefan Berger
On 12/11/24 5:37 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau When the vTPM source path is specified, such as: Do not delete the parent directory, but only the given file/dir. Fixes: commit f1304cc566 ("qemu_tpm: handle file/block storage source") Signed-off-by: Mar

Re: [libvirt PATCH v3] qemu: tpm: do not update profile name for transient domains

2024-12-11 Thread Peter Krempa
On Wed, Dec 11, 2024 at 09:46:49 +0100, Ján Tomko wrote: > If we do not have a persistent definition, there's no point in > looking for it since we cannot store it. > > Also skip the update if the tpm device(s) in the persistent > definition are different. > > This fixes the crash when starting a

Re: [libvirt PATCH v3] qemu: tpm: do not update profile name for transient domains

2024-12-11 Thread Stefan Berger
On 12/11/24 3:46 AM, Ján Tomko wrote: If we do not have a persistent definition, there's no point in looking for it since we cannot store it. Also skip the update if the tpm device(s) in the persistent definition are different. This fixes the crash when starting a transient domain. https://

Re: [PATCH v4 3/5] ch: events: Read and parse cloud-hypervisor events

2024-12-11 Thread Praveen K Paladugu
On 12/11/2024 1:10 AM, Purna Pavan Chandra Aekkaladevi wrote: On Tue, Dec 10, 2024 at 10:28:41AM -0600, Praveen K Paladugu wrote: On 12/2/2024 3:46 AM, Purna Pavan Chandra Aekkaladevi wrote: Implement `chReadProcessEvents` and `chProcessEvents` to read events from event monitor FIFO file a

Re: [libvirt PATCH v3] qemu: tpm: do not update profile name for transient domains

2024-12-11 Thread Jiri Denemark
On Wed, Dec 11, 2024 at 09:46:49 +0100, Ján Tomko wrote: > If we do not have a persistent definition, there's no point in > looking for it since we cannot store it. > > Also skip the update if the tpm device(s) in the persistent > definition are different. > > This fixes the crash when starting a

[PATCH v2 1/3] Revert "qemu: explicit swtpm state locking"

2024-12-11 Thread marcandre . lureau
From: Marc-André Lureau This reverts commit bb5e26749fe5b5856a3541be2cbe147701e6e121. swtpm-setup doesn't have "tpmstate-lock", only swtpm. Signed-off-by: Marc-André Lureau --- src/qemu/qemu_tpm.c | 11 ++- src/util/virtpm.c | 1 - src/util/virtpm.h | 1 - tests/testutilsq

[PATCH v2 2/3] qemu_tpm: lock the state explicitly when running swtpm

2024-12-11 Thread marcandre . lureau
From: Marc-André Lureau Commit bb5e26749fe5b ("qemu: explicit swtpm state locking") attempted to lock the state, but only for swtpm-setup. The capability "tpmstate-opt-lock" is actually only exposed by swtpm. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger --- src/qemu/qemu_tpm.c

[PATCH v2 3/3] qemu_tpm: do not delete parent directory for custom source

2024-12-11 Thread marcandre . lureau
From: Marc-André Lureau When the vTPM source path is specified, such as: Do not delete the parent directory, but only the given file/dir. Fixes: commit f1304cc566 ("qemu_tpm: handle file/block storage source") Signed-off-by: Marc-André Lureau --- src/qemu/qemu_tpm.c | 26

Re: [libvirt PATCH v2] qemu: tpm: do not update profile name for transient domains

2024-12-11 Thread Jiri Denemark
On Tue, Dec 10, 2024 at 13:28:44 -0500, Stefan Berger wrote: > > > On 12/10/24 10:50 AM, Jiri Denemark wrote: > > On Tue, Dec 10, 2024 at 15:01:16 +0100, Ján Tomko wrote: > >> If we do not have a persistent definition, there's no point in > >> looking for it since we cannot store it. > >> > >> Al

[libvirt PATCH v3] qemu: tpm: do not update profile name for transient domains

2024-12-11 Thread Ján Tomko
If we do not have a persistent definition, there's no point in looking for it since we cannot store it. Also skip the update if the tpm device(s) in the persistent definition are different. This fixes the crash when starting a transient domain. https://issues.redhat.com/browse/RHEL-69774 Fixes:

Re: [PATCH v5 00/18] *** qemu: block: Support block disk along with throttle filters ***

2024-12-11 Thread Harikumar R
Hi Team, Can we fix all unfixed version numbers and submit new patch v7, or can we wait till the reviews are complete? Thanks & Regards, Harikumar R

[RFC PATCH 2/5] qemu: Implement and auto-add a nestedSmmuv3 device type

2024-12-11 Thread Nathan Chen via Devel
Add support for parsing "nestedSmmuv3" devices from the VM definition. When a "nestedSmmuv3" IOMMU model is parsed from the VM definition, add a "nestedSmmuv3" device to the VM definition for each host SMMU node detected from sysfs. Specify the associated host SMMU sysfs filename as the "name" attr

[RFC PATCH 5/5] qemu: Add test case for specifying multiple nested SMMUs

2024-12-11 Thread Nathan Chen via Devel
Implement a sub-test in qemuxmlconftest that mocks the scanning of sysfs to determine how many "nestedSmmuv3" devices to assign to the VM when "nestedSmmuv3" IOMMU model is parsed from the VM definition. Add a VM definition example with an associated qemu command line that exercises the detection o

[RFC PATCH 0/5] qemu: Route hostdevs to multiple nested SMMUs

2024-12-11 Thread Nathan Chen via Devel
Hi, This is a draft solution for supporting multiple vSMMU instances in a qemu VM. Based on discussions/suggestions received for a previous RFC by Nicolin here[0], the association of vSMMUs to VFIO devices in VM PCIe topology should be moved out of qemu into libvirt. In addition, the nested SMMU

[RFC PATCH 3/5] qemu: Create PXBs and auto-assign VFIO devs and nested SMMUs

2024-12-11 Thread Nathan Chen via Devel
Add a pcie-expander-bus controller to the VM definition for each "nestedSmmuv3" device that is generated when the "nestedSmmuv3" IOMMU model is parsed from the VM definition. Assign each "nestedSmmuv3" device to one PXB controller, and route any unmanaged "hostdev" VFIO devices with associated host

[RFC PATCH 4/5] qemu: Update PXB busNr for nestedSmmuv3 controllers

2024-12-11 Thread Nathan Chen via Devel
Update the PXB controller busNrs to account for devices we attached in the previous commit, ensuring there are enough VM bus numbers to be assigned for each device attached downstream from each PXB controller. Signed-off-by: Nathan Chen --- src/qemu/qemu_domain_address.c | 52 +++

[RFC PATCH 1/5] conf: Add a nestedSmmuv3 IOMMU model

2024-12-11 Thread Nathan Chen via Devel
Add support for specifying "nestedSmmuv3" as the IOMMU model. In the following commits, when the "nestedSmmuv3" IOMMU model is parsed from the VM definition, PXB controllers and "nestedSmmuv3" devices will be auto-added to the VM definition and VFIO devices will be routed to PXB controllers based o

[PATCH 0/3] Addng POWER11 cpu support

2024-12-11 Thread Narayana Murty N
This patch series includes the changes needed to support POWER11 cpu and POWER11 host on libvirt. Patch also adds and updates the qemu caps with the latest qemu for the caps tests to include POWER11. Patch 0001: Add POWER11 cpu model support. Patch 0002: Add POWER11 host model support. Patch 0003:

[PATCH 2/3] cpu_ppc64: Add POWER11 host-model support

2024-12-11 Thread Narayana Murty N
This changes will add POWER11 host-model support to libvirt. Signed-off-by: Narayana Murty N --- src/cpu/cpu_ppc64.c | 8 tests/qemuxmlconftest.c | 4 tests/testutilshostcpus.h | 11 +++ tests/testutilsqemu.c | 4 tests/testutilsqemu.h | 1 + 5 file

[PATCH 1/3] cpu_map: Add POWER11 cpu model support

2024-12-11 Thread Narayana Murty N
Add POWER11 as a supported cpu model for ppc64. Signed-off-by: Narayana Murty N --- src/cpu_map/index.xml | 1 + src/cpu_map/meson.build | 1 + src/cpu_map/ppc64_POWER11.xml | 6 ++ 3 files changed, 8 insertions(+) create mode 100644 src/cpu_map/ppc64_POWER11.xml diff --git a