Re: [PATCH 0/5] cpu_map: Add missing -v1 models

2024-11-29 Thread Jiri Denemark
On Fri, Nov 29, 2024 at 12:33:19 +0800, Han Han wrote: > Tested on this branch with qemu-kvm-9.1.0-5.el9.x86_64: > # for i in $(/usr/libexec/qemu-kvm -cpu help|grep deprecated -v|awk > '/Available CPUs/,/Recognized CPUID flags/'|grep '^ '|awk '{print $1}');do > if ! virsh cpu-models x86_64|grep -q

Re: [PATCH 0/5] cpu_map: Add missing -v1 models

2024-11-29 Thread Daniel P . Berrangé
On Fri, Nov 29, 2024 at 09:50:01AM +0100, Jiri Denemark wrote: > On Fri, Nov 29, 2024 at 12:33:19 +0800, Han Han wrote: > > Tested on this branch with qemu-kvm-9.1.0-5.el9.x86_64: > > # for i in $(/usr/libexec/qemu-kvm -cpu help|grep deprecated -v|awk > > '/Available CPUs/,/Recognized CPUID flags/'

[PATCH] docs: Document how to enable coredumps for session qemu

2024-11-29 Thread Richard W.M. Jones
Thanks: Daniel P. Berrangé Signed-off-by: Richard W.M. Jones --- docs/kbase/qemu-core-dump.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/docs/kbase/qemu-core-dump.rst b/docs/kbase/qemu-core-dump.rst index 5c3781cf90..4bd3ff0b9d 100644 --- a/docs/kbase/qemu-core-dump.rst +++ b/doc

[PATCH] qemu: enable QEMU core dump by default on Linux

2024-11-29 Thread Daniel P . Berrangé
The Linux MADV_DONTDUMP flag was added to Linux kernels > 3.3, back in 2012, and the dump-guest-core flag was added to QEMU > 1.0 at the same time. IOW, on Linux we have long been able to assume that QEMU core dumps will exclude guest memory, unless the user has overridden the host level defaults

Re: [PATCH] qemu: enable QEMU core dump by default on Linux

2024-11-29 Thread Richard W.M. Jones
On Fri, Nov 29, 2024 at 12:00:51PM +, Daniel P. Berrangé wrote: > The Linux MADV_DONTDUMP flag was added to Linux kernels > 3.3, > back in 2012, and the dump-guest-core flag was added to QEMU > > 1.0 at the same time. > > IOW, on Linux we have long been able to assume that QEMU core > dumps wi

Re: [PATCH v5 01/18] schema: Add new domain elements to support multiple throttle groups

2024-11-29 Thread Peter Krempa
On Mon, Nov 18, 2024 at 19:24:09 +0530, Harikumar R wrote: > From: Chun Feng Wu > > Introduce schema for defining '' element which > configures throttling groups which can be configured for multiple > disks. > > * Refactor "diskIoTune" to extract common schema "iotune" > * Add new elements '' >

Re: [PATCH v5 02/18] schema: Add new domain elements to support multiple throttle filters

2024-11-29 Thread Peter Krempa
On Mon, Nov 18, 2024 at 19:24:10 +0530, Harikumar R wrote: > From: Chun Feng Wu > > Introduce schema for defining '' element which > references throttling groups to form filter chain in qemu for specific > disk > > * Add new elements '' > * can include multiple throttlegroup references to > f

Re: [PATCH] qemu:qemu_snapshot: Fix a libvirtd cransh when delete snapshot

2024-11-29 Thread jungle man
Thank you. I will check it out.and resend in a new email On Wed, Nov 27, 2024 at 5:49 PM Peter Krempa wrote: > > Typo in shortlog (cransh); use: > > > qemuSnapshotDeleteValidate: Fix crash when disk is not found in VM > definition > > On Thu, Nov 21, 2024 at 23:36:14 +0800, jungle man wrote:

Re: [PATCH v5 03/18] config: Introduce ThrottleGroup and corresponding XML parsing

2024-11-29 Thread Peter Krempa
On Mon, Nov 18, 2024 at 19:24:11 +0530, Harikumar R wrote: > From: Chun Feng Wu > > Introduce throttlegroup into domain and provide corresponding methods > > * Define new struct 'virDomainThrottleGroupDef' and corresponding destructor > * Add operations(Add, Update, Del, ByName, Copy, Free) for

[PATCH] qemuSnapshotDeleteValidate: Fix crash when disk is not found in VM definition

2024-11-29 Thread kaihuan
qemuDomainDiskByName() can return a NULL pointer on failure. But this returned value in qemuSnapshotDeleteValidate is not checked.It will make libvirtd crash. Signed-off-by: kaihuan --- src/qemu/qemu_snapshot.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a