[PATCH 0/2] ch_driver: add basic save and restore functionalities

2024-02-06 Thread Purna Pavan Chandra Aekkaladevi
Purna Pavan Chandra Aekkaladevi (2): ch_driver: Add basic domain save & restore support NEWS: Mention save & restore support for ch driver NEWS.rst| 6 + src/ch/ch_conf.c| 6 + src/ch/ch_conf.h| 12 ++ src/ch/ch_driver.c | 511 ++

[PATCH 1/2] ch_driver: Add basic domain save & restore support

2024-02-06 Thread Purna Pavan Chandra Aekkaladevi
From: Purna Pavan Chandra Aekkaladevi save, managedsave and restore is supported for domains without any network, hostdev config defined. The `path` input to the save command should be a directory path since cloud-hypervisor expects directory path. Signed-off-by: Purna Pavan Chandra Aekkaladevi

[PATCH 2/2] NEWS: Mention save & restore support for ch driver

2024-02-06 Thread Purna Pavan Chandra Aekkaladevi
Signed-off-by: Purna Pavan Chandra Aekkaladevi --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index e2796fd8b2..6a2c69b2c4 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -23,6 +23,12 @@ v10.1.0 (unreleased) Additionally, if CPU clusters are present in th

Re: [PATCH v2 4/4] cpu_map: Rewrite feature sync script

2024-02-06 Thread Tim Wiederhake
On Mon, 2024-02-05 at 11:44 +0100, Tim Wiederhake wrote: > Previously, the script would only detect differences between > libvirt's and qemu's list of x86 features, adding those features > to libvirt was a manual and error prone procedure. > > Replace with a script that can generate libvirt's feat

Re: [PATCH 2/5] virSocketSendMsgWithFDs: Don't report errors, just set errno

2024-02-06 Thread Ján Tomko
On a Friday in 2024, Michal Privoznik wrote: Currently, virSocketSendMsgWithFDs() reports two errors: 1) if CMSG_FIRSTHDR() fails, 2) if sendmsg() fails. Well, the latter sets an errno, so caller can just use virReportSystemError(). And the former - it is very unlikely to fail because memory fo

Re: [PATCH 3/5] virSocketSendMsgWithFDs: Introduce @payload_len argument

2024-02-06 Thread Ján Tomko
On a Friday in 2024, Michal Privoznik wrote: Instead of using strlen() to calculate length of payload we're sending, let caller specify the size: they may want to send just a portion of a buffer (even though the only current user doesn't). Signed-off-by: Michal Privoznik --- src/ch/ch_process.c

Re: [PATCH 4/5] virsocket: Simplify virSocketSendFD()

2024-02-06 Thread Ján Tomko
On a Friday in 2024, Michal Privoznik wrote: After previous cleanups, virSocketSendFD() is but a thin wrapper over virSocketSendMsgWithFDs(). Almost. virSocketSendFD is documented to return 0 on success. After this change, it returns the number of bytes sent. None of the callers care, so adjus

Re: [PATCH 5/5] qemu_monitor: Simplify qemuMonitorIOWriteWithFD()

2024-02-06 Thread Ján Tomko
On a Friday in 2024, Michal Privoznik wrote: After previous cleanups, qemuMonitorIOWriteWithFD() is but a thin wrapper over virSocketSendMsgWithFDs(). Replace the body of the former with a call to the latter. Signed-off-by: Michal Privoznik --- src/qemu/qemu_monitor.c | 27 ++---

[PATCH] docs: Improve documentation for dies and clusters

2024-02-06 Thread Andrea Bolognani
I've seen examples in the wild of the cluster attribute having non-zero value on x86_64. This is obviously quite confusing, but it's the information that Linux exposes to userspace and we don't really have a way to tell apart a valid die/cluster ID from a dummy one. What ultimately matters is tha

Re: [PATCH] docs: Improve documentation for dies and clusters

2024-02-06 Thread Daniel P . Berrangé
On Tue, Feb 06, 2024 at 07:04:30PM +0100, Andrea Bolognani wrote: > I've seen examples in the wild of the cluster attribute having > non-zero value on x86_64. > > This is obviously quite confusing, but it's the information that > Linux exposes to userspace and we don't really have a way to tell >