Re: [PATCH 1/2] ci: integration: Switch upstream integration tests to Fedora 39

2024-01-03 Thread Michal Prívozník
On 12/15/23 18:06, Erik Skultety wrote: > On Fri, Dec 15, 2023 at 02:26:11AM -0800, Andrea Bolognani wrote: >> On Thu, Dec 14, 2023 at 09:28:16AM +0100, Michal Privoznik wrote: >>> Currently, Fedora 37 and 38 is used. The former is now EOL since >>> there's new release. Switch 37 to 39 then. >>> >>

Plans for 10.0.0 release (freeze on Tuesday 09 Jan)

2024-01-03 Thread Jiri Denemark
We are getting close to 10.0.0 release of libvirt. To aim for the release on Monday 15 Jan I suggest entering the freeze on Tuesday 09 Jan and tagging RC2 on Friday 12 Jan. I hope this works for everyone. Jirka ___ Devel mailing list -- devel@lists.libv

[PATCH] ci: Switch from FreeBSD 12.0 to FreeBSD 14.0

2024-01-03 Thread Michal Privoznik
FreeBSD 12.0 is no longer supported since 14.0 is out. Change the CI manifest and refresh the rest. Signed-off-by: Michal Privoznik --- .../{freebsd-12.vars => freebsd-14.vars} | 0 ci/gitlab/builds.yml | 28 +-- ci/manifest.yml

[PATCH] qemucapabilitiesdata: Final update of 'caps_8.2.0_x86_64'

2024-01-03 Thread Peter Krempa
QEMU 8.2 was released, update the x86_64 data for a final time. Signed-off-by: Peter Krempa --- .../qemucapabilitiesdata/caps_8.2.0_x86_64.replies | 13 +++-- tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml| 4 ++-- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/te

Re: [PATCH 00/19] qemu XML testing improvements, part 1 - forgotten test files and network driver

2024-01-03 Thread Peter Krempa
On Fri, Dec 15, 2023 at 13:33:10 +0100, Peter Krempa wrote: > This patch saga aims to improve and simplify testing of qemu XML > configs. > > Part 1 deals with input test files which are not used in > qemuxml2argvtest, introduces a mock network driver and adds a checker > that all input files are

Re: [PATCH] ci: Switch from FreeBSD 12.0 to FreeBSD 14.0

2024-01-03 Thread Daniel P . Berrangé
On Wed, Jan 03, 2024 at 10:11:43AM +0100, Michal Privoznik wrote: > FreeBSD 12.0 is no longer supported since 14.0 is out. Change the > CI manifest and refresh the rest. > > Signed-off-by: Michal Privoznik > --- > .../{freebsd-12.vars => freebsd-14.vars} | 0 > ci/gitlab/builds.yml

Re: [PATCH] qemucapabilitiesdata: Final update of 'caps_8.2.0_x86_64'

2024-01-03 Thread Michal Prívozník
On 1/3/24 10:14, Peter Krempa wrote: > QEMU 8.2 was released, update the x86_64 data for a final time. > > Signed-off-by: Peter Krempa > --- > .../qemucapabilitiesdata/caps_8.2.0_x86_64.replies | 13 +++-- > tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml| 4 ++-- > 2 files change

Re: [PATCH 08/19] qemuxml2argvtest: Add test cases covered only by qemuxml2xmltest - part 1

2024-01-03 Thread Michal Prívozník
On 12/15/23 13:33, Peter Krempa wrote: > There were plenty of test cases invoked only from qemuxml2xmltest but > not from qemuxml2argvtest, either by accident or it was deemed unneeded. > > Bulk-add all test cases which fit the above description which don't > require faking the network driver. Use

Re: [PATCH 15/19] qemuxml2xmltest: Introduce fake network driver

2024-01-03 Thread Michal Prívozník
On 12/15/23 13:33, Peter Krempa wrote: > In order to be able to use ' network driver in qemuxml2argvtest. Create one by simply allowing users > to reuse configs from tests/networkxml2xmlin and > tests/virnetworkportxml2xmldata > which will be returned to corresponding functions. > > The driver im

Re: [PATCH 00/19] qemu XML testing improvements, part 1 - forgotten test files and network driver

2024-01-03 Thread Michal Prívozník
On 1/3/24 10:20, Peter Krempa wrote: > On Fri, Dec 15, 2023 at 13:33:10 +0100, Peter Krempa wrote: >> This patch saga aims to improve and simplify testing of qemu XML >> configs. >> >> Part 1 deals with input test files which are not used in >> qemuxml2argvtest, introduces a mock network driver and

Re: [PATCH 1/2] ci: integration: Switch upstream integration tests to Fedora 39

2024-01-03 Thread Erik Skultety
On Wed, Jan 03, 2024 at 09:42:01AM +0100, Michal Prívozník wrote: > On 12/15/23 18:06, Erik Skultety wrote: > > On Fri, Dec 15, 2023 at 02:26:11AM -0800, Andrea Bolognani wrote: > >> On Thu, Dec 14, 2023 at 09:28:16AM +0100, Michal Privoznik wrote: > >>> Currently, Fedora 37 and 38 is used. The for

Re: [PATCH 00/19] qemu XML testing improvements, part 1 - forgotten test files and network driver

2024-01-03 Thread Peter Krempa
On Wed, Jan 03, 2024 at 10:52:11 +0100, Michal Prívozník wrote: > On 1/3/24 10:20, Peter Krempa wrote: > > On Fri, Dec 15, 2023 at 13:33:10 +0100, Peter Krempa wrote: > >> This patch saga aims to improve and simplify testing of qemu XML > >> configs. > >> > >> Part 1 deals with input test files whi

Re: [PATCH 00/19] qemu XML testing improvements, part 1 - forgotten test files and network driver

2024-01-03 Thread Peter Krempa
On Wed, Jan 03, 2024 at 12:31:53 +0100, Peter Krempa wrote: > On Wed, Jan 03, 2024 at 10:52:11 +0100, Michal Prívozník wrote: > > On 1/3/24 10:20, Peter Krempa wrote: > > > On Fri, Dec 15, 2023 at 13:33:10 +0100, Peter Krempa wrote: > > >> This patch saga aims to improve and simplify testing of qem

Re: [PATCH v2] qemu_driver: Don't handle the EOF event if vm get restarted

2024-01-03 Thread Guoyi Tu
ping... Can everyone help review this patch, please? On 2023/12/7 20:52, t...@chinatelecom.cn wrote: From: Guoyi Tu Currently, libvirt creates a thread pool with only on thread to handle all qemu monitor events for virtual machines, In the cases that if the thread gets stuck while handling a

[PATCH] conf: Restore setting default bus for input devices

2024-01-03 Thread Michal Privoznik
Prior to v9.3.0-rc1~30 we used to set default bus for devices, during XML parsing. In the commit this code was moved to a post parse callback. But somehow the line that sets the bus in one specific case disappeared. Bring it back. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/577 Fixes: c

Re: [PATCH] conf: Restore setting default bus for input devices

2024-01-03 Thread Jiri Denemark
On Wed, Jan 03, 2024 at 13:58:13 +0100, Michal Privoznik wrote: > Prior to v9.3.0-rc1~30 we used to set default bus for > devices, during XML parsing. In the commit this code was moved to > a post parse callback. But somehow the line that sets the bus in > one specific case disappeared. Bring it b

[PATCH] Fix regression on default bus for keyboard/mouse from c4bc4d3b #577

2024-01-03 Thread Jonathan Wright
Signed-off-by: Jonathan Wright --- src/conf/domain_postparse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_postparse.c b/src/conf/domain_postparse.c index e79913b73f..ee27023f3e 100644 --- a/src/conf/domain_postparse.c +++ b/src/conf/domain_postparse.c @@ -657,6 +657,7 @@

[PATCH] Fix regression on default bus for keyboard/mouse from c4bc4d3b #577

2024-01-03 Thread Jonathan Wright
Signed-off-by: Jonathan Wright --- src/conf/domain_postparse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_postparse.c b/src/conf/domain_postparse.c index e79913b73f..ee27023f3e 100644 --- a/src/conf/domain_postparse.c +++ b/src/conf/domain_postparse.c @@ -657,6 +657,7 @@

Re: [PATCH 0/2] ci: Update to Fedora 39

2024-01-03 Thread Andrea Bolognani
On Thu, Dec 14, 2023 at 09:28:15AM +0100, Michal Privoznik wrote: > Green pipeline: > > https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1106643445 > > Michal Prívozník (2): > ci: integration: Switch upstream integration tests to Fedora 39 > ci: Update Alpine and Fedora and regenerate Re

Re: [PATCH v2] qemu_driver: Don't handle the EOF event if vm get restarted

2024-01-03 Thread Daniel P . Berrangé
On Thu, Dec 07, 2023 at 08:52:39PM +0800, t...@chinatelecom.cn wrote: > From: Guoyi Tu > > Currently, libvirt creates a thread pool with only on thread to handle all > qemu monitor events for virtual machines, In the cases that if the thread > gets stuck while handling a monitor EOF event, such a

Re: [PATCH 05/10] virDomainBlockResize: Introduce VIR_DOMAIN_BLOCK_RESIZE_CAPACITY

2024-01-03 Thread Daniel P . Berrangé
On Thu, Dec 14, 2023 at 10:19:40AM +0100, Peter Krempa wrote: > Allow users to easily resize 'raw' images on block devices to the full > capacity of the block device. Obviously this won't work on file-backed > storage (filling the remaining capacity is most likely wrong) or for > formats with metad

Re: [PATCH] Fix regression on default bus for keyboard/mouse from c4bc4d3b #577

2024-01-03 Thread Michal Prívozník
On 1/3/24 16:26, Jonathan Wright wrote: > Signed-off-by: Jonathan Wright > --- > src/conf/domain_postparse.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/conf/domain_postparse.c b/src/conf/domain_postparse.c > index e79913b73f..ee27023f3e 100644 > --- a/src/conf/domain_postparse.

Re: [PATCH] Fix regression on default bus for keyboard/mouse from c4bc4d3b #577

2024-01-03 Thread Jonathan Wright
Thank you! Having never done a patch via email with the git tools I failed to add a good commit message :) I appreciate the quick action on this one so I can start working on backports/patches into distros now! On Wed, Jan 3, 2024 at 10:23 AM Michal Prívozník wrote: > On 1/3/24 16:26, Jonatha

[PATCH] qemu: tighten semantics of 'size' when resizing block devices

2024-01-03 Thread Daniel P . Berrangé
When VIR_DOMAIN_BLOCK_RESIZE_CAPACITY is set, the 'size' parameter is currently ignored. Since applications must none the less pass a value for this parameter, it is preferrable to declare some explicit semantics for it. This declare that the parameter must be 0, or the exact size of the underlyin

Re: [ PATCH vf-token 0/8] Introduce vf-token when using userspace PF

2024-01-03 Thread Vivek Kashyap
On Tue, 2 Jan 2024, Alex Williamson wrote: On Tue, 2 Jan 2024 18:55:10 +0530 Vivek Kashyap wrote: The VFIO PCI ABI has been extended to require userspace PF driver to set a VF token to a known value. The VF drivers are then required to provide this token to access the VF device. The vf-tok

Re: [libvirt PATCH 0/5] Initial network support in ch driver.

2024-01-03 Thread Praveen K Paladugu
Folks, Bubbling this patchset for reviews. I would appreciate some feedback on this patch set. On 11/29/2023 5:11 PM, Praveen K Paladugu wrote: This series introduces network support for ch guests. ETHERNET network mode is the only mode supported. More modes will be add once this series is mer

Re: [libvirt PATCH v3] qemu: add runtime config option for nbdkit

2024-01-03 Thread Andrea Bolognani
On Thu, Nov 30, 2023 at 05:04:11PM -0600, Jonathon Jongsma wrote: > Sorry for the delay in getting out a new version. Thanksgiving break in > the USA, etc. ... followed by holidays in Europe. We still have a few days to get this into 10.0.0 though :) > +++ b/meson_options.txt > @@ -104,7 +104,8 @

Re: [libvirt PATCH v3] qemu: add runtime config option for nbdkit

2024-01-03 Thread Jonathon Jongsma
On 1/3/24 12:37 PM, Andrea Bolognani wrote: On Thu, Nov 30, 2023 at 05:04:11PM -0600, Jonathon Jongsma wrote: Sorry for the delay in getting out a new version. Thanksgiving break in the USA, etc. ... followed by holidays in Europe. We still have a few days to get this into 10.0.0 though :) +

[PATCH 0/7] Code cleanup 2

2024-01-03 Thread Artem Chernyshev
Several functions was modified to become invariant. Change their type to void and remove unnecessary checks of their return values. Found by Linux Verification Center (linuxtesting.org) with SVACE. Artem Chernyshev (7): cpu: : virCPUx86DataAddItem() to void rpc: virnetserver: virNetServerAddS

[PATCH 2/7] rpc: virnetserver: virNetServerAddService() to void

2024-01-03 Thread Artem Chernyshev
virNetServerAddService() return value is invariant, so change it type and remove all dependent checks. Fixes: 7d2fd6ef01 ("Do not check return value of VIR_EXPAND_N") Signed-off-by: Artem Chernyshev --- src/lxc/lxc_controller.c | 3 +-- src/rpc/virnetserver.c | 25 +

[PATCH 3/7] lxc: virLXCControllerAddConsole() to void

2024-01-03 Thread Artem Chernyshev
virLXCControllerAddConsole() return value is invariant, so change it type and remove all dependent checks. Fixes: 7d2fd6ef01 ("Do not check return value of VIR_EXPAND_N") Signed-off-by: Artem Chernyshev --- src/lxc/lxc_controller.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) di

[PATCH 1/7] cpu: : virCPUx86DataAddItem() to void

2024-01-03 Thread Artem Chernyshev
virCPUx86DataAddItem() return value is invariant, so change it type and remove all dependent checks. Functions changed to void: virCPUx86DataAddItem() x86DataAdd() virCPUx86DataAdd() x86DataAddSignature() virCPUx86DataSetSignature() libxlCapsAddCPUID() cpuidSetLeaf4() cpuidSetLeaf7() cpuidSetLea

[PATCH 4/7] conf: virDomainNetUpdate() to void

2024-01-03 Thread Artem Chernyshev
virDomainNetUpdate() return value is invariant, so change it type and remove all dependent checks. Fixes: 98f6f2081d ("util: alloc: Reimplement VIR_APPEND_ELEMENT using virAppendElement") Signed-off-by: Artem Chernyshev --- src/conf/domain_conf.c | 3 +-- src/conf/domain_conf.h | 2 +- src/lxc

[PATCH 6/7] node_device: udevTranslatePCIIds() to void

2024-01-03 Thread Artem Chernyshev
udevTranslatePCIIds() return value is invariant, so change it type and remove all dependent checks. Fixes: 7f1f0453fc ("node_device: use g_strdup instead of VIR_STRDUP") Signed-off-by: Artem Chernyshev --- src/node_device/node_device_udev.c | 14 +- 1 file changed, 5 insertions(+),

[PATCH 5/7] virprocess: virProcessGetNamespaces() to void

2024-01-03 Thread Artem Chernyshev
virProcessGetNamespaces() return value is invariant, so change it type and remove all dependent checks. Fixes: 7d2fd6ef01 ("Do not check return value of VIR_EXPAND_N") Signed-off-by: Artem Chernyshev --- src/libvirt-lxc.c | 5 + src/lxc/lxc_driver.c| 3 +-- src/qemu/qemu_process.c

[PATCH 7/7] node_device: udevGetStringSysfsAttr() to void

2024-01-03 Thread Artem Chernyshev
udevGetStringSysfsAttr() return value is invariant, so change it type and remove all dependent checks. Fixes: 7f1f0453fc ("node_device: use g_strdup instead of VIR_STRDUP") Signed-off-by: Artem Chernyshev --- src/node_device/node_device_udev.c | 55 +- 1 file changed

Re: [libvirt PATCH 3/5] Config some capabilities for loongarch virt machine

2024-01-03 Thread lixianglai
Hi  Andrea: On Tue, Dec 19, 2023 at 11:52:03AM +0800, lixianglai wrote: So does loongarch actually have ioapic support? Just making sure. I'm surprised because apparently no other non-x86 architecture supports it... Yes, loongarch does have IOAPIC, but this feature has no effect on loongarch a

Re: [libvirt PATCH 5/5] Add bios path for loongarch

2024-01-03 Thread lixianglai
Hi  Andrea: On Tue, Dec 19, 2023 at 07:44:02PM +0800, lixianglai wrote: On Thu, Dec 14, 2023 at 02:08:49PM +0800, xianglai li wrote: The way firmware is configured these days is through firmware descriptor files. See src/qemu/qemu_firmware* and tests/qemufirmware* for additional information, but

Re: [libvirt PATCH 0/5] add loongarch support for libvirt

2024-01-03 Thread lixianglai
Hi  Andrea : On Mon, Dec 18, 2023 at 11:40:03AM +0800, lixianglai wrote: On Thu, Dec 14, 2023 at 02:08:44PM +0800, xianglai li wrote: Great to see that edk2 support has already been mainlined! An excellent next step would be to get an edk2-loongarch64 package into the various distros... Please