Re: [PATCH v8 15/18] test_driver: Test throttle group lifecycle APIs

2025-03-15 Thread Harikumar Rajkumar
Thanks for the update and for your efforts on the review. We understand your approach and we'll wait until it's completed.

Re: [PATCH v8 15/18] test_driver: Test throttle group lifecycle APIs

2025-03-14 Thread Peter Krempa
On Fri, Mar 14, 2025 at 09:03:09 -, Harikumar Rajkumar wrote: > > On Wed, Feb 19, 2025 at 22:27:19 +0530, Harikumar Rajkumar wrote: > > > > For the sake of not prolonging the review any more I'm dropping this > > patch for now. Please submit it once we're done with the qemu driver > > impl. >

Re: [PATCH v8 15/18] test_driver: Test throttle group lifecycle APIs

2025-03-14 Thread Harikumar Rajkumar
> On Wed, Feb 19, 2025 at 22:27:19 +0530, Harikumar Rajkumar wrote: > > For the sake of not prolonging the review any more I'm dropping this > patch for now. Please submit it once we're done with the qemu driver > impl. Could you kindly confirm if the patch review has been completed? If so, we w

Re: [PATCH v8 15/18] test_driver: Test throttle group lifecycle APIs

2025-03-13 Thread Peter Krempa
On Wed, Feb 19, 2025 at 22:27:19 +0530, Harikumar Rajkumar wrote: > From: Chun Feng Wu > > Test throttle group APIs > > * Extract common methods for both "testDomainSetThrottleGroup" and > "testDomainSetBlockIoTune": > testDomainValidateBlockIoTune, testDomainSetBlockIoTuneFields, > testDomain