RE: [PATCH v3 21/21] docs: domain: Add documentation for Intel TDX guest

2025-07-09 Thread Duan, Zhenzhong
>-Original Message- >From: Daniel P. Berrangé >Subject: Re: [PATCH v3 21/21] docs: domain: Add documentation for Intel >TDX guest > >On Mon, Jun 30, 2025 at 02:17:32PM +0800, Zhenzhong Duan wrote: >> Signed-off-by: Zhenzhong Duan >> ---

Re: [PATCH v3 21/21] docs: domain: Add documentation for Intel TDX guest

2025-07-09 Thread Daniel P . Berrangé via Devel
On Wed, Jul 09, 2025 at 03:13:11PM +0800, Xiaoyao Li wrote: > On 7/9/2025 2:58 PM, Daniel P. Berrangé wrote: > > > > Could we rename "policy" to "attributes", or more precisely > > > > "tdAttributes"? It's not intuitive for users to connect "policy" with > > > > "TD attributes". > > > Will use "att

Re: [PATCH v3 21/21] docs: domain: Add documentation for Intel TDX guest

2025-07-09 Thread Xiaoyao Li
On 7/9/2025 2:58 PM, Daniel P. Berrangé wrote: Could we rename "policy" to "attributes", or more precisely "tdAttributes"? It's not intuitive for users to connect "policy" with "TD attributes". Will use "attributes" as QAPI exposes "attributes". IMHO 'policy' is preferrable as it is consistent

Re: [PATCH v3 21/21] docs: domain: Add documentation for Intel TDX guest

2025-07-08 Thread Daniel P . Berrangé via Devel
On Wed, Jul 09, 2025 at 03:46:14AM +, Duan, Zhenzhong wrote: > > > >-Original Message- > >From: Li, Xiaoyao > >Subject: Re: [PATCH v3 21/21] docs: domain: Add documentation for Intel > >TDX guest > > > >On 6/30/2025 2:17 PM, Zhenzhong Duan

Re: [PATCH v3 21/21] docs: domain: Add documentation for Intel TDX guest

2025-07-08 Thread Xiaoyao Li
On 7/9/2025 11:46 AM, Duan, Zhenzhong wrote: (It should be commenting on the patch that enables the policy. I'm just too lazy to find that patch) Will do. It's just myself excuse for not commenting it in patch 07 Could we rename "policy" to "attributes", or more precisely "tdAttributes"? It'

Re: [PATCH v3 21/21] docs: domain: Add documentation for Intel TDX guest

2025-07-08 Thread Xiaoyao Li
On 6/30/2025 2:17 PM, Zhenzhong Duan wrote: Signed-off-by: Zhenzhong Duan --- docs/formatdomain.rst | 63 +++ 1 file changed, 63 insertions(+) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 9a2f065590..5acebefec0 100644 --- a/docs/for

RE: [PATCH v3 21/21] docs: domain: Add documentation for Intel TDX guest

2025-07-08 Thread Duan, Zhenzhong
>-Original Message- >From: Li, Xiaoyao >Subject: Re: [PATCH v3 21/21] docs: domain: Add documentation for Intel >TDX guest > >On 6/30/2025 2:17 PM, Zhenzhong Duan wrote: >> Signed-off-by: Zhenzhong Duan >> --- &

Re: [PATCH v3 21/21] docs: domain: Add documentation for Intel TDX guest

2025-07-08 Thread Daniel P . Berrangé via Devel
On Mon, Jun 30, 2025 at 02:17:32PM +0800, Zhenzhong Duan wrote: > Signed-off-by: Zhenzhong Duan > --- > docs/formatdomain.rst | 63 +++ > 1 file changed, 63 insertions(+) > > diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst > index 9a2f065590..5a