Re: [PATCH 1/1] virsh: Add option '--no-pkttyagent'

2025-05-14 Thread Michal Prívozník via Devel
On 5/6/25 23:50, Jens Schmidt via Devel wrote: > Thanks for your review and comments! > > On 2025-05-06 10:24, Peter Krempa wrote: > >> As witnessed by the fact that you needed to include assert.h we don't >> use asserts in the code base. >> >> While this code path should not be possible to reac

Re: [PATCH 1/1] virsh: Add option '--no-pkttyagent'

2025-05-07 Thread Jens Schmidt via Devel
Thanks for your review and comments! On 2025-05-06 10:24, Peter Krempa wrote: > As witnessed by the fact that you needed to include assert.h we don't > use asserts in the code base. > > While this code path should not be possible to reach without doing > a programming error we still should repo

Re: [PATCH 1/1] virsh: Add option '--no-pkttyagent'

2025-05-06 Thread Peter Krempa via Devel
On Mon, May 05, 2025 at 23:09:52 +0200, Jens Schmidt via Devel wrote: Since you domain uses DMARC protections, in order to properly honour your autorship you need to set the following git option: git config --global format.forceInBodyFrom true https://www.libvirt.org/submitting-patches.html#git-