Re: [PATCH 01/19] src: add constants for guest info 'user.' parameters

2025-03-04 Thread Daniel P . Berrangé
On Tue, Mar 04, 2025 at 03:20:56PM +0100, Peter Krempa wrote: > Couple notes before doing a proper review: > > On Tue, Mar 04, 2025 at 14:03:56 +, Daniel P. Berrangé wrote: > > Contrary to most APIs returning typed parameters, there are no constants > > defined for the guest info data keys. Th

Re: [PATCH 01/19] src: add constants for guest info 'user.' parameters

2025-03-04 Thread Peter Krempa
Couple notes before doing a proper review: On Tue, Mar 04, 2025 at 14:03:56 +, Daniel P. Berrangé wrote: > Contrary to most APIs returning typed parameters, there are no constants > defined for the guest info data keys. This is was because many of the > keys needs to be dynamically constructed