Re: [PATCH v3 3/5] qemu: Propagate shared_filesystems

2024-05-09 Thread Peter Krempa
On Thu, May 09, 2024 at 06:48:36 -0700, Andrea Bolognani wrote: > On Thu, May 09, 2024 at 02:17:21PM GMT, Peter Krempa wrote: > > I'd go with 'exportedFilesystems' instead of 'sharedFilesystems' > > throughout this patch(set) for any case when the list contains only the > > paths configured by user

Re: [PATCH v3 3/5] qemu: Propagate shared_filesystems

2024-05-09 Thread Andrea Bolognani
On Thu, May 09, 2024 at 02:17:21PM GMT, Peter Krempa wrote: > I'd go with 'exportedFilesystems' instead of 'sharedFilesystems' > throughout this patch(set) for any case when the list contains only the > paths configured by user (from previous commit). Isn't that all cases? We never build a list wh

Re: [PATCH v3 3/5] qemu: Propagate shared_filesystems

2024-05-09 Thread Peter Krempa
On Thu, May 02, 2024 at 19:39:40 +0200, Andrea Bolognani wrote: > virFileIsSharedFS() is the function that ultimately decides > whether a filesystem should be considered shared, but the list > of manually configured shared filesystems is part of the QEMU > driver's configuration, so we need to pass

[PATCH v3 3/5] qemu: Propagate shared_filesystems

2024-05-02 Thread Andrea Bolognani
virFileIsSharedFS() is the function that ultimately decides whether a filesystem should be considered shared, but the list of manually configured shared filesystems is part of the QEMU driver's configuration, so we need to pass the information through several layers in order to make use of it. Not