Re: [PATCH v2] storage: Upgrade default qcow2 verion to 1.1

2024-03-12 Thread Daniel P . Berrangé
On Tue, Mar 12, 2024 at 11:09:47AM +0100, Peter Krempa wrote: > On Tue, Mar 12, 2024 at 10:01:25 +, Daniel P. Berrangé wrote: > > On Tue, Mar 12, 2024 at 10:36:28AM +0100, Peter Krempa wrote: > > > On Wed, Mar 06, 2024 at 01:20:13 +0530, Abhiram Tilak wrote: > > > > Change the default to modern

Re: [PATCH v2] storage: Upgrade default qcow2 verion to 1.1

2024-03-12 Thread Peter Krempa
On Tue, Mar 12, 2024 at 10:01:25 +, Daniel P. Berrangé wrote: > On Tue, Mar 12, 2024 at 10:36:28AM +0100, Peter Krempa wrote: > > On Wed, Mar 06, 2024 at 01:20:13 +0530, Abhiram Tilak wrote: > > > Change the default to modern qcow2 as it's supported by all qemu > > > versions supported by libvi

Re: [PATCH v2] storage: Upgrade default qcow2 verion to 1.1

2024-03-12 Thread Daniel P . Berrangé
On Tue, Mar 12, 2024 at 10:36:28AM +0100, Peter Krempa wrote: > On Wed, Mar 06, 2024 at 01:20:13 +0530, Abhiram Tilak wrote: > > Change the default to modern qcow2 as it's supported by all qemu > > versions supported by libvirt and in fact 'qemu-img' already defaults to > > the new format for a lon

Re: [PATCH v2] storage: Upgrade default qcow2 verion to 1.1

2024-03-12 Thread Peter Krempa
On Wed, Mar 06, 2024 at 01:20:13 +0530, Abhiram Tilak wrote: > Change the default to modern qcow2 as it's supported by all qemu > versions supported by libvirt and in fact 'qemu-img' already defaults to > the new format for a long time. > > Some Unittests require changes to pass, now that version

Re: [PATCH v2] storage: Upgrade default qcow2 verion to 1.1

2024-03-06 Thread atp exp
Apparently, if you change the commit message, patchew doesn't pick up v2 and mark the v1 as old (O). Sorry for the inconvenience if there is a patch, with a changed commit message [1], please ignore it and consider the present one. [1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.

[PATCH v2] storage: Upgrade default qcow2 verion to 1.1

2024-03-05 Thread Abhiram Tilak
Change the default to modern qcow2 as it's supported by all qemu versions supported by libvirt and in fact 'qemu-img' already defaults to the new format for a long time. Some Unittests require changes to pass, now that version 1.1 is default. Unittests like `qcow2-1.1.argv` may not be relevant any