On Wed, Feb 12, 2025 at 09:42:44AM +0300, Alexander Shursha wrote:
Sponsored by: Future Crew, LLC
Signed-off-by: Alexander Shursha
Hi, thanks for your contribution, but please be aware of our
contribution guidelines:
https://libvirt.org/hacking.html
and some pages linked from there:
https:/
On Fri, Mar 07, 2025 at 08:46:23AM +0300, Alexander Shursha wrote:
Martin Kletzander writes:
I understand you are switching to libpciaccess APIs from our manual
handling of PCI devices. That does have the added benefit of working on
FreeBSD, but adds a new dependency where it might not have b
Martin Kletzander writes:
> I understand you are switching to libpciaccess APIs from our manual
> handling of PCI devices. That does have the added benefit of working on
> FreeBSD, but adds a new dependency where it might not have been. That
> is probably fine, but some more explanation and rea
Daniel P. Berrangé writes:
Done.
> Please provide a commit message that describes the problem
> you're solving with this refactoring. Likewise for other
> commits in this series which all have empty commit messages.
>
>> Sponsored by: Future Crew, LLC
>
> While it is nice that they're sponsoring
sysfs is used to get a list of PCI devices. It doesn't work under
FreeBSD. The libpciaccess library provides cross-platform functions
for accessing the PCI bus.
Signed-off-by: Alexander Shursha
---
src/meson.build | 1 +
src/util/virpci.c | 465 ++-
On Wed, Feb 12, 2025 at 02:54:17PM +0300, Alexander Shursha wrote:
> Daniel P. Berrangé writes:
>
> Should I remove Sponsored from the commit log and add Copyright to the
> file?
>
> * virpci.c: helper APIs for managing host PCI devices
> *
> * Copyright (C) 2009-2015 Red Hat, Inc.
> + * C
Daniel P. Berrangé writes:
Should I remove Sponsored from the commit log and add Copyright to the
file?
* virpci.c: helper APIs for managing host PCI devices
*
* Copyright (C) 2009-2015 Red Hat, Inc.
+ * Copyright (C) 2024-2025 Future Crew, LLC
*
* This library is free software; you ca
On Wed, Feb 12, 2025 at 09:46:07AM +0300, Alexander Shursha wrote:
Please provide a commit message that describes the problem
you're solving with this refactoring. Likewise for other
commits in this series which all have empty commit messages.
> Sponsored by: Future Crew, LLC
While it is nice th
On Wed, Feb 12, 2025 at 09:46:07 +0300, Alexander Shursha wrote:
> Sponsored by: Future Crew, LLC
> Signed-off-by: Alexander Shursha
As mentioned in the PR upstream the commit message serves as a place to
describe the patch and most importantly the justification/why it's done,
rather than serving
Sponsored by: Future Crew, LLC
Signed-off-by: Alexander Shursha
---
src/meson.build | 1 +
src/util/virpci.c | 464 ++--
tests/qemuhotplugtest.c | 11 +-
tests/qemumemlocktest.c | 9 +
tests/qemuxmlconftest.c | 9 +
tests/virpcimock.c
10 matches
Mail list logo
