Re: [PATCH 1/2] qemu: Decompose qemuSaveImageOpen

2025-01-30 Thread Jim Fehlig via Devel
On 1/30/25 02:09, Michal Prívozník wrote: On 1/29/25 18:35, Jim Fehlig wrote: I eventually need something like 1/2 for the mapped-ram support. Currently qemuSaveImageOpen does too much IMO. I've been working on an improvement to this series and would like to get opinions on that first. And befo

Re: [PATCH 1/2] qemu: Decompose qemuSaveImageOpen

2025-01-30 Thread Michal Prívozník
On 1/29/25 18:35, Jim Fehlig wrote: > > I eventually need something like 1/2 for the mapped-ram support. > Currently qemuSaveImageOpen does too much IMO. I've been working on an > improvement to this series and would like to get opinions on that first. > And before posting I'll be sure to test it o

Re: [PATCH 1/2] qemu: Decompose qemuSaveImageOpen

2025-01-29 Thread Jim Fehlig via Devel
On 1/29/25 04:40, Michal Prívozník wrote: On 1/28/25 22:23, Jim Fehlig wrote: On 1/28/25 06:52, Michal Prívozník wrote: On 1/25/25 01:37, Jim Fehlig via Devel wrote: Split the reading of libvirt's save image metadata from the opening of the fd that will be passed to QEMU. This allows improved

Re: [PATCH 1/2] qemu: Decompose qemuSaveImageOpen

2025-01-29 Thread Michal Prívozník
On 1/28/25 22:23, Jim Fehlig wrote: > On 1/28/25 06:52, Michal Prívozník wrote: >> On 1/25/25 01:37, Jim Fehlig via Devel wrote: >>> Split the reading of libvirt's save image metadata from the opening >>> of the fd that will be passed to QEMU. This allows improved error >>> handling and provides mo

Re: [PATCH 1/2] qemu: Decompose qemuSaveImageOpen

2025-01-28 Thread Jim Fehlig via Devel
On 1/28/25 06:52, Michal Prívozník wrote: On 1/25/25 01:37, Jim Fehlig via Devel wrote: Split the reading of libvirt's save image metadata from the opening of the fd that will be passed to QEMU. This allows improved error handling and provides more flexibility for code reading saved images. Sig

Re: [PATCH 1/2] qemu: Decompose qemuSaveImageOpen

2025-01-28 Thread Michal Prívozník
On 1/25/25 01:37, Jim Fehlig via Devel wrote: > Split the reading of libvirt's save image metadata from the opening > of the fd that will be passed to QEMU. This allows improved error > handling and provides more flexibility for code reading saved images. > > Signed-off-by: Jim Fehlig > --- > sr

[PATCH 1/2] qemu: Decompose qemuSaveImageOpen

2025-01-24 Thread Jim Fehlig via Devel
Split the reading of libvirt's save image metadata from the opening of the fd that will be passed to QEMU. This allows improved error handling and provides more flexibility for code reading saved images. Signed-off-by: Jim Fehlig --- src/qemu/qemu_driver.c| 37 src/qemu/qemu