Re: [PATCH 1/1] qemu: qapi: fix potential SIGSEGV in virQEMUQAPISchemaTraverseObject()

2025-07-16 Thread Peter Krempa via Devel
On Thu, Jul 03, 2025 at 13:19:07 +0300, Nikolai Barybin via Devel wrote: Please also fix your git configuration: https://libvirt.org/submitting-patches.html#git-configuration Otherwise the author will be wrong (Nikolai Barybin via Devel) unless fixed manually due to the DMARC countermeasures th

Re: [PATCH 1/1] qemu: qapi: fix potential SIGSEGV in virQEMUQAPISchemaTraverseObject()

2025-07-16 Thread Peter Krempa via Devel
On Thu, Jul 03, 2025 at 13:19:07 +0300, Nikolai Barybin via Devel wrote: > We need to check obj ptr before passing it to > virJSONValueObjectHasKey(). If it's NULL it will fail with SIGSEGV. > > Signed-off-by: Nikolai Barybin > --- > src/qemu/qemu_qapi.c | 2 +- > 1 file changed, 1 insertion(+),

[PATCH 1/1] qemu: qapi: fix potential SIGSEGV in virQEMUQAPISchemaTraverseObject()

2025-07-03 Thread Nikolai Barybin via Devel
We need to check obj ptr before passing it to virJSONValueObjectHasKey(). If it's NULL it will fail with SIGSEGV. Signed-off-by: Nikolai Barybin --- src/qemu/qemu_qapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_qapi.c b/src/qemu/qemu_qapi.c index 184c0a96