Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-12 Thread Andrea Bolognani via Devel
On Tue, Aug 05, 2025 at 12:56:56PM +0200, Gerd Hoffmann wrote: > > Assuming that > > > > * the need to use -bios for SEV-SNP is intended; > > Yes. SEV-SNP (and TDX too) are by design incompatible with pflash > emulation. Both do not allow the host change guest memory layout > after launch, and

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-12 Thread Gerd Hoffmann via Devel
> [adding Daniel to CC] > > Daniel suggested that elsewhere in the thread and of course it's an > > appealing proposition, as it would keep complexity down and unify > > handling across CVM use cases. > > > > However I wonder if changing things would break migration for > > existing SEV(-ES) guest

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-12 Thread Daniel P . Berrangé via Devel
On Mon, Aug 04, 2025 at 02:15:01PM -0600, Jim Fehlig wrote: > On 8/4/25 05:31, Andrea Bolognani wrote: > > On Fri, Aug 01, 2025 at 11:39:45AM -0600, Jim Fehlig via Devel wrote: > > > With this addition, the correct firmware is detected, but it's not > > > properly > > > provided to qemu > > > > >

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-12 Thread Jim Fehlig via Devel
On 8/5/25 07:02, Gerd Hoffmann wrote: [adding Daniel to CC] Daniel suggested that elsewhere in the thread and of course it's an appealing proposition, as it would keep complexity down and unify handling across CVM use cases. However I wonder if changing things would break migration for existi

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-12 Thread Gerd Hoffmann via Devel
Hi, > Assuming that > > * the need to use -bios for SEV-SNP is intended; Yes. SEV-SNP (and TDX too) are by design incompatible with pflash emulation. Both do not allow the host change guest memory layout after launch, and pflash needs to do that to switch between reading mode and programmi

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-12 Thread Daniel P . Berrangé via Devel
On Tue, Aug 05, 2025 at 01:18:12AM -0700, Andrea Bolognani wrote: > On Tue, Aug 05, 2025 at 08:08:14AM +0100, Daniel P. Berrangé wrote: > > On Mon, Aug 04, 2025 at 02:15:01PM -0600, Jim Fehlig wrote: > > > On 8/4/25 05:31, Andrea Bolognani wrote: > > > > On Fri, Aug 01, 2025 at 11:39:45AM -0600, Ji

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-12 Thread Andrea Bolognani via Devel
On Tue, Aug 05, 2025 at 08:08:14AM +0100, Daniel P. Berrangé wrote: > On Mon, Aug 04, 2025 at 02:15:01PM -0600, Jim Fehlig wrote: > > On 8/4/25 05:31, Andrea Bolognani wrote: > > > On Fri, Aug 01, 2025 at 11:39:45AM -0600, Jim Fehlig via Devel wrote: > > > > With this addition, the correct firmware

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-12 Thread Andrea Bolognani via Devel
[adding Daniel to CC] On Tue, Aug 05, 2025 at 05:17:14AM -0700, Andrea Bolognani wrote: > On Tue, Aug 05, 2025 at 12:56:56PM +0200, Gerd Hoffmann wrote: > > > Assuming that > > > > > > * the need to use -bios for SEV-SNP is intended; > > > > Yes. SEV-SNP (and TDX too) are by design incompatible

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-04 Thread Jim Fehlig via Devel
On 8/4/25 05:31, Andrea Bolognani wrote: On Fri, Aug 01, 2025 at 11:39:45AM -0600, Jim Fehlig via Devel wrote: With this addition, the correct firmware is detected, but it's not properly provided to qemu internal error: QEMU unexpectedly closed the monitor (vm='sles15sp7-snp'): 2025-08-01T17:11

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-04 Thread Andrea Bolognani via Devel
On Fri, Aug 01, 2025 at 11:39:45AM -0600, Jim Fehlig via Devel wrote: > With this addition, the correct firmware is detected, but it's not properly > provided to qemu > > internal error: QEMU unexpectedly closed the monitor (vm='sles15sp7-snp'): > 2025-08-01T17:11:20.589614Z qemu-system-x86_64: pfl

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-01 Thread Jim Fehlig via Devel
On 8/1/25 03:14, Andrea Bolognani wrote: On Fri, Aug 01, 2025 at 02:06:44AM -0700, Andrea Bolognani wrote: On Thu, Jul 31, 2025 at 11:33:08AM -0600, Jim Fehlig wrote: Apologies for not having time to look at this in more detail today, but I quickly tried these patches and now see operation fai

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-01 Thread Andrea Bolognani via Devel
On Fri, Aug 01, 2025 at 02:06:44AM -0700, Andrea Bolognani wrote: > On Thu, Jul 31, 2025 at 11:33:08AM -0600, Jim Fehlig wrote: > > Apologies for not having time to look at this in more detail today, but I > > quickly tried these patches and now see > > > > operation failed: unable to find any mast

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-08-01 Thread Andrea Bolognani via Devel
On Thu, Jul 31, 2025 at 11:33:08AM -0600, Jim Fehlig wrote: > Apologies for not having time to look at this in more detail today, but I > quickly tried these patches and now see > > operation failed: unable to find any master var store for loader: > /usr/share/qemu/ovmf-x86_64-sev.bin This happens

Re: [PATCH 0/5] qemu: Fixes to firmware selection

2025-07-31 Thread Jim Fehlig via Devel
On 7/31/25 09:45, Andrea Bolognani via Devel wrote: See [1] for the discussion motivating these changes. [1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/U33UEJEXZGZEWOLGVAA5UWPLYY4WHEHT/ Andrea Bolognani (5): tests: Tweak descriptor for combined firmware tests:

[PATCH 0/5] qemu: Fixes to firmware selection

2025-07-31 Thread Andrea Bolognani via Devel
See [1] for the discussion motivating these changes. [1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/U33UEJEXZGZEWOLGVAA5UWPLYY4WHEHT/ Andrea Bolognani (5): tests: Tweak descriptor for combined firmware tests: Add firmware-auto-efi-sev-snp qemu: Fix matching for